Commit graph

11458 commits

Author SHA1 Message Date
Kate Lovett 8df0d6556d
Skia Gold Support for Local & PreSubmit Testing in package:flutter (#40710) 2019-10-21 16:45:56 -07:00
Jonah Williams 31a4ff80c7
add samsungexynos7570 to list of known physical devices (#43042) 2019-10-21 16:45:48 -07:00
Kate Lovett 83878683c0
Re-landing SliverAnimatedList (#42485) 2019-10-21 16:44:55 -07:00
Jonah Williams 6db4c44da8
remove period from URL so that it opens correctly in vscode (#43200) 2019-10-21 16:43:11 -07:00
Tong Mu 1c535de7e0
Soften layer breakage (#42953)
* Replace hard break of Layer.find/All with findAllAnnotations
* Deprecate findAll
2019-10-18 16:40:42 -07:00
Ian Hickson 124dc6617f
Clean up test infrastructure (#43030)
See #41880 for history.
2019-10-18 16:35:39 -07:00
Edman P. Anjos faa514fc24 Quick fix on material dialog docs (#42968) 2019-10-18 15:43:04 -07:00
Aditya Sharma b6c865ff9c Fix typo (#42922) 2019-10-18 15:42:28 -07:00
Jonah Williams 39e4d9d152
Expand scope of rethrown gradle errors (#42966) 2019-10-18 14:56:39 -07:00
Jonah Williams 6fc99e98ad
rename headless server to web server (#42970) 2019-10-18 12:41:47 -07:00
Jonah Williams 21be8372c9
implement debugTogglePlatform for the web (#42951) 2019-10-18 12:41:15 -07:00
Jonah Williams e67f9a3f6c
ensure we can disable --track-widget-creation in debug mode (#43016) 2019-10-18 12:40:50 -07:00
Erick (CptBlackPixel) 12b7b08da5 Reading deviceId for RawKeyEventDataAndroid event (#42235)
This PR adds a new property on RawKeyEventDataAndroid to hold the deviceId from which that event was generated. The deviceId is been sent from the engine on the changes from this PR: flutter/engine#12958

With this, we will be able to identify from where the event came from, adding the ability to support local multiplayer games, with multiple gamepads.
2019-10-18 12:32:21 -07:00
Greg Spencer 560873af92
Wire up canRequestFocus and skipTraversal in FocusScopeNode (#43013)
This adds a canRequestFocus and skipTraversal argument to FocusScope and FocusScopeNode, so that a scope can prevent being traversed.

This allows a fix for a problem in the gallery where the focus while traversing the list of items would sometimes appear to disappear, since it would be focusing things that were in the backdrop that were part of the tree, but were not visible.

Related Issues
Fixes #42955
2019-10-18 12:31:15 -07:00
Greg Spencer df76354488
Add a Focus node to the DropdownButton, and adds an activation action for it. (#42811)
This adds a Focus node to the DropdownButton widget, allowing it to receive keyboard focus, and to show a focus highlight. In addition, I added the ability to activate the dropdown using the "enter" key binding (which is bound to ActivateAction in the WidgetsApp).

Related Issues
Fixes #42646
Fixes #43008
Fixes #42511
2019-10-18 12:30:40 -07:00
Jonah Williams 1982a5c3ec
Revert "Clean up test infrastructure (#41880)" (#42982)
This reverts commit 1781d5c9bb.
2019-10-17 19:47:16 -07:00
Ian Hickson 1781d5c9bb
Clean up test infrastructure (#41880) 2019-10-17 19:22:47 -07:00
Jonah Williams 863fb2f2cc
Remove linux-x64 unpack logic (#42962) 2019-10-17 19:22:03 -07:00
Jonah Williams f53b32eb23
refactor depfile usage and update linux rule (#42487) 2019-10-17 17:42:40 -07:00
Ryan Macnak 315471bfb0
Do not produce an error when encountering a new type in a service response. (#42972)
Flutter tool's service client library tries to "upgrade" sub-components of service responses with higher level model objects. It does this for all members of the response, rather than only those documented in the version it targets, and it errors out when encountering a new type. This causes it to fail when a new field is introduced with a new typed. Clients are required to ignore this.
2019-10-17 16:56:57 -07:00
Michael Goderbauer ddca78b4b7
Fix memory leak in TransitionRoute (#42777) 2019-10-17 15:51:45 -07:00
Jaumard 1faf6a9a89 create gesture recognizers on attach and dispose on detach to avoid leaks (#42076) 2019-10-17 15:48:20 -07:00
Jenn Magder b194f93541
Remove use_modular_headers from Podfiles using libraries (#42872)
* Remove use_modular_headers from Podfiles using libraries

* Remove @imports
2019-10-17 15:26:10 -07:00
Jonah Williams bc396d1b5c
Add onVisible callback to snackbar. (#42344) 2019-10-17 15:12:25 -07:00
Greg Spencer a7aa66164e
Re-implement hardware keyboard text selection. (#42879)
This re-implements keyboard text selection so that it will work on platforms other than Android (e.g. macOS, Linux, etc.).

Also, fixed a number of bugs in editing selection via a hardware keyboard (unable to select backwards, incorrect conversion to ASCII when cutting to clipboard, lack of support for CTRL-SHIFT-ARROW word selection, etc.).

Did not address the keyboard locale issues that remain, or add platform specific switches for the bindings. All that will need some more design work before implementing them.

Related Issues
Fixes #31951
2019-10-17 15:11:44 -07:00
Ferhat f7ce5ae3fc
[web] Update web runner message with flutter.dev/web (#42676)
* Update web runner message with flutter.dev/web

* Update spoopy test to use Warning instead
2019-10-17 15:08:15 -07:00
Shi-Hao Hong 3dc8898e10
Revert "Default colorScheme data in ButtonThemeData (Fix for #38655) (#39627)" (#42854)
This reverts commit 19899db223.
2019-10-17 15:07:42 -07:00
Hans Muller 0a7e605632
Support AppBars with jumbo titles (#42936) 2019-10-17 15:01:41 -07:00
Greg Spencer 3afdd08af4
This disables the up/down arrow focus navigation in text fields in a different way. (#42790)
In #42533, I disabled the up/down arrows for focus navigation in text fields, but we thought of a better way to do it, so this is that better way.

This change reverts the other change, and instead it tests the context of the node in the action to see if it's an EditableText node. If so, then it doesn't do the navigation action.
2019-10-17 15:01:22 -07:00
Emmanuel Garcia 08c645b3b2
Test the Android embedding v2 (#42708)
* Test the Android embedding v2

* Update integration tests

* Split into shards
2019-10-16 21:26:10 -07:00
Jonah Williams cb518c4219
Fix progress indicators for release/profile builds of web. (#42857) 2019-10-16 16:10:06 -07:00
Jonah Williams 01f779e97a
Fix NPE in Chrome Device (#42813) 2019-10-16 15:46:07 -07:00
Gary Qian 3bbf54d79f
Reland "Expose API for resizing image caches #41415" (#42785) 2019-10-16 14:15:13 -07:00
Emmanuel Garcia 0a93f4eb75
Remove isNewAndroidEmbeddingEnabled flag when reading an existing pro… (#42684) 2019-10-16 12:47:04 -07:00
Yegor 86f069f1c0
Add most of the widget tests; add more web test shards (#42807) 2019-10-16 09:18:44 -07:00
creativecreatorormaybenot a665393a0d Fix Tooltip implementation of PopupMenuButton (#42613)
* Fix tooltip not showing when PopupMenuButton.child was non-null
2019-10-16 09:01:24 -07:00
Jenn Magder 357d02c87b
Always embed Flutter.framework build mode version from Xcode configuration (#42029) 2019-10-15 15:33:55 -07:00
Jonah Williams ad1d67e0a1
serve correct content type from debug server (#42701) 2019-10-15 15:25:57 -07:00
Yegor 21a18fbe16
enable rendering rests on the Web (#42773) 2019-10-15 15:25:47 -07:00
Jonah Williams 68e768dbcf
fix type error in manifest asset bundle (#42791) 2019-10-15 15:25:33 -07:00
liyuqian 31cb44825c
Add --cache-sksl flag to drive and run (#42353)
So we can test SkSL precompile using the command line tools.
See https://github.com/flutter/engine/pull/12412.
2019-10-15 14:28:55 -07:00
Jonah Williams e22d4aa140
Add debugging option to write vmservice address to file after starting (#41583) 2019-10-15 13:05:47 -07:00
Christopher Fujino 428d7d7f2d
dispose devices on cleanupAtFinish() for run_cold.dart (#42668) 2019-10-15 12:50:44 -07:00
Jonah Williams daa7143c08
Unpin test and update packages (#42699) 2019-10-15 12:50:10 -07:00
Jenn Magder dda74a1993
Increase template Swift version from 4 to 5 (#41882) 2019-10-15 12:37:13 -07:00
Jenn Magder 649cf82018
use_modular_headers (#42204) 2019-10-15 12:36:50 -07:00
Jason Simmons fb33b7a1b8
Use placeholder dimensions that reflect the final text layout (#42558)
The _computeChildren[Width/Height]With[Min/Max]Intrinsics methods in
RenderParagraph overwrite the text painter's placeholder dimensions
in order to compute potential widths and heights for the paragraph.

The placeholder dimensions should be restored to the values computed by
_layoutChildren before painting the text.
2019-10-15 10:17:52 -07:00
Shi-Hao Hong 0821b759f5
Typo fixes (#42688) 2019-10-15 10:06:50 -07:00
Jonah Williams 7f8e89b5dc
Revert "Expose API for custom image decode and cache sizes (#41415)" (#42764) 2019-10-15 08:42:55 -07:00
Gary Qian b857632306
Expose API for custom image decode and cache sizes (#41415) 2019-10-15 00:07:32 -07:00