engine-flutter-autoroll
a46a7fdc3d
Roll Flutter Engine from 1f9edbeeceb3 to 445c3bfc0d5b (1 revision) ( #147776 )
...
1f9edbeece...445c3bfc0dskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cScmnvKM3py9E2087... to QDv0tal7_BgoZx0ju... (flutter/engine#52543 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cScmnvKM3py9 to QDv0tal7_Bgo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 13:36:24 +00:00
engine-flutter-autoroll
764121cd06
Roll Flutter Engine from 75eb18090510 to 1f9edbeeceb3 (1 revision) ( #147769 )
...
75eb180905...1f9edbeeceskia-flutter-autoroll@skia.org Roll Dart SDK from 138695ec00bd to 33bb0f4b0770 (1 revision) (flutter/engine#52542 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 09:58:28 +00:00
drown0315
cfeb76e0e6
Improved documentation for SpringSimulation ( #146674 )
...
Add a code snippet demonstrating the usage of SpringSimulation in the docs.
Improve the descriptions of each argument in SpringDescription.
2024-05-03 08:48:18 +00:00
engine-flutter-autoroll
0c7a5148e9
Roll Flutter Engine from b8d81a4f6e5a to 75eb18090510 (1 revision) ( #147766 )
...
b8d81a4f6e...75eb180905skia-flutter-autoroll@skia.org Roll Skia from d2f0fd0faf90 to 8f5808650129 (1 revision) (flutter/engine#52541 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 08:25:25 +00:00
engine-flutter-autoroll
f4d42c50d3
Roll Flutter Engine from d8c8cf4384f0 to b8d81a4f6e5a (2 revisions) ( #147765 )
...
d8c8cf4384...b8d81a4f6eskia-flutter-autoroll@skia.org Roll Skia from 2eaea0383201 to d2f0fd0faf90 (1 revision) (flutter/engine#52540 )
2024-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 03b7868a71ae to 138695ec00bd (1 revision) (flutter/engine#52539 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 06:43:24 +00:00
Greg Spencer
183bc15816
Move snippets package back into flutter repo ( #147690 )
...
## Description
This moves the snippets package back into the Flutter repo so that API documentation generation can happen without the use of `dart pub global run` because `pub run` doesn't handle concurrency well.
The change modifies the dartdoc building process to include building an executable from the snippets tool and installing that in the cache directory for use during docs generation.
The snippets tool will reside in dev/snippets, where it originally resided before being moved to https://github.com/flutter/assets-for-api-docs .
The snippets code itself is unchanged from the code that is in https://github.com/flutter/assets-for-api-docs/packages/snippets .
## Related Issues
- https://github.com/flutter/flutter/issues/144408
- https://github.com/flutter/flutter/issues/147609
- https://github.com/flutter/flutter/pull/147645
## Tests
- Added snippets tests to the overall testing build.
2024-05-03 06:09:03 +00:00
engine-flutter-autoroll
4006d1bd7b
Roll Flutter Engine from 98a800b00cfc to d8c8cf4384f0 (2 revisions) ( #147763 )
...
98a800b00c...d8c8cf4384dustingreen@google.com [fuchsia] route fuchsia.sysmem2.Allocator pt 2 (flutter/engine#52509 )
2024-05-03 jason-simmons@users.noreply.github.com [et] Add Linux host_debug_unopt local engine builder (flutter/engine#52538 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 04:17:24 +00:00
engine-flutter-autoroll
c0a0fed5ac
Roll Flutter Engine from c380e9fd4122 to 98a800b00cfc (3 revisions) ( #147761 )
...
c380e9fd41...98a800b00cbdero@google.com [et] Add ios_debug_unopt build config. (flutter/engine#52537 )
2024-05-03 skia-flutter-autoroll@skia.org Roll Skia from df970dcd6cfa to 2eaea0383201 (1 revision) (flutter/engine#52536 )
2024-05-03 bdero@google.com [Impeller] Remove Entity capture/AiksInspector. (flutter/engine#52526 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 03:31:24 +00:00
engine-flutter-autoroll
7c62afb444
Roll Flutter Engine from fc71b650a70a to c380e9fd4122 (4 revisions) ( #147759 )
...
fc71b650a7...c380e9fd41skia-flutter-autoroll@skia.org Roll Dart SDK from 0316fa44b401 to 03b7868a71ae (1 revision) (flutter/engine#52534 )
2024-05-02 skia-flutter-autoroll@skia.org Roll Skia from 716e757c1ffb to df970dcd6cfa (1 revision) (flutter/engine#52533 )
2024-05-02 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Round physical size to nearest whole number pixels (flutter/engine#52467 )
2024-05-02 30870216+gaaclarke@users.noreply.github.com Updated RBE documentation for default credentials. (flutter/engine#52530 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 01:48:17 +00:00
flutter-pub-roller-bot
69edf4d7a7
Roll pub packages ( #147741 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-05-03 00:37:06 +00:00
engine-flutter-autoroll
fbb080fefa
Roll Flutter Engine from 3f1f81915620 to fc71b650a70a (2 revisions) ( #147753 )
...
3f1f819156...fc71b650a7tugorez@users.noreply.github.com Put the view focus functionality behind a (disabled by default) flag (flutter/engine#52527 )
2024-05-02 skia-flutter-autoroll@skia.org Roll Skia from f9671ecda7da to 716e757c1ffb (5 revisions) (flutter/engine#52528 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-03 00:23:49 +00:00
engine-flutter-autoroll
9b2cf3d1b3
Roll Flutter Engine from 5088f63ecee2 to 3f1f81915620 (3 revisions) ( #147748 )
...
5088f63ece...3f1f819156bdero@google.com [Impeller] Remove checkerboard. (flutter/engine#52524 )
2024-05-02 skia-flutter-autoroll@skia.org Roll Skia from 894919003036 to f9671ecda7da (3 revisions) (flutter/engine#52525 )
2024-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 040d3f6c4c45 to 0316fa44b401 (1 revision) (flutter/engine#52523 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 22:39:19 +00:00
Yegor
d5836ee60c
[web] skip debug mode CanvasKit e2e tests due to flakiness; unskip all other modes ( #147736 )
...
- Skip debug mode CanvasKit e2e tests due to flakiness.
- Unskip all other modes (`text_editing_integration` was over-skipped).
Fixes https://github.com/flutter/flutter/issues/146189
2024-05-02 22:23:30 +00:00
Nate
5d1bfdcb87
Control flow collections: flutter_tools/ ( #147450 )
...
This pull request aims for improved readability, based on issue #146600 .
```dart
// before
List<SupportedPlatform> getSupportedPlatforms({bool includeRoot = false}) {
final List<SupportedPlatform> platforms = includeRoot
? <SupportedPlatform>[SupportedPlatform.root]
: <SupportedPlatform>[];
if (android.existsSync()) {
platforms.add(SupportedPlatform.android);
}
if (ios.exists) {
platforms.add(SupportedPlatform.ios);
}
if (web.existsSync()) {
platforms.add(SupportedPlatform.web);
}
if (macos.existsSync()) {
platforms.add(SupportedPlatform.macos);
}
if (linux.existsSync()) {
platforms.add(SupportedPlatform.linux);
}
if (windows.existsSync()) {
platforms.add(SupportedPlatform.windows);
}
if (fuchsia.existsSync()) {
platforms.add(SupportedPlatform.fuchsia);
}
return platforms;
}
// after
List<SupportedPlatform> getSupportedPlatforms({bool includeRoot = false}) {
return <SupportedPlatform>[
if (includeRoot) SupportedPlatform.root,
if (android.existsSync()) SupportedPlatform.android,
if (ios.exists) SupportedPlatform.ios,
if (web.existsSync()) SupportedPlatform.web,
if (macos.existsSync()) SupportedPlatform.macos,
if (linux.existsSync()) SupportedPlatform.linux,
if (windows.existsSync()) SupportedPlatform.windows,
if (fuchsia.existsSync()) SupportedPlatform.fuchsia,
];
}
```
2024-05-02 22:19:18 +00:00
Nate
7436cc25eb
Add default arguments to AnimatedPhysicalModel ( #147424 )
...
Currently, `PhysicalModel` has [default arguments](2e806700b9/packages/flutter/lib/src/widgets/basic.dart (L1093)2e806700b9/packages/flutter/lib/src/widgets/implicit_animations.dart (L1998)
2024-05-02 21:59:07 +00:00
engine-flutter-autoroll
9d007937c6
Roll Flutter Engine from 9982b5ffd913 to 5088f63ecee2 (3 revisions) ( #147740 )
...
9982b5ffd9...5088f63eceskia-flutter-autoroll@skia.org Roll Skia from a0f0c08f31d8 to 894919003036 (2 revisions) (flutter/engine#52522 )
2024-05-02 skia-flutter-autoroll@skia.org Roll Skia from 4dbf9ad5fa1e to a0f0c08f31d8 (3 revisions) (flutter/engine#52521 )
2024-05-02 skia-flutter-autoroll@skia.org Roll Skia from d37c4d0c5e5d to 4dbf9ad5fa1e (3 revisions) (flutter/engine#52520 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 21:04:15 +00:00
LongCatIsLooong
f76eda1e7f
_RenderDecorator.computeDryBaseline (#146365 )
...
Depends on https://github.com/flutter/flutter/pull/146363
No test because the consistency of the `computeDryBaseline` implementations is checked at paint time.
2024-05-02 20:56:11 +00:00
engine-flutter-autoroll
21da3a8063
Roll Flutter Engine from e1126e59b698 to 9982b5ffd913 (1 revision) ( #147727 )
...
e1126e59b6...9982b5ffd9aam@google.com Use new Dart_PortEx api to ensure SendPort can be rebuild properly. (flutter/engine#52498 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 18:44:08 +00:00
Yegor
1d0e798c21
[web] increase chromedriver logging level ( #147687 )
...
This can help debugging https://github.com/flutter/flutter/issues/146189
2024-05-02 10:16:37 -07:00
engine-flutter-autoroll
da05147d6a
Roll Flutter Engine from 1fb36ac9d718 to e1126e59b698 (1 revision) ( #147720 )
...
1fb36ac9d7...e1126e59b6skia-flutter-autoroll@skia.org Roll Dart SDK from faabc0c9861c to 040d3f6c4c45 (1 revision) (flutter/engine#52518 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 16:42:41 +00:00
engine-flutter-autoroll
bf7191fd38
Roll Flutter Engine from b989d239e281 to 1fb36ac9d718 (2 revisions) ( #147713 )
...
b989d239e2...1fb36ac9d7skia-flutter-autoroll@skia.org Roll Skia from 6c41182ab9bb to d37c4d0c5e5d (1 revision) (flutter/engine#52517 )
2024-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from c34adf6abcca to faabc0c9861c (1 revision) (flutter/engine#52515 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 13:51:48 +00:00
engine-flutter-autoroll
13a05def83
Roll Flutter Engine from 3c9c2ce8369e to b989d239e281 (1 revision) ( #147711 )
...
3c9c2ce836...b989d239e2skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PIHl-e41i3mzbriG1... to cScmnvKM3py9E2087... (flutter/engine#52516 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PIHl-e41i3mz to cScmnvKM3py9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 12:22:29 +00:00
engine-flutter-autoroll
07123b61b0
Roll Flutter Engine from 58b031c096ea to 3c9c2ce8369e (2 revisions) ( #147703 )
...
58b031c096...3c9c2ce836skia-flutter-autoroll@skia.org Roll Skia from 7c68b9c33b08 to 6c41182ab9bb (2 revisions) (flutter/engine#52513 )
2024-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 30b5422ec1b2 to c34adf6abcca (1 revision) (flutter/engine#52512 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 09:10:24 +00:00
engine-flutter-autoroll
9f3be7dfd9
Roll Flutter Engine from fc28057dbd4d to 58b031c096ea (1 revision) ( #147701 )
...
fc28057dbd...58b031c096skia-flutter-autoroll@skia.org Roll Skia from 97aa3f4cf290 to 7c68b9c33b08 (1 revision) (flutter/engine#52511 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 08:15:02 +00:00
engine-flutter-autoroll
d34d4cd125
Roll Flutter Engine from bfc6787eedc3 to fc28057dbd4d (1 revision) ( #147700 )
...
bfc6787eed...fc28057dbdjonahwilliams@google.com [Impeller] allow for one more active swapchain image. (flutter/engine#52505 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 07:08:30 +00:00
engine-flutter-autoroll
70f4a6301e
Roll Flutter Engine from 7cbef71f4f54 to bfc6787eedc3 (1 revision) ( #147699 )
...
7cbef71f4f...bfc6787eedian@hixie.ch Remove rasterizerTracingThreshold, checkerboardRasterCacheImages, and checkerboardOffscreenLayers, etc (flutter/engine#52446 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 06:27:04 +00:00
engine-flutter-autoroll
6ce591f7ea
Roll Flutter Engine from 90ce9e5959fc to 7cbef71f4f54 (1 revision) ( #147696 )
...
90ce9e5959...7cbef71f4fskia-flutter-autoroll@skia.org Roll Skia from 81ccf3ab27ee to 97aa3f4cf290 (1 revision) (flutter/engine#52508 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 05:33:40 +00:00
engine-flutter-autoroll
4b691f7739
Roll Flutter Engine from 78dced50c467 to 90ce9e5959fc (1 revision) ( #147695 )
...
78dced50c4...90ce9e5959skia-flutter-autoroll@skia.org Roll Dart SDK from 04d373e0a99d to 30b5422ec1b2 (1 revision) (flutter/engine#52507 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 04:47:16 +00:00
Andrew Kolos
13beab1ecc
add verbose logging to select hot reload/hot restart tests ( #147673 )
...
In service of https://github.com/flutter/flutter/issues/146879 and https://github.com/flutter/flutter/issues/145812 . In these issues, we see what appears to be the flutter tool getting stuck somewhere during hot reload. It may help if we knew were exactly where we are getting stuck (preparing assets, writing them to device, etc.).
This PR adds a new parameter to `FlutterTestDriver::run`, `verbose`. When verbose is set, `FlutterTestDriver` will run `flutter` with `--verbose` in its tests. Keep in mind that `FlutterTestDriver` only prints logs from `flutter` when a test fails, so this shouldn't spam the logs of passing tests.
This PR sets the parameter when invoking the flaky tests from https://github.com/flutter/flutter/issues/146879 and #145812 , so we should see more detailed logs in future flakes.
While this is a low risk PR, you can verify the change by intentionally breaking hot reload code, clearing the cached tool binaries, and then running either of these tests.
2024-05-02 04:03:32 +00:00
engine-flutter-autoroll
bda9eef950
Roll Flutter Engine from 3087ec1adddd to 78dced50c467 (3 revisions) ( #147693 )
...
3087ec1add...78dced50c4bdero@google.com et phone home (flutter/engine#52506 )
2024-05-02 ditman@gmail.com [web] Expose browser_detection through ui_web. (flutter/engine#52380 )
2024-05-02 jonahwilliams@google.com [Impeller] remove incremental allocation during filled path tessellation. (flutter/engine#52401 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 03:43:37 +00:00
auto-submit[bot]
706f39b0a0
Reverts "Implement computeDryBaseline for RenderWrap ( #146260 )" ( #147692 )
...
Reverts: flutter/flutter#146260
Initiated by: chingjun
Reason for reverting: Broke internal tests. See b/338308016
Original PR Author: LongCatIsLooong
Reviewed By: {goderbauer}
This change reverts the following previous change:
2024-05-02 02:26:28 +00:00
engine-flutter-autoroll
8025af0aa6
Roll Flutter Engine from f56c20c6ac67 to 3087ec1adddd (2 revisions) ( #147688 )
...
f56c20c6ac...3087ec1addjacksongardner@google.com [skwasm] Don't mark the backend texture as mipmapped, since it isn't. (flutter/engine#52501 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from 36ec16922dad to 81ccf3ab27ee (1 revision) (flutter/engine#52504 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 01:55:14 +00:00
Greg Spencer
2e78ed0ff9
Allow explicit exclusion of packages from pinned packages in flutter update-packages --force-update ( #147679 )
...
## Description
This introduces a list of packages that we will explicitly not pin. It is to be used for things where the package isn't actually published, but is a transitive dependency of another package included in the SDK. This happens with the `macros` package, for instance, which depends on the private, unpublished, `_macros` package where the SDK does some tricky things to depend on it (it depends on "any", but ships it as part of the SDK).
Also ran `flutter update-packages --force-update` to update all of the pubspec files.
## Related Issues
- Fixes #147656
## Tests
- Added a test that makes sure that explicitly unpinned packages don't show up in the pinned list.
2024-05-02 01:16:54 +00:00
LongCatIsLooong
ab8ecd5e74
Implement getDryBaseline for Stack and Overlay ( #146253 )
2024-05-02 00:31:12 +00:00
engine-flutter-autoroll
603416233c
Roll Flutter Engine from 2d73fa207927 to f56c20c6ac67 (2 revisions) ( #147681 )
...
2d73fa2079...f56c20c6acskia-flutter-autoroll@skia.org Roll Dart SDK from f5a429107c87 to 04d373e0a99d (2 revisions) (flutter/engine#52503 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from 553b6e2eddc5 to 36ec16922dad (2 revisions) (flutter/engine#52502 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 00:18:22 +00:00
Polina Cherkasova
5eb1807464
Update selectable_text_test.dart ( #147677 )
...
Fix leak introduced by https://github.com/flutter/flutter/pull/147341
2024-05-02 00:03:15 +00:00
engine-flutter-autoroll
7203af3e2f
Roll Flutter Engine from c536a14052e5 to 2d73fa207927 (2 revisions) ( #147678 )
...
c536a14052...2d73fa2079magder@google.com Migrate PlatformMessageHandlerIos to ARC (flutter/engine#52226 )
2024-05-01 47866232+chunhtai@users.noreply.github.com macOS fluttertextinputplugin drops selector called if no client (flutter/engine#52495 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 23:24:41 +00:00
LongCatIsLooong
88ffd89685
Implement computeDryBaseline for RenderWrap ( #146260 )
2024-05-01 22:39:08 +00:00
engine-flutter-autoroll
730167eb38
Roll Flutter Engine from 842cf254ec58 to c536a14052e5 (1 revision) ( #147675 )
...
842cf254ec...c536a14052skia-flutter-autoroll@skia.org Roll Skia from 0b31f64bd8d8 to 553b6e2eddc5 (5 revisions) (flutter/engine#52500 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 22:37:15 +00:00
dependabot[bot]
ffbeb5a39c
Bump codecov/codecov-action from 4.3.0 to 4.3.1 ( #147674 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.3.0 to 4.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v4.3.1</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump typescript from 5.4.4 to 5.4.5 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1370 ">codecov/codecov-action#1370</a></li>
<li>fix: more verbose log message when failing to import pgp key by <a href="https://github.com/ReenigneArcher "><code>@âReenigneArcher</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1371 ">codecov/codecov-action#1371</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 7.6.0 to 7.7.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1374 ">codecov/codecov-action#1374</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.6.0 to 7.7.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1375 ">codecov/codecov-action#1375</a></li>
<li>build(deps): bump actions/checkout from 4.1.2 to 4.1.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1382 ">codecov/codecov-action#1382</a></li>
<li>build(deps): bump github/codeql-action from 3.24.10 to 3.25.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1381 ">codecov/codecov-action#1381</a></li>
<li>build(deps): bump actions/upload-artifact from 4.3.1 to 4.3.2 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1380 ">codecov/codecov-action#1380</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.7.0 to 7.7.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1384 ">codecov/codecov-action#1384</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 7.7.0 to 7.7.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1383 ">codecov/codecov-action#1383</a></li>
<li>Update README.md to point to docs about tokenless by <a href="https://github.com/rohan-at-sentry "><code>@ârohan-at-sentry</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1395 ">codecov/codecov-action#1395</a></li>
<li>build(deps): bump actions/upload-artifact from 4.3.2 to 4.3.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1393 ">codecov/codecov-action#1393</a></li>
<li>build(deps): bump actions/checkout from 4.1.3 to 4.1.4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1392 ">codecov/codecov-action#1392</a></li>
<li>build(deps): bump github/codeql-action from 3.25.1 to 3.25.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1391 ">codecov/codecov-action#1391</a></li>
<li>style: Node Packages by <a href="https://github.com/marcobiedermann "><code>@âmarcobiedermann</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1394 ">codecov/codecov-action#1394</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 7.7.1 to 7.8.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1402 ">codecov/codecov-action#1402</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.7.1 to 7.8.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1401 ">codecov/codecov-action#1401</a></li>
<li>docs: Type Annotations by <a href="https://github.com/marcobiedermann "><code>@âmarcobiedermann</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1397 ">codecov/codecov-action#1397</a></li>
<li>docs: main branch by <a href="https://github.com/marcobiedermann "><code>@âmarcobiedermann</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1396 ">codecov/codecov-action#1396</a></li>
<li>fix: bypass token checks for forks and OIDC by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1404 ">codecov/codecov-action#1404</a></li>
<li>chore(release): 4.3.1. by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1405 ">codecov/codecov-action#1405</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/ReenigneArcher "><code>@âReenigneArcher</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1371 ">codecov/codecov-action#1371</a></li>
<li><a href="https://github.com/rohan-at-sentry "><code>@ârohan-at-sentry</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1395 ">codecov/codecov-action#1395</a></li>
<li><a href="https://github.com/marcobiedermann "><code>@âmarcobiedermann</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1394 ">codecov/codecov-action#1394</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.3.0...v4.3.1 ">https://github.com/codecov/codecov-action/compare/v4.3.0...v4.3.1 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="5ecb98a3c6https://redirect.github.com/codecov/codecov-action/issues/1405 ">#1405</a>)</li>
<li><a href="5a299d1127https://redirect.github.com/codecov/codecov-action/issues/1404 ">#1404</a>)</li>
<li><a href="dad251dcafhttps://redirect.github.com/codecov/codecov-action/issues/1396 ">#1396</a>)</li>
<li><a href="e8bbe5fc01https://redirect.github.com/codecov/codecov-action/issues/1397 ">#1397</a>)</li>
<li><a href="a6fd87fc19https://redirect.github.com/codecov/codecov-action/issues/1401 ">#1401</a>)</li>
<li><a href="76c8cd61631290bddc88https://redirect.github.com/codecov/codecov-action/issues/1394 ">#1394</a>)</li>
<li><a href="951ef79006https://redirect.github.com/codecov/codecov-action/issues/1391 ">#1391</a>)</li>
<li><a href="bb71c1ba2fhttps://redirect.github.com/codecov/codecov-action/issues/1392 ">#1392</a>)</li>
<li><a href="acc5d43cadhttps://redirect.github.com/codecov/codecov-action/issues/1393 ">#1393</a>)</li>
<li>Additional commits viewable in <a href="84508663e9...5ecb98a3c6https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.3.0&new-version=4.3.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-05-01 22:19:20 +00:00
Ian Hickson
db4dfa0dde
Remove obsolete performance analysis tools. ( #147663 )
...
We're unlikely to support these reliably going forward.
2024-05-01 22:05:02 +00:00
engine-flutter-autoroll
74771f12af
Roll Flutter Engine from 5129b4919434 to 842cf254ec58 (3 revisions) ( #147670 )
...
5129b49194...842cf254ecchinmaygarde@google.com [Impeller] Wire up hardware buffer backed swapchains on Android. (flutter/engine#52087 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from bfbd738fb97b to 0b31f64bd8d8 (3 revisions) (flutter/engine#52492 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from d946408c559a to f5a429107c87 (2 revisions) (flutter/engine#52487 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 21:42:24 +00:00
PurplePolyhedron
68f8b536e2
fix DropdownMenu overflow ( #147233 )
...
fix `DropdownMenu` overflow issue in https://github.com/flutter/flutter/issues/147076 and https://github.com/flutter/flutter/issues/147173
However I believe the the menu placement issue in https://github.com/flutter/flutter/issues/147076 is a separate issue. It is not fixed here.
fixes https://github.com/flutter/flutter/issues/147173
2024-05-01 21:24:58 +00:00
Yegor
f256f68831
[web] remove platform_messages_integration test ( #147654 )
...
This functionality is already fully covered by https://github.com/flutter/engine/blob/main/lib/web_ui/test/engine/platform_views/message_handler_test.dart
This might help with https://github.com/flutter/flutter/issues/146189 a little.
2024-05-01 21:12:01 +00:00
Renzo Olivares
5181086fac
Fix TextField horizontal drag conflicts ( #147341 )
...
Currently on iOS `TextField` horizontal drag gestures will have precedence over parent horizontal drag gestures when competing with each other because the default `touchSlop` value used by `TextField` to calculate whether the threshold for a drag has been met is the same as the one used by parent horizontal drag gestures like `PageView`, and other `Scrollable`s. The default value is `18.0`, and because the `TextField` receives the `PointerEvent` first in this scenario, it always declares victory before any parent horizontal drag gestures has the chance to.
Native iOS behavior: The parent horizontal drag gestures will always win unless the drag originated on the cursor (collapsed selection), in that case the TextField cursor drag gestures will win.
This change:
* Introduces `BaseTapAndDragGestureRecognizer.eagerVictoryOnDrag` which can be used to configure the recognizer to declare victory immediately when it detects a drag, or when disabled it will wait until it is the last recognizer in the arena before declaring victory. The default behavior is that it declares victory immediately when the drag is detected.
* Eliminates the iOS cursor drag logic from `TextSelectionGestureDetector`, this logic is now delegated to the selection handle overlay which already had this logic in place.
* Enables iOS cursor to always beat other drag gestures by setting the touch slop lower.
* Disables `eagerVictoryOnDrag` for iOS to allow for parent drag gestures to win and match native behavior.
Fixes #124421 , Fixes #130198 , Fixes #142624 , Fixes #142447 , Fixes #127017
2024-05-01 20:51:54 +00:00
Nate
586e1fce1b
flutter/lib/src/: refactoring if-chains into switch expressions (#147472 )
...
Cleans up some code by porting if chains to switch statements.
2024-05-01 12:58:35 -07:00
auto-submit[bot]
5a41e1edac
Reverts "Draggable feedback positioning ( #145647 )" ( #147658 )
...
Reverts: flutter/flutter#145647
Initiated by: jmagman
Reason for reverting: Failing draggable_test in post-submit.
Original PR Author: timcreatedit
Reviewed By: {justinmc, goderbauer}
This change reverts the following previous change:
We changed the coordinates used to position the `Draggable` feedback by transforming them into the `Overlay`s coordinate space. This has no influence on any untransformed `Overlay`, most Flutter apps should be not affected.
This PR fixes the positioning of the feedback in transformed context (see #145639 for before video):
https://github.com/flutter/flutter/assets/42270125/df34e198-0667-453d-a27a-a79b2e2825a1
- fixes #145639
2024-05-01 18:26:27 +00:00
engine-flutter-autoroll
71a29452c0
Roll Flutter Engine from 0014e0353aa9 to 5129b4919434 (1 revision) ( #147655 )
...
0014e0353a...5129b4919430870216+gaaclarke@users.noreply.github.com [Impeller] Implements retry for `Picture.toImage` (flutter/engine#52470 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 17:35:06 +00:00
Yegor
ba6302e2d5
add lang attribute to the a11y_assessments app ( #147586 )
...
Since the app is used to assess Flutter's overall accessibility, the app
should follow at many guidelines as possible, including setting the
`lang` attribute.
Fixes b/338044851
2024-05-01 10:29:17 -07:00
Tim Lehmann
5f9e069111
Draggable feedback positioning ( #145647 )
...
Fixes a calculation in Draggable that was previously wrong when the target was transformed.
2024-05-01 09:56:23 -07:00
