Commit graph

7128 commits

Author SHA1 Message Date
Jenn Magder 8930e9b892
Catch FormatException parsing XCDevice._getAllDevices (#90967) 2021-10-08 13:08:04 -07:00
Jenn Magder 6253f9018c
Move DeviceManager into null migrated globals library (#91457) 2021-10-08 12:37:48 -07:00
Ian Hickson 61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson 5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Zachary Anderson 5188df0821
Revert gradle roll (#91459)
* Revert "Mark last failing test after gradle update as flaky. (#91423)"

This reverts commit 46a52d03bd.

* Revert "fix android template for Gradle 7 (#91411)"

This reverts commit 51d06d537f.

* Revert "Add explicit version for mac and windows openjdk. (#91408)"

This reverts commit bf429f2771.

* Revert "Update the openjdk version used by linux android tests. (#91405)"

This reverts commit 2144ab8b45.

* Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642)"

This reverts commit b6459f9b63.
2021-10-07 19:42:24 -07:00
Christopher Fujino f753168cb6
[flutter_tools] add working directory to ProcessException when pub get fails (#91436) 2021-10-07 18:08:04 -07:00
Majid Hajian 6c10f19b80
add package_name for consistency across all platforms (#88457) 2021-10-07 17:08:02 -07:00
Ian Hickson f25b833f27
Enable avoid_print lint. (#91444) 2021-10-07 16:48:04 -07:00
Mouad Debbar c2ea78d231
Revert "Enable avoid_print lint. (#91332)" (#91438)
This reverts commit cb378edc9e.
2021-10-07 16:16:17 -04:00
Jenn Magder 91d1e3ed8b
Default new project to the ios-signing-cert development team (#90021) 2021-10-07 10:23:02 -07:00
Ian Hickson cb378edc9e
Enable avoid_print lint. (#91332) 2021-10-07 09:53:03 -07:00
Taha Tesser 51d06d537f
fix android template for Gradle 7 (#91411) 2021-10-07 08:00:26 -07:00
Taha Tesser b6459f9b63
Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642) 2021-10-06 17:01:13 -07:00
Jenn Magder afbfc1f33a
Migrate assets, common, icon_tree_shaker to null safety (#91309) 2021-10-06 15:16:33 -07:00
Pierre-Louis 3e43c3e110
Categorize flutter tool commands (#87747) 2021-10-05 17:28:04 -07:00
Michael Goderbauer dc54c7f7be
Remove accidental print (#91317) 2021-10-05 15:13:03 -07:00
Greg Spencer 8405868db4
Update outdated platform directories in examples (#91125)
The first of three or four changes to update the platform directories of the packages in the Flutter repo that have out date platform code.

This batch includes updating the flutter_view example, updating the sanity check numbers in analyze.dart, and adding some missing Podfiles in the examples. I also eliminated some trailing whitespace in the templates for Android.
2021-10-05 14:52:11 -07:00
stuartmorgan 64fd68ed42
Don't generate plugin registry in ResidentWebRunner (#91281)
* Don't generate plugin registry in ResidentWebRunner

generateDartPluginRegistry was being set to true unconditionally in
ResidentRunner, bypassing the primary check in
DartPluginRegistrantTarget, and the targetPlatform was not set in that
codepath, bypassing the second after the changes in
https://github.com/flutter/flutter/pull/87991. This caused web hot
restarts to be slower due to doing unnecessary work.

This ensures that generateDartPluginRegistry is false in the
ResidentWebRunner to skip that unnecessary step.

Fixes https://github.com/flutter/flutter/issues/91262

* Formatting

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-10-05 12:27:53 -07:00
Ian Hickson 2bab6514b0
Enable avoid_implementing_value_types lint (#91078) 2021-10-04 13:48:04 -07:00
Ian Hickson 126cd7388e
Clean up dependency pins and update all packages (#91109) 2021-10-04 10:28:03 -07:00
Jenn Magder 61e2e86611
Add iOS build -destination flag (#90915) 2021-10-04 10:18:03 -07:00
Christopher Fujino 91dd3276fd
migrate vm service to null safety (#88320) 2021-10-02 10:18:03 -07:00
Littlegnal 1b73a35fba
Change project.buildDir in standalone subprojects property (#91030) 2021-10-01 17:18:05 -07:00
stuartmorgan 23cea26715
Add dartPluginClass support for Android and iOS (#87991) 2021-10-01 16:03:04 -07:00
Ian Hickson 4315cdcf76
Some test cleanup for flutter_tools. (#90227) 2021-10-01 10:38:02 -07:00
Ian Hickson 989f864497
Enable avoid_setters_without_getters (#91067) 2021-10-01 00:58:05 -07:00
stuartmorgan 97fb8c0560
Fix Dart plugin registrant interaction with 'flutter test' (#90288)
Building an application for a desktop platform that transitively included any Dart-based plugins (such as path_provider) broke `flutter test`, because its compilation was overriding the provided main (in this case, the test main) with `generated_main.dart` if it was present. This PR:
- Changes the `flutter test` compilation path to update `generated_main.dart`, so that the tests will work, and will include any registered Dart plugins.
- Makes using `generated_main.dart` during recompile opt-in, to try to reduce the chance of a similar bug happening with other codepaths in the future.

Fixes https://github.com/flutter/flutter/issues/88794
2021-09-30 20:25:13 -07:00
Christopher Fujino 738a7747cc
[flutter_tools] Handle disk device not found (#90996) 2021-09-30 17:28:57 -07:00
Jenn Magder c48c428e46
Xcode 13 as minimum recommended version (#90906) 2021-09-30 12:23:55 -07:00
Christopher Fujino afd84ad425
flutter update-packages (#90994) 2021-09-30 11:38:02 -07:00
Greg Spencer 01af8e5987
Make flutter update-packages run in parallel (#91006)
This modifies the flutter update-packages and flutter update-packages --force-upgrade commands so that the many invocations of "dart pub get" in each repo project run in parallel instead of in series.
2021-09-30 10:26:31 -07:00
Jenn Magder faaca13f22
Catch FormatException from bad simulator log output (#90966) 2021-09-30 09:33:04 -07:00
Kenzie (Schmoll) Davisson 5a85c0d81c
Launch DevTools from the 'dart devtools' command instead of pub (#90894) 2021-09-29 15:32:24 -07:00
Nicholas Shahan 3074c9e04b
Add tests for web library platform defines (#90620) 2021-09-28 22:08:04 -07:00
Greg Spencer ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021)
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
2021-09-28 09:32:06 -07:00
Jason Simmons cd19bc6007
Do not retry if pub get is run in offline mode (#90394) 2021-09-27 08:18:06 -07:00
Christopher Fujino 61bce1d83b
[flutter_tools] remove non-null check from AndroidValidator (#90090) 2021-09-25 16:53:06 -07:00
Jenn Magder 1b53f7beba
Migrate iOS project to Xcode 13 compatibility (#90304) 2021-09-22 13:23:05 -07:00
chunhtai 8d7068694b
Fixes resident_web_runner_test initialize the mock correctly (#90546) 2021-09-22 12:58:21 -07:00
Jason Simmons c761c6c2d4
Fix an unnecessary_import analyzer error in the skeleton app template (#90417) 2021-09-20 15:18:37 -07:00
Jason Simmons 58056bbe74
Close the IntegrationTestTestDevice stream when the VM service shuts down (#90022) 2021-09-17 19:18:03 -07:00
Liam Appelbe 9afbab8477
Use report_lines flag in flutter coverage (#90142)
* Use the report lines flag

* Handle major version bumps in the version check

* Fix existing tests and add a new test
2021-09-16 11:33:32 -07:00
Ahmed Ashour eb185d73ce
internationalization: fix select with incorrect message (#90096) 2021-09-16 09:23:22 -07:00
Jenn Magder ab6f2fc8ce
Set BUILD_DIR when determining if plugins support arm64 simulators (#90088) 2021-09-15 18:37:04 -07:00
Kate Lovett 65d8dd988d
Update md5 method in flutter_goldens_client (#90154) 2021-09-15 17:42:05 -07:00
Sam Rawlins bcb5db7758
Remove "unnecessary" imports from packages/ (#89795) 2021-09-15 01:27:02 -07:00
Christopher Fujino a2cd16ba82
use test logger, which does not allow colors (#90010) 2021-09-14 11:22:02 -07:00
Michael Thomsen b889915997
Change min Dart SDK constraint to track actual version (#88743) 2021-09-14 14:08:36 +02:00
Jason Simmons fad5e4cf89
Remove a redundant test case in the flutter_tools create_test (#89872) 2021-09-13 13:37:07 -07:00