Taha Tesser
8363e78280
Fix SearchAnchor
triggers unnecessary suggestions builder calls ( #143443 )
...
fixes [`SearchAnchor` triggers extra search operations](https://github.com/flutter/flutter/issues/139880 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
Future<List<String>> createFuture() async {
return List.generate(1000, (index) => "Hello World!");
}
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
title: 'Flutter Demo',
home: MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
final SearchController controller = SearchController();
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
title: Text(widget.title),
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
SearchAnchor(
searchController: controller,
suggestionsBuilder: (suggestionsContext, controller) {
final resultFuture = createFuture();
return [
FutureBuilder(
future: resultFuture,
builder: ((context, snapshot) {
if (snapshot.connectionState != ConnectionState.done) {
return const LinearProgressIndicator();
}
final result = snapshot.data;
if (result == null) {
return const LinearProgressIndicator();
}
return ListView.builder(
shrinkWrap: true,
physics: const NeverScrollableScrollPhysics(),
itemCount: result.length,
itemBuilder: (BuildContext context, int index) {
final root = result[index];
return ListTile(
leading: const Icon(Icons.article),
title: Text(root),
subtitle: Text(
root,
overflow: TextOverflow.ellipsis,
style: TextStyle(
color: Theme.of(suggestionsContext)
.colorScheme
.onSurfaceVariant,
),
),
onTap: () {},
);
},
);
}),
),
];
},
builder: (BuildContext context, SearchController controller) {
return IconButton(
onPressed: () {
controller.openView();
},
icon: const Icon(Icons.search),
);
},
),
],
),
),
);
}
}
```
</details>
### Before
https://github.com/flutter/flutter/assets/48603081/69f6dfdc-9f92-4d2e-8a3e-984fce25f9e4
### After
https://github.com/flutter/flutter/assets/48603081/be105e2c-51d8-4cb0-a75b-f5f41d948e5e
2024-03-25 22:58:11 +00:00
Jesse
2832611da8
Refactor add_to_app_life_cycle_tests ( #145546 )
...
Refactor add_to_app_life_cycle_tests in order to reduce testing logic in test.dart, create a suite_runners directory and allow for later implementing package:test onto add_to_app_life_cycle_tests
Part of https://github.com/flutter/flutter/issues/145482
2024-03-25 22:44:58 +00:00
engine-flutter-autoroll
b05937d3dc
Roll Flutter Engine from 04191a122e9a to 5fc95a3277ea (3 revisions) ( #145722 )
...
04191a122e...5fc95a3277
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 625d04f3a7c5 to 7ffd936a66df (7 revisions) (flutter/engine#51657 )
2024-03-25 lauren@selfisekai.rocks font_subset tests: name correct variant in exception (flutter/engine#51492 )
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 8a587a10323f to 625d04f3a7c5 (5 revisions) (flutter/engine#51655 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 21:51:21 +00:00
Taha Tesser
5e19b33534
Fix vertical Stepper
draws connector on the last step ( #145703 )
...
fixes [Vertical stepper shows line after last step](https://github.com/flutter/flutter/issues/144376 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: Stepper(
currentStep: 1,
steps: const <Step>[
Step(
title: Text("Step 1"),
content: Text("Content 1"),
),
Step(
title: Text("Step 2"),
content: Text("Content 2"),
),
],
),
),
),
);
}
}
```
</details>
### Before
![Screenshot 2024-03-25 at 18 36 32](https://github.com/flutter/flutter/assets/48603081/af859a88-7ec8-4432-8eec-f8eb72706b57 )
### After
![Screenshot 2024-03-25 at 18 36 24](https://github.com/flutter/flutter/assets/48603081/994325b2-4bd4-44ef-9473-245d3492faf7 )
2024-03-25 21:47:05 +00:00
Michael Goderbauer
330a2ca2ab
Update links in analysis_options.yaml ( #145706 )
...
According to the [readme](https://github.com/dart-lang/linter?tab=readme-ov-file#repository-has-moved ) of the linter repository, the source of truth for the linter has moved to the SDK repository. This updates the link to `all.yaml` in our file.
While I am in here, I also updated two other links that were outdated.
2024-03-25 21:47:03 +00:00
Kenzie Davisson
31f4f2b6c0
Add a --print-dtd
flag to print the DTD address served by DevTools server ( #144272 )
2024-03-25 13:04:18 -07:00
engine-flutter-autoroll
dbdcead932
Roll Flutter Engine from ef896e942f44 to 04191a122e9a (1 revision) ( #145709 )
...
ef896e942f...04191a122e
2024-03-25 jonahwilliams@google.com [Impeller] fix unbalanced restores. (flutter/engine#51648 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 18:17:57 +00:00
Ikko Eltociear Ashimine
9fa731ddf8
Update semantics.dart ( #145683 )
...
loosing -> losing
2024-03-25 18:17:54 +00:00
Kostia Sokolovskyi
453a04d9f3
TwoDimensionalChildDelegate should dispatch creation and disposal events ( #145684 )
2024-03-25 10:45:02 -07:00
Kostia Sokolovskyi
47bfa827ba
Memory leaks clean up 1 ( #145691 )
2024-03-25 10:36:42 -07:00
engine-flutter-autoroll
2dd276487b
Roll Flutter Engine from 2e8d77dbb0f0 to ef896e942f44 (1 revision) ( #145705 )
...
2e8d77dbb0...ef896e942f
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from e7ae039f5b1b to 8a587a10323f (1 revision) (flutter/engine#51654 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 17:35:09 +00:00
Sahil Kachhap
a9f18b803b
[Fix]: Searchbar doesn't lose focus when tapped outside ( #145232 )
...
Added a Fix to search bar that allows it be unfocused when tapped anywhere outside the search bar.
I have attached below the app flow after implementing the fix.
https://github.com/flutter/flutter/assets/54017876/70915c47-9b77-4a43-a128-8706107f921f
Issue that gets resolved by this fix : #145096
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-25 17:02:07 +00:00
Kostia Sokolovskyi
2851ed3202
Fix typo in hitTest docs ( #145677 )
...
This PR fixes the typo in the `hitTest` method documentation.
2024-03-25 17:00:06 +00:00
engine-flutter-autoroll
b39660df8f
Roll Packages from 611aea1657fb to 28d126c54c63 (1 revision) ( #145690 )
...
611aea1657...28d126c54c
2024-03-25 engine-flutter-autoroll@skia.org Roll Flutter from 18340ea16c
to 14774b95c2
(20 revisions) (flutter/packages#6376 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 15:49:39 +00:00
Daco Harkes
baa54fdd76
[deps] Bump native assets dependencies ( #145612 )
...
Roll of a bunch of breaking changes from the native_assets_builder and
native_assets_cli upstream. Most notably:
* https://github.com/dart-lang/native/pull/946
* https://github.com/dart-lang/native/pull/1018
* https://github.com/dart-lang/native/pull/1019
This PR also updates the template in `flutter create
--template=package_ffi` to use the rewritten API.
This PR does not change any functionality in Flutter.
For reference, the same roll in the Dart SDK:
* https://dart-review.googlesource.com/c/sdk/+/357605
* https://dart-review.googlesource.com/c/sdk/+/357623
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-03-25 15:02:49 +01:00
engine-flutter-autoroll
280037f6b1
Roll Flutter Engine from 857584c458ff to 2e8d77dbb0f0 (1 revision) ( #145678 )
...
857584c458...2e8d77dbb0
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from e6dc16a6d82d to e7ae039f5b1b (1 revision) (flutter/engine#51653 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 12:17:38 +00:00
Taha Tesser
23687c5260
Add AnimationStyle
to showBottomSheet
and showModalBottomSheet
( #145536 )
...
fixes [Introduce animation customizable with `AnimationStyle` to `BottomSheet`](https://github.com/flutter/flutter/issues/145532 )
### Default bottom sheet animation
![00-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/a295b002-b310-4dea-8bc4-23b1d299748c )
### Custom bottom sheet animation
![01-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/8c5c3d5f-e67d-4ed5-880d-f17d262087e1 )
### No bottom sheet animation
![02-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/872409d8-8a8d-4db9-b95b-7f96a62cdffc )
2024-03-25 08:39:05 +00:00
engine-flutter-autoroll
62adaff870
Roll Flutter Engine from ae758d54630d to 857584c458ff (2 revisions) ( #145673 )
...
ae758d5463...857584c458
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 7f2e8320bbfe to e6dc16a6d82d (1 revision) (flutter/engine#51652 )
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from df5d7a960d34 to 7f2e8320bbfe (1 revision) (flutter/engine#51651 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 08:00:16 +00:00
engine-flutter-autoroll
7f06c263a4
Roll Flutter Engine from efdde39a2a57 to ae758d54630d (1 revision) ( #145669 )
...
efdde39a2a...ae758d5463
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from fa486cd8b2d0 to df5d7a960d34 (1 revision) (flutter/engine#51650 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 04:33:34 +00:00
Andrew Kolos
cd785544fa
make hot reload reflect changes to asset transformer configurations ( #144660 )
...
In service of https://github.com/flutter/flutter/issues/143348
This PR makes hot reloads reflect changes to transformer configurations under the `assets` section in pubspec.yaml.
This PR is optimized for ease of implementation, and should not be merged as-is. If it is merged as-is, seriously consider creating a tech debt issue and assigning it to someone to make sure it gets resolved.
2024-03-25 04:13:11 +00:00
engine-flutter-autoroll
a5cf4191dc
Roll Flutter Engine from 0734f47f2a3d to efdde39a2a57 (2 revisions) ( #145668 )
...
0734f47f2a...efdde39a2a
2024-03-25 robert.ancell@canonical.com Add fl_standard_method_codec_new_with_message_codec() (flutter/engine#51599 )
2024-03-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IPZvFWIGJFJnJ409e... to ySBsQPn-0UgTQaXIw... (flutter/engine#51649 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from IPZvFWIGJFJn to ySBsQPn-0UgT
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-25 02:30:39 +00:00
engine-flutter-autoroll
52dc43f34f
Roll Flutter Engine from 7c139e0a4897 to 0734f47f2a3d (1 revision) ( #145662 )
...
7c139e0a48...0734f47f2a
2024-03-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 88f531b19ed5 to a783a4a043ec (1 revision) (flutter/engine#51647 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-24 19:26:11 +00:00
Polina Cherkasova
9fee27b244
Leak clean up. ( #144803 )
...
Fix some leaks and mark others.
[Known leaks](https://github.com/issues?q=is%3Aopen+is%3Aissue+label%3A%22a%3A+leak+tracking%22+-label%3A%22c%3A+new+feature%22+ )
2024-03-24 18:01:17 +00:00
Polina Cherkasova
e10049b2ff
Turn off randomization for leak detection bots. ( #145624 )
2024-03-24 17:47:23 +00:00
engine-flutter-autoroll
3373961720
Roll Flutter Engine from 2f5afdf62365 to 7c139e0a4897 (1 revision) ( #145655 )
...
2f5afdf623...7c139e0a48
2024-03-24 skia-flutter-autoroll@skia.org Roll Skia from 755ca0094a77 to fa486cd8b2d0 (2 revisions) (flutter/engine#51646 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-24 08:52:24 +00:00
engine-flutter-autoroll
d8854fd898
Roll Flutter Engine from 7aa8521e640e to 2f5afdf62365 (2 revisions) ( #145651 )
...
7aa8521e64...2f5afdf623
2024-03-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 567a19adbe9a to 88f531b19ed5 (1 revision) (flutter/engine#51644 )
2024-03-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _uuBNUJ6KbprCDWmC... to IPZvFWIGJFJnJ409e... (flutter/engine#51643 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from _uuBNUJ6Kbpr to IPZvFWIGJFJn
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-24 02:03:12 +00:00
engine-flutter-autoroll
638e47146d
Roll Flutter Engine from 689ea4b10b17 to 7aa8521e640e (1 revision) ( #145643 )
...
689ea4b10b...7aa8521e64
2024-03-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ed5b58c2cf7 to 567a19adbe9a (1 revision) (flutter/engine#51642 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-23 19:16:54 +00:00
engine-flutter-autoroll
73e78fd97c
Roll Flutter Engine from 42d4262b4b20 to 689ea4b10b17 (1 revision) ( #145636 )
...
42d4262b4b...689ea4b10b
2024-03-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 45169152b424 to 4ed5b58c2cf7 (1 revision) (flutter/engine#51641 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-23 14:18:25 +00:00
Pierre-Louis
9ae8a6b7d5
Reland #128236 "Improve build output for all platforms" ( #145495 )
...
Reland #128236 , reverted in https://github.com/flutter/flutter/pull/143125 , https://github.com/flutter/flutter/pull/145261 , and https://github.com/flutter/flutter/pull/145487 .
The errors were raised in post-submit tests on Windows. I have finally obtained a Windows machine to reproduce the errors locally and adjust the test (remove size expectation and rename output `.exe`).
## Original description
Improves the build output:
1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained)
### `apk`, `appbundle`
<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-03-23 12:05:21 +00:00
engine-flutter-autoroll
09b1afbd0d
Roll Flutter Engine from 7690eb12ded5 to 42d4262b4b20 (1 revision) ( #145635 )
...
7690eb12de...42d4262b4b
2024-03-23 skia-flutter-autoroll@skia.org Roll Skia from 2e99e3a5445c to 755ca0094a77 (1 revision) (flutter/engine#51639 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-23 08:23:30 +00:00
engine-flutter-autoroll
c7dc2ce605
Roll Flutter Engine from 8a51e124fbf1 to 7690eb12ded5 (1 revision) ( #145634 )
...
8a51e124fb...7690eb12de
2024-03-23 skia-flutter-autoroll@skia.org Roll Dart SDK from ad26f4885bf4 to 45169152b424 (2 revisions) (flutter/engine#51638 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-23 07:38:26 +00:00
engine-flutter-autoroll
085dbd85f9
Roll Flutter Engine from bc4fa4367edb to 8a51e124fbf1 (4 revisions) ( #145630 )
...
bc4fa4367e...8a51e124fb
2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from 10a460af3308 to 2e99e3a5445c (1 revision) (flutter/engine#51632 )
2024-03-22 skia-flutter-autoroll@skia.org Roll Dart SDK from a959c7def805 to ad26f4885bf4 (1 revision) (flutter/engine#51631 )
2024-03-22 1961493+harryterkelsen@users.noreply.github.com [web] Add ability to customize font fallback download URL (flutter/engine#51569 )
2024-03-22 jacksongardner@google.com [skwasm] Use test fonts while in debugEmulateFlutterTesterEnvironment mode (flutter/engine#51630 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-23 01:43:20 +00:00
dependabot[bot]
5b6a121dc5
Bump github/codeql-action from 3.24.8 to 3.24.9 ( #145627 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.8 to 3.24.9.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.9 - 22 Mar 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.5. <a href="https://redirect.github.com/github/codeql-action/pull/2203 ">#2203</a></li>
</ul>
<h2>3.24.8 - 18 Mar 2024</h2>
<ul>
<li>Improve the ease of debugging extraction issues by increasing the verbosity of the extractor logs when running in debug mode. <a href="https://redirect.github.com/github/codeql-action/pull/2195 ">#2195</a></li>
</ul>
<h2>3.24.7 - 12 Mar 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.4. <a href="https://redirect.github.com/github/codeql-action/pull/2185 ">#2185</a></li>
</ul>
<h2>3.24.6 - 29 Feb 2024</h2>
<p>No user facing changes.</p>
<h2>3.24.5 - 23 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156 ">#2156</a></li>
</ul>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151 ">#2151</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147 ">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141 ">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124 ">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121 ">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024 ">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106 ">#2106</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1b1aada464
"><code>1b1aada</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2208 ">#2208</a> from github/update-v3.24.9-09d4101d2</li>
<li><a href="6505708f95
"><code>6505708</code></a> Update changelog for v3.24.9</li>
<li><a href="09d4101d2b
"><code>09d4101</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2203 ">#2203</a> from github/update-bundle/codeql-bundle-v2.16.5</li>
<li><a href="a3ab02e645
"><code>a3ab02e</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.16.5</li>
<li><a href="9cf4574790
"><code>9cf4574</code></a> Add changelog note</li>
<li><a href="964f5e7811
"><code>964f5e7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2207 ">#2207</a> from github/henrymercer/more-processing-error-catego...</li>
<li><a href="9c0c35b370
"><code>9c0c35b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2206 ">#2206</a> from github/henrymercer/improved-autobuild-error-wit...</li>
<li><a href="c84e4c8e7b
"><code>c84e4c8</code></a> Mark some more processing errors as invalid SARIF upload requests</li>
<li><a href="4aca720110
"><code>4aca720</code></a> Improve error message when using build modes and autobuild fails</li>
<li><a href="7f375aeb76
"><code>7f375ae</code></a> Wrap configuration errors for all CLI commands</li>
<li>Additional commits viewable in <a href="05963f47d8...1b1aada464
">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.8&new-version=3.24.9 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-03-23 01:25:27 +00:00
godofredoc
716f82763a
Add workaround for bug adding unicode strings to test reports. ( #145607 )
...
When print is used inside tests its content is added to the test report as a string of unicode \u0000 making the test reporting parser fail. This PR cleans removes non json content every line of the report.
Bug: https://github.com/flutter/flutter/issues/145553
2024-03-23 01:04:05 +00:00
engine-flutter-autoroll
42d6f719cb
Roll Flutter Engine from 52142e428760 to bc4fa4367edb (1 revision) ( #145626 )
...
52142e4287...bc4fa4367e
2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from eb6976fc57cc to 10a460af3308 (3 revisions) (flutter/engine#51629 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-23 00:57:06 +00:00
David Iglesias
df75d249b2
[web][docs] Improve HtmlElementView widget docs. ( #145192 )
...
This PR expands the `HtmlElementView` widget DartDocs, with the following sections:
* Usage: How to use the widget, two ways:
* The `HtmlElementView.fromTagName` constructor
* The `PlatformViewRegistry` way
* Lifecycle: There's an `onCreated` callback on the widget. When does it get called?
* HTML Lifecycle: How to listen to events coming from the DOM.
* Visibility: what is the `isVisible` property for?
Small additional tweaks here and there to mention common pitfalls of using HtmlElementView on the web, and mentions to workarounds, like `package:pointer_interceptor`.
## Issues
* Fixes: https://github.com/flutter/flutter/issues/143922
* Fixes: https://github.com/flutter/flutter/issues/49634
* Related: https://github.com/flutter/website/issues/5063
2024-03-23 00:53:26 +00:00
Jackson Gardner
6836b0445a
Disable flaky text_editing_integration tests temporarily. ( #145629 )
...
I did some local debugging but couldn't get an exact root cause on the flakiness of these tests. Running them locally, there are a lot of assertions and exceptions being thrown in console, so I think we need to figure out what's going on there, but we should disable these for now to unblock the tree.
2024-03-23 00:34:18 +00:00
engine-flutter-autoroll
233dd97f1e
Roll Flutter Engine from cc8f752b81e5 to 52142e428760 (4 revisions) ( #145625 )
...
cc8f752b81...52142e4287
2024-03-22 jacksongardner@google.com [Skwasm] Respect the `debugDisableFallbackFonts` flag. (flutter/engine#51626 )
2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from 6484a450c457 to eb6976fc57cc (1 revision) (flutter/engine#51627 )
2024-03-22 jacksongardner@google.com [skwasm] Throw when gradient color stops are invalid in debug mode. (flutter/engine#51624 )
2024-03-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AW70sjrQKy2sSXpUA... to _uuBNUJ6KbprCDWmC... (flutter/engine#51625 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from AW70sjrQKy2s to _uuBNUJ6Kbpr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 21:11:25 +00:00
Kate Lovett
4820e0cd9f
Fix skipping golden comparator for CI environments ( #145619 )
...
Fixes https://github.com/flutter/flutter/issues/145618
The local file comparator was being used in post submit for the Linux coverage shard. This corrects it to choose the skipping comparator.
2024-03-22 20:45:35 +00:00
engine-flutter-autoroll
de68c9385d
Roll Flutter Engine from 68301f268278 to cc8f752b81e5 (1 revision) ( #145621 )
...
68301f2682...cc8f752b81
2024-03-22 jason-simmons@users.noreply.github.com [Impeller] Check for empty sizes when creating render targets in RenderTargetCache (flutter/engine#51597 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 19:40:30 +00:00
engine-flutter-autoroll
7009b926b5
Roll Packages from b7fbe68d4ec2 to 611aea1657fb (4 revisions) ( #145615 )
...
b7fbe68d4e...611aea1657
2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter from b96c13d1e9
to 18340ea16c
(26 revisions) (flutter/packages#6370 )
2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ba39319843
to 68bfaea224
(2 revisions) (flutter/packages#6368 )
2024-03-21 stuartmorgan@google.com [flutter_adaptive_scaffold] Remove broken link from README (flutter/packages#6364 )
2024-03-21 38110731+aliasgar4558@users.noreply.github.com [adaptive_scaffold] : ð : #110902 : Assertion added when try with less that 2 destinations. (flutter/packages#6360 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 18:40:08 +00:00
engine-flutter-autoroll
e9a0c354a1
Roll Flutter Engine from 63ff0dedd8e6 to 68301f268278 (2 revisions) ( #145613 )
...
63ff0dedd8...68301f2682
2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from 14c5a8540691 to 6484a450c457 (19 revisions) (flutter/engine#51623 )
2024-03-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b89d2de510d1 to a959c7def805 (4 revisions) (flutter/engine#51622 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 18:38:15 +00:00
engine-flutter-autoroll
26909e0a83
Roll Flutter Engine from 09dadce76828 to 63ff0dedd8e6 (2 revisions) ( #145611 )
...
09dadce768...63ff0dedd8
2024-03-22 737941+loic-sharma@users.noreply.github.com [Embedder API] Add helper to create viewport metrics (flutter/engine#51562 )
2024-03-22 737941+loic-sharma@users.noreply.github.com [Windows] Allow view controllers to not own the engine (flutter/engine#51570 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 17:23:23 +00:00
Kate Lovett
c5047e0ada
2DScrollView - Fix drag when one axis does not have enough content ( #145566 )
...
Fixes https://github.com/flutter/flutter/issues/144982
For reference, may have to do with #138442 when we reworked the gesture handling. The adjustments to the comments here were certainly from #138442 not updating them. Confused myself for a minute or two. ð
2024-03-22 16:42:19 +00:00
engine-flutter-autoroll
14774b95c2
Roll Flutter Engine from eba6e31498b8 to 09dadce76828 (1 revision) ( #145603 )
...
eba6e31498...09dadce768
2024-03-22 kjlubick@users.noreply.github.com Update one more use of deprecated GrDirectContext::MakeMetal (flutter/engine#51619 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 16:40:21 +00:00
engine-flutter-autoroll
7ad647ab92
Roll Flutter Engine from f9a34ae0b14f to eba6e31498b8 (1 revision) ( #145598 )
...
f9a34ae0b1...eba6e31498
2024-03-22 jason-simmons@users.noreply.github.com Post Dart message handling tasks directly to the platform task runner for isolates running on the platform thread (flutter/engine#51573 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 15:55:02 +00:00
Nate
7fb35db62f
Intensive if
chain refactoring ( #145194 )
...
This pull request refactors if-statements into switch expressions, as part of the effort to solve issue #144903 .
Making changes beyond just swapping syntax is more difficult (and also more difficult to review, I apologize), but much more satisfying too.
2024-03-22 13:55:06 +00:00
Bruno Leroux
859eb2eda9
Adds numpad navigation shortcuts for Linux ( #145464 )
...
## Description
This PR adds shortcuts related to numpad keys on Linux.
## Related Issue
Linux side for https://github.com/flutter/flutter/issues/144936
## Tests
Adds 2 tests.
2024-03-22 06:22:09 +00:00
engine-flutter-autoroll
5fab92f062
Roll Flutter Engine from 5a12de1beab7 to f9a34ae0b14f (1 revision) ( #145581 )
...
5a12de1bea...f9a34ae0b1
2024-03-22 26625149+0xZOne@users.noreply.github.com [Android] Fix the issue of blank or frozen pages in shared engine scenarios (flutter/engine#50947 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 04:56:12 +00:00
engine-flutter-autoroll
5058c2687e
Roll Flutter Engine from e2f324beac3b to 5a12de1beab7 (1 revision) ( #145578 )
...
e2f324beac...5a12de1bea
2024-03-21 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view][performance] overlay intersection (flutter/engine#50637 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 03:20:10 +00:00