Commit graph

11996 commits

Author SHA1 Message Date
Justin McCandless 92c21a5701
Fix a typo in the docs (#47391)
Just a docs text change.
2019-12-19 09:40:01 -08:00
Alexandre Ardhuin 78db965642 Reland implicit-casts: false (#47431) 2019-12-19 02:23:01 -08:00
Lau Ching Jun a4858782da
Revert "implicit-casts: false (#47199)" (#47428)
This reverts commit c235998acf.
2019-12-18 23:53:00 -08:00
Alexandre Ardhuin c235998acf implicit-casts: false (#47199) 2019-12-18 23:23:01 -08:00
Dan Field 0a9ff388bf Revert "Use platform appropriate filepaths" (#47395) 2019-12-18 18:08:02 -08:00
Lau Ching Jun d51956a9ea
Revert "Call setEditingState when text changes. (#47177)" (#47397)
This reverts commit d4b49ce9fc.
2019-12-18 18:03:24 -08:00
Lau Ching Jun 2df964581f
Revert "Flutter Web Driver Support (#45951)" (#47389)
This reverts commit 1ef0eadb45.
2019-12-18 17:02:31 -08:00
Lau Ching Jun f32dee6e30
Revert "Fix sliver geometry assert (#47027)" (#47390)
This reverts commit 117dfaf287.
2019-12-18 17:02:11 -08:00
Kate Lovett c281369356 Fix subdirectory output (#47256) 2019-12-18 16:33:01 -08:00
Gary Qian f05ab50370
Detect and dump flaky LineMetrics test data (#46213) 2019-12-19 09:28:02 +09:00
Jenn Magder 9184f4d6fb
Build iOS frameworks with relative output path (#47369) 2019-12-18 15:31:54 -08:00
Michael Goderbauer beb86d2cc4 Revert "Simplify Chip slightly (#47254)" (#47353) 2019-12-18 14:03:01 -08:00
Dan Field b23238890a Pipe through test-randomize-ordering-seed (#47243) 2019-12-18 13:58:01 -08:00
KalilDev b39ebcb55f Fix CupertinoContextMenuAction color behavior (#47151)
"destructive" color wasn't working for ContextMenuAction, this PR fixes it.
2019-12-18 13:57:40 -08:00
Lau Ching Jun bc67d22449
Revert "iOS UITextInput autocorrection prompt (#45354)" (#47373)
This reverts commit 0f8c0da0a9.
2019-12-18 13:56:44 -08:00
Shi-Hao Hong bde351eea2
Make AlertDialog scrollable through AlertDialog.scrollable parameter (#45079)
* Add AlertDialog.scrollable

* Add deprecation notice

* Ignore deprecation warning in dialog.dart with TODO
2019-12-18 12:31:16 -08:00
Lau Ching Jun 7850e2525f
Is executable doesn't mean a+x (#47359) 2019-12-18 12:21:46 -08:00
Angjie Li 1ef0eadb45 Flutter Web Driver Support (#45951)
* Support Flutter Driver test for Flutter Web application.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation issues.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation.

* Remove unused file from dartdoc check.

* Sync to date.

* Revert change to dartdoc.

* Address comments.

* Apply suggestions from code review

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update copyrights.

* Update allowed list for browsers.

* Verify command line arguments for Drive command is correctly parsed.

* Make waitUntilFirstFrameRasterized throw unimplementedError for Flutter Web Driver.

* Add comment for why sync WebDriver is used.

* Update documentations.

* Add more unit tests and update documentation.

* Configure test.dart so that web_extension_test will be executed with --platform=chrome.

* Revert unnecessary changes.

* Add new file path for Windows to blacklist.

* Reconstruct the structure of flutter_driver/test/src folder to remove filtering logic in dev/bots/test.dart/

* Fix path to web_extension_test.dart.

* Add instructions for how to use WebFlutterDriver.

* Update getLayerTree to use sendCommand instead of _sendCommand.

* Update pubspec files.
2019-12-18 10:45:39 -08:00
Alex Vincent f546aa7def Fix buildCounter returns a widget when set to return null. (#45749)
When buildCounter returns null it no longer produces a widget that takes up space.
2019-12-18 10:45:28 -08:00
Zachary Anderson d328e0cea0 [flutter_tool] Improve iOS mDNS failure error message (#47348) 2019-12-18 09:23:00 -08:00
Scott Hyndman ceef460a64 Correct name in DecorationImage error string (#47260) 2019-12-18 00:23:02 -08:00
Emmanuel Garcia 9884f9980f Change meaning of a plugin not supporting the android platform (#47015) 2019-12-17 19:48:01 -08:00
Shouichi Kamiya 0764548231 s/v-sync/Vsync/g (#46660) 2019-12-17 19:43:03 -08:00
神楽坂花火 0ec73510ec Add textScaleFactor to SelectableText (#44682) 2019-12-17 19:38:01 -08:00
Jenn Magder 65ad8d805a
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928)" (#47264)
This reverts commit e54e301d50.
2019-12-17 17:20:57 -08:00
Michael Goderbauer b7d221227c
Simplify Chip slightly (#47254) 2019-12-17 16:23:05 -08:00
LongCatIsLooong 0f8c0da0a9
iOS UITextInput autocorrection prompt (#45354) 2019-12-17 16:22:28 -08:00
Jenn Magder e54e301d50 Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928) 2019-12-17 16:13:01 -08:00
Emmanuel Garcia a15a81be21
Fix androidSdk NPE (#47187) 2019-12-17 14:10:36 -08:00
Jenn Magder 1cdf0f44db
Only set flutter run usage values for targeted device platforms (#46931) 2019-12-17 14:09:34 -08:00
Alek Åström 853c8c569f [flutter_tools] Add violating plugin name to validation errors (#46601) 2019-12-17 14:08:03 -08:00
George Wright 56f4eaf58c
Re-enable --no-link-platform for JIT mode (#47242) 2019-12-17 17:05:32 -05:00
Dan Field d4b49ce9fc
Call setEditingState when text changes. (#47177) 2019-12-17 14:03:04 -08:00
Michael Goderbauer 862289fa79 fix imports to unawaited (#47181) 2019-12-17 13:29:26 -08:00
LongCatIsLooong a82a399733
remove mediaQuery bottom padding when the tab scaffold has an opaque navbar (#46106) 2019-12-16 23:28:02 -08:00
Jonah Williams 0a2d8e0cce
[flutter_tool] Remove direct usage of package:linter in the flutter_tools (#47174) 2019-12-16 18:37:20 -08:00
LongCatIsLooong 117dfaf287
Fix sliver geometry assert (#47027) 2019-12-16 18:19:23 -08:00
Jonah Williams a723c94650
[flutter_tool] restructure ProjectFileInvalidator to no longer directly depend on context (#45739) 2019-12-16 18:12:04 -08:00
Shi-Hao Hong 7874bca248
Move localization executables to bin folder (#46251) 2019-12-16 17:30:57 -08:00
Shi-Hao Hong 7f56a61417
Fix isDense default for DropdownButtonFormField (#47160) 2019-12-16 16:40:15 -08:00
Alexandre Ardhuin dfbd585668 implicit-casts:false in flutter/test (#46245) 2019-12-16 15:03:02 -08:00
Alexandre Ardhuin aa071efd17 implicit-casts:false in flutter/lib/src/cupertino (#45502) 2019-12-16 14:58:03 -08:00
Zachary Anderson a72cca137d
[flutter_tool] Print a helpful message on some mDNS failures (#47157) 2019-12-16 14:57:29 -08:00
George Wright 9a76b4209e
Add support for getting a string representation of the LayerTree (#47014) 2019-12-16 15:39:06 -05:00
Dan Field 467f3d49ec remove duplicative checks (#47026) 2019-12-16 12:38:02 -08:00
Kate Lovett b0b8b91b97
RenderProxySliver (#45942) 2019-12-16 12:37:57 -08:00
Kate Lovett 9024231030 SliverVisibility (#45582) 2019-12-16 12:23:03 -08:00
Kate Lovett 89d72a1208 Throwing when goldctl cannot authorize/initialize (#45925) 2019-12-16 12:18:03 -08:00
Yuwen Yan fba96809f4 Add enableDrag configuration for showModalBottomSheet (#46685) 2019-12-16 12:14:24 -08:00
Justin McCandless c06bf6503a
iOS smart quote/dash configuration (#44923)
smartDashesType and smartQuotesType params for text fields to control iOS's smart punctuation feature.
2019-12-13 17:42:35 -05:00
Dan Field 1bca434cdd
Check for NaN in sliver constraints, improve error messaging (#46995) 2019-12-13 14:39:07 -08:00
Dan Field 82f6d43bf1
Avoid NaN for shrinkwrapping viewports (#46265) 2019-12-13 14:36:53 -08:00
Todd Volkert fc9b30a4f1
Revert "flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917)" (#46999)
This reverts commit f28592018d.

It broke forbidden_imports_test, which uses a custom ignore directive.
2019-12-13 12:23:12 -08:00
Sam Rawlins f28592018d flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917) 2019-12-13 12:03:02 -08:00
liyuqian 6a5ef29a75 More clarifications on mutating Widget's children (#46725) 2019-12-13 09:53:01 -08:00
Alexandre Ardhuin d81d91606a
implicit-casts:false in flutter/lib/src/material (#45567)
* implicit-casts:false in flutter/lib/src/material

* address review comments
2019-12-13 08:55:12 +01:00
Jonah Williams 0497235c20
[flutter_tool] experimental resident web runner is not debuggable (#46916) 2019-12-12 19:05:48 -08:00
Jenn Magder dfa6eb31a0
Revert "flutter run FULL_PRODUCT_NAME (#46838)" (#46925) 2019-12-12 17:34:54 -08:00
Jenn Magder 7a7e2bb247 flutter run FULL_PRODUCT_NAME (#46838) 2019-12-12 17:03:01 -08:00
Jonah Williams 5ba2830c83
[flutter_tool][gallery] Standardize target platform override behavior in tool and update flutter gallery to support it (#46206) 2019-12-12 15:20:52 -08:00
Hans Muller 187c89b69d
Remove accentTextTheme from sliders and chips, tests and docs (#46801) 2019-12-12 15:14:01 -08:00
Jonah Williams 23b7853dfd
[flutter_tool] remove ability to disable Fingerprinter with DISABLE_FLUTTER_BUILD_CACHE env variable (#46913) 2019-12-12 15:12:53 -08:00
Jonah Williams 8ca55605c8
[flutter_tool] forward device-vmservice-port to iOS device launch arguments (#46822) 2019-12-12 13:55:42 -08:00
Jonah Williams 592a842b86
[flutter_tool] fix NPE in daemon caused by returning null connection info from experimental web runner (#46909) 2019-12-12 13:55:09 -08:00
Dan Field 948e2b0101 Avoid exceptions for control flow (#46897) 2019-12-12 13:53:01 -08:00
Emmanuel Garcia a467932d5b
Skip plugins that don't have an android impl when building AARs (#46835) 2019-12-12 12:38:09 -08:00
Danny Tuppeny 4944622b5d
Support URL tunnelling (pass dwds UrlEncoder through to editors via daemon) (#44271)
* Prposal for supporting URL tunnelling

* Update daemon.md

* Add the ability for daemon to call clients to expose URLs

* Fix dwds mock in web_fs tests

* Fix type error

* Remove build_runner import from run

* Move appStartedTime back to after the app has started

* Remove nested DI scope and pass urlTunneller down

* Fix import

* Tweak TODO

* Fix existing tests

* Fix spec to use result instead of params for response object

* Fix exposeUrl to use a url field, as spec'd

* Test that the daemon's exposeUrl sends a request and handles the response
2019-12-12 18:43:58 +00:00
Lau Ching Jun be53bc14aa
Reset the global variable before running a test. (#46203)
The variable debugDisableShadows wasn't reset before each test, so the
output of the test is different depending on whether the previous test
has passed.
2019-12-12 10:37:42 -08:00
Lau Ching Jun 535526b03c
Enable web for some of the golden tests (#46820)
* Make golden test timeout longer, some tests are flaky if the timeout is too short

* Enable some golden tests for web
2019-12-12 10:36:41 -08:00
Sean Freiburg 418b814555 Add buildNumber param to "flutter build aar" command (#46291) 2019-12-12 10:28:01 -08:00
Emmanuel Garcia 354f80b84a
Check and give execute permission to Gradle if needed (#46748) 2019-12-11 16:36:03 -08:00
Jonah Williams 8b88c8296f
remove test_api dependency from flutter_tools/base/io (#46796) 2019-12-11 13:31:30 -08:00
Jonah Williams d0e5824040
[flutter_tool] Update require.js artifact location for tests (#46787) 2019-12-11 12:56:58 -08:00
Zachary Anderson 895ffc80dc
[flutter_tool] Handling of certain unrecoverable filesystem errors (#46617) 2019-12-11 12:54:36 -08:00
Kate Lovett ceab1248d0
Use FlutterLocalFileComparator when user permission denied on Cirrus (#46688) 2019-12-11 11:03:21 -08:00
Alexandre Ardhuin 36e599eb5d
implicit-casts:false in flutter_localizations (#45241) 2019-12-11 07:27:13 +01:00
Jonah Williams 01953a1015
[flutter_tool] fix NPE in log reader for web server device (#46729) 2019-12-10 16:14:48 -08:00
Taufiq Rahman c5f61ac3e8 Feature: ExpandIcon should use the size parameter (#45712)
* ExpandIcon should use the size parameter
2019-12-10 15:18:56 -05:00
Koichi Ishida 4938ea0385 Fix typo in gradle tools exit message (#46580) 2019-12-10 13:41:31 -05:00
Jonah Williams bda9d90804
[flutter_tool] Reland: support --fast-start for Android applications (as an opt-in) (#46140) 2019-12-10 10:26:14 -08:00
Shi-Hao Hong 0bec3dc3d2
Add UniqueKey documentation regarding const constructor (#46647) 2019-12-10 13:24:58 -05:00
Shi-Hao Hong ac9fefdfa6
Fix InputDecorator.isDense typo from true -> false (#46648) 2019-12-10 13:24:44 -05:00
Sebastian Döll 645c32311e Set modal bottom sheet barrier color (#45067) 2019-12-10 10:07:32 -08:00
Anthony 8a205f8194
Revert "Made the behavior for caching large images modular. (#46010)" (#46629)
This reverts commit 86dd664fef.
2019-12-10 11:44:52 -05:00
Jonah Williams 81aa2710d2
[flutter_tool] add a vmservice API for hot ui requests (#45649) 2019-12-09 21:31:34 -08:00
Jonah Williams 523ac7b6f5
[flutter_tool] Always re-copy Framework/podspec when regenerating iOS module project (#45877) 2019-12-09 21:18:09 -08:00
Jonah Williams d0526d3f92
[flutter_tool] Prevent accidental calls to io.exit in unit tests (#46639) 2019-12-09 18:58:29 -08:00
Ian Hickson 14145a4ec9 Try re-enabling all these tests. (#46615) 2019-12-09 18:58:02 -08:00
Jonah Williams a491697893
[flutter_tool] Ensure dependency constraint for templates created with a driver test are correct 2019-12-09 17:32:03 -08:00
Christopher Fujino 0268510480 Fix analytics regression (#46242) 2019-12-09 15:13:02 -08:00
Tong Mu a4f7a0dfb9
Revert changes to TestPointer; MouseTracker no longer relies on Add events (#46285)
* Revert test pointer

* Synthesize new state
2019-12-09 15:12:11 -08:00
Jonah Williams 63cc4ad3aa
Revert "[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210)" (#46630)
This reverts commit b698c9d72e.
2019-12-09 13:13:59 -08:00
Jonah Williams b698c9d72e
[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210) 2019-12-09 13:01:37 -08:00
Emmanuel Garcia f264d6c277
Allow plugins that don't support the Android platform (#46282) 2019-12-08 20:04:19 -08:00
Lau Ching Jun c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Tom Robinson 9233b53255 Update SliverPersistentHeader docs (#46081) 2019-12-06 14:17:29 -08:00
Amr Yousef 237c478683 Update iOS build signing error message (#45835) 2019-12-06 10:41:06 -08:00
Jonah Williams 7f235ea8bc
Mitigation for current tool test skips on CI (#46181) 2019-12-05 23:16:25 -08:00
Tong Mu ad20d368ff Fix null event crash in TapGestureRecognizer (#45943) 2019-12-05 19:33:01 -08:00
Greg Spencer bc7ed36db5
Add visualDensity to checkbox, radio, icon button, and chip. (#46091)
This adds a visualDensity attribute to checkbox, radio, icon button, and chip.
2019-12-05 17:36:42 -08:00