Commit graph

9911 commits

Author SHA1 Message Date
Ian Hickson 80d6095d98
Fix ShapeDecoration (#14009)
And add a test that catches these problems.
2018-01-12 15:03:51 -08:00
Sam Rawlins e8b666249a Bump collection dependency to 1.14.5 (#14048) 2018-01-12 14:33:26 -08:00
Yegor 6028fe85bb
mark complex_layout_scroll_perf_ios__timeline_summary as flaky\ (#14080) 2018-01-12 13:33:54 -08:00
Ian Hickson 8cf109d20f
Reland #14054 after having landed all the engine commits in between (#14064)
This gets us back to where we were a few minutes ago.
2018-01-11 23:21:53 -08:00
Ian Hickson e859995d11
Update engine.version 2018-01-11 22:29:07 -08:00
Ian Hickson 2ff39d88a6
Update engine.version 2018-01-11 22:28:57 -08:00
Ian Hickson cafc5dc5f0
Update engine.version 2018-01-11 22:28:46 -08:00
Ian Hickson 6fd5f265a0
Update engine.version 2018-01-11 22:28:34 -08:00
Ian Hickson 34bbc58a1d
Update engine.version 2018-01-11 22:28:19 -08:00
Ian Hickson 5c3ca9f625
Update engine.version 2018-01-11 22:28:05 -08:00
Ian Hickson 908db567c9
Update engine.version 2018-01-11 22:27:49 -08:00
Ian Hickson 78dcc0e685
Revert "Revive "Push physical layers with paths instead of rects in RenderPhy… (#14054)" (#14063)
This reverts commit 592f297922.
2018-01-11 22:27:11 -08:00
amirh 592f297922
Revive "Push physical layers with paths instead of rects in RenderPhy… (#14054)
* Revive "Push physical layers with paths instead of rects in RenderPhysicalModel. (#13942)"

That commit was reverted due to a performance problem which has now been
fixed.

* Roll engine 05fe72d068e19c7886e8d27f9b004201d5ad1300
2018-01-11 18:54:12 -08:00
Alexander Aprelev a48185a6ad
When targeting iOS sim in preview-dart-2, always compile. (#14059)
Fixes https://github.com/flutter/flutter/issues/14058.
2018-01-11 18:19:28 -08:00
Alexander Aprelev e2e3c5df05
Reland 9534082fc0 with fix for incremen… (#14040)
* Reland 9534082fc0 with fix for incremental compilation.

When in incremental mode, awaiting exitCode won't work because compiler is not expected to exit after compilation.
Instead listen for stdout stream closing and report error if outputFilename has not been received.

* Fix lints
2018-01-11 14:33:50 -08:00
Alexander Aprelev bedf987fc8
Pipe strong mode option for iOS simulator. (#14002) 2018-01-11 14:08:28 -08:00
Alexander Aprelev 991765780b
Fix handling --preview-dart-2 for ios (#14016)
* Fix handling --preview-dart-2 for ios

* final var
2018-01-11 13:24:51 -08:00
Devon Carew ccc0d29454
send 'reloadRecommended' info to IDEs (#13996)
* send 'reloadRecommended' info to IDEs

* rename hint ==> hintMessage
2018-01-11 12:55:00 -08:00
Sebastiano Poggi 2a07f3f211 Fix typo in framework.dart private method name (#14046) 2018-01-11 21:15:34 +01:00
Leaf Petersen 1dca1b22e8
Remove use of "--assert-initializer" flag from CONTRIBUTING.md (#14032)
* Remove mention of --assert-initializer from CONTRIBUTING.md
* Remove options variable as well
2018-01-11 08:55:14 -08:00
Michael Thomsen 62ea62a729
Remove enableAssertInitializer from analysis options as it's not needed in Dart 2 (#14042) 2018-01-11 16:52:34 +01:00
Mikkel Nygaard Ravn aad36ab7dd
Remove large int support in standard message codec (#14011) 2018-01-11 08:47:16 +01:00
Alexandre Ardhuin 0fe1e5bf5b
apply upcoming lint prefer_const_literals_to_create_immutables (#14029) 2018-01-11 08:38:55 +01:00
Alexander Aprelev 5dc4ce85d9
Revert "Handle abnormal termination of frontend compiler. (#13982)" (#14037)
This reverts commit 9534082fc0.

Causes hot_mode_dev_cycle__preview_dart_2_benchmark test timeout.
2018-01-10 19:54:08 -08:00
Alexander Aprelev 9534082fc0
Handle abnormal termination of frontend compiler. (#13982)
* Check frontend_server exit code.

When frontend_server completes abnormally, flutter tools has to stop and let user know.

* Add tests
2018-01-10 17:51:08 -08:00
Jason Simmons 5c88f8f295
Update instructions for testing the buildbot recipes (#14033) 2018-01-10 17:05:47 -08:00
Alexander Aprelev f1e5551c45
Fix stage for hot_mode ios test. (#14034) 2018-01-10 17:05:33 -08:00
Michael Goderbauer 54e3333182
Use bundled mingit on Windows if available (#14025)
In the packaged ZIP files for Flutter we bundle mingit on Windows to make setup for our users easier (they don't have to download and install git anymore). This change makes Flutter use the bundled mingit if it is available and if git is not installed on the system.

This change will still require that users add `flutter\bin` to their path or they'll have to execute `flutter\bin\flutter.bat` directly. A follow-up PR will add a pre-configured Flutter Console that people can start with a double-click to minimize setup even further.

Also in this PR:
* If 7Zip is not available to unpack the Dart SDK try 7Zip's standalone version.
2018-01-10 16:48:39 -08:00
Ian Hickson 09270dcb0b
The Ink widget (#13900)
This provides a way to draw colors, images, and general decorations on Material widgets, without interfering with InkWells that are further descendants of the widget.

This thus provides a cleaner way to solve the issue of FlatButtons and InkWells not working when placed over Image widgets than the old hack of introducing a transparency Material.

Fixes #3782.

Also, some fixes to documentation, and remove a redundant property on the Image widget.
2018-01-10 16:42:45 -08:00
Leaf Petersen ab874da7be
Roll Dart SDK to 2.0.0-dev.16.0, along with associated package updates (#13857)
Rolling the Dart SDK to 2.0, with associated package updates.  

https://groups.google.com/forum/#!topic/flutter-dev/E22RdKAYjs8
2018-01-10 14:31:28 -08:00
Alexander Aprelev 5b02a5ec58
Fix iOS automatic signing on buildbots. (#14024) 2018-01-10 14:01:20 -08:00
Michael Goderbauer 9e51a60299
Reland #13918 (#14023)
* Revert "Reverting package changes until I can figure out how to fix Windows. (#14007)"

This reverts commit 6fda8ee821.

* Make prepare_package run on Windows
2018-01-10 13:37:36 -08:00
Alexander Aprelev 0c5dd8d31e
Add hot_mode preview_dart_2 tests for ios. (#14022)
* Add hot_mode preview_dart_2 tests for ios.

* Explicitly request ios os in the test.

* 2018
2018-01-10 13:06:53 -08:00
Jason Simmons 77872cc560
libtxt: update paragraph_text for current libtxt behavior (#14004)
* libtxt now calculates selection rectangles reflecting the heights of
differently styled text spans within a line (matching Blink)
* libtxt does not round the coordinates of selection rectangles (unlike Blink)
2018-01-10 10:27:59 -08:00
Michael Goderbauer 46629b7187
Do not crash when toggling Semantics on, off, on (#13999)
* Do not crash when toggeling Semantics on, off, on

* review comments
2018-01-10 10:12:36 -08:00
Ian Hickson 316d8e1c2c
Make DecoratedBox repaint after being reparented (#13927)
Fixes https://github.com/flutter/flutter/issues/12553

The root cause of https://github.com/flutter/flutter/issues/12553 was that when the refresh indicator went away, which happened after the avatars had started their image loads but before the avatars had loaded, the DecoratedBoxes, along with the rest of the list, got GlobalKey-reparented, which caused the RenderDecoratedBox objects to unregister from the DecorationImagePainters, but they never re-registered since the whole subtree was in a RepaintBoundary and was therefore not explicitly repainted when the tree got reattached.

This fixes the bug by explicitly requiring any RenderDecoratedBox to repaint when it's reattached. This is probably a little more aggressive than required; we could probably expose a flag on Decoration that says whether or not the onChanged handler will ever be invoked, and only call markNeedsPaint if that's true, but we'll do that if it turns out that there's a performance issue here.

(This patch also introduces a bunch of improved debugging information that I used to track down the bug.)
2018-01-09 20:26:37 -08:00
Greg Spencer 6fda8ee821
Reverting package changes until I can figure out how to fix Windows. (#14007)
* Revert "Fixed output validation. (#14005)"

This reverts commit d84398db72.

* Revert "Update package prep script to do async process execution and emit output as it happens. (#13918)"

This reverts commit b7169c1d95.
2018-01-09 19:47:19 -08:00
Greg Spencer d84398db72
Fixed output validation. (#14005) 2018-01-09 18:08:26 -08:00
Greg Spencer b7169c1d95
Update package prep script to do async process execution and emit output as it happens. (#13918)
- Switches to async process execution, which now shows output as it happens instead of in chunks when the process completes
-  Now uses ProcessManager so that it may be mocked for the test.
- Adds in the download and install of mingit on Windows.
- Updated package dependencies because of added dependency on process package.
2018-01-09 17:42:42 -08:00
Ben Konyi 64aac3d3cb Rolled engine to 5a72197b733c01537a6583fa3715155d9fc936ef 2018-01-09 16:19:32 -08:00
Hans Muller 03e8ab1f53
Add support for a new kind of InkSplash: the "ripple" (#13986) 2018-01-09 14:43:08 -08:00
xster c5c63dfd47
Don't flush touch events during first launch frame pre-warm (#13990)
* Lock events during runApp's warm up frame

* move to scheduler binding

* let the one scheduleWarmUpFrame api always lock

* tweak test
2018-01-09 14:05:12 -08:00
Michael Goderbauer 8a6e973739
Remove semantics boundary from gesture detector AND MORE (#13983)
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly.

Fixes https://github.com/flutter/flutter/issues/12589.
Fixes https://github.com/flutter/flutter/issues/11991.
See also https://github.com/flutter/flutter/issues/11993.

This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand.

In addition, the following minor changes are included in this PR:
* Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`.
* Logic optimizations for `markNeedsSemanticsUpdate` .
* Fix for edge case where `MergeSemantics` failed to merge semantics.
* Use of emojis to better indicate leaf merging in the printed semantics tree.
* Better assert message for adding invisible child semantics nodes.
* Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries.

Fixes https://github.com/flutter/flutter/issues/13943.
2018-01-09 13:31:59 -08:00
jcollins-g 33d8a03545
Revert "Make artifact downloading more robust for flaky networks" (#13995)
* Revert "Change github readme links to be served by github (#13929)"

This reverts commit fd516d9538.

* Revert " Rename SemanticsFlags to SemanticsFlag (#13994)"

This reverts commit 24e3f70536.

* Revert "Make artifact downloading more robust for flaky networks (#13984)"

This reverts commit 4d37e03e1d.
2018-01-09 12:15:58 -08:00
Michael Thomsen fd516d9538
Change github readme links to be served by github (#13929) 2018-01-09 19:37:59 +01:00
Michael Goderbauer 24e3f70536
Rename SemanticsFlags to SemanticsFlag (#13994)
to align with `SemanticsAction` and other enum-like types.
2018-01-09 10:31:23 -08:00
jcollins-g 4d37e03e1d
Make artifact downloading more robust for flaky networks (#13984)
* First version

* Add a clarifying comment

* Add verify to ZipDecoder.decodeBytes call

* Review comments

* Need OS Error for missing files

* FileSystemException, not OSError.
2018-01-09 10:30:42 -08:00
Ian Hickson 9b92c919a0
Imply stops on LinearGradient and RadialGradient if they're missing (#13987) 2018-01-09 08:22:17 -08:00
Ian Hickson 77711d4a3c
Try to work better on NFS (#13955)
(untested)
2018-01-08 23:19:21 -08:00
Ian Hickson 7cf58702c1
Wrap _debug flag setting in asserts. (#13974)
Fixes the last bits of #5759.
2018-01-08 21:39:50 -08:00