Commit graph

9998 commits

Author SHA1 Message Date
Jonah Williams 096439b417
add ignorable track-widget-creation flag to build and remove --track-widget-creation from xcode backend aot build aot (#31399) 2019-04-22 16:21:17 -07:00
Jonah Williams a476a08e62
check if project exists before regenerating platform specific tooling (#31342) 2019-04-22 15:18:15 -07:00
Jonah Williams 7f959d8b78
Add Xcode build script for macOS target (#31329) 2019-04-22 13:51:00 -07:00
xster 30637bfe28
Add more shuffle cupertino icons (#31326) 2019-04-22 11:21:47 -07:00
Stanislav Baranov e2a3c2ee45
Remove support for building dynamic patches on Android. (#31359) 2019-04-22 10:40:50 -07:00
Tong Mu 0fb6a05054
PointerDownEvent and PointerMoveEvent default buttons to 1 (#30579)
* Down and Move have default buttons = kPrimary.
2019-04-22 10:15:26 -07:00
Jonah Williams 18e294dbd7
throw toolExit instead of rethrowing on filesystem exceptions (#31404) 2019-04-22 09:56:14 -07:00
Todd Volkert b9170a9d9a
Add more breadcrumb docs to Transformation (#31420) 2019-04-22 09:53:03 -07:00
Todd Volkert 9a4a3fc62a
Add Widget of the Week video to SizedBox (#31421) 2019-04-22 09:52:41 -07:00
Greg Spencer 4218c0bc38
Implement focus traversal for desktop platforms, shoehorn edition. (#30040)
Implements focus traversal for desktop platforms, including re-implementing the existing focus manager and focus tree.

This implements a Focus widget that can be put into a widget tree to allow input focus to be given to a particular part of a widget tree.

It incorporates with the existing FocusScope and FocusNode infrastructure, and has minimal breakage to the API, although FocusScope.reparentIfNeeded is removed, replaced by a call to FocusAttachment.reparent(), so this is a breaking change:

FocusScopeNodes must now be attached to the focus tree using FocusScopeNode.attach, which takes a context and an optional onKey callback, and returns a FocusAttachment that should be kept by the widget that hosts the FocusScopeNode. This is necessary because of the need to make sure that the focus tree reflects the widget hierarchy.

Callers that used to call FocusScope(context).reparentIfNeeded in their build method will call reparent  on a FocusAttachment instead, which they will obtain by calling FocusScopeNode.attach in their initState method. Widgets that own FocusNodes will need to call dispose on the focus node in their dispose method.

Addresses #11344, #1608, #13264, and #1678
Fixes #30084
Fixes #26704
2019-04-22 09:51:40 -07:00
Dan Field 37bc48f26e
rectMoreOrLess equals, prep for 64bit rects (#30942)
* rectMoreOrLess equals, prep for 64bit rects
2019-04-22 09:40:19 -07:00
Danny Tuppeny 783d80d799
Add a note about events coming from the server (#31419) 2019-04-22 17:36:07 +01:00
chunhtai 77ab0b8321
Fix 25807: implement move for sliver multibox widget (#29188) 2019-04-22 09:28:53 -07:00
Stanislav Baranov 08445c8a01
Stop precaching the artifacts for dynamic mode. (#31282) 2019-04-22 09:05:38 -07:00
Keerti Parthasarathy b593f5167b
Add track-widget-creation flag to attach command (#31262)
* Add track-widget-creation flag to attach command

* use the flag
2019-04-22 07:51:33 -07:00
Justin McCandless 6e1b143fed
Text field scroll physics (#31088)
TextField and CupertinoTextField can now specify scrollPhysics. Cupertino defaults to bouncing now.
2019-04-22 07:42:59 -07:00
MH Johnson 0545c63b9b
Revert "[Material] Update slider and slider theme with new sizes, shapes, and color mappings (#30390)" (#31339)
This reverts commit b1039f0f1b.

(This is a temporary revert while some of our customers deal with the breaking changes involved.)
2019-04-19 20:41:32 -04:00
Ben Konyi 1459b1e91f
Fixed failing tests caused by introduction of authentication codes (#31315) 2019-04-19 11:45:53 -07:00
Christopher Fujino eaf058d81d
Add flutter attach documentation (#31279)
* add attach.md document
2019-04-19 08:50:30 -07:00
Ben Konyi a009d71101
Updated flutter_driver to support auth codes (#31310) 2019-04-19 07:57:04 -07:00
Ben Konyi 3764cb8515
Added support for authentication codes for the VM service. (#30857)
* Added support for authentication codes for the VM service.

Previously, a valid web socket connection would use the following URI:

`ws://127.0.0.1/ws`

Now, by default, the VM service requires a connection to be made with a
URI similar to the following:

`ws://127.0.0.1:8181/Ug_U0QVsqFs=/ws`

where `Ug_U0QVsqFs` is an authentication code generated and shared by
the
service.

This behavior can be disabled with the `--disable-service-auth-codes`
flag.
2019-04-18 21:01:50 -07:00
Devon Carew 086fd993c6
add daemon.log to the daemon spec (#31273)
* add daemon.log to the daemon spec

* mention use in flutter run --machine
2019-04-18 20:07:52 -07:00
stuartmorgan d9718aa4b9
Add desktop workflows to doctor (#31283)
The 'doctor' check to determine if any devices can be listed for the
device should consider desktop workflows as well.

This has no effect unless the environment variable to enable desktop
device listing is set.
2019-04-18 18:24:31 -07:00
Jonah Williams ac36e4423e
Add flutter run support for linux and windows (#31229) 2019-04-18 18:05:04 -07:00
Jonah Williams 65f45999a3
initial work on coverage generating script for tool (#29494) 2019-04-18 17:59:14 -07:00
Jonah Williams f5672b9316
add --force flag to precache (#31278) 2019-04-18 16:04:21 -07:00
chunhtai b275e11170
fix issue 12999: Make assets available during tests (#31207) 2019-04-18 15:31:47 -07:00
Jonah Williams e69a8a15b3
pass track widget creation flag through to build script (#31277) 2019-04-18 15:03:34 -07:00
Anthony b1039f0f1b
[Material] Update slider and slider theme with new sizes, shapes, and color mappings (#30390)
This PR makes a number of changes to the visual appearance of material sliders:

Sizes/Shapes
** enabled thumb radius from 6 to 10
** disabled thumb radius from 4 to 10 with no gap
** default track shape is a rounded rect rather than a rect
**
Colors
** all of the colors now use the new color scheme
** overlay opacity has been reduce from 16% to 12%
** value indicator text color now respects the indicator it is on by using onPrimary
** disabledThumb color no respects the surface it is on by using onSurface
The slider theme is also now constructed consistently with other theme objects within the ThemeData. By default, all values are null, and have default values that are resolved in the slider itself, rather than in the slider theme.
2019-04-18 17:02:17 -04:00
Efthymis Sarmpanis 2e6edaf49d Adds Tap Header Feature to ExpansionPanelList (#29390) 2019-04-18 13:53:55 -07:00
Devon Carew d075d647c3
remove the unused hintMessage and hintId fields from the reload results (#31267) 2019-04-18 11:00:54 -07:00
Jonah Williams da92fc1109
Add run capability for macOS target (#31218) 2019-04-17 22:40:26 -07:00
Jonah Williams 3c8c630f01
Allow disabling all fingerprint caches via environment variable (#31171) 2019-04-17 17:27:50 -07:00
Gary Qian 3c8e3b097f
Use full height of the glyph for caret height on Android v2 (#31210)
Will cause golden and Scuba changes. Caret will become taller and shift upwards by 2 pixels.
2019-04-17 15:50:03 -07:00
xster 1c332caed5
Commit a navigator.pop as soon as the back swipe is lifted (#30422) 2019-04-17 13:53:14 -07:00
xster fdf9a45313
Add some more cupertino icons (#30946) 2019-04-17 13:52:47 -07:00
xster 5f18d0f721
Clarify various CupertinoTabView docs (#31109) 2019-04-17 13:52:10 -07:00
Jonah Williams 86c938b5b3
Add desktop projects and build commands (experimental) (#31205) 2019-04-17 12:16:55 -07:00
Todd Volkert 1e2e96dbe4
Add breadcrumb to docs (#31178) 2019-04-17 10:59:23 -07:00
Todd Volkert a4ab0321ad
Rename Border.uniform() -> Border.fromSide() (#30792) 2019-04-17 10:58:42 -07:00
Gary Qian 0f5de8725e
Revert "Use full height of the glyph for caret height on Android" (#31159)
* Revert "Use full height of the glyph for caret height on Android (#30991)"

This reverts commit 96e1fc9c34.
2019-04-16 16:49:39 -07:00
Jonah Williams 5228a7851a
Fuchsia step 1: add SDK version file and artifact download (#31073) 2019-04-16 13:24:58 -07:00
Gary Qian 96e1fc9c34
Use full height of the glyph for caret height on Android (#30991) 2019-04-16 10:42:36 -07:00
Dima Rostopira e6f33e92a9 Add sorting to flutter version command (#31064) 2019-04-16 10:23:56 -07:00
Greg Spencer 857fe320e0
Update keycodes, fix a comment. (#30938)
Updates the keycodes by regenerating them using the script, and fixed a comment in the template to conform to style.
2019-04-16 08:02:11 -07:00
Alexander Aprelev d775908c7e
Download and handle product version of flutter patched sdk (#31063)
* Support release/debug flavors of flutter_patched_sdk

* Use [anyNamed] instead of [any] for mocking named arguments

* Fix use of local engine in release mode
2019-04-15 21:02:20 -07:00
Tom Robiquet 4ef0292790 Added opacity to cupertino switch when disabled (#29451) 2019-04-15 20:58:03 -07:00
Jonah Williams 1c779442a0
Add null checks to coverage collection (#31092) 2019-04-15 17:33:28 -07:00
xster 364d73c7d8
Make CupertinoNavigationBarBackButton correctly return an assert error (#30815) 2019-04-15 15:33:33 -07:00
liyuqian a8116e9ea3
Allow profile widget builds in profile mode (#30990)
## Description

Previously, such function is only available in the debug mode. But the
performance information is very noisy in debug mode with JIT. I feel
that such function is as important and useful as the performance overlay
and the `--trace-skia` option for the GPU thread.  So we should give it
the same ability to run in both profile and debug mode.

I've tested it using flutter_gallery in the profile mode. There's no
observable difference in the performance overlay between toggling widget
build profiling.

## Related Issues

https://github.com/flutter/flutter/issues/30984
2019-04-15 13:57:43 -07:00
Dan Field 330dc94c0f Check that ErrorWidget.builder is not modified after test (#30898) 2019-04-15 12:38:51 -07:00
Jonah Williams 28cb589cd3
make flutterProject option of CoverageCollector optional (#31074) 2019-04-15 12:26:43 -07:00
Christopher Fujino be5f345f33
New flag to flutter drive to skip installing fresh app on device (#30818)
* add a --build/--no-build flag to flutter drive command
2019-04-15 09:31:51 -07:00
Jonah Williams 715cb5132e
Fix bugs in contrast guideline and improve heuristic (#31000) 2019-04-15 09:01:09 -07:00
Jonah Williams 301eaa8c32
Make coverage, like, really fast (#30811) 2019-04-15 08:59:28 -07:00
Emily Fortuna ce6fbcea20
Allow mouse hover to only respond to some mouse events but not all. (#30886)
* Allow mouse hover to only respond to some mouse events but not all.
2019-04-11 16:29:21 -07:00
chunhtai fbeb5e0cf5
Fix issue 23527: Exception: RenderViewport exceeded its maximum number of layout cycles (#30809) 2019-04-11 16:23:11 -07:00
Greg Spencer 8bea3fb2eb
Keep hover annotation layers in sync with the mouse detector. (#30829)
Adds a paint after detaching/attaching hover annotations to keep the annotation layers in sync with the annotations attached to the mouse detector.

Fixes #30744
2019-04-11 13:11:22 -07:00
Siva e7c7a58d5d
Use identical instead of '==' in a constant expression. (#30921)
* Use identical instead of '==' in a constant expression.

* Fix analyzer warnings.

* Fix analyzer warnings.
2019-04-11 13:08:00 -07:00
Jonah Williams cadde2459b
Add toggle for debugProfileWidgetBuilds (#30867) 2019-04-11 12:44:33 -07:00
Justin McCandless ecb468f335
Baseline Aligned Row (#30746)
Text in a baseline aligned row now works, and the height of the row is properly calculated.
2019-04-11 09:32:22 -07:00
MH Johnson 3bbb8d8b77
[Material] Fix showDialog crasher caused by old contexts (#30754)
* Fix bug, add regression test.

* remove unnecessary space
2019-04-11 09:48:35 -04:00
Dan Field 42d3464d2e
Let sliver.dart _createErrorWidget work with other Widgets (#30880)
Credit to @ymback
2019-04-11 00:31:06 -07:00
xster 2736c8c19f
Add more dialog doc cross-reference (#30887) 2019-04-10 22:38:34 -07:00
Jonah Williams 259641c4b3
Allow downloading of desktop embedding artifacts (#30648) 2019-04-10 22:08:44 -07:00
LongCatIsLooong 1a3201bc74
CupertinoDatePicker initialDateTime accounts for minuteInterval (#30862)
initialDateTime should account for minuteInterval
2019-04-10 20:14:35 -07:00
LongCatIsLooong b8a1870d92
add golden tests for CupertinoDatePicker (#30828)
Add golden tests for CupertinoDatePicker
2019-04-10 19:46:23 -07:00
liyuqian 8ca7c4cbbd
Simplify toImage future handling (#30876)
Thanks to cbracken@'s suggestion on another Google-internal change.
2019-04-10 19:19:30 -07:00
champeauxr a5dd074b0d Fixed Table flex column layout error #30437 (#30470)
RenderTable._computeColumnWidths() had a logic error that caused flex columns to be collapsed to their minimum widths in certain situations dependent on the layout width constraint and the number of flex columns.
2019-04-10 18:53:27 -07:00
Dan Field d2790bd2bb
Check for invalid elevations (#30215)
* Check for invalid elevation usage in the layer tree
2019-04-10 14:57:46 -07:00
Sam Rawlins 83ddd98849 Fix additional @mustCallSuper indirect overrides and mixins (#30667) 2019-04-10 14:54:51 -07:00
Todd Volkert 499004779b
Revert "Add Form.onSaved (#30643)" (#30793)
This reverts commit 949023b276.
2019-04-10 14:49:10 -07:00
Tong Mu f34c2ef0a3
Revert "Remove pressure customization from some pointer events (#30414)" (#30873)
This reverts commit a821136997.
2019-04-10 14:14:12 -07:00
Tong Mu a821136997
Remove pressure customization from some pointer events (#30414)
* Remove pressure from PointerHoverEvent ctor
2019-04-10 12:40:33 -07:00
Jonah Williams 316d44989a
warn on uncomitted changes (#30235) 2019-04-10 12:24:53 -07:00
Jonah Williams f66ee3e470
Add semanticsLabel parameter to TextSpan (#30837) 2019-04-10 12:24:01 -07:00
Justin McCandless ed91a3be49
Fix cursor outside of input width (#30525)
* Disallow cursor from appearing beyond the width of the input.

* Test that verifies the cursor can't exceed the width of the input

* Use constant from editable.dart to explain 1 pixel difference in test

* Fix failing test that tested the case of overflowing spaces
2019-04-10 10:35:03 -05:00
xster 5a6c140d0d
Cupertino localization step 7: modularize material specific things out of gen_localizations.dart (#29822) 2019-04-10 01:24:58 -07:00
Shi-Hao Hong b3bb5cd6b0
Fix StatefulWidget and StatelessWidget Sample Documentation (#30814) 2019-04-09 19:32:00 -07:00
liyuqian eb30745faf
Print warning if flutter drive is run in debug (#30747)
## Description

Print actionable warnings if `flutter drive` (where most of our performance benchmarks come from) is run in debug mode and it tries to gather benchmarks using `traceAction`.

## Related Issues

https://github.com/flutter/flutter/issues/30625

## Tests

I added the following tests:
* drive_perf_debug_warning devicelab test
2019-04-09 18:55:42 -07:00
xster 5a4eaabaf1
Cupertino localization step 11: add more translation clarifications in the instructions (#30527) 2019-04-09 17:47:44 -07:00
Shi-Hao Hong c7d7ba1c2b
Update ExpansionPanelList Samples with Scaffold template (#30805) 2019-04-09 14:01:47 -07:00
Shi-Hao Hong 1835aac558
Update ListTile sample snippets to use Material Scaffold Template (#30800) 2019-04-09 13:46:31 -07:00
ShaLi Shaltiel a018264131 Updated package template .gitignore file (#27034) 2019-04-09 10:12:32 -07:00
Shi-Hao Hong 9f9c5c29ec
Embedded images and variations to ListTile sample code (#30537)
Also includes counter-examples for list items that differ from ListTile.
2019-04-09 10:10:57 -07:00
Michael Thomsen 811f1ad98f
Forward missing pub commands (#30115) 2019-04-09 17:03:09 +02:00
Jonah Williams 03817a995a
fix cast NPE in invokeListMethod and invokeMapMathod (#30760) 2019-04-09 07:22:25 -07:00
Jonah Williams ed49122aa3
register gradle wrapper as universal artifact (#30755) 2019-04-08 20:22:34 -07:00
xster e2b6a3a7a8
Cupertino localization step 6: add a GlobalCupertinoLocalizations base class with date time formatting (#29767) 2019-04-08 16:56:58 -07:00
Jonah Williams 9baffb97ca
Reland: Ensure that flutter run/drive/test/update_packages only downloads required artifacts (#30254) 2019-04-08 13:49:09 -07:00
Jonah Williams 99b4459944
Allow disabling experimental commands, devices on stable branch (#30153) 2019-04-08 13:48:21 -07:00
Lau Ching Jun 294d7ea0cf
Mark ios-deploy version 2.0.0 as bad (#30578)
Mark ios-deploy version 2.0.0 as bad.

ios-deploy before version 1.9.4 declares itself as v2.0.0
https://github.com/ios-control/ios-deploy/commits/master/src/ios-deploy/version.h
2019-04-08 12:37:43 -07:00
Todd Volkert 0b8403b61c
Add const Border.uniform() (#30640)
`Border.all()` is a factory constructor and thus not const
constructible. This change adds a `const Border.uniform()`
constructor and makes `Border.all()` delegate to it. This allows
callers to more likely be able to make their widget tree const
constructible.
2019-04-07 21:29:32 -07:00
Todd Volkert 949023b276
Add Form.onSaved (#30643)
When submitting data to a server, callers need a callback that will
get invoked after all the individual form fields are saved. If they
have a button that submits the form, they could just do this logic
in the click handler for the button (save the form, then submit to
the server), but if they have more ways than one to submit the form
(i.e. hitting enter while in a text form field), then it becomes
more convoluted and calls for a unified callback that will get
notified when the form is submitted.
2019-04-07 21:02:09 -07:00
Todd Volkert cb78274c3f
Make FormField._validate() return void (#30644)
None of its callers were using the return value, so no need to
invoke the `isValid` getter unnecessarily.
2019-04-07 21:01:33 -07:00
Todd Volkert 535523dbe0
Add docs to FormFieldValidator (#30645)
To describe what its return value represents
2019-04-07 21:00:53 -07:00
Dan Field d42db56b52
Add sample for ValueListenableBuilder (#30626)
* Add sample for ValueListenableBuilder
2019-04-06 20:14:41 -07:00
Hans Muller ab06d033ca
Fixed a typo in the Expanded API doc (#30563) 2019-04-05 17:40:38 -07:00
LongCatIsLooong e153883d43
Provide a default IconTheme in CupertinoTheme (#30521)
-* Inserted an `IconTheme` widget under `CupertinoTheme` to provide a default icon color when using `CupertinoTheme`.
* Changed `CupertinoTheme` to a `StatelessWidget`, to match the implementation of `Theme`
* Changed the nesting order of `Theme`'s sub widgets, to let `Theme.iconTheme` take precedence, so that `Theme`'s behavior is kept as is.
2019-04-05 15:57:29 -07:00
Tim Sneath 529189791c
Replace flutter.io with flutter.dev (#30562) 2019-04-05 11:39:30 -07:00