development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 19:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity
17398 commits 770 branches 974 tags 1.7 GiB
Commit graph

12220 commits

Author SHA1 Message Date
Dan Field 505af78ae1
StackTrace parser, fix assertion error message (#48343) 2020-01-07 22:49:27 -08:00
Dan Field 4552724f0e
Don't use local file system in devfs test (#48367) 2020-01-07 22:49:09 -08:00
Alexander Aprelev b4c79239da
Cleanup accidental use of global fs in test. (#48358) 
This is follow-up to ee7a37f1d3.
 2020-01-07 22:35:03 -08:00
Alexander Aprelev 317b9e786b
Revert "Document reasoning for why CustomMultiChildLayout size can't depend on children and how to do it (#47797)" (#48369) 
This reverts commit de2514c0e2 as it breaks analyze-linux and web_tests-0-linux checks.
 2020-01-07 21:42:18 -08:00
creativecreatorormaybenot de2514c0e2 Document reasoning for why CustomMultiChildLayout size can't depend on children and how to do it (#47797) 2020-01-07 18:48:01 -08:00
Zachary Anderson a1bf03f87a
Revert "Esarbanis flutter run help (#48314)" (#48351) 
This reverts commit 866fa64dce.
 2020-01-07 15:06:40 -08:00
Dan Field 134c2ff076 analytics ordering issue (#48278) 2020-01-07 12:23:02 -08:00
Jonah Williams bf6c4c4a41
[flutter_tools]web]Add support for --csp mode to build web (#48319) 2020-01-07 12:20:03 -08:00
Sam Rawlins 965ba387d4 Remove unused public static members of private classes/enums (#48218) 2020-01-07 12:18:02 -08:00
wise86-android c86517c0bb [issue 7293] add test for rettangle box decoration with boarder radius (#47915) 2020-01-07 12:13:02 -08:00
Zachary Anderson 866fa64dce
Esarbanis flutter run help (#48314) 
* Reword flutter run help screen.

* As per Hixie request, added Efthymios Sarmpanis to the AUTHORS file

* fix test

Co-authored-by: Efthymis Sarmpanis <e.sarbanis@gmail.com>
 2020-01-07 12:10:08 -08:00
Kate Lovett 76b21d2867 Refactor SliverFillRemaining (#47379) 2020-01-07 12:08:02 -08:00
Sam Rawlins 5005824763 Mark unused but desired private constructors as such (#46200) 2020-01-07 12:03:03 -08:00
Kate Lovett f974c295b5 SliverFadeTransition (#45950) 2020-01-07 11:58:01 -08:00
Alexandre Ardhuin 4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Dan Field d73b3682c9
Fix state in test (#48269) 2020-01-06 16:33:31 -08:00
Dan Field 79c4c38cc9 Make analyze once test not depend on test order or flutter create command (#48003) 2020-01-06 16:33:01 -08:00
Mouad Debbar f6a88d0309
Registering multiple transformed events should work (#48149) 2020-01-06 14:24:52 -08:00
Jonah Williams 2221a9f514
[flutter_tool] Cache the path context in the flutter tool (#48250) 
recomputing the path context in the getter violates flutter repo style guide and adds a small but measurable overhead to all path operations
 2020-01-06 13:57:13 -08:00
Dan Field ea799d97f4
.. (#48263) 2020-01-06 13:30:21 -08:00
Ben Konyi a0e5621956
Added showCheckboxColumn parameter to DataTable and PaginatedDataTable (#47552) 
`showCheckboxColumn` will determine whether or not selectable rows in
DateTable or PaginatedDataTable will contain a leading CheckBox.
 2020-01-06 16:29:36 -05:00
Jacob MacDonald c3f590a872
update dependencies for flutter_tool (#48260) 2020-01-06 13:08:06 -08:00
Jonah Williams ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable (#47398) 2020-01-06 11:04:20 -08:00
Dan Field 19c7550540 fix mockStopWatch creation (#48098) 2020-01-06 11:03:01 -08:00
神楽坂花火 80ee2ff04f Add Border.symmetric constructor (#47523) 2020-01-06 09:48:02 -08:00
Phil Quitslund 7fee0c52d3 mark widget == and hashCode as nonVirtual (#46900) 2020-01-06 09:43:02 -08:00
Alexandre Ardhuin 1fc43d9330
add key to constructors of public widgets (#47884) 
* add key to constructors of public widgets

* fix a test

* fix a test
 2020-01-06 17:41:54 +01:00
Jenn Magder 0aed0b61a1
Add newlines between plugin names in GitHub template (#46937) 2020-01-03 17:53:54 -08:00
Shi-Hao Hong fa1ebab88e
Added API docs on opening a Scaffold's drawer programmatically (#48152) 
* Added docs on how to set drawer to open only programmatically
 2020-01-03 15:20:48 -08:00
LongCatIsLooong adc6482784
Implement CupertinoDatepicker time/dateTime constraints (#44628) 2020-01-03 14:50:41 -08:00
LongCatIsLooong 7511d8c06a
fix MediaQuery override in CupertinoDatePicker (#48001) 2020-01-03 11:05:50 -08:00
Devon Carew c924f499f5
ignore a (potentially) unused import in generated code (#47593) 2020-01-03 11:04:03 -08:00
creativecreatorormaybenot b383bdfd1f Initial (#47831) 2020-01-03 10:53:32 -08:00
Shi-Hao Hong 62e436f049
Implement AlertDialog.actionsPadding and AlertDialog.buttonPadding (#47709) 
* Implement AlertDialog.actionsPadding and AlertDialog.buttonPadding
 2020-01-03 08:18:21 -08:00
Dan Field 7b69d137c8 reset state between runs of devFS tests (#48101) 2020-01-03 08:18:02 -08:00
Dan Field d7c347f027 make pub get test shufflable (#48095) 2020-01-03 08:13:03 -08:00
Dan Field 5ff7225450 fix io_test (#48097) 2020-01-02 19:53:02 -08:00
Angjie Li 9df1790f24 Flutter Web Driver Support (#47890) 2020-01-02 19:48:01 -08:00
chunhtai 57a93419b4
EditableText should not update textinput style when the textinput is … (#47904) 2020-01-02 16:19:52 -08:00
Jenn Magder dc99d61e5d Remove simulator arch in Profile and Release, App.xcframework (#48002) 2020-01-02 13:03:01 -08:00
Jenn Magder a6c3ffe10c Allow Xcode project Info.plist to be moved (#47993) 2020-01-02 12:03:02 -08:00
Dan Field 24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081) 
This reverts commit 04ea3183ce.
 2020-01-02 11:47:28 -08:00
Francisco Magdaleno 04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080) 
This reverts commit e768c92fbc.
 2020-01-02 09:25:59 -08:00
Ian Hickson e768c92fbc
Add many more global analyses. (#47875) 
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
 2019-12-30 17:12:19 -08:00
Kate Lovett 4fbef2a4a9
Revert "Testing tryjob triage (#47893)" (#47985) 
This reverts commit 659dc8129d.
 2019-12-30 13:09:14 -08:00
Kate Lovett 659dc8129d
Testing tryjob triage (#47893) 2019-12-30 09:24:47 -08:00
Devon Carew 43a8c24344
fix an analysis ignore for the missing_required_param hint (#47956) 2019-12-29 12:28:57 -08:00
神楽坂花火 b28dd0c296 Reland "Add brightness to CupertinoNavigationBar (fixes #46216) (#47521)" (#47855) 2019-12-27 18:33:01 -08:00
Francisco Magdaleno bc0d35c34e
Reland "fix duration event of timeline summary (#47742)" (#47889) 
This reverts commit 50d421224d.
 2019-12-27 11:15:48 -08:00
Francisco Magdaleno 50d421224d
Revert "fix duration event of timeline summary (#47742)" (#47888) 
This reverts commit e43fd1c54d.
 2019-12-27 10:26:49 -08:00
Gityuan e43fd1c54d fix duration event of timeline summary (#47742) 
* fix duration event of timeline summary

* Revert "fix duration event of timeline summary"

This reverts commit 699aa45ed3.

* fix duration event of timeline summary
 2019-12-27 09:36:59 -08:00
LongCatIsLooong ae24f18414
Reland 39919 CupertinoPicker (#47837) 2019-12-26 17:26:55 -08:00
Jonathan White 1fe05983e6 Fix typos in DefaultTabController.of documentation (#46907) 
Fix error in `DefaultTabController.of` documentation

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
 2019-12-26 09:45:25 -08:00
LongCatIsLooong b7af5e714d
Revert "Add brightness to CupertinoNavigationBar (fixes #46216) (#47521)" (#47805) 2019-12-25 23:49:55 -08:00
神楽坂花火 2cbf126fe8 Add brightness to CupertinoNavigationBar (fixes #46216) (#47521) 2019-12-25 21:54:12 -08:00
Shi-Hao Hong 6e72facad1
Fix Icon.color docs (#47691) 2019-12-24 10:54:04 -08:00
Chen Yumin 0265cb6849 Make tab's icon margin configurable (Fix #47363) (#47364) 
Adds the `iconMargin` parameter to Tab
 2019-12-23 15:37:16 -08:00
Francisco Magdaleno f2f9d0e4fd
Revert "Flutter Web Driver Support (#47470)" (#47698) 
This reverts commit cc1c9649c4.
 2019-12-23 15:20:11 -08:00
Jenn Magder 9861a1c045
flutter build ios-framework generate Flutter.podspec (#47556) 2019-12-23 13:12:36 -08:00
Alexandre Ardhuin 4adad2c652
update list of lints (#47661) 2019-12-23 18:40:56 +01:00
Jim Graham fcaf9c4070 Support for ImageFiltered widget to apply ImageFilter to children. (#47489) 2019-12-21 14:03:01 -08:00
Lau Ching Jun ef398d9e87 Disable most screenshot tests for web until we understand the flakes. (#47554) 2019-12-20 18:43:01 -08:00
Jenn Magder 85e9be36bf
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266)" (#47568) 
This reverts commit 648a5d8a1e.
 2019-12-20 17:45:16 -08:00
Greg Spencer 19b9206add
Add variant testing to testWidgets (#45646) 
This adds the ability to define variants of tests with different environmental values for a particular testWidgets test.

This allows you to run the same test multiple times with a different test environment. One test variant has been implemented that allows running a test with different settings of the TargetPlatform.
 2019-12-20 15:00:16 -08:00
gaaclarke 72a3d914ee
Added a code sample for replacing the image cache. (#47467) 2019-12-20 08:50:42 -08:00
Dan Field 93f718b386 Fix requestExistingInputState response (#47472) 2019-12-20 03:33:01 -08:00
Angjie Li cc1c9649c4 Flutter Web Driver Support (#47470) 2019-12-19 19:53:01 -08:00
Matt Sullivan f6922d57fc Fixed incorrect offsetting when applying ShaderMasks (#45654) 2019-12-19 19:48:01 -08:00
LongCatIsLooong e3c8ecaf7f
Reland "Fix sliver geometry assert (#47027)" 2019-12-19 14:27:35 -08:00
Jenn Magder 648a5d8a1e
Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266) 2019-12-19 14:18:10 -08:00
Dan Field 41a911099b comments (#47473) 2019-12-19 13:48:02 -08:00
Gary Qian b011ea5468
Pass _caretPrototype to prevent cache miss (#46720) 2019-12-20 06:46:49 +09:00
Jonah Williams 3fe6668849
[flutter_tool] ensure extraGenSnapshotArguments are forwarded to gen_snapshot from Android builds (#47059) 2019-12-19 13:44:21 -08:00
Dan Field 4ad8271bf5 Reland text state (#47464) 2019-12-19 13:43:02 -08:00
Justin McCandless 92c21a5701
Fix a typo in the docs (#47391) 
Just a docs text change.
 2019-12-19 09:40:01 -08:00
Alexandre Ardhuin 78db965642 Reland implicit-casts: false (#47431) 2019-12-19 02:23:01 -08:00
Lau Ching Jun a4858782da
Revert "implicit-casts: false (#47199)" (#47428) 
This reverts commit c235998acf.
 2019-12-18 23:53:00 -08:00
Alexandre Ardhuin c235998acf implicit-casts: false (#47199) 2019-12-18 23:23:01 -08:00
Dan Field 0a9ff388bf Revert "Use platform appropriate filepaths" (#47395) 2019-12-18 18:08:02 -08:00
Lau Ching Jun d51956a9ea
Revert "Call setEditingState when text changes. (#47177)" (#47397) 
This reverts commit d4b49ce9fc.
 2019-12-18 18:03:24 -08:00
Lau Ching Jun 2df964581f
Revert "Flutter Web Driver Support (#45951)" (#47389) 
This reverts commit 1ef0eadb45.
 2019-12-18 17:02:31 -08:00
Lau Ching Jun f32dee6e30
Revert "Fix sliver geometry assert (#47027)" (#47390) 
This reverts commit 117dfaf287.
 2019-12-18 17:02:11 -08:00
Kate Lovett c281369356 Fix subdirectory output (#47256) 2019-12-18 16:33:01 -08:00
Gary Qian f05ab50370
Detect and dump flaky LineMetrics test data (#46213) 2019-12-19 09:28:02 +09:00
Jenn Magder 9184f4d6fb
Build iOS frameworks with relative output path (#47369) 2019-12-18 15:31:54 -08:00
Michael Goderbauer beb86d2cc4 Revert "Simplify Chip slightly (#47254)" (#47353) 2019-12-18 14:03:01 -08:00
Dan Field b23238890a Pipe through test-randomize-ordering-seed (#47243) 2019-12-18 13:58:01 -08:00
KalilDev b39ebcb55f Fix CupertinoContextMenuAction color behavior (#47151) 
"destructive" color wasn't working for ContextMenuAction, this PR fixes it.
 2019-12-18 13:57:40 -08:00
Lau Ching Jun bc67d22449
Revert "iOS UITextInput autocorrection prompt (#45354)" (#47373) 
This reverts commit 0f8c0da0a9.
 2019-12-18 13:56:44 -08:00
Shi-Hao Hong bde351eea2
Make AlertDialog scrollable through AlertDialog.scrollable parameter (#45079) 
* Add AlertDialog.scrollable

* Add deprecation notice

* Ignore deprecation warning in dialog.dart with TODO
 2019-12-18 12:31:16 -08:00
Lau Ching Jun 7850e2525f
Is executable doesn't mean a+x (#47359) 2019-12-18 12:21:46 -08:00
Angjie Li 1ef0eadb45 Flutter Web Driver Support (#45951) 
* Support Flutter Driver test for Flutter Web application.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation issues.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation.

* Remove unused file from dartdoc check.

* Sync to date.

* Revert change to dartdoc.

* Address comments.

* Apply suggestions from code review

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update copyrights.

* Update allowed list for browsers.

* Verify command line arguments for Drive command is correctly parsed.

* Make waitUntilFirstFrameRasterized throw unimplementedError for Flutter Web Driver.

* Add comment for why sync WebDriver is used.

* Update documentations.

* Add more unit tests and update documentation.

* Configure test.dart so that web_extension_test will be executed with --platform=chrome.

* Revert unnecessary changes.

* Add new file path for Windows to blacklist.

* Reconstruct the structure of flutter_driver/test/src folder to remove filtering logic in dev/bots/test.dart/

* Fix path to web_extension_test.dart.

* Add instructions for how to use WebFlutterDriver.

* Update getLayerTree to use sendCommand instead of _sendCommand.

* Update pubspec files.
 2019-12-18 10:45:39 -08:00
Alex Vincent f546aa7def Fix buildCounter returns a widget when set to return null. (#45749) 
When buildCounter returns null it no longer produces a widget that takes up space.
 2019-12-18 10:45:28 -08:00
Zachary Anderson d328e0cea0 [flutter_tool] Improve iOS mDNS failure error message (#47348) 2019-12-18 09:23:00 -08:00
Scott Hyndman ceef460a64 Correct name in DecorationImage error string (#47260) 2019-12-18 00:23:02 -08:00
Emmanuel Garcia 9884f9980f Change meaning of a plugin not supporting the android platform (#47015) 2019-12-17 19:48:01 -08:00
Shouichi Kamiya 0764548231 s/v-sync/Vsync/g (#46660) 2019-12-17 19:43:03 -08:00
神楽坂花火 0ec73510ec Add textScaleFactor to SelectableText (#44682) 2019-12-17 19:38:01 -08:00
Jenn Magder 65ad8d805a
Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928)" (#47264) 
This reverts commit e54e301d50.
 2019-12-17 17:20:57 -08:00
Michael Goderbauer b7d221227c
Simplify Chip slightly (#47254) 2019-12-17 16:23:05 -08:00
LongCatIsLooong 0f8c0da0a9
iOS UITextInput autocorrection prompt (#45354) 2019-12-17 16:22:28 -08:00
Jenn Magder e54e301d50 Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#46928) 2019-12-17 16:13:01 -08:00
Emmanuel Garcia a15a81be21
Fix androidSdk NPE (#47187) 2019-12-17 14:10:36 -08:00
Jenn Magder 1cdf0f44db
Only set flutter run usage values for targeted device platforms (#46931) 2019-12-17 14:09:34 -08:00
Alek Åström 853c8c569f [flutter_tools] Add violating plugin name to validation errors (#46601) 2019-12-17 14:08:03 -08:00
George Wright 56f4eaf58c
Re-enable --no-link-platform for JIT mode (#47242) 2019-12-17 17:05:32 -05:00
Dan Field d4b49ce9fc
Call setEditingState when text changes. (#47177) 2019-12-17 14:03:04 -08:00
Michael Goderbauer 862289fa79 fix imports to unawaited (#47181) 2019-12-17 13:29:26 -08:00
LongCatIsLooong a82a399733
remove mediaQuery bottom padding when the tab scaffold has an opaque navbar (#46106) 2019-12-16 23:28:02 -08:00
Jonah Williams 0a2d8e0cce
[flutter_tool] Remove direct usage of package:linter in the flutter_tools (#47174) 2019-12-16 18:37:20 -08:00
LongCatIsLooong 117dfaf287
Fix sliver geometry assert (#47027) 2019-12-16 18:19:23 -08:00
Jonah Williams a723c94650
[flutter_tool] restructure ProjectFileInvalidator to no longer directly depend on context (#45739) 2019-12-16 18:12:04 -08:00
Shi-Hao Hong 7874bca248
Move localization executables to bin folder (#46251) 2019-12-16 17:30:57 -08:00
Shi-Hao Hong 7f56a61417
Fix isDense default for DropdownButtonFormField (#47160) 2019-12-16 16:40:15 -08:00
Alexandre Ardhuin dfbd585668 implicit-casts:false in flutter/test (#46245) 2019-12-16 15:03:02 -08:00
Alexandre Ardhuin aa071efd17 implicit-casts:false in flutter/lib/src/cupertino (#45502) 2019-12-16 14:58:03 -08:00
Zachary Anderson a72cca137d
[flutter_tool] Print a helpful message on some mDNS failures (#47157) 2019-12-16 14:57:29 -08:00
George Wright 9a76b4209e
Add support for getting a string representation of the LayerTree (#47014) 2019-12-16 15:39:06 -05:00
Dan Field 467f3d49ec remove duplicative checks (#47026) 2019-12-16 12:38:02 -08:00
Kate Lovett b0b8b91b97
RenderProxySliver (#45942) 2019-12-16 12:37:57 -08:00
Kate Lovett 9024231030 SliverVisibility (#45582) 2019-12-16 12:23:03 -08:00
Kate Lovett 89d72a1208 Throwing when goldctl cannot authorize/initialize (#45925) 2019-12-16 12:18:03 -08:00
Yuwen Yan fba96809f4 Add enableDrag configuration for showModalBottomSheet (#46685) 2019-12-16 12:14:24 -08:00
Justin McCandless c06bf6503a
iOS smart quote/dash configuration (#44923) 
smartDashesType and smartQuotesType params for text fields to control iOS's smart punctuation feature.
 2019-12-13 17:42:35 -05:00
Dan Field 1bca434cdd
Check for NaN in sliver constraints, improve error messaging (#46995) 2019-12-13 14:39:07 -08:00
Dan Field 82f6d43bf1
Avoid NaN for shrinkwrapping viewports (#46265) 2019-12-13 14:36:53 -08:00
Todd Volkert fc9b30a4f1
Revert "flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917)" (#46999) 
This reverts commit f28592018d.

It broke forbidden_imports_test, which uses a custom ignore directive.
 2019-12-13 12:23:12 -08:00
Sam Rawlins f28592018d flutter_tools: Remove unused //ignore comments; change flutter-specific ones to "ignore_for_flutter" (#45917) 2019-12-13 12:03:02 -08:00
liyuqian 6a5ef29a75 More clarifications on mutating Widget's children (#46725) 2019-12-13 09:53:01 -08:00
Alexandre Ardhuin d81d91606a
implicit-casts:false in flutter/lib/src/material (#45567) 
* implicit-casts:false in flutter/lib/src/material

* address review comments
 2019-12-13 08:55:12 +01:00
Jonah Williams 0497235c20
[flutter_tool] experimental resident web runner is not debuggable (#46916) 2019-12-12 19:05:48 -08:00
Jenn Magder dfa6eb31a0
Revert "flutter run FULL_PRODUCT_NAME (#46838)" (#46925) 2019-12-12 17:34:54 -08:00
Jenn Magder 7a7e2bb247 flutter run FULL_PRODUCT_NAME (#46838) 2019-12-12 17:03:01 -08:00
Jonah Williams 5ba2830c83
[flutter_tool][gallery] Standardize target platform override behavior in tool and update flutter gallery to support it (#46206) 2019-12-12 15:20:52 -08:00
Hans Muller 187c89b69d
Remove accentTextTheme from sliders and chips, tests and docs (#46801) 2019-12-12 15:14:01 -08:00
Jonah Williams 23b7853dfd
[flutter_tool] remove ability to disable Fingerprinter with DISABLE_FLUTTER_BUILD_CACHE env variable (#46913) 2019-12-12 15:12:53 -08:00
Jonah Williams 8ca55605c8
[flutter_tool] forward device-vmservice-port to iOS device launch arguments (#46822) 2019-12-12 13:55:42 -08:00
Jonah Williams 592a842b86
[flutter_tool] fix NPE in daemon caused by returning null connection info from experimental web runner (#46909) 2019-12-12 13:55:09 -08:00
Dan Field 948e2b0101 Avoid exceptions for control flow (#46897) 2019-12-12 13:53:01 -08:00
Emmanuel Garcia a467932d5b
Skip plugins that don't have an android impl when building AARs (#46835) 2019-12-12 12:38:09 -08:00
Danny Tuppeny 4944622b5d
Support URL tunnelling (pass dwds UrlEncoder through to editors via daemon) (#44271) 
* Prposal for supporting URL tunnelling

* Update daemon.md

* Add the ability for daemon to call clients to expose URLs

* Fix dwds mock in web_fs tests

* Fix type error

* Remove build_runner import from run

* Move appStartedTime back to after the app has started

* Remove nested DI scope and pass urlTunneller down

* Fix import

* Tweak TODO

* Fix existing tests

* Fix spec to use result instead of params for response object

* Fix exposeUrl to use a url field, as spec'd

* Test that the daemon's exposeUrl sends a request and handles the response
 2019-12-12 18:43:58 +00:00
Lau Ching Jun be53bc14aa
Reset the global variable before running a test. (#46203) 
The variable debugDisableShadows wasn't reset before each test, so the
output of the test is different depending on whether the previous test
has passed.
 2019-12-12 10:37:42 -08:00
Lau Ching Jun 535526b03c
Enable web for some of the golden tests (#46820) 
* Make golden test timeout longer, some tests are flaky if the timeout is too short

* Enable some golden tests for web
 2019-12-12 10:36:41 -08:00
Sean Freiburg 418b814555 Add buildNumber param to "flutter build aar" command (#46291) 2019-12-12 10:28:01 -08:00
Emmanuel Garcia 354f80b84a
Check and give execute permission to Gradle if needed (#46748) 2019-12-11 16:36:03 -08:00
Jonah Williams 8b88c8296f
remove test_api dependency from flutter_tools/base/io (#46796) 2019-12-11 13:31:30 -08:00
Jonah Williams d0e5824040
[flutter_tool] Update require.js artifact location for tests (#46787) 2019-12-11 12:56:58 -08:00
Zachary Anderson 895ffc80dc
[flutter_tool] Handling of certain unrecoverable filesystem errors (#46617) 2019-12-11 12:54:36 -08:00
Kate Lovett ceab1248d0
Use FlutterLocalFileComparator when user permission denied on Cirrus (#46688) 2019-12-11 11:03:21 -08:00
Alexandre Ardhuin 36e599eb5d
implicit-casts:false in flutter_localizations (#45241) 2019-12-11 07:27:13 +01:00
Jonah Williams 01953a1015
[flutter_tool] fix NPE in log reader for web server device (#46729) 2019-12-10 16:14:48 -08:00
Taufiq Rahman c5f61ac3e8 Feature: ExpandIcon should use the size parameter (#45712) 
* ExpandIcon should use the size parameter
 2019-12-10 15:18:56 -05:00
Koichi Ishida 4938ea0385 Fix typo in gradle tools exit message (#46580) 2019-12-10 13:41:31 -05:00
Jonah Williams bda9d90804
[flutter_tool] Reland: support --fast-start for Android applications (as an opt-in) (#46140) 2019-12-10 10:26:14 -08:00
Shi-Hao Hong 0bec3dc3d2
Add UniqueKey documentation regarding const constructor (#46647) 2019-12-10 13:24:58 -05:00
Shi-Hao Hong ac9fefdfa6
Fix InputDecorator.isDense typo from true -> false (#46648) 2019-12-10 13:24:44 -05:00
Sebastian Döll 645c32311e Set modal bottom sheet barrier color (#45067) 2019-12-10 10:07:32 -08:00
Anthony 8a205f8194
Revert "Made the behavior for caching large images modular. (#46010)" (#46629) 
This reverts commit 86dd664fef.
 2019-12-10 11:44:52 -05:00
Jonah Williams 81aa2710d2
[flutter_tool] add a vmservice API for hot ui requests (#45649) 2019-12-09 21:31:34 -08:00
Jonah Williams 523ac7b6f5
[flutter_tool] Always re-copy Framework/podspec when regenerating iOS module project (#45877) 2019-12-09 21:18:09 -08:00
Jonah Williams d0526d3f92
[flutter_tool] Prevent accidental calls to io.exit in unit tests (#46639) 2019-12-09 18:58:29 -08:00
Ian Hickson 14145a4ec9 Try re-enabling all these tests. (#46615) 2019-12-09 18:58:02 -08:00
Jonah Williams a491697893
[flutter_tool] Ensure dependency constraint for templates created with a driver test are correct 2019-12-09 17:32:03 -08:00
Christopher Fujino 0268510480 Fix analytics regression (#46242) 2019-12-09 15:13:02 -08:00
Tong Mu a4f7a0dfb9
Revert changes to TestPointer; MouseTracker no longer relies on Add events (#46285) 
* Revert test pointer

* Synthesize new state
 2019-12-09 15:12:11 -08:00
Jonah Williams 63cc4ad3aa
Revert "[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210)" (#46630) 
This reverts commit b698c9d72e.
 2019-12-09 13:13:59 -08:00
Jonah Williams b698c9d72e
[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests (#46210) 2019-12-09 13:01:37 -08:00
Emmanuel Garcia f264d6c277
Allow plugins that don't support the Android platform (#46282) 2019-12-08 20:04:19 -08:00
Lau Ching Jun c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Tom Robinson 9233b53255 Update SliverPersistentHeader docs (#46081) 2019-12-06 14:17:29 -08:00
Amr Yousef 237c478683 Update iOS build signing error message (#45835) 2019-12-06 10:41:06 -08:00
Jonah Williams 7f235ea8bc
Mitigation for current tool test skips on CI (#46181) 2019-12-05 23:16:25 -08:00
Tong Mu ad20d368ff Fix null event crash in TapGestureRecognizer (#45943) 2019-12-05 19:33:01 -08:00
Greg Spencer bc7ed36db5
Add visualDensity to checkbox, radio, icon button, and chip. (#46091) 
This adds a visualDensity attribute to checkbox, radio, icon button, and chip.
 2019-12-05 17:36:42 -08:00
Jonah Williams e6fa5717d1
fix release web builds where the target file is not under lib (#46179) 2019-12-05 15:57:12 -08:00
Greg Spencer e3005e6962
Fixes Focus and FocusScope's assignment of canRequestFocus. (#46168) 
This fixes an issue where lines like this:

    focusNode.canRequestFocus = widget.canRequestFocus ?? focusNode.canRequestFocus;

Were causing the canRequestFocus bit to copy the status of the enclosing scope, since canRequestFocus also looks to the enclosing scope to decide if it can focus.
 2019-12-05 15:33:05 -08:00
Chris Bracken fa0c49d775
Dispatch hover events to PlatformViewController (#46124) 
This adds support to PlatformViewLayer for handling hover events. Prior
to this, PlatformViewLayers only supported events forwarded by the
gesture recognizers associated with the PlatformViewRenderBox. Hover
events don't participate in gesture recognition and as such are dropped
in GestureBinding. That said, hover event processing in platform views
is expected for desktop and other platforms with hover event support.

This adds support for passing an optional MouseTrackerAnnotation to
PlatformViewLayer. PlatformViewRenderBox populates this with a mouse
tracker annotation that forwards hover events to
PlatformViewController.dispatchPointerEvent() for handling by users.
 2019-12-05 13:31:50 -08:00
gaaclarke 86dd664fef
Made the behavior for caching large images modular. (#46010) 
Introduced LargeImageHandler to ImageCache class.
 2019-12-05 12:46:59 -08:00
Greg Spencer c6fe7bb9e1
Normalizes all of the "See also" blocks in comments. (#46121) 
This normalizes all of the "See also" blocks in comments so that they conform in style.

They all look like this now:

  /// See also:
  ///
  ///  * [MyFavoriteWidget], because it's cool.
  class Foo {}

I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references.

This is my penance for adding so many bullets that are "-" instead of "*". :-)
 2019-12-05 12:27:05 -08:00
Tong Mu f8027a795d Only schedule callback when there is mouse (#46113) 2019-12-05 12:18:03 -08:00
Jenn Magder fb69a393b8
Add bitcode and architectures to App.framework build ios framework command (#46130) 2019-12-05 12:16:54 -08:00
Zachary Anderson e98acc7d1d [flutter_tool] Print version info on a no-op upgrade. (#46109) 2019-12-05 12:16:48 -08:00
Zachary Anderson 99684ce159 [flutter_tool] Make Device.dispose() abstract (#46006) 2019-12-05 08:48:00 -08:00
Alexandre Ardhuin 649e188562
implicit-casts:false in flutter/lib/src/painting (#45621) 2019-12-05 09:41:49 +01:00
Jenn Magder d01de941b9
Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138) 
This reverts commit 2a113165c0.
 2019-12-04 18:12:57 -08:00
Jonah Williams 2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
Greg Spencer f7d1616173
Overridable default platform key bindings (#45102) 
This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings.

I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).
 2019-12-04 16:07:01 -08:00
Kate Lovett 9011cece25
Pre-Submit Tryjobs for Flutter Gold (#44474) 2019-12-04 15:43:36 -08:00
Emmanuel Garcia 9e94eb93bc
Remove flutterBuildPluginAsAarFeature flag (#46101) 2019-12-04 15:42:08 -08:00
Greg Spencer 09927b94c3
Add a VisualDensity manual test (#46083) 
Adds a manual test that allows testing of density for buttons. Also updates some of the button tests to be somewhat simpler and to test the child positions in the test to make sure they are consistent.
 2019-12-04 10:48:06 -08:00
Christopher Fujino dfc108c66c improve resetChanges() dartdoc (#46008) 2019-12-04 09:58:01 -08:00
Brian Egan 3ea8c87ce9
Api Samples and Diagrams for 10 more classes / functions (#45603) 
* Api Samples and Diagrams for the following classes and methods:

  - AlertDialog
  - SimpleDialog
  - SingleChildScrollView
  - showDatePicker
  - RichText
  - InputDecoration
  - Divider
  - StreamBuilder
  - DataTable
  - BottomSheet
    - showBottomSheet
    - showModalBottomSheet

* Update packages/flutter/lib/src/material/divider.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/widgets/basic.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/data_table.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/scaffold.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Move animation out of sample

* Remove "widget.size", replace with "60"
 2019-12-04 13:27:23 +01:00
Alexandre Ardhuin 4956bcc2f9
implicit-casts:false in flutter_driver (#45175) 
* implicit-casts:false in flutter_driver

* address review comments
 2019-12-04 11:10:50 +01:00
Alexandre Ardhuin a5f9b3b036
implicit-casts:false in flutter/lib/src/rendering (#45720) 
* implicit-casts:false in flutter/lib/src/rendering

* address review comments
 2019-12-04 10:27:04 +01:00
Alexandre Ardhuin 166d422b05
implicit-casts:false in flutter/lib/src/widgets (#45728) 
* implicit-casts:false in flutter/lib/src/widgets

* address review comments

* address review comment
 2019-12-04 09:43:54 +01:00
Alexandre Ardhuin 4049460d31
implicit-casts:false in flutter/lib/src/semantics (#45722) 2019-12-04 08:59:19 +01:00
Alexandre Ardhuin 1c7a1c3873
implicit-casts:false in flutter/lib/src/services (#45723) 2019-12-04 07:51:54 +01:00
Sebastian Döll 417db34d35 Set track color in Cupertino Switch and Adaptive Switch (#45074) 2019-12-03 20:42:48 -08:00
Jacek Marchwicki 50532f387a [Driver] correct type for getWidgetDiagnostics (#45985) 2019-12-03 20:33:02 -08:00
Zachary Anderson 4484ae4043 [flutter_tool] Do not continue with a no-op 'upgrade' (#46011) 2019-12-03 20:08:24 -08:00
Greg Spencer 185da9b0af
Add Density API to ThemeData, implement for buttons. (#43547) 
* Add a density attribute to ThemeData

* Simplify tests

* Review changes (Hans)
 2019-12-03 19:49:56 -08:00
Michael Goderbauer 1ac17c14fc Re-land "Add option to delay rendering the first frame (#45135)" (#45941) 2019-12-03 19:48:01 -08:00
Emmanuel Garcia 09126abb22
Enable Android embedding v2 on the beta, dev and stable channel (#46040) 2019-12-03 17:43:00 -08:00
Ian Hickson 97495d8938
Simplify logging code in flutter_driver (#45945) 
* Simplify logging code in flutter_driver

It appears nobody is benefitting from this logic, so we may as well not pay the cost.

* Make all of the driver interface public.

This is the second attempt at this; it should be better than before because the Logger interface, which conflicted in various places, no longer exists.

See #45733 for original attempt.

This reverts commit 0ce9206ef4 (PR #45924).
 2019-12-03 17:14:43 -08:00
Dan Field b61dec79c7
Start fixing docs (#45977) 2019-12-03 13:59:19 -08:00
Jonah Williams b96d818c19
Remove record/replay/bug report functionality from the tool (#45999) 2019-12-03 13:24:45 -08:00
Sahand Akbarzadeh f68cdacdd5 Add clip behaviour to Container (#44971) 2019-12-03 10:13:01 -08:00
Jonah Williams c95dafc4c6
Add printTrace when vscode package.json parsing fails (#45998) 2019-12-03 09:56:04 -08:00
Jonah Williams 0dace48932
Add comments to package scheme fix (#45997) 2019-12-03 09:55:50 -08:00
Jonah Williams 0b2bf99491
Reland: Update macOS configuration settings (#45966) 2019-12-03 08:13:08 -08:00
Alexandre Ardhuin 1ae5d676e5
implicit-casts:false in flutter/lib/src/scheduler (#45721) 2019-12-03 09:32:03 +01:00
XinLei 9d574d2c22 Remove canTransitionFrom override from Material/CupertinoPageRoute (#45750) 2019-12-02 23:23:53 -08:00
Jonah Williams 8a9897c84c
Revert "update macOS configuration settings (#45920)" (#45965) 
This reverts commit 3b2042a028.
 2019-12-02 21:34:41 -08:00
Jonah Williams 9708e7d16a
use package-scheme imports for generated web entrypoint (#45934) 2019-12-02 21:10:08 -08:00
Jonah Williams 3b2042a028
update macOS configuration settings (#45920) 2019-12-02 21:06:38 -08:00
Dan Field c0283d85f5 Deprecate UpdateLiveRegionEvent (#45940) 2019-12-02 19:08:01 -08:00
Jonah Williams df0b3fed7b
fix lint applied after PR was opened (#45953) 2019-12-02 17:31:11 -08:00
Greg Spencer 37f86c3195
Clean up some things I noticed while doing another change (#45658) 
This fixes some minor things I noticed while doing another change.

- Uncomments an old test that wants to be run, but can't be, and marked it as "skipped", so that the code won't rot anymore.
- Added the focus state to the short string version of a FocusNode
- Added a missing piece of information to findAncestorWidgetOfExactType
 2019-12-02 17:10:09 -08:00
Kate Lovett 2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00
Jonah Williams b63683b6cd
Update configuration for flutter features (#45914) 2019-12-02 17:06:41 -08:00
Jonah Williams 8cf20f3be7
Dont crash on malformed packages.json (#45786) 2019-12-02 17:04:37 -08:00
Kate Lovett 0ce9206ef4
Revert "Make all of the driver interface public. (#45733)" (#45924) 
This reverts commit f2445002b2.
 2019-12-02 17:02:59 -08:00
Kate Lovett cd052a56cb
Revert "Re-land "Add option to delay rendering the first frame (#45135)" (#45588)" (#45939) 
This reverts commit c59151b1cd.
 2019-12-02 15:08:35 -08:00
Emmanuel Garcia 8c25328014
Handle case where lastLogcatTimestamp is null (#45937) 2019-12-02 15:02:11 -08:00
Michael Goderbauer c59151b1cd Re-land "Add option to delay rendering the first frame (#45135)" (#45588) 2019-12-02 13:33:45 -08:00
Dan Field 088fa24463
Set the LANG when invoking cocoapods (#45710) 2019-12-02 13:26:32 -08:00
Tong Mu afb8f38211
Improve MouseTracker lifecycle: Move checks to post-frame (#44631) 
This PR rewrites MouseTracker's lifecycle, so that mouse callbacks are all triggered in post frame, instead of the current one where some are triggered during the build phase. This PR also changes the onExit callback to MouseRegion, RenderMouseRegion, and MouseTrackerAnnotation, so that it is no longer triggered on dispose.
 2019-12-02 13:00:48 -08:00
Michael Goderbauer 8954ee85dd
Add Sliver video to RenderSliver (#45708) 2019-12-02 12:58:04 -08:00
Kaushik Iska 3994872073
Sample driver test working on Fuchsia (#45652) 
* [flutter_driver] [fuchsia] Validate existance of cmx for driver tests

Also added an example driver test that can run on Fuchsia devices.

Fixes: https://github.com/flutter/flutter/issues/45624

* update packages for stock example

* fix licenses
 2019-12-02 12:56:16 -08:00
Gary Qian d345a3b303
Revert "Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622)" (#45698) 
This reverts commit 6b66d79436.
 2019-11-28 19:42:06 +09:00
Emmanuel Garcia 475ee89879
Make Android log reader read any recent logs (#45743) 2019-11-27 17:52:36 -08:00
Jenn Magder e2642fd6c0
Do not delete output directory during flutter build ios-framework (#45740) 2019-11-27 17:48:19 -08:00
Ian Hickson f2445002b2
Make all of the driver interface public. (#45733) 
We keep finding things that we've accidentally not made public. The
pattern we use elsewhere in the platform is to just export everything,
to avoid encouraging people from importing `src/` files directly.
 2019-11-27 16:26:05 -08:00
Ian Hickson 449f4a6673
License update (#45373) 
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
 2019-11-27 15:04:02 -08:00
Chris Bracken dc49fa2140
Eliminate commented-out code (#45726) 
This appears to have been inadvertently added in #37497 (333c961).

The code in question already exists in `_PlatformViewGestureMixin`, which
`PlatformViewRenderBox` (where it was added) mixes in.
 2019-11-27 14:50:15 -08:00
Ian Hickson f87c5102af
Add more documentation around layers. (#45648) 2019-11-27 14:22:48 -08:00
Jonah Williams 59ca523b2c
Support web-server/profile/release mode with incremental compiler support for web (#45713) 2019-11-27 13:32:45 -08:00
Jonah Williams 598f2ab0fb
Cleanups to resident runner and flutter device classes (#45673) 2019-11-27 13:11:04 -08:00
Chris Bracken b39949ff09
Fix parameter name: handlePointerEvent (#45717) 
Removes an unnecessary leading underscore from a parameter name. The
parameter type is library private, but parameters cannot be 'private'.
 2019-11-27 12:48:43 -08:00
liyuqian 264082f34f
Print clipBehavior while debugging ClipXXXLayer (#45716) 
Fixes https://github.com/flutter/flutter/issues/45587
 2019-11-27 12:48:03 -08:00
Alexandre Ardhuin 5ccd4f3430
implicit-casts:false in flutter/lib/src/physics (#45622) 2019-11-27 21:28:45 +01:00
LongCatIsLooong 37f9c54116
Use RenderSliverPadding to inset SliverFillViewport (#45432) 2019-11-27 11:33:38 -08:00
Kate Lovett 1374a41313
Provide debug output for Gold uploads on post-submit (#45704) 2019-11-27 11:29:53 -08:00
Zachary Anderson e4b809b7c8
[flutter_tool] Crash less when git fails during 'version' (#45628) 2019-11-27 10:18:43 -08:00
Takeshi Tsukamoto 876303b3f9 Fix comment (#45325) 2019-11-27 10:01:57 -08:00
Danny Tuppeny 4741e9c3fe
Retry Xcode builds if they fail due to concurrent builds running (#45608) 
* Retry Xcode builds if they fail due to concurrent builds running

Fixes #40576.

* Add tests for concurrent iOS launches

* Increase number of retries to account for the initial build being slow
 2019-11-27 09:44:05 +00:00
Kaushik Iska d1805aa22a
update-packages after dwds updates (#45633) 2019-11-26 18:34:06 -08:00
Greg Spencer 245d1b51ce
Add macOS to TargetPlatform (#43457) 
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
 2019-11-26 18:32:34 -08:00
Jonah Williams 831163f0d0
Register memory info command on vmservice for Android devices (#45568) 2019-11-26 14:49:56 -08:00
Dan Field 2d3d220988
Implicit scrolling for pageview (#45598) 2019-11-26 14:12:34 -08:00