Commit graph

9850 commits

Author SHA1 Message Date
Chris Bracken 6ff844a9c0
Scaffold resizeToAvoidBottomPadding uses view insets (#13437)
Now that keyboard height is modelled as a (bottom) view inset, migrate
scaffold bottom resizing to use view insets instead of bottom padding,
which, after an engine roll, will only be used for safe areas.

Until the aforementioned engine roll, the keyboard height is still
included in both bottom padding and view insets. As such
resizeToAvoidBottomPadding still drives bottom padding removal until
that roll lands.

Renames _ScaffoldLayout.bottomPadding to bottomViewInset
2017-12-07 17:49:11 -08:00
Chris Bracken 60effb993c
Extract a shared MediaQueryData for padding and viewInsets (#13434)
Also adds a TODO that should have landed with flutter/flutter#13423.
2017-12-07 16:19:58 -08:00
Jason Simmons 3979dafaed
Fix calculation of downstream caret location at the end of a string (#13426) 2017-12-07 15:34:42 -08:00
Chris Bracken 38c82ea88f
Update scaffold test bottom bar height (#13429)
This patch contains no framework changes.

This change adjusts a test bottom navigation bar height to be greater
than the media bottom padding.

This change is pre-factoring to clarify diffs in an upcoming change that
will expose bottom padding to the bottom navigation bar in order to
allow it to visually adapt its appearance in the presence of bottom
padding such as thatexposed for the iPhone X home screen indicator.
Since the bottom padding was previously greater than the height of the
bottom navigation bar, the height of insideBottomNavigation bar was
driven to 0 when padding is exposed.
2017-12-07 14:53:26 -08:00
Ian Hickson 44e228eb9e
Move image logic from services/ to painting/. (#13409)
This allows the scheduler library to depend on the services library
and the painting library to depend on the scheduler library without
the services library having to depend on the scheduler library.

While I was at it I also cleaned up some of the binding logic: the
licenses logic can now be overridden (and the test library does so),
and the image cache can now be overridden as well.
2017-12-07 14:53:08 -08:00
Kevin Moore 64feb95ada
Revert "(cleanup) standardize on shouldRunPub and usesPubOptions() in commands (#13427)" (#13430)
This reverts commit 9315a79b11.

There is an unfortunate interaction with verifyThenRunCommand
2017-12-07 14:29:12 -08:00
Kevin Moore 9315a79b11
(cleanup) standardize on shouldRunPub and usesPubOptions() in commands (#13427) 2017-12-07 13:31:32 -08:00
Chris Bracken 71021b4706
Use greater of viewInsets, padding for Scaffold bottom padding (#13423)
Scaffold bottom padding now applies the maximum of window
viewInsets.bottom (typically used for iOS safe areas) and padding.bottom
(typically used for keyboard height).
2017-12-07 12:59:26 -08:00
Yegor 5f7ef89675
more setTextEntryEmulation docs; isRegistered check (#13420) 2017-12-07 12:08:52 -08:00
Jacob Richman ed54868c22
Change enum properties to use camel case instead of dash separated names
Make regular Alignment values look more like enumProperties while
leaving more complex AlignmentDirectional values unchanged.
2017-12-07 10:32:56 -08:00
Devon Carew 0350c9ecff
route device issue diagnostics to flutter doctor (#13346)
* route device issue diagnostics to flutter doctor

* review comments

* review comments
2017-12-07 09:32:23 -08:00
Sarah Zakarias 496534cc01
Revert "Increase connection timeout" (#13418) 2017-12-07 18:13:36 +01:00
Jakob Andersen e1018fab34
Make artifacts URLs configurable. (#13380)
Add support for configuring the base storage URL for Flutter's
artifacts. If FLUTTER_STORAGE_BASE_URL is set, use it instead of
storage.googleapis.com.

The pub server can be overridden by setting PUB_HOSTED_URL.
2017-12-07 16:30:23 +01:00
Sarah Zakarias 3016a56c84
Revert "Increase connection timeout further (#13415)" (#13417)
This reverts commit f40a9398a5.
2017-12-07 16:24:22 +01:00
Sarah Zakarias f40a9398a5
Increase connection timeout further (#13415) 2017-12-07 15:06:57 +01:00
Sarah Zakarias e38d48021c
Increase connection timeout (#13413) 2017-12-07 12:07:02 +01:00
Yegor d1e918fa10
support disabling text entry emulation (#13410) 2017-12-06 19:59:07 -08:00
Yegor bf4409f1f3
link from CONTRIBUTING.md to various build infra docs (#13399) 2017-12-06 17:30:44 -08:00
Yegor e27bcd0f9d
Emulate text entry in FlutterDriver (#13373)
* Emulate text entry in FlutterDriver

* document enterText behavior

* remove the unnecessary composint TextRange
2017-12-06 17:29:37 -08:00
Chris Bracken 5a1e639a2f
Roll engine to f888186e50f20fdb49ceea0dae74b6443a22ddaa (#13402)
Rolls:
flutter/engine#4411
flutter/engine#4416
flutter/engine#4420
flutter/engine#4421
flutter/engine#4423
2017-12-06 17:00:19 -08:00
xster 53c470ddf0
Add helper function to create cylindrical projection matrices (#13376)
* Add a cylindrical projection helper matrix

* specify tangential

* more doc clarifications

* reshuffle arguments

* more code comments

* add some sanity tests

* review

* review 2

* added one more caveat for consideration in docs
2017-12-06 15:57:50 -08:00
Michael Goderbauer 045ee5fd0a
Do not show handles when changing text selection via keyboard (#13338)
This contains a breaking API change to `SelectionChangedHandler`.

This is part of making text input accessible on Andriod (https://github.com/flutter/flutter/issues/12785).
2017-12-06 13:37:15 -08:00
Greg Spencer 389e13f8b9
Fixing the pub get test so that it doesn't care what the flutter root looks like. (#13385) 2017-12-06 13:27:29 -08:00
Ian Hickson 99987c2272
Update gallery for https://github.com/flutter/flutter/pull/13195 (#13361) 2017-12-06 12:17:46 -08:00
Chris Bracken 2c49240df2
Roll engine to 033daf152d78919101c0022f98fb18fd830284c0 (#13387)
This picks up a single commit: flutter/engine#4418, which fixes #12585.
2017-12-06 12:11:54 -08:00
Ben Konyi 582c9a5887 Flutter engine roll 2/2 (with Dart SDK roll) for 2017/12/08 2017-12-06 12:38:01 -05:00
Ben Konyi 913039c67a Flutter engine roll 1/2 for 2017/12/08 2017-12-06 12:38:01 -05:00
Kevin Moore 13a6d40f90
flutter_tools: ensure the context value passed to pub is consistent (#13366)
Adds a class `PubContext` with a fixed set of allowed values
Make it clear these values should not be changed casually

Fixed one inconsistency already: update_packages vs update_pkgs
Provide more information for verify calls
Eliminate `ctx_` prefix.
2017-12-06 08:10:56 -08:00
Devon Carew cbcdd03ef0
some wording tweaks to the doctor text (#13356) 2017-12-06 08:05:51 -08:00
Chris Bracken 324ef1d1f6
Apply media bottom padding to CupertinoTabBar (#13372)
This adjusts the CupertinoTabBar height in the presence of bottom
padding. On the iPhone X, this will increase the height to account for
the home indicator widget.
2017-12-05 19:17:58 -08:00
Collin Jackson 10a4f329c3
Finish release of 0.0.19, start dev version of 0.0.20 (#13370) 2017-12-05 17:06:16 -08:00
Yegor e3cf62bc5b
modernize corners & borders in animation demo (#13352) 2017-12-05 16:38:42 -08:00
Collin Jackson fd7853faad
Release 0.0.19 (#13365) 2017-12-05 16:12:55 -08:00
Greg Spencer f29ecba6de
Use .pub-cache from Flutter root, if it exists. (#13358)
The purpose of this PR is to make it so that when the user runs 'flutter', if they have a .pub-cache directory in their flutter root, we use that instead of the default location for the pub cache. Otherwise, it should act as before.

The eventual goal is to support a pre-populated flutter .zip/.tar.gz file that has everything the developer needs in one bundle. In order for that to actually work, we need to have the pub cache be self-contained, and not in the user's home dir.

Another advantage of this is that if you have multiple flutter repos that you're switching between, then the versions in the pub cache will remain static when you switch between them.

This is an attempt to re-land: #13248. Includes a fix for the test that makes it work on bots in the presence of PUB_CACHE being set, and no other changes.
2017-12-05 14:46:39 -08:00
Greg Spencer c89cf6ccc6
Reverting my .pub-cache change to figure out why it's still failing. (#13355)
* Revert "Add tests."

This reverts commit 31bad961ff.

* Revert "Use .pub-cache from Flutter root, if it exists. (#13248)"

This reverts commit 72d6bcc3f7.
2017-12-05 12:51:18 -08:00
Greg Spencer 3174443e0e
Fix a problem with the flutter_tools/test/dart/pub_get_test.dart test. (#13354)
It turns out that when a PR build clones the flutter repo, it puts it into a directory called "flutter", and when the "real" build clones the flutter repo, it puts it into a directory called "build". This allowed the tests to succeed in my PR, but fail when I committed it.

This fixes the test so it doesn't depend on the cloned directory name.
2017-12-05 12:30:13 -08:00
Greg Spencer 72d6bcc3f7
Use .pub-cache from Flutter root, if it exists. (#13248)
The purpose of this PR is to make it so that when the user runs 'flutter', if they have a .pub-cache directory in their flutter root, we use that instead of the default location for the pub cache. Otherwise, it should act as before.

The eventual goal is to support a pre-populated flutter .zip/.tar.gz file that has everything the developer needs in one bundle. In order for that to actually work, we need to have the pub cache be self-contained, and not in the user's home dir.

Another advantage of this is that if you have multiple flutter repos that you're switching between, then the versions in the pub cache will remain static when you switch between them.
2017-12-05 12:02:14 -08:00
xster 9db8966f94
Make drawer demo header not scroll away (#13337)
* Make drawer demo header not scroll

* Add test for gallery drawer demo and fix user accounts drawer header overflow
2017-12-05 11:58:03 -08:00
Martin Kustermann 3280f23452
Use only one message for NDK discovery, remove accidental newline (#13348) 2017-12-05 18:17:28 +01:00
Sigurd Meldgaard 2352e31f4e
Video demo is unsupported on simulator (#13333)
* Video demo is unsupported on simulator

Display a message stating this.

* Address review
2017-12-05 13:39:24 +01:00
Sigurd Meldgaard b46d79041a
Add spinner to loading video (#13330)
* Add spinner to loading video
2017-12-05 10:20:13 +01:00
Yegor ffb24eda56
Accessibility API for CustomPainter (#13313)
Summary:

- Add `key` field to `SemanticsNode`, while moving key into `foundation` library so it can be used by the render layer.
- Introduce `SemanticsProperties` and move many of the `Semantics` fields into it.
- Introduce `CustomPaintSemantics` - a `SemanticsNode` prototype created by `CustomPainter`.
- Introduce `semanticsBuilder` and `shouldRebuildSemantics` in `CustomerPainter`

**Breaking change**

The default `Semantics` constructor becomes non-const (due to https://github.com/dart-lang/sdk/issues/20962). However, a new `const Semantics.fromProperties` is added that still allowed creating constant `Semantics` widgets ([mailing list announcement](https://groups.google.com/forum/#!topic/flutter-dev/KQXBl2_1sws)).

Fixes https://github.com/flutter/flutter/issues/11791
Fixes https://github.com/flutter/flutter/issues/1666
2017-12-04 19:49:14 -08:00
Alexander Markov a69af9902c
Pass --aot option to front-end server when generating kernel for AOT build (#13342) 2017-12-04 16:57:44 -08:00
Alexander Markov 373e510cbe Roll engine to b57fca02b5b5465b2c553952cccd2b595ace2b65 (with dart-sdk roll) 2017-12-04 15:34:47 -08:00
Alexander Markov 223e5340a1 Roll engine to b5d0a4ac513fab4052aec75004d75f3d0e5c45b4 (before dart-sdk roll) 2017-12-04 15:34:47 -08:00
krisgiesing 898646f0f0
Separate focus management by build owner (#13334)
Separate focus management by build owner

Currently the focus manager is held by the singleton WidgetBinding.
This change places a focus manager in each build owner object,
which allows clients to run offscreen pipelines without disturbing
focus management for the main UI.
2017-12-04 15:04:41 -08:00
Ian Hickson da5be60130
Fix overlay_geometry manual test. (#13315)
Somehow the test ended up checking for notification messages at the wrong depth.
2017-12-04 13:53:23 -08:00
Ian Hickson c44f15e6e9
Add a showBottomSheet for consistency with showModalBottomSheet. (#13314)
Also, extra docs.

Fixes https://github.com/flutter/flutter/issues/13279
Fixes https://github.com/flutter/flutter/issues/2115
2017-12-04 13:43:09 -08:00
Ian Hickson d6f496cab8
Localize the Chip delete button's default tooltip (#13312)
...and document what I did.
2017-12-04 12:59:48 -08:00
Sarah Zakarias 47e490294c
Include pod-related build phases in flutter_view project.pbxproj. (#13327) 2017-12-04 10:56:15 +01:00