Commit graph

10329 commits

Author SHA1 Message Date
Alexandre Ardhuin 7667db6362
apply upcomming prefer_const_declarations (#15498) 2018-03-14 06:24:49 +01:00
Alexander Aprelev 7b8c79634d
Move dart2 tests from 'allowed to fail' to 'required to pass' (#15491) 2018-03-13 19:31:31 -07:00
Jason Simmons 5a58b36e36
Roll engine to e61bb9ac3a3fd789754e2e54220bcfc27076a857 (#15495)
This engine has libtxt enabled by default
2018-03-13 13:20:13 -07:00
Jason Simmons b9bd51cc36
Roll engine to e44cd55fc452ba5524147280c451fb3ace350ec4 (#15494) 2018-03-13 12:42:29 -07:00
Greg Spencer d28e9aa5c9
Add slider minimum interaction time (#15358)
This change makes the discrete slider show the value indicator for a minimum amount of time for any interaction (tap, drag).
2018-03-13 09:41:49 -07:00
Greg Spencer fc96326b9c
Add neck stretch (#15445)
During the review, we determined that it would be good for the value indicator to stretch when the text scale was smaller, and the shrink when it was larger, to keep the value visible over the finger at small sizes, and closer to the finger at large sizes. This implements that change.
2018-03-12 20:28:34 -07:00
Chris Bracken dc03398bc3
Avoid NPE in InkDecoration dispose (#15473)
Avoids a null pointer exception if dispose() is called on an
already-disposed InkDecoration.
2018-03-12 19:05:55 -07:00
Alexander Aprelev e23a658685
Rev dependencies up and regenerate stock_messages. (#15469)
This fixes https://github.com/flutter/flutter/issues/15458.
2018-03-12 17:46:26 -07:00
Jonah Williams d682259eab
Use a set to remove duplicate channel names (#15392)
* Use a set to remove duplicate channel names

* Add test for git command
2018-03-12 17:04:02 -07:00
Alexander Aprelev 2f8474f9aa
Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f. (#15444)
* Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f.

Changes since last roll:
```
b6df7a637 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (#4771)
a6764dbd5 Add sources for Fuchsia target. (#4763)
2d5900615 [fuchsia] Remove unused header file. (#4769)
9717063b7 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)" (#4768)
9a9814312 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)
e74e8b35c [async] Update includes of async headers to new path (#4760)
e2c4b2760 Use Dart 2 camel case constants in the engine Dart libraries (#4766)
9c1e48434 Updates for Fuchsia roll. (#4765)
14c940e27 Switch from fxl::Mutex to std::mutex (#4764)
debf82c0b Roll Garnet (#4759)
5bffdefbb Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (#4761)
```
2018-03-12 15:44:25 -07:00
Hans Muller 07eb5ea0be
Added custom selection indicators to the gallery scrollable tabs demo (#15323) 2018-03-12 12:20:33 -07:00
Mikkel Nygaard Ravn a61592793c Silence broken test (#15446)
* Silence broken test

* Mark test as flaky instead
2018-03-12 12:02:58 -07:00
Jason Simmons 466d15433f
Use Dart 2 camel case constants (#15360) 2018-03-12 11:06:32 -07:00
Hans Muller 33f9afd99c
Updated the BottomNavigationBar class doc (#15347) 2018-03-12 10:27:20 -07:00
Hans Muller 11d81b11d7
Add OutlineButton, Tristate Checkbox to Flutter Gallery (#15312) 2018-03-12 10:21:14 -07:00
Danny Tuppeny 465929f71e Remove flaky flag from all tests that are green for the whole dashboard
Plus run_machine_concurrent_hot_reload which isn't all green, but is
green since the fix was pushed.
2018-03-12 17:03:21 +00:00
Mikkel Nygaard Ravn 658f9e6c83
Make plugins work in Swift projects (#15437) 2018-03-12 17:33:10 +01:00
P.Y. Laligand c0118ea4b9
Leave source list empty for Fuchsia targets. (#15337) 2018-03-12 15:38:32 +01:00
xster c8fd99fb33
Add a simple convenience test task runner for VSCode (#15417) 2018-03-12 01:05:23 -07:00
Siva e5ba3041cd
Update dart-petitparser and dart-xml packages (#15376)
* Update the following packages
- dart-petitparser to 1.7.5
- dart-xml to 3.0.3
- image to 1.1.30
These updates fix some of the strong mode errors we were encountering
while running flutter tests.
2018-03-11 18:57:14 -07:00
Ian Hickson 7865d319ba
Factor out BorderSide creation for dividers (#15403)
This allows other code to get the same style without having to know exactly it is computed.
2018-03-11 13:01:00 -07:00
Ian Hickson ded3905102
Various documentation improvements. (#15071)
For example, mention the icon used for the drawer menu in the docs (this helps people writing unit tests); add DefaultAssetBundle sample code.
2018-03-11 03:19:18 -07:00
Ian Hickson 48bb5b7926
Include opacity in FadeTransition logging (#15073) 2018-03-09 22:49:19 -08:00
Greg Spencer 984a24c51b
Fix error handling for the packaging script (#15351)
This fixes the error handling for the packaging script so that it will properly report a failure exit code when it can't find the executable that it's looking for.

Added a test too.
2018-03-09 18:58:41 -08:00
Jason Simmons 4b56ba17d5 More fixes for the prefer_const_literals_to_create_immutables analyzer check (#15363)
See 3961306bad
2018-03-09 16:47:56 -08:00
Alexandre Ardhuin 3961306bad enable lints prefer_const_declarations and prefer_const_literals_to_create_immutables (#14848) 2018-03-09 14:37:06 -08:00
Greg Spencer 7fab7f6d02
Adding edge avoidance, painting tests, general cleanup (#15078)
Fixed the real repaint problem the Slider had (missing addListener), and added tests for it.

Added GlobalKey reparenting test.

Added the ability for the value indicator to slide left and right to avoid falling off the edge of the screen.
It only shifts as much as it can without deforming, but even at large text scales, that is enough to keep the text on the screen.

Updated the formatting on theme_data.dart and others to use longer line length.

Also, removed a color tween that faded the value indicator in as it scaled, since that wasn't to spec.
2018-03-09 14:04:58 -08:00
Michael Goderbauer 3a40d0ee4e
Support SemanticsFlag for Header (#15255) 2018-03-09 13:32:01 -08:00
Jason Simmons 96ce9d64ac
Add more package names to the flutter create conflict list (#15350)
Fixes https://github.com/flutter/flutter/issues/12445
2018-03-09 13:11:33 -08:00
Todd Volkert 2e970008ad
Pass --verbose to pub instead of --trace when in verbose mode (#15314) 2018-03-09 12:55:06 -08:00
Yegor 2e429bfbdd
[tools] add Stdio to AppContext created by daemon AppInstance (#15268) 2018-03-09 12:25:30 -08:00
Alexander Aprelev ded538a1bb
Update dependencies with forced upgrade. (#15344)
* Update dependencies with forced upgrade.

Now that https://github.com/flutter/flutter/issues/15261 is fixed, do the update with upgrade.

* Update test package use following upgrade

* Replace addOption(allowMultiple) with addMultiOption
2018-03-09 10:38:54 -08:00
Michael Goderbauer 5d03a59379
Allow wrapping CheckBox in Semantics (#15259) 2018-03-09 10:37:59 -08:00
Jonah Williams 7d1ceb4080
Add Text.rich constructor to Text widget (#15317)
* add fromSpan constructor to Text widget and simple smoke test:

* change fromSpan to rich, clean up comments

* 'directly from' to 'with'

* make sure text styles are applied to either data or textspan. add diagnostic properties for span

* add expectation for text style to test case

* some work on diagnostics and docs
2018-03-09 09:57:17 -08:00
Jonah Williams 4ace88bfc0
fix spacing issue and add test for supportsHardwareRendering (#15305)
* fix spacing issue and add test for supportsHardwareRendering

* remove extra async tag

* move spacing to prev line
2018-03-09 09:30:13 -08:00
Jacob Richman 046c6d5f7f
Track which Widget objects were created by the local project. (#15041)
Make flutter test support the --track-widget-creation flag.
Add widget creation location tests. Tests are skipped when
--track-widget-creation flag is not passed.
2018-03-09 08:09:49 -08:00
Michael Goderbauer a9e2781132
Do not do semantics for detached objects (#15320) 2018-03-08 22:33:46 -08:00
Michael Goderbauer 35c43ecc98
Roll engine to 1d0da7799583b089ede66b81068f40cc4597a429 (#15322) 2018-03-08 22:30:55 -08:00
Michael Goderbauer f002839d44
Better print-out of semantics tree (#15302) 2018-03-08 19:14:43 -08:00
Alexander Aprelev 2890e18bcb
Return copied kernel filename for flutter test execution. (#15298)
* Return copied kernel filename.

This fixes 'flutter test --preview-dart-2' crash.
2018-03-08 16:02:21 -08:00
Hans Muller 0038a2b21c
Updated the material_en.arb description for signedIn (#15306) 2018-03-08 15:42:29 -08:00
Jason Simmons 6f5bcb97a4
Do not add spacing to the first child's width in RenderWrap line wrapping (#15272)
The first child fits on the line if the line can accomodate its width.
After the first child the line needs room for the child's width plus spacing.
2018-03-08 15:01:37 -08:00
Todd Volkert d996ab921c
Rename "slow mode" to be "debug mode" (#15205)
This moves toward more consistency in our messaging. Apps are
launched using --debug, so the banner will reflect the build
mode.
2018-03-08 12:54:06 -08:00
Alexander Aprelev 1087279a4d
Create frontend compiler in flutter test lazily. (#15251)
* Create frontend compiler in `flutter test` lazily.

This is needed to avoid unwarranted runtime dependencies on Artifacts,
for example when in non-preview-dart-2 mode.
Refactor the compilation-related code into _Compiler class.
2018-03-08 11:21:40 -08:00
Alexander Aprelev 1a3c9b83c0
Step process, boolean_selector, collection deps up. (#15262)
This is needed to fix 'flutter test --preview-dart-2 test/all.dart' in dev/devicelab
2018-03-08 11:07:03 -08:00
Hans Muller f14397ae11
Correct DefaultMaterialLocalizations.delegate supported locales list (#15260) 2018-03-08 11:06:31 -08:00
Hans Muller ea155df91e
Roll localizations (#15269) 2018-03-08 11:06:09 -08:00
Stefano Rodriguez b944cd7187 Plug TextDirection into box_decoration background gradient (#14810)
* Plug TextDirection into box_decoration background gradient

* Add test
2018-03-08 11:00:21 -08:00
Jonah Williams afabdfecf9
Display a message if hardware rendering is supported (#15266)
* add device.supportsHardwareRendering and display a message if true

* Address some comments
2018-03-08 10:41:29 -08:00
Alexander Aprelev 69c33a321a
Fix path to uri conversion. (#15264) 2018-03-08 10:25:27 -08:00