Commit graph

14611 commits

Author SHA1 Message Date
Jonah Williams e9c94e6c45
fix build analysis errors (#67476) 2020-10-06 17:41:21 -07:00
Alexandre Ardhuin f1c1d944e3
fix nullability issues (#67443) 2020-10-06 17:07:05 -07:00
Justin McCandless 896c19a292
Characters docs (#67361) 2020-10-06 17:02:04 -07:00
Kate Lovett b5562c1b19
[NNBD] More test migration for Cupertino & Painting (#67323) 2020-10-06 16:57:03 -07:00
Jonah Williams ef6c720d40
[flutter_test] handle breaking change to test main (#67425)
* [flutter_test] handle breaking change to test main . Fixes #67382
2020-10-06 16:52:23 -07:00
Ian Hickson 8d923bf9a7
flutter_web_plugins cleanup and documentation (#67164) 2020-10-06 16:52:02 -07:00
Jonah Williams d411242468
[null-safety] reland: migrate app side flutter driver to null-safety (#67441)
Reland: #67155

Fixes analysis error caused by landing of material migration, and g3 error caused by moving of fuchsia lib.
2020-10-06 16:51:37 -07:00
Michael Goderbauer 4fa4f91d5c
Remove required for onRemove in InteractiveInkFeature.create (#67427) 2020-10-06 12:31:25 -07:00
Michael Goderbauer 582c67a125
Make CupertinoTabView restorable (#67169) 2020-10-06 11:03:13 -07:00
Jonah Williams 4818537044
Revert "[null-safety] migrate app dependencies of flutter driver (#67155)" (#67433)
This reverts commit e826442ef4.
2020-10-06 10:41:45 -07:00
Jonah Williams e826442ef4
[null-safety] migrate app dependencies of flutter driver (#67155)
Ensures all of the libraries that the application side code import are migrated to null safety. full null safety migration is blocked by json rpc 2 and a breaking change to vm service client.
2020-10-06 10:30:15 -07:00
stuartmorgan be6a368801
Improve Windows symlink instructions (#67029)
When the developer doesn't have permission to create symlinks, we
display specific instructions, but they were only correct for recent
versions of Windows 10. This improves them by:
- Giving the correct instructions for older versions.
- For recent versions, adds a command that will deep-link into the
  settings application so that developers don't have to figure out
  where/how to enable developer mode.

Fixes https://github.com/flutter/flutter/issues/66973
2020-10-06 08:32:54 -07:00
Nate Bosch 8ee2b2f1d1
Condense package:test_core imports (#67357)
Use the new single `src/platform.dart` import to pick up what is needed
to implement a test platform from both `test_api` and `test_core`.
2020-10-06 08:26:31 -07:00
Alexandre Ardhuin 555cb66ece
fix tree (#67410) 2020-10-06 14:38:19 +02:00
Alexandre Ardhuin f551178408
migrate material to nullsafety (#67166)
* migrate material to nullsafety

* address review comments

* address review comments

* fix build
2020-10-06 11:36:50 +02:00
Michael Goderbauer b3bd9e6924
Migrate more tests to null safety (#67360) 2020-10-05 19:52:03 -07:00
Jonah Williams 734cc1a132
[flutter_tools] work around hostonly test (#67369)
Many of the host only devicelab tests were relying on doctor to download android dependencies.
2020-10-05 18:26:37 -07:00
Michael Goderbauer 42fa4f033b
Migrate some more non-test utils for tests (#67351) 2020-10-05 18:12:04 -07:00
Michael Goderbauer 8998167d0f
Make FlutterErrorDetails.exception non-nullable as documented (#67364) 2020-10-05 18:07:02 -07:00
Jonah Williams 1271447bbe
[flutter_tools] remove globals from FlutterValidator, add documentation and move tests to new file (#67234)
Remove globals from the flutter validator class, and refactor the tests into a separate file. Applies some other cleanup like adding doc comments, and making the doctor validator work like it is documented to work - removing the gen_snapshot check if the artifact is not downloaded instead of downloading all android artifacts.

#47161
2020-10-05 17:58:56 -07:00
Jonah Williams 2474b07768
[flutter_tools] add more docs to cocoapods, move to globals (#67237)
Add some placeholder docs to the Cocoapods validator and Cocoapods class. Add the injected validator to globals. #47161
2020-10-05 17:57:48 -07:00
Ming Lyu (CareF) 277a72e3fe
move resampler to handlePointerEvent and fix complex_layout_android__scroll_smoothness with PointerEvent (#66745) 2020-10-05 17:17:03 -07:00
Jonah Williams c8466d0430
[flutter_tools] handle case where file is deleted by other program or running on read only volume (#66708)
* [flutter_tools] handle case where file is deleted by other program

* Add test cases

* Update file_system.dart

* Update file_system_test.dart

* fix import

* make a static on ErrorHandligFS

* add support for no exit on failure

* address comments

* update doc comment to file or directory
2020-10-05 17:00:07 -07:00
Kate Lovett 64c845c579
Re-land ScaffoldMessenger (#66504) 2020-10-05 18:59:12 -05:00
Jonah Williams 7f2ca5e532
[flutter_tools] refactor engine locator to its own class (#67274)
Make the logic for locating a local engine path part of its own class, add documentation, and update tests to cover engine source path locating too.

#47161
2020-10-05 16:25:47 -07:00
Darren Austin 2f74e30511
Fixed a problem with invalid dates when switching back to calendar mode in the date range picker. (#67159) 2020-10-05 16:05:48 -07:00
Justin McCandless 19b2aea608
InteractiveViewer table example improvements (#67314)
Improving IV table docs due to confusion in an issue.
2020-10-05 16:04:56 -07:00
Darren Austin 01e8c39534
Migrate gestures, physics and scheduler tests to null safety. (#62701) 2020-10-05 16:01:34 -07:00
Jonah Williams 6180a4c179
[flutter_tools] fix documentation, globals, and todos in the android codebase (#66980)
Cleans up some undocumented classes and re-organizes the AndroidDevices class to avoid the need for the static testing only member. Adds a script for tracking globals.
2020-10-05 15:47:57 -07:00
Kratos b1df925b3c
Update documentation for borderWidth/renderBorder on ToggleButtons (#67290) 2020-10-05 14:47:03 -07:00
Jonah Williams 186765b3a7
[flutter_tools] cleanups to plugin test cases (#67242)
Removes usage of global variables, expands documentation, and fixes some formatting inconsistencies. Increased test coverage for android plugin to prove it can determine the embedding version.
2020-10-05 14:45:39 -07:00
Alexandre Ardhuin 304e2c57d2
fix nullability issues (#67306) 2020-10-05 14:37:04 -07:00
Michael Goderbauer c14ab91fe5
Reland "migrate some material files to nullsafety (#67078)" (#67318) 2020-10-05 13:54:36 -07:00
Jonah Williams aa90dbe7f4
[flutter_tools] disable source maps by default for release builds, enable for run and with command line arg (#67331)
Disables source map production by default for build web. For web builds performed as a part of flutter run --release, enable the source maps, or allow force enabling with --source-maps command line flag.

fixes #67328
2020-10-05 13:24:51 -07:00
Abhishek Ghaskata 3a00c4e73c
change the documentation of bottom navigation bar (#67218) 2020-10-05 12:22:03 -07:00
Jenn Magder 6e5f9ed94d
Replace MockProcessManager with FakeProcessManager (#67019) 2020-10-05 12:21:43 -07:00
Kate Lovett b42cf8a75b
[NNBD] Migrate some Cupertino tests (#67086) 2020-10-05 12:17:03 -07:00
Tong Mu 2cdf2f0059
Treat hover events as normal pointer events, and bring them back to Listener (#63834) 2020-10-05 12:12:04 -07:00
Dan Field 2cdec25877
Reland dispose images when done (#67100) (#67177)
* Reland dispose images when done (#67100)

Changes since last time:

- Test for CanvasKit image rendering
  (https://github.com/flutter/flutter/pull/67176)
- Fix CanvasKit dispose impl
  (https://github.com/flutter/engine/pull/21555)
- Update internal google3 customer with a problematic ImageStream
  Listener impl (cl/335091311, cl/335459002)

This reverts commit 473358d93d.
2020-10-05 12:03:27 -07:00
Dan Field ece2f98eb0
Remove goldens request timeout (#67316) 2020-10-05 10:15:09 -07:00
Jonah Williams 3a51bcb5c0
[flutter_tools] delete code related to reload method (#67279)
This functionality ultimately became the single widget reload optimization, which did not require a separate service protocol.
2020-10-05 09:57:10 -07:00
Jonah Williams 21bb29cc68
[flutter_tools] support all engine debugging options with FLUTTER_ENGINE_SWITCH environment variables (#67150)
Allow providing all debugging options to the desktop engine via the FLUTTER_ENGINE_SWITCH_ environment variables.

Fixes #66532
Fixes #46005
Fixes #58882

The underling engine changes have already landed for Windows, macOS, but linux is still in progress
2020-10-05 09:56:48 -07:00
Jonah Williams 4ce2a7aa6d
[flutter_tools] do not use IOSink for writing cache responses (#67231)
Any File-derived IOSink may throw un-handleable async exceptions into the zone, see dart-lang/sdk#43663 . Instead, just write to a file with an append mode.
2020-10-05 09:05:41 -07:00
Danny Tuppeny fdd1bf2944
Handle missing Android SDKs in getEmulators() (#67295) 2020-10-05 08:57:04 -07:00
Tong Mu 5e97eed895
Migrate foundation test to nullsafety (#62616)
* Migrate
2020-10-05 00:42:50 -07:00
Jonah Williams 63852d2073
Roll flutter engine to a24c7c13925e4e3282f7b85814b70e63782fa057 (#67193)
* Roll flutter engine to a24c7c13925e4e3282f7b85814b70e63782fa057
2020-10-03 09:14:48 -07:00
Jesse 60d7bb2588
Use XDG_CONFIG_HOME dir by default for config files (#66645)
This PR changes the Config class in flutter_tools to use the XDG Base directory specification instead of putting files directly in the user's home directory. If those files are already present in the home directory, they are used instead.
2020-10-03 08:40:09 -07:00
Michael Goderbauer a0a65fc604
Revert "migrate some material files to nullsafety (#67078)" (#67183)
This reverts commit 8143992262.
2020-10-03 04:54:45 -07:00
Michael Goderbauer cbf1e135c4
Migrate non-test files in flutter/test (#67098) 2020-10-02 21:57:04 -07:00
Jonah Williams ddb8177018
[flutter_tools] remove globals from desktop configuration (#67146)
Refactors the desktop devices and workflow to remove unnecessary usage of global variables. This should make it easier to test and continue enhancing the desktop functionality of the tooling

#47161
2020-10-02 21:52:53 -07:00
Jonah Williams ddb01a0c81
[null-safety] add integration tests for sound null safety modes, add support for sound null safety in dart2js (#67171)
Add integration tests to verify that ddc and dart2js can be built and run in sound mode. Updates dart2js compilation to insert a language version comment into the generated entrypoint if necessary.

dart-lang/sdk#42253
2020-10-02 21:52:38 -07:00
Michael Goderbauer 687121d6da
Migrate some tests to null-safety (#67085) 2020-10-02 21:52:02 -07:00
Jonah Williams 1bea512a83
[flutter_tools] flutter logs no longer requires supported device (#66696)
Flutter logs should not attempt to filter the device list based on the current project, because it does not require a current project. Also fix disabled polling test

Fixes #47996
Fixes #63550
2020-10-02 21:12:50 -07:00
Jonah Williams f6cbf488e1
[null-safety] pass experiments to builders (#67152)
Force opt-in flutter test platform to null safety for repo testing
2020-10-02 16:38:50 -07:00
Mouad Debbar b42e34690a
[web] Update index.html template to support new path strategy (#67081) 2020-10-02 15:12:04 -07:00
Tong Mu 74fe6bff84
Lazily compute PointerEvent's transformed positions (#63813)
* PointerEvent.local* properties are calculated lazily; other properties are delegated to original.
* Transformed PointerEvent becomes a subclass of its original class.
* Unnamed constructors no longer accepts transform and origin.
2020-10-02 15:09:23 -07:00
Alexandre Ardhuin 8143992262
migrate some material files to nullsafety (#67078)
* migrate some material files to nullsafety

* review
2020-10-02 23:10:29 +02:00
David Reveman 371667ec94
Fix resampling of down, up, and remove events. (#67080)
This adds the neccessary synthetic move/hover events to
resampler, which is needed for position to not change as
part of a down, up, or remove event.

Co-authored-by: David Reveman <reveman@google.com>
2020-10-02 16:16:57 -04:00
Michael Goderbauer fc85492d7c
Make Navigator restorable (inkl. WidgetsApp, MaterialApp, CupertinoApp) (#65658) 2020-10-02 11:42:02 -07:00
Mouad Debbar 5d6321b509
[web] Respond with 404 to non-found asset or package files (#67088) 2020-10-02 11:02:03 -07:00
Jonah Williams 385ae40218
allow web shard to compile null-safe tests (#67106) 2020-10-02 10:59:00 -07:00
Jason Simmons 70973e0214
Handle empty selection box lists in RenderParagraph.assembleSemanticsNode (#67017) 2020-10-02 10:57:05 -07:00
Rami 9e715205b7
[Time Picker] Double tapping hours/minutes will switch time picker to input mode (#67076) 2020-10-02 13:53:36 -04:00
includecmath f1013e6873
[flutter_tools] According to AnalysisSeverity return exit code detailed proposal (#61589)
No matter what level(error, warning, info) issues flutter analyze always return fatal exit code(1). CI/CD environment receive 1(!0). This may leads to e.g. Jenkins Build step 'Execute shell' marked build as failure.
I propose according to AnalysisSeverity level return fatal(1) or success(0) exit code.
2020-10-01 18:50:33 -07:00
Dan Field 473358d93d
Revert dispose images when done (#67100)
* Revert "docs for image disposal (#67066)"

This reverts commit bcb2ac5a55.

* Revert "Dispose of images after using them (#66688)"

This reverts commit a7954691da.
2020-10-01 16:53:50 -07:00
Michael Goderbauer cba170fbb2
Migrate the tests of flutter_test to null-safety (#67058) 2020-10-01 16:27:02 -07:00
Dan Field bcb2ac5a55
docs for image disposal (#67066) 2020-10-01 14:14:15 -07:00
Jason Simmons c9392da6a4
Relax the bounds of some Cupertino text field tests (#67020)
SkParagraph may calculate slightly different metrics for text layouts
2020-10-01 13:46:17 -07:00
Kate Lovett d1178ae73b
Fix local gold output for flutter/flutter (#66139) 2020-10-01 11:17:03 -07:00
Jacob MacDonald b95c3d7d56
update stack_trace dep (and others) (#67057) 2020-10-01 09:54:07 -07:00
Dan Field a7954691da
Dispose of images after using them (#66688)
* Dispose of images after using them
Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf.
Makes all stateful holders of ui.Image objects properly clone and dispose of them.
Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created.
Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
2020-10-01 09:48:54 -07:00
Rami 79400b2462
[Material] Update some semantics for time picker controls (#66652) 2020-10-01 09:06:46 -04:00
Alexandre Ardhuin 9d41ddcbac
migrate some material files to nullsafety (#66985)
* migrate some material files to nullsafety

* fix test_private

* address review comments

* fix private test on windows

* use uri in include entry of analysis_options
2020-10-01 08:01:58 +02:00
Phil Quitslund d3155658bc
API docs for typedefs. (#67003) 2020-09-30 19:32:02 -07:00
Dan Field 25f44bb271
test (#67021) 2020-09-30 18:02:04 -07:00
Michael Goderbauer 19e07d2beb
Migrate flutter_test (#66663) 2020-09-30 17:03:40 -07:00
Madhur Maurya 2de1c8da47
Nested Scaffolds Documentation Improvement (#66972) 2020-10-01 07:55:15 +08:00
Jenn Magder 36fca52c0d
Replace MockArtifacts with Artifacts.test() (#67012) 2020-09-30 16:25:29 -07:00
stuartmorgan b92bb62d4d
Fix Windows and Linux plugin template filenames (#66997) 2020-09-30 16:07:03 -07:00
Jonah Williams b6768ec7a6
[flutter_tools] dont let crash reporter crash tool (#66755)
package:http can throw a ClientException, which the crash reporter must catch or the tool will crash in the crash reporter. 3/4 crash on dev.
2020-09-30 15:26:25 -07:00
Jonah Williams 0f90747bb3
[flutter_tool] enable single widget reload optimization by default on dev (#66995)
Continued gradual rollout - dev is not that much riskier than master but will give much more data
2020-09-30 15:10:51 -07:00
Mehmet Fidanboylu 95d72bf9d8
Clarify the docs on what scrollUntilVisible does (#65817) 2020-09-30 14:58:13 -07:00
Anhad Singh 64a23504bb
Added transformAlignment for container (#66201) 2020-09-30 14:55:58 -07:00
Jenn Magder becaf4913f
Replace MockCache with Cache.test() (#66946) 2020-09-30 14:53:57 -07:00
Pedro Massango f800a67ee4
[fix] once errorBuilder is called Image widget stops loading images (#65180) 2020-09-30 14:53:05 -07:00
Jason Simmons e5de2b08b8
Text test should check that a paragraph's longest line is not greater than the width constraint (#67000) 2020-09-30 14:52:08 -07:00
Jonah Williams fe22d196fc
[flutter_tools] prevent running analyze-size with split-debug-info (#66983)
Running a build command with split debug info and analyze size causes a crash in the snapshot analysis library. Disable the combination of these two flags.

Fixes #66962
2020-09-30 11:15:49 -07:00
Helin Shiah 9ca15d0118
Set DDS port to requested observatory port for test (#66607)
* Set DDS port to requested observatory port for test

* Add test for DDS and observatory ports

* Use FakePlatform instead of mock, fix spacing

* Use FakeProcessManager instead of mock

* Fix analyze issue

* Make completer private and add fn for future
2020-09-30 10:14:13 -07:00
Jonah Williams f8750b16bb
[flutter_tools] do not error doctor on missing vs code extension (#66780)
In cases where the VSCode plugins are not located, display links to where they can be downloaded but do not surface an error.
2020-09-30 08:41:31 -07:00
Jonah Williams e819f292b3
[flutter_tools] do not require a dependency on devtools server (#66842)
Re-arrange the implementation of the devtools launcher so that google3 is not required to depend on any devtools packages. Also renames the build_runner folders to isolated to better clarify their intention.
2020-09-29 18:15:56 -07:00
Jenn Magder e8fbb43aac
Replace MockFile with memory file system files (#66941) 2020-09-29 17:50:33 -07:00
Jonah Williams 9bc533c9e5
[flutter_tools] do not error flutter doctor on missing AS/intellij plugins (#66782)
In cases where the Intellij/AS plugins are not located, display links to where they can be downloaded but do not surface an error. This should generally reduce confusion about whether the plugins are required for every installed IDE. For example, frequently users may only install AS so that they can install the Android SDK - or they may have multiple copies of Intellij installed.

For example: #66762
2020-09-29 16:51:28 -07:00
Dan Field e8812c409b
Revert "Improve the behavior of Scrollable.ensureVisible when Scrollable nested (#65226)" (#66918)
This reverts commit 73b6398932.
2020-09-29 16:11:30 -07:00
Daniel Edrisian 6501f1b5cf
Allow modifying barrier color and barrier dismissible for Cupertino Modal Popup (#66692) 2020-09-29 15:37:04 -07:00
Ming Lyu (CareF) 3c321ac80f
cleanup (#66743) 2020-09-29 15:32:03 -07:00
Alexandre Ardhuin e605b7c225
migrate some material files to nullsafty (#66858)
* migrate some material files to nullsafty

* address review comments
2020-09-29 22:51:21 +02:00
Jonah Williams 0e9c6a3d5f
[flutter_tools] do not crash if chrome preference save fails (#66705)
Crash reporting shows at least one occurrence of this due to a windows file lock. That could happen if there is another running chrome instance, or perhaps a virus scanner is running. Print out the error and do not crash.
2020-09-29 13:00:11 -07:00
Konstantin Scheglov d227788a53
Move assert(s) that reference 'this' to the constructor bodies. (#66914) 2020-09-29 11:47:21 -07:00
Marcus Tomlinson 5f76bfb4af
Add the ability to inject a bootstrap script (#66897) 2020-09-29 19:24:21 +01:00
Ben Konyi 65a81c7cd3
Roll package:dds to 1.4.0 and update error handling (#66836) 2020-09-29 10:28:17 -07:00