Commit graph

5419 commits

Author SHA1 Message Date
Hans Muller 74c3e74fba Call it Flutter Gallery (#3801) 2016-05-09 11:00:54 -07:00
Devon Carew a5b198e9b9 remove the --checked option (#3799) 2016-05-09 10:58:47 -07:00
Adam Barth 40152c5593 We were looking for HapticFeedback in the wrong service bundle (#3797)
Fixes #3795
2016-05-09 10:28:43 -07:00
Jason Simmons 2ea3c9471d Fix for how flutter refresh locates the Android package manifest (#3791) 2016-05-09 09:31:46 -07:00
Jason Simmons 09dde8718b Change the Android activity launch mode to singleTop (#3792) 2016-05-09 09:31:34 -07:00
Phil Quitslund a7f2a4e448 Merge pull request #3780 from pq/error_msgs
Fix analyzer error messages.
2016-05-09 08:39:17 -07:00
Adam Barth ee903af03f Move TextAlign out of TextStyle (#3789)
TextAlign applies to a whole paragraph instead of applying to an individual
text span. This patch moves the property out of TextStyle and into a separate
property on Text and RichText.
2016-05-06 17:33:27 -07:00
Chinmay Garde 8f4a5659b0 Update engine revision to pull in changes that add support for the interpreter on iOS. (#3793) 2016-05-06 16:37:19 -07:00
pq c973629ed7 Fixed braces. 2016-05-06 13:43:21 -07:00
pq 96de7c4dcc Fix analyzer error messages.
Will have the result of restoring `[static warning]` to `[warning]`, etc.

(This is essentially how we handle it in the analyzer CLI.)
2016-05-06 13:39:48 -07:00
Adam Barth ac2c8fec34 Left-align contents of drop-down button (#3775)
Fixes #3759
2016-05-06 13:07:05 -07:00
Phil Quitslund 11a54dee01 Merge pull request #3752 from pq/analysis_rework
Analysis re-work to use analyzer APIs.
2016-05-06 10:56:59 -07:00
Ian Hickson 4d9fdda759 Remove ModalPosition (for real)
It has no more clients.

Follow-up to #3734.

Fixes #2484
2016-05-06 09:46:51 -07:00
pq 2df43d50d3 Merge branch 'master' into analysis_rework 2016-05-06 08:58:49 -07:00
Devon Carew bd564a02af avoid sending analytics on ci systems (#3765)
* avoid sending analytics on ci systems

* review comments
2016-05-05 19:51:22 -07:00
Viktor Lidholt 153e1bb918 Fixes to particle system API (#3762) 2016-05-05 17:31:16 -07:00
krisgiesing 01978d98a8 Move global analysis options file to the repo root (#3750)
* Move global analysis options file to the repo root

Also restore the analysis options file for stocks example, since
the global options trigger warnings on generated intl files.

* Remove obsolete analysis options file for Material Gallery example
2016-05-05 16:30:38 -07:00
Jason Simmons 4d0e6984c2 Build tool support for Android x86 targets in 32- or 64-bit modes (#3761) 2016-05-05 16:04:22 -07:00
pq eb215c14ac Review cleanup. 2016-05-05 15:16:27 -07:00
Devon Carew a999366482 remove the analyze --benhcmark-expected option (#3755) 2016-05-05 14:26:21 -07:00
pq 4311ddb461 Duplicate test fix. 2016-05-05 13:39:58 -07:00
pq 3b882fc449 Updated arg default handling and .dartignore support. 2016-05-05 13:25:59 -07:00
pq e808125c5b Dead code cleanup. 2016-05-05 12:35:52 -07:00
pq 71203e9a89 Analyzer dep commentary fix. 2016-05-05 12:15:26 -07:00
Adam Barth 2592f8f4b6 DropDownMenu should use ScrollableList (#3745)
Previously it used Block, which is less efficient for large numbers of items.
Also move the top margin out of the menu item to fix the baseline alignment of
the text.

Fixes #1615
2016-05-05 12:09:29 -07:00
Adam Barth b357aa32ec More docs for PerformanceOverlay (#3749)
Fixes #3747
2016-05-05 12:09:23 -07:00
pq a59a713f75 Analysis re-work to use analyzer APIs.
Introduces a new Dart analysis wrapper that works directly with the analyzer API (in favor of shelling out to a separate process).

Some consequences:

  * we no longer need to fear parts (simplifying our dart file gathering)
  * we can filter by error code (when needed), rather than by error strings
  * no more IO scraping
  * no need to generate `main()` or to run with `--package-warnings`
  * we now specify an analyzer (and linter) version in the pubspec (we’ll want to make sure this doesn’t diverge too far from the analyzer shipped with the SDK but it does give us some room to play with experimental builds)
  * no more (re)scanning of error source files (and so no more source cache)
  * should generally be a bit simpler and easier to maintain
  * runs a bit faster :)
2016-05-05 12:08:58 -07:00
Adam Barth 2fbf11a77b Expose blurSigma (#3743)
Fixes #3741
2016-05-04 18:50:38 -07:00
Adam Barth 6a46bf2e45 Ensure that DropDownMenus are always onscreen (#3742)
This patch sizes the menu such that it is always on screen, but doesn't scroll
the menu to ensure that the currently selected item is always visible and on
top of the button. That will need to wait for a later patch.

Also, teach CustomPaint how to repaint animations more efficiently.

Fixes #3720
2016-05-04 17:13:15 -07:00
Phil Quitslund 0e515631a1 Merge pull request #3739 from pq/eq_matcher_cleanup
Prefer implict `equals` matcher in test expectations.
2016-05-04 14:16:06 -07:00
Yegor 39e741dfb7 [tools] remove --flutter-repo flag in flutter test (#3728) 2016-05-04 14:08:16 -07:00
Phil Quitslund 32bbbc6458 Merge pull request #3738 from pq/annotate_literals_3
Last literals get their types.
2016-05-04 13:59:09 -07:00
pq 79d1d3a7c4 Prefer implict equals matcher in test expectations.
@Hixie: as per our conversation, a little more concise.
2016-05-04 13:58:45 -07:00
Adam Barth 8da98105b4 Skip the gallery smoke test (#3736)
This test hangs occationally on the bots and the bots aren't smart enough to
recover, which means the whole project gets blocked.

Filed #3735 about the hang.
2016-05-04 13:42:29 -07:00
Devon Carew 61c003734b checked mode fix; add type annotation (#3737) 2016-05-04 13:41:46 -07:00
pq 98ef58396a Last literals get their types.
Last fixes to get the repo running clean checking for annotations on list and map literals.
2016-05-04 13:37:23 -07:00
Adam Barth a5eb4c04c7 Remove ModalPosition (#3734)
Clients of getPosition should just use a one-child custom layout delegate
instead.

Fixes #2484
2016-05-04 12:40:50 -07:00
Matt Perry a5920c3d52 First pass at a material-style copy/paste toolbar. (#3698)
* First pass at a material-style copy/paste toolbar.

This mimics the toolbar you see when selecting text in an Android
material app. There's still more to do (like integration with the system
clipboard), but this seemed like a good stopping point.

BUG=https://github.com/flutter/flutter/issues/1567
2016-05-04 15:37:04 -04:00
Devon Carew f34d31717c complain on missing entries in flutter.yaml (#3731)
* complain on missing entries in flutter.yaml

* change to a hard failure
2016-05-04 12:33:34 -07:00
Phil Quitslund 04e892a457 Merge pull request #3729 from pq/annotate_literals_2
More type annotations for literals.
2016-05-04 12:32:54 -07:00
Devon Carew e365453eac better parsing of adb devices output (#3726)
* better parsing of adb devices output

* re-order lines
2016-05-04 12:32:46 -07:00
Ian McKellar b04670699e Fix case of 'GET' HTTP method. (#3732)
Fixes #3730
2016-05-04 12:24:04 -07:00
Devon Carew e464a81998 remove the packages/flutter_tools/.analysis_options file (#3733) 2016-05-04 11:43:01 -07:00
krisgiesing 07b5f83e55 Add analysis options near the root of the repository (#3700)
This aligns the analysis options used by 'flutter analyze' with the
options used by Atom.
2016-05-04 10:15:15 -07:00
pq 8bc06aa9b3 More type annotations for literals.
The `flutter` package gets more types!

Follow-up from: https://github.com/flutter/flutter/pull/3727.
2016-05-04 10:10:08 -07:00
Devon Carew 1d4cda5d13 fix the benchmark file written by the analyze command (#3725) 2016-05-04 10:01:39 -07:00
Phil Quitslund c2363c88a6 Merge pull request #3727 from pq/annotate_literals
Literals get type annotations.
2016-05-04 09:37:53 -07:00
pq bcede8dffb Literals get type annotations.
As per the recent fix to the `always_specify_types` lint (https://github.com/dart-lang/linter/issues/199), literal maps and lists are now expected to be explicitly typed.

Running that lint on the repo identifies quite a few spots to update.  This focuses on `flutter_driver` and `flutter_sprites` (somewhat arbitrarily) but the changes are fairly representative.

Note there are a number of places where I made a quick judgement on how specific to make the types.  Feedback on those is welcome.  (Especially as we move forward with more.)
2016-05-04 09:18:31 -07:00
Ian Hickson 1e093701b7 Save some memory by only storing one copy of the animation object... (#3724)
Turns out we were storing the same object in the base class and the
subclass. For pretty much every AnimatedWidget subclass.
2016-05-03 23:49:35 -07:00
Adam Barth 7712e583a4 Add missing dartdocs from material.dart (#3709)
Making progress towards document all public APIs in material.dart. We're still
missing a few odds and ends (as well as missing docs in tabs.dart,
tooltip.dart, and two_level_list.dart).
2016-05-03 21:07:29 -07:00