Commit graph

16644 commits

Author SHA1 Message Date
Emmanuel Garcia 6d77996d6a
Attach looks at future observatory URIs (#44637) 2019-11-19 15:11:41 -08:00
Danny Tuppeny 37eec86294
Allow web server device to use extension if started with --start-paused (#44263)
* Allow web server device to use extension if started with --start-paused

* Fix comment

* Remove browser-launch option that allowed using Chrome without launching Chrome

The web-server device should now be used if you don't want to launch a browser.

* Add tests for WebServerDevice with --start-paused

* Fixes from rebase

* More fixes from rebase

* Fix from rebase

* Fix condition for page refresh in non-debug builds

* Make dwds conditions match with a new getter

* Add missing .device
2019-11-19 20:11:53 +00:00
Danny Tuppeny 92e9f5f167
Increase memory from 8->10GB for tool_tests-commands-linux (#45178)
I've had many OOMKilled failures on Cirrus on this shard today on trivial PRs.
2019-11-19 19:52:02 +00:00
Greg Spencer 29ab6b549a
Update manual_tests to be able to run on macOS/web (#44830)
I updated the build files for manual_tests, as well as adding in a macos and web directory to allow the manual tests to be run on the web or on desktop.

The main change here are the parts that I added to the files in manual_tests/lib/... (the addition of kIsWeb to "if (!kIsWeb && Platform.isMacOS) {") The rest is just an update of the auto-generated code from flutter create.
2019-11-19 11:29:35 -08:00
Jason Simmons 68d1fe58da
Add the rally_assets package to Gallery's BUILD.gn (#45180) 2019-11-19 11:27:43 -08:00
Jonah Williams df3505c1f3
Improve performance of build APK (~50%) by running gen_snapshot concurrently (#44534) 2019-11-19 11:26:07 -08:00
Jenn Magder 6e5769d425
Remove FLUTTER_DEVICELAB_XCODE_PROVISIONING_CONFIG code paths (#45136) 2019-11-19 11:19:44 -08:00
Per Classon b5a85fcf48
Allow plural localized strings to not specify every case (#45168)
* Allow plural localized strings to not specify every case
2019-11-19 18:58:28 +01:00
Jonah Williams e236196037
cache sdkNameAndVersion logic for web devices (#45145) 2019-11-19 09:36:24 -08:00
Per Classon 399aebc4b7
[Gallery] Add Material Study app Rally as an example app (#44907)
Add Material Study app Rally as an example app
2019-11-19 12:12:56 +01:00
Alexandre Ardhuin 0df8812681
fix type errors (#45151) 2019-11-19 09:28:24 +01:00
Alexandre Ardhuin 4bf03c6cf8
implicit-casts:false in flutter_test (#44996) 2019-11-19 08:10:24 +01:00
Alexandre Ardhuin adc7351046
implicit-casts:false on flutter_tools/lib (#44447)
* implicit-casts:false on flutter_tools/lib

* address review comments

* use castStringKeyedMap

* introduce {bool,string,strings}Arg

* fix ci
2019-11-19 07:57:42 +01:00
engine-flutter-autoroll 152e6ec006
ecb32952f Roll src/third_party/dart 830f291773..62c67e40dc (15 commits) (#45147)
git@github.com:flutter/engine.git/compare/762294cf2d29...ecb32952ffcb

git log 762294cf2d29..ecb32952ffcb --no-merges --oneline
2019-11-19 bkonyi@google.com Roll src/third_party/dart 830f291773..62c67e40dc (15 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-19 01:03:50 -05:00
engine-flutter-autoroll 1b1365376b
Roll engine 9832bc8f2eb2..762294cf2d29 (8 commits) (#45144)
git@github.com:flutter/engine.git/compare/9832bc8f2eb2...762294cf2d29

git log 9832bc8f2eb2..762294cf2d29 --no-merges --oneline
2019-11-19 tvolkert@users.noreply.github.com Revert "RendererContextSwitch guard flutter's gl context rework. (#13812)" (flutter/engine#13906)
2019-11-19 bkonyi@google.com Roll src/third_party/dart 06e6554d2e..830f291773 (22 commits) (flutter/engine#13905)
2019-11-19 ferhat@gmail.com Fix withIn matcher distance function lookup (flutter/engine#13904)
2019-11-18 bkonyi@google.com Roll src/third_party/dart aceeba7567..06e6554d2e (2 commits) (flutter/engine#13900)
2019-11-18 ferhat@gmail.com Fix single line bitmap canvas text shadow (flutter/engine#13901)
2019-11-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from dhwMR... to kSMF7... (flutter/engine#13899)
2019-11-18 bkonyi@google.com Roll src/third_party/dart 7b67303318..aceeba7567 (8 commits)
2019-11-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6ZRA_... to Oo6E_... (flutter/engine#13894)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-19 00:05:51 -05:00
Kaushik Iska f45bd48cca
Revert "[flutter_runner] Use sky_engine from the topaz tree (#44935)" (#45141)
This reverts commit f48f457350.
2019-11-18 19:36:50 -08:00
Greg Spencer 6e10719dc5
FocusableActionDetector widget (#44867)
This adds a FocusableActionDetector, a widget which combines the functionality of Actions, Shortcuts, MouseRegion and a Focus widget to create a detector that defines actions and key bindings, and will notify that the focus or hover highlights should be shown or not. This widget can be used to give a control the required detection modes for focus and hover handling on desktop and web platforms.

I replaced a bunch of similar code in many of our widgets with this widget, and found that pretty much any control that wants to be focusable wants all of these features as well: focus highlights, hover highlights, and actions to activate it.

Also eliminated an extra _hasFocus variable in FocusState that wasn't being used.
2019-11-18 17:23:30 -08:00
Shi-Hao Hong cce445e278
ignore vscode auto-generated files (#45080) 2019-11-18 16:25:32 -08:00
Amir Hardon 3c65463f89
Enable iOS platform views for Flutter Gallery (#45126)
While building the iOS platform views support we only enabled it when the app developer explicitly specified it with a flag, the main reasons were using an untested thread configuration, and taking a performance hit (even when no platform view is used due to disabled raster cache).

Now that we are using the same dynamic thread configuration whether platform views is used or not, and that raster cache works with platform views in the tree as well, we are almost ready to enabled the platform views support by default.

As a first step, I'm enabling it for the Flutter Gallery app on which we run benchmarks. After monitoring the benchmarks and making sure the gallery takes no hit we should be more confident to enabled platform views by default.

This change is expected to have no performance effect on the Gallery app at all.
2019-11-18 16:13:52 -08:00
Jonah Williams 58438fca3f Provide specific field to accept depfiles in target class (#44481)
* add depfile slot to Target class

* Update source.dart

* Update source.dart
2019-11-18 14:09:40 -08:00
Greg Spencer d026f2d948
Properly interpret modifiers on GLFW key events (#44844)
GLFW key events set modifier flags based on what the modifier state was before the event, unlike every other platform. This modifies the GLFW key support to take that into account.

As a small cleanup, I fixed a documentation macro reference for the modifier flags that was duplicate
2019-11-18 14:07:08 -08:00
Greg Spencer 21158d8337
Add command key bindings to macOS text editing and fix selection. (#44130)
This adds support for the command key for text selection/editing on macOS. I had ported the text editing code (in #42879), but forgot to add support for the command key itself. This also adds a test that tests the text editing on multiple platforms instead of just testing Android.

There appears to still be a bug (filed #44135) where we're losing key events sometimes on macOS, leaving some keys "stuck" on, but this PR at least allows the right key combinations to be used.
2019-11-18 14:06:37 -08:00
Jonah Williams a7367b650b
Don't log stack traces to console on build failures (#44966) 2019-11-18 14:04:11 -08:00
Christopher Fujino ff84b3e66d catch IOSDeviceNotFoundError in IOSDevice.startApp() (#45011) 2019-11-18 13:53:55 -08:00
engine-flutter-autoroll 01b0a62974
9832bc8f2 Roll src/third_party/skia 78fa08b279c5..c9d263c1213e (1 commits) (flutter/engine#13893) (#45108)
git@github.com:flutter/engine.git/compare/5fb7eb753b28...9832bc8f2eb2

git log 5fb7eb753b28..9832bc8f2eb2 --no-merges --oneline
2019-11-18 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78fa08b279c5..c9d263c1213e (1 commits) (flutter/engine#13893)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-18 16:49:51 -05:00
chunhtai 7e1920b817
revert added lifecycle enum (#45119) 2019-11-18 13:38:47 -08:00
chunhtai 439d798712
fix ios_add2app_life_cycle license (#45115) 2019-11-18 11:33:42 -08:00
Danny Tuppeny 81f6ba84b9
Switch from using app.progress to app.webLaunchUrl for passing web launch urls (#44268)
* Switch from using app.progress to app.url for passing web launch urls

* Update daemon.md

* Change app.url -> app.webLaunchUrl

* Add tests for app.webLaunchUrl event

* Update tests with recent changes after rebasing
2019-11-18 18:10:15 +00:00
chunhtai af48f71497
reland add new enum change (#45012)
This reverts commit 75f310791f.
2019-11-18 10:04:09 -08:00
Bartosz Wiśniewski 5c15b270b3 Remove duplicated expect from text field test (#45081) 2019-11-18 09:51:16 -08:00
engine-flutter-autoroll 2461c75600
5fb7eb753 Roll src/third_party/dart 8617da2bf0..7b67303318 (3 commits) (#45094)
git@github.com:flutter/engine.git/compare/3261324fab79...5fb7eb753b28

git log 3261324fab79..5fb7eb753b28 --no-merges --oneline
2019-11-18 bkonyi@google.com Roll src/third_party/dart 8617da2bf0..7b67303318 (3 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-18 12:26:51 -05:00
engine-flutter-autoroll 21e6fe1ddf
3261324fa Roll fuchsia/sdk/core/mac-amd64 from pVwSb... to 6ZRA_... (flutter/engine#13891) (#45084)
git@github.com:flutter/engine.git/compare/4da0645df1aa...3261324fab79

git log 4da0645df1aa..3261324fab79 --no-merges --oneline
2019-11-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from pVwSb... to 6ZRA_... (flutter/engine#13891)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-17 23:39:51 -05:00
engine-flutter-autoroll 802bd5514f
4da0645df Roll fuchsia/sdk/core/mac-amd64 from Ass60... to pVwSb... (flutter/engine#13890) (#45064)
git@github.com:flutter/engine.git/compare/54be2d5fd8ea...4da0645df1aa

git log 54be2d5fd8ea..4da0645df1aa --no-merges --oneline
2019-11-17 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Ass60... to pVwSb... (flutter/engine#13890)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-17 11:11:51 -05:00
engine-flutter-autoroll a0c929bf81
54be2d5fd Roll src/third_party/skia 541f310b3482..78fa08b279c5 (9 commits) (flutter/engine#13884) (#45060)
git@github.com:flutter/engine.git/compare/fb9b91428b44...54be2d5fd8ea

git log fb9b91428b44..54be2d5fd8ea --no-merges --oneline
2019-11-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia 541f310b3482..78fa08b279c5 (9 commits) (flutter/engine#13884)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-17 09:08:51 -05:00
engine-flutter-autoroll 028b4c4f40
fb9b91428 Roll fuchsia/sdk/core/mac-amd64 from rX-Bh... to Ass60... (flutter/engine#13888) (#45051)
git@github.com:flutter/engine.git/compare/7ef587220aca...fb9b91428b44

git log 7ef587220aca..fb9b91428b44 --no-merges --oneline
2019-11-17 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from rX-Bh... to Ass60... (flutter/engine#13888)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-16 22:41:51 -05:00
engine-flutter-autoroll c82c587b33
Roll engine f0371e2f8f97..7ef587220aca (2 commits) (#45049)
git@github.com:flutter/engine.git/compare/f0371e2f8f97...7ef587220aca

git log f0371e2f8f97..7ef587220aca --no-merges --oneline
2019-11-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from s9Vl7... to rX-Bh... (flutter/engine#13887)
2019-11-16 bkonyi@google.com Roll src/third_party/dart d6b0a27665..8617da2bf0 (1 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-16 18:02:51 -05:00
engine-flutter-autoroll b521d01701
f0371e2f8 Work around Fuchsia a11y / ICU name conflict (flutter/engine#13885) (#45029)
git@github.com:flutter/engine.git/compare/59b5a0cf7676...f0371e2f8f97

git log 59b5a0cf7676..f0371e2f8f97 --no-merges --oneline
2019-11-16 ianloic@google.com Work around Fuchsia a11y / ICU name conflict (flutter/engine#13885)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-16 16:56:51 -05:00
engine-flutter-autoroll 35043cbbe3
59b5a0cf7 Roll src/third_party/dart fdb9d19826..d6b0a27665 (19 commits) (#45024)
git@github.com:flutter/engine.git/compare/7892c69445d4...59b5a0cf7676

git log 7892c69445d4..59b5a0cf7676 --no-merges --oneline
2019-11-16 bkonyi@google.com Roll src/third_party/dart fdb9d19826..d6b0a27665 (19 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-15 23:52:17 -05:00
engine-flutter-autoroll dec339bc55
7892c6944 Roll fuchsia/sdk/core/mac-amd64 from RI85D... to s9Vl7... (flutter/engine#13882) (#45021)
git@github.com:flutter/engine.git/compare/486e62d02a2a...7892c69445d4

git log 486e62d02a2a..7892c69445d4 --no-merges --oneline
2019-11-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from RI85D... to s9Vl7... (flutter/engine#13882)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-15 22:47:17 -05:00
Ian Hickson 62e4ab87b3
Update our deprecation style. (#44618) 2019-11-15 19:21:53 -08:00
engine-flutter-autoroll 879da263ff
Roll engine b3463e3580bc..486e62d02a2a (2 commits) (#45018)
git@github.com:flutter/engine.git/compare/b3463e3580bc...486e62d02a2a

git log b3463e3580bc..486e62d02a2a --no-merges --oneline
2019-11-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1496758da42e..541f310b3482 (12 commits) (flutter/engine#13880)
2019-11-16 bkonyi@google.com Roll src/third_party/dart 8e176998b4..fdb9d19826 (5 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-15 21:45:17 -05:00
engine-flutter-autoroll f50ea3ba2a
Roll engine b2640d97e7e8..b3463e3580bc (2 commits) (#45017)
git@github.com:flutter/engine.git/compare/b2640d97e7e8...b3463e3580bc

git log b2640d97e7e8..b3463e3580bc --no-merges --oneline
2019-11-15 garyq@google.com getLineBoundary edge condition use <= instead of < (flutter/engine#13881)
2019-11-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia b3d3551577a3..1496758da42e (5 commits) (flutter/engine#13876)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-15 20:39:16 -05:00
Jonah Williams 2a576b774c
remove no-gen-bytecode flag (#43908) 2019-11-15 13:15:05 -08:00
Kate Lovett ae62a3cf1b
Error Message for createState assertion (#44610)
* Init

* Added error message to assert

* Removing unrelated changes
2019-11-15 13:05:18 -08:00
Kate Lovett b1ca7f419e
Update Gold to fallback on skipping comparator when offline (#44619) 2019-11-15 13:04:59 -08:00
Ben Konyi e3ae7fab62
Manual engine roll to b2640d97e7e8034f28b4e7b92c15b0824e433897 (#45000)
Fixes failures in some tests which used regular expressions to compare
stack traces which had instances of "<asynchronous suspension>".
2019-11-15 12:13:59 -08:00
engine-flutter-autoroll a44f53931d
096ba6892 Reland children isolates sharing isolate group change. (flutter/engine#13758) (#44997)
git@github.com:flutter/engine.git/compare/cc2fe6be9e42...096ba6892a43

git log cc2fe6be9e42..096ba6892a43 --no-merges --oneline
2019-11-15 aam@google.com Reland children isolates sharing isolate group change. (flutter/engine#13758)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-15 14:34:17 -05:00
Kate Lovett 7aa5b07537
Adding flutter_goldens package tests (#44479) 2019-11-15 10:29:19 -08:00
Greg Spencer dcc4b82540
Fix snippets to include element ID in the output sample. (#44787)
This fixes the snippet code output so that it includes the name of the element that it is a snippet for in the first line.
2019-11-15 10:23:04 -08:00
Zachary Anderson 29c026fac4
[flutter_tool] Don't crash when failing to delete downloaded artifacts (#44933)
* [flutter_tool] Don't crash when failing to delete downloaded artifacts

* Add space

* Add more spaces.
2019-11-15 10:05:45 -08:00