Greg Spencer
a5053bfb29
Fix transforms for things with RenderPointerListeners ( #32535 )
...
This fixes #32525 , because it now marks the compositing bits as needing to be recalculated if the mouse tracker changes its idea of whether or not a mouse is attached.
This bug occurred because the test framework was leaking state from one test to the next (the state about whether a mouse pointer was active), and so even though there was a "passing" test when run in order with the other tests in the file, when the test was run individually (or first), it would have failed and caught the bug.
This adds an assert to make sure that after each test there are no simulated mouse pointers connected, and now calls removePointer in all of the tests where this was a problem.
2019-05-13 15:48:12 -07:00
Jason Simmons
f5cf209a66
Remove appbundle build steps that are required for APKs but not AABs ( #32515 )
...
Some parts of the appbundle build process were based on the logic for building
APK packages. However, these steps (copying to a directory shared by all
build variants, and calculating a SHA) are not necessary for an appbundle.
2019-05-13 15:36:47 -07:00
Shi-Hao Hong
41ff8408ca
Add Actions to AppBar Sample Doc ( #32530 )
...
* Add actions to AppBar sample doc
2019-05-13 15:19:14 -07:00
engine-flutter-autoroll
74d3fe6555
Roll engine f4d23ef694a9..904cfc4fe363 (5 commits) ( #32648 )
...
f4d23ef694...904cfc4fe3#32642 ). (flutter/engine#8947 )
c9406d45c Roll src/third_party/skia d696f8e6bca3..0221e8b22687 (5 commits) (flutter/engine#8948 )
1b649a57d update docs (flutter/engine#8928 )
47fd66c89 Terminate debug background task on expiry (flutter/engine#8930 )
14c82d996 Only cache required frames (flutter/engine#8837 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 17:54:40 -04:00
liyuqian
06f86c8b2f
Reland matrix check ( #32521 )
...
This relands flutter/flutter#31701 with missing const added
This reverts commit 549b412656
2019-05-13 14:36:09 -07:00
xster
1cd88c3501
Let CupertinoNavigationBarBackButton take a custom onPressed ( #32469 )
2019-05-13 12:41:24 -07:00
engine-flutter-autoroll
f82c83b31c
f4d23ef69 Replace Skia font macros with enums. (flutter/engine#8920) ( #32640 )
...
839628b1e8...f4d23ef694flutter/engine#8920 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 15:39:39 -04:00
engine-flutter-autoroll
11fe9fc91c
839628b1e Roll src/third_party/skia 617d801ff762..d696f8e6bca3 (6 commits) (flutter/engine#8946) ( #32635 )
...
c454d2ef7f...839628b1e8flutter/engine#8946 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 14:26:40 -04:00
Shi-Hao Hong
9545c5d166
Tab Animation Sample Video ( #32177 )
...
* Improve tabs documentation regarding matching lengths
* Add Tabs animation to docs
2019-05-13 09:06:43 -07:00
engine-flutter-autoroll
c4d527123e
Roll engine 816d3fc58611..c454d2ef7fc5 (2 commits) ( #32625 )
...
816d3fc586...c454d2ef7fflutter/engine#8945 )
8d126ce9f Roll src/third_party/skia 806621b2e0b5..695206d7149a (1 commits) (flutter/engine#8942 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-13 11:00:41 -04:00
Danny Tuppeny
b76a1e8312
Comment out .vscode/ in gitignore for templates ( #32404 )
2019-05-13 09:06:30 +01:00
engine-flutter-autoroll
9b2a1853ac
816d3fc58 New Plugin API PR1: Introduces PluginRegistry and FlutterPlugin, adds support for plugin registration to FlutterEngine. (flutter/engine#8826) ( #32598 )
...
21ad7f051c...816d3fc586flutter/engine#8826 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-12 21:28:38 -04:00
engine-flutter-autoroll
ebacca34e5
21ad7f051 Move the Fuchsia Flutter Runner to //flutter/shell/platform/fuchsia/flutter (flutter/engine#8939) ( #32593 )
...
7553de25db...21ad7f051cflutter/engine#8939 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-12 19:09:39 -04:00
engine-flutter-autoroll
3d42e3fadf
7553de25d Roll src/third_party/skia 5c7b54112bca..806621b2e0b5 (1 commits) (flutter/engine#8941) ( #32579 )
...
5526884e78...7553de25dbflutter/engine#8941 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-12 11:05:39 -04:00
stuartmorgan
710a0cb9a5
Adjust macOS build flow ( #32538 )
...
- Removes SYMROOT from the Generated.xcconfig. Having it causes current
versions of Xcode to switch the project's build output to "Legacy",
which causes anything not overridden to use a project-relative build
directory instead of a shared directory in DerivedData, breaking
anything with subprojects that it depends on.
This means that `flutter run` and builds from Xcode will use
completely different build directories, but that each should be
internally consistent.
- Moves the FlutterMacOS.framework to $SRCROOT/Flutter. This is
consistent with the approach we're moving to for all desktop
platforms, and avoids issues finding it now that SYMROOT doesn't match
for the two different build modes.
Fixes #32494
2019-05-11 21:12:42 -04:00
engine-flutter-autoroll
145f9f7ea6
Roll engine 6e3c0431410c..5526884e7878 (3 commits) ( #32568 )
...
6e3c043141...5526884e78flutter/engine#8936 )
5ad986424 Roll src/third_party/skia 303bacbc0fcb..5c7b54112bca (2 commits) (flutter/engine#8938 )
64481bd5d Roll src/third_party/skia 6e407986cd3b..303bacbc0fcb (2 commits) (flutter/engine#8935 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-11 19:47:39 -04:00
Jonah Williams
8b0243f413
Teach Linux to use local engine ( #31631 )
2019-05-11 00:08:29 -07:00
Kate Lovett
829bdeb426
Fixing accidental merge from WIP branch. ( #32520 )
...
Revert "Merge branch 'master' into master"
This reverts commit e3a03c04c46474982649
2019-05-10 15:53:41 -07:00
Kate Lovett
e3a03c04c4
Merge branch 'master' into master
2019-05-10 15:16:40 -07:00
engine-flutter-autoroll
6474982649
6e3c04314 Synthesize buttons for embedders (flutter/engine#8873) ( #32508 )
...
3822aeccd9...6e3c043141flutter/engine#8873 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-10 16:56:38 -04:00
Dan Field
382704ca95
Use precisionErrorTolerance ( #32499 )
2019-05-10 13:28:19 -07:00
engine-flutter-autoroll
38f408f02e
Roll engine 710e9edda6a4..3822aeccd93f (2 commits) ( #32505 )
...
710e9edda6...3822aeccd9flutter/engine#8867 )
0bc6dc974 Platform_views gesture: let flutter view controller be the media to pass the touches. (flutter/engine#8685 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-10 15:33:38 -04:00
engine-flutter-autoroll
a7a9e875c2
710e9edda Roll src/third_party/skia 6eeaf927e381..6e407986cd3b (4 commits) (flutter/engine#8933) ( #32497 )
...
bf17478a91...710e9edda6flutter/engine#8933 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-10 14:21:38 -04:00
Jonah Williams
549b412656
Revert "Add more asserts to check matrix validity ( #31701 )" ( #32496 )
2019-05-10 10:05:15 -07:00
liyuqian
0dc290c023
Add more asserts to check matrix validity ( #31701 )
...
## Description
These will help identify where the matrix starts to get wrong.
Also fixed `RenderFittexBox` to no longer paint with empty child which previously triggered invalid matrix computations (NaN with dividing by 0). See also https://github.com/flutter/flutter/pull/7489
## Related Issues
https://github.com/flutter/flutter/issues/31650
https://github.com/flutter/flutter/issues/31700
https://github.com/flutter/flutter/issues/7431
## Tests
* RenderFittedBox does not paint with empty sizes
2019-05-10 09:33:09 -07:00
Michael Goderbauer
b37c3be0fa
Add ancestor and descendant finders to Driver ( #32410 )
2019-05-10 18:21:19 +02:00
Riccardo Ratta
705143855f
Make font semibold when isDefaultAction is true in CupertinoDialogAction ( #31308 )
...
Make font semibold when isDefaultAction is true in CupertinoDialogAction
2019-05-10 08:22:56 -07:00
engine-flutter-autoroll
fc6dfe538f
bf17478a9 Roll src/third_party/skia 4f6eb15178d8..6eeaf927e381 (12 commits) (flutter/engine#8932) ( #32490 )
...
d8646ed07c...bf17478a91flutter/engine#8932 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-10 10:47:39 -04:00
Efthymis Sarmpanis
b24f1f78a7
Add breadcrumbs to TextOverflow ( #32328 )
2019-05-10 13:29:31 +02:00
Michael Goderbauer
8cf65526e7
everything const ( #32380 )
2019-05-10 13:29:03 +02:00
xster
87d9c553f4
Revert "Cupertino localization step 12: push translation for all supported languages ( #31644 )" ( #32470 )
...
This reverts commit 10922df68e
2019-05-10 01:08:59 -07:00
xster
10922df68e
Cupertino localization step 12: push translation for all supported languages ( #31644 )
2019-05-09 23:18:56 -07:00
xster
1ac813a5e6
Cupertino localization step 10: update the flutter_localizations README ( #30224 )
2019-05-09 23:17:43 -07:00
Hans Muller
6d0e235cf8
Support for replacing the TabController, after disposing the old one ( #32434 )
2019-05-09 22:02:46 -07:00
engine-flutter-autoroll
3fb1079a19
Roll engine f1f95f91df12..d8646ed07cf3 (2 commits) ( #32460 )
...
f1f95f91df...d8646ed07cflutter/engine#8731 )
b3e32e730 Roll src/third_party/skia dbded16fadde..4f6eb15178d8 (7 commits) (flutter/engine#8922 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-10 00:58:39 -04:00
engine-flutter-autoroll
4dce050c52
Roll engine 644db5a49c35..f1f95f91df12 (3 commits) ( #32440 )
...
644db5a49c...f1f95f91dfflutter/engine#8925 )
27409dc1c [fuchsia] Guard out-of-tree Fuchsia targets to fix in-tree build (flutter/engine#8923 )
6ed91ce8e Roll src/third_party/dart a0290f823c..c1e2df8f36 (3 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-10 00:06:39 -04:00
Greg Spencer
d2fe08628d
Implements FocusTraversalPolicy and DefaultFocusTraversal features. ( #30076 )
...
This implements a DefaultFocusTraversal widget to describe the focus traversal policy for its children, defined by a FocusTraversalPolicy object from which custom policies may be created. Pre-defined policies include widget-order traversal, "reading order" traversal and directional traversal.
2019-05-09 20:24:23 -07:00
Sam Rawlins
9c77e8e8a0
Fix missing return statements on function literals ( #31825 )
2019-05-09 12:43:51 -07:00
Greg Spencer
66a6726306
Fix benchmark regression in layer.find<S>(Offset) ( #32425 )
...
This fixes a benchmark regression introduced in #32350 . The performance is improved by just reverting the Layer.find<S> routines to use their old definitions, instead of defining them in terms of the findAll<S> lazy iterators.
Fixes #32387
2019-05-09 12:25:52 -07:00
liyuqian
3436e165c8
Add master channel to performance issue template ( #32345 )
...
I helped the daily mail debug a performance issue on I/O yesterday. Not
using the master branch could be wasting a lot of time due to old bugs.
2019-05-09 10:37:34 -07:00
Phil Quitslund
3a6acb8c25
More const conversions ( #32408 )
...
* update immutable to const
* => const lists
* revert making list const
* make Centers const
2019-05-09 09:23:30 -07:00
engine-flutter-autoroll
d80a14c116
Roll engine 3ef5007d90cf..644db5a49c35 (10 commits) ( #32413 )
...
3ef5007d90...644db5a49cflutter/engine#8913 )
1c8e31b4f Make sure Window.dpr still has a setter (flutter/engine#8912 )
ad02f3cc1 Roll src/third_party/dart 678f4bb926..a0290f823c (1 commits)
ccfc02a8a Roll src/third_party/skia dfda5f57bf25..dbded16fadde (1 commits) (flutter/engine#8918 )
f901126cc Roll src/third_party/skia b9330017c070..dfda5f57bf25 (2 commits) (flutter/engine#8917 )
c12b917e9 Roll src/third_party/dart ef0c812b0d..678f4bb926 (11 commits)
ee45100b5 Roll src/third_party/skia 15c91422339a..b9330017c070 (11 commits) (flutter/engine#8915 )
812616a67 Fix TimePoint on Windows (flutter/engine#8910 )
30885db99 Roll src/third_party/dart f7bf890ff7..ef0c812b0d (13 commits)
78adbf78d Add web sdk implementation. (flutter/engine#8891 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-09 12:10:40 -04:00
Jonah Williams
4d3b51e284
Allow flutter web to be compiled with flutter ( #32360 )
2019-05-09 08:57:26 -07:00
stuartmorgan
e8c5c98132
Fix assignment in macos_build_flutter_assets.sh ( #32406 )
...
Bash assignment doesn't have spaces around '='.
Fixes #32341
2019-05-09 10:16:30 -04:00
Phil Quitslund
d96c1c88b7
make immutables const ( #32340 )
...
* make immutables const
2019-05-09 05:47:01 -07:00
Michael Goderbauer
1621baafc7
Introduce separate HitTestResults for Box and Sliver ( #31894 )
2019-05-09 10:00:01 +02:00
Michael Goderbauer
ff1dbcdeb6
Add geometry getters to Flutter Driver ( #32302 )
2019-05-09 09:50:02 +02:00
engine-flutter-autoroll
8b114482a4
Roll engine 026df8e46cde..3ef5007d90cf (2 commits) ( #32355 )
...
026df8e46c...3ef5007d90flutter/engine#8889 )
e7e6689b7 Expose API to decode images to specified dimensions (flutter/engine#8596 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 21:05:39 -04:00
Greg Spencer
aeccd6a8bc
Fix nested listeners so that ancestor listeners can also receive enter/exit/move events. ( #32350 )
...
This changes Listener to trigger enter/move/exit in all Listeners below the pointer, not just the leaf region (the first region hit). This is because we need to allow listeners to be nested so that, say, a widget that handles changing color on hover, but also is wrapped in a Tooltip (that handles hover) can trigger both actions, not just one.
To that end, I added a findAll to Layer, similar to the existing find method that was previously used. It returns an iterator over annotated layers which match the given data type.
Since the findAll is implemented as returning an Iterable (and is sync*), I re-implemented the find routines as just returning the first result from findAll, since that should be just as efficient, and would then prevent duplication in the implementation.
2019-05-08 17:57:42 -07:00
engine-flutter-autoroll
e0943c4268
026df8e46 Roll src/third_party/dart f80f0bfcfd..f7bf890ff7 (2 commits) ( #32343 )
...
0a2d18da95...026df8e46chttps://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com ), and stop
the roller if necessary.
2019-05-08 20:13:39 -04:00
