Commit graph

7601 commits

Author SHA1 Message Date
Chris Bracken 6c97dd2c6c Declare locals as final where not reassigned (dev) (#8574) 2017-03-03 18:06:08 -08:00
Chris Bracken 7a52fb6772 Declare locals final where not reassigned (stocks) (#8573) 2017-03-03 18:05:27 -08:00
Chris Bracken 4c8c420e0b Declare locals final where not reassigned (layers) (#8572) 2017-03-03 18:04:27 -08:00
Chris Bracken 96eea437b2 Declare locals final where not reassigned (gallery) (#8571) 2017-03-03 17:51:21 -08:00
Chris Bracken aa07d14755 Declare locals final where not reassigned (flutter_markdown) (#8568) 2017-03-03 17:51:10 -08:00
Chris Bracken 895f3e6350 Declare locals final where not reassigned (flutter_test) (#8569) 2017-03-03 17:51:01 -08:00
Chris Bracken 7a09316cd0 Declare locals final where not reassigned (flutter_tools) (#8570) 2017-03-03 17:50:46 -08:00
Chris Bracken 46291903e0 Declare locals final where not reassigned (tests) (#8566) 2017-03-03 17:43:22 -08:00
Chris Bracken 27e8cc3797 Declare locals final where not reassigned (#8564)
Covers lib/ in package:flutter.
2017-03-03 17:42:23 -08:00
Yegor 8738eb97bc add crash reporting without enabling it (#8518)
* add crash reporting without enabling it

* do not drop futures on the floor

* return exitCode from executable run

* debug travis

* remove unnecessary todo

* rename local fs getter
2017-03-03 16:54:47 -08:00
Adam Barth 46c4c5f51a Improve ClipRect documentation (#8560)
Fixes #8557
2017-03-03 15:51:07 -08:00
xster f894edebff Use exact Ahem and exact dimensions for Cupertino button test (#8561)
* Use exact Ahem and exact dimensions for test

* use ‘px’ everywhere
2017-03-03 14:30:33 -08:00
Hans Muller 54d9541638 Added a gallery animation demo (#8547) 2017-03-03 11:38:19 -08:00
Luke baaa2e67f8 adds highlightColor and splashColor to InkResponse and InkWell (#8551) 2017-03-02 23:28:55 -08:00
Adam Barth 0403ed4659 Add viewportFraction feature to PageView (#8539)
This feature lets you see a portion of the next and previous page in a
PageView.

Fixes #8408
2017-03-02 21:09:14 -08:00
Michael Goderbauer bb1dea7440 change messaging around Windows (#8549) 2017-03-02 20:06:23 -08:00
Michael Goderbauer e4f586d239 Enable Hot Restart on Windows (#8548) 2017-03-02 20:05:47 -08:00
Adam Barth 1bb164ab0d Stabilize initial scroll simulation velocity on Android (#8543)
Previously, we would create a simulation whose initial velocity did not match
the requested parameters. We now compute the parameters for the simulation in a
way that ensures all the math works out.

Fixes #8255
2017-03-02 17:40:36 -08:00
Michael Goderbauer ae1a719e03 fix FLUTTER_ANSI_TERMINAL check (#8544)
* fix FLUTTER_ANSI_TERMINAL check

should have been included in the previous PR :(

* review comments
2017-03-02 16:25:33 -08:00
Chris Bracken c54cc96905 Default contacts demo to pinned AppBar (#8445) 2017-03-02 14:40:13 -08:00
Chris Bracken 62cc326a67 Constrain app bar header paint origin on iOS overscroll (#8517)
Prevent the app bar header from being overscrolled on iOS by setting
paintOrigin to the overlap.
2017-03-02 14:25:04 -08:00
Michael Goderbauer 1f7b8ae11f Enable ANSI codes in PowerShell (#8537) 2017-03-02 13:09:36 -08:00
xster e55c7239ec Fix test (#8536) 2017-03-02 12:46:43 -08:00
Chris Bracken 8916b101f3 Avoid potential ConcurrentModificationError (#8534)
Also make locals final where possible.

Followup to 5271546794.
2017-03-02 11:28:30 -08:00
Adam Barth 0421b4f37b Improve docs for Center (#8522)
Fixes #8478
2017-03-02 11:25:55 -08:00
Michael Goderbauer d579d58702 Enable Hot Reload on Windows (backed by gen_snapshot) (#8512)
* Enable Hot Reload on Windows (backed by gen_snapshot)

\o/

Two caveats:
* Hot Reload on Windows is slower than on other platforms because gen_snapshot is slower then sky_snapshot
* We currently cannot hot reload projects with spaces in the path

* enable tests
2017-03-02 10:57:27 -08:00
Michael Thomsen 55e10a6630 Add exception handling (#8528) 2017-03-02 16:15:52 +01:00
Jakob Andersen c9644a49f2 Read package ID and activity name from .apk for Gradle-based builds. (#8452)
The gradle build scripts can be configured to output different
application IDs for different build types, so we need to examine the
built .apk to figure out the name of the package and activity.

Re-landing this change, updated to only get information from the .apk
if it exists.

Since the tools create an AndroidApk instance early, even before we've
actually built an .apk, we have to create a new instance after building,
so we can start the right app/activity.

Fixes #8327.
2017-03-02 09:21:40 +01:00
Mikkel Nygaard Ravn ddaba8992f PlatformMessageChannel: code cleanup, bugfixes, and unit tests (#8509) 2017-03-02 07:24:18 +01:00
Alexandre Ardhuin 69b6bb87d1 prefer_is_empty and prefer_is_not_empty (#8474) 2017-03-01 22:17:30 -08:00
Ian Hickson 2f002885cc Allow two shrine order pages to be on the screen at the same time. (#8507)
This happens when, for instance, you go back then forward quickly.
2017-03-01 22:07:37 -08:00
Chris Bracken 5271546794 Better defaulting for scroll view primary-ness (#8506)
* Improved defaults for scroll view primary-ness

* Vertical scroll views default to primary:true.
* Horizontal scroll views default to primary:false.
* If a scroll view is primary and it got a non-null inherited primary
  scroll controller, it introduces a primary scroll controller inherited
  with a value of null for its descendants.

ScrollController now multiplexes writes to all registered positions;
reads of position continue to assert that only one position is
registered. Reads still require a single position.
2017-03-01 16:13:09 -08:00
xster a76c352d57 Add Cupertino to gallery and add CupertinoButton and many yak friends (#8411)
* Add cupertino to gallery and add CupertinoButto

* Use single quotes

* Add disabled state

* Some review notes

* Make button animation more responsive and tweak timing

* Renamed things Cupertino

* Button with background, move cupertino demos, move material demos

* Move 2 level list too

* Refactor various demo route names

* Some review notes

* More reviews and add test

* Linter as

* Move private constant up
2017-03-01 16:06:48 -08:00
Todd Volkert 9dec5f9016 Change to use mockito_no_mirrors.dart (#8511)
This got missed in the last sweep due to concurrent PRs
2017-03-01 15:34:59 -08:00
Michael Goderbauer 99ca38e988 make use of Dart's new capability to print Unicode on Windows (#8505) 2017-03-01 13:15:48 -08:00
Michael Goderbauer 46f2542b3f Update DArt SDK to 1.23.0-dev.2.0 (#8504)
This one comes with sweet Unicode support for Windows!
2017-03-01 12:59:28 -08:00
Chris Bracken 9f92f7928e Add tests for ScrollController assertions (#8499)
Ensure that read and write operations fail on ScrollControllers
associated with a number of positions other than 1.
2017-03-01 11:18:43 -08:00
Adam Barth 0b7845a5ac Recommend using AlwaysScrollableScrollPhysics with RefreshIndicator (#8498)
Using these physics avoids a problem whereby the scroll view isn't scrollable
due to lack of content and therefore cannot trigger the refresh indicator.

Fixes #8432
2017-03-01 11:04:42 -08:00
Adam Barth fcf6740851 Factor BackButton out of AppBar (#8491)
This widget is useful on its own. This patch factors it out of AppBar so
folks can use it separately.

Fixes #8489
2017-03-01 10:45:44 -08:00
Michael Goderbauer 17057bb44b [devFS] Use URI to represent paths on device (#8446)
* [devFS] Use URI to represent paths on device

Previosuly, regular file paths in the format of the host platform were used to represent paths on device. That works when host and device share the same (POSIX) file path format. With a Windows host, this breaks. URIs are the solution as they are platform independent and the VM service on the device already interpreted the file paths as URIs anyways.

* review comments

* switch to file paths

* fix tests on Windows

* review comments
2017-03-01 10:11:56 -08:00
Yegor 5ce67b084a driver: remove obsolete TODO (#8494)
This TODO was fixed by the transition to `Finder` objects.
2017-03-01 10:10:39 -08:00
Chris Bracken 297a0341a6 Update scroll tests to use pumpUntilNoTransientCallbacks (#8495)
This ensures that both timer/microtask queues are cleared out rather
than assuming that all work is completed in a specified amount of time.
2017-03-01 10:09:29 -08:00
Michael Thomsen 34c63aff84 Update platform-services to new APIs (#8488) 2017-03-01 17:36:07 +01:00
Michael Thomsen 1b52d46b0e Add missing IntelliJ metadata files to platform_services (#8487) 2017-03-01 15:43:47 +01:00
Mikkel Nygaard Ravn 390993d070 PlatformXxxChannel concepts added to support Flutter/platform interop (#8394)
New concepts: PlatformMessageChannel (basic message send/receive superseding some existing  PlatformMessages methods), PlatformMethodChannel (method invocation and event streams), pluggable codecs for messages and method calls: unencoded binary, string, json, and 'standard' flutter binary encoding.
2017-03-01 14:35:41 +01:00
Jakob Andersen 41d81132f9 Don't print stacktraces from ToolExit errors during flutter run. (#8453)
Instead, actually exit the tool.

Fixes #8363.
2017-03-01 13:15:31 +01:00
Michael Goderbauer 2a9fc2e70e Remove self-package import (#8483)
This is apperently breaking some customers.

If this gets submitted, we should investigate why self-package imports
don't work for certain customers.
2017-02-28 19:45:29 -08:00
Michael Goderbauer d7d73a302f fix analyzer warning (#8484) 2017-02-28 19:45:22 -08:00
Adam Barth a9e9e3fde6 CustomSingleChildLayout should support listenable (#8470) 2017-02-28 19:09:58 -08:00
Michael Goderbauer 65835af4e6 Roll forward #8467 (#8477)
* Revert "Revert "Simplify path handling logic in dependency checker and devFS (#8414)" (#8467)"

This reverts commit 96ba7f76d2.

* Intentionally use a self-package URI in flutter_gallery

* tests to catch problems with self-package imports
2017-02-28 17:21:17 -08:00