Commit graph

11330 commits

Author SHA1 Message Date
Sigurd Meldgaard 6a8f904104
Revert "Use FlutterProject to locate files (#18913)" (#19409)
This reverts commit 57d78cc739.
2018-07-16 16:21:20 +02:00
Sigurd Meldgaard f93a65a7f7
Extra debug information in run_release_test (#19405) 2018-07-16 15:46:19 +02:00
Sigurd Meldgaard f6b234a0ea
Fix typo (#19402) 2018-07-16 14:23:25 +02:00
Sigurd Meldgaard 57d78cc739
Use FlutterProject to locate files (#18913) 2018-07-16 09:39:37 +02:00
amirh e7832a3897
Revert "roll engine to 9af920ef22f311588b649ba876127993f5c1362c (#19365)" (#19376)
This reverts commit 44995dc42b.
2018-07-14 09:32:41 -07:00
amirh 44995dc42b
roll engine to 9af920ef22f311588b649ba876127993f5c1362c (#19365) 2018-07-14 08:14:46 -07:00
Jonah Williams e4e8ab47a3
increase cache size if image is loaded that is larger than max size (#19352) 2018-07-13 21:51:00 -07:00
Greg Spencer 5d0d1b038f
Add Bash and Zsh command-line completion for flutter (#19243)
This uses @kevmoo's completion package to do command line completion for flutter, and a new command "bash-completion" (with alias "zsh-completion") that will output the necessary shell script setup code, and adds the hidden command "completion" that does the actual completion.

Because it adds a dependency, I also had to do flutter update-packages --force-upgrade.

Fixes #18988.
2018-07-13 21:24:36 -07:00
Jonah Williams 1b35cc2cc2
Support keyboardAppearance field for iOS (#19244) 2018-07-13 20:41:55 -07:00
Jonah Williams 2f0b4158ab
Add option to silence driver extension errors (#19247) 2018-07-13 19:13:10 -07:00
xster e32e44799a
Add HeroController to CupertinoApp (#19326) 2018-07-13 16:46:01 -07:00
Jonah Williams 8359d99e48
have text finder convert Text.rich to plain text for comparison (#19270) 2018-07-13 13:00:58 -07:00
Hans Muller 698bda6ada
Correct contentPadding type in InputDecoration.debugFillProperties (#19318) 2018-07-13 10:37:55 -07:00
Gary Miguel 35f374036c Revert "Revert "Use runTests in fuchsia tester. (#19178)" (#19321)" (#19327)
This reverts commit e22f99743b.

Adding the exit(exitCode) fixes the hang.
Tested by running `fx run-host-tests` with a topaz checkout.
Verified the hang before, no hang after.
2018-07-13 10:37:44 -07:00
Jonah Williams 579d2fba99
Roll engine to c5a63d (#19288) 2018-07-13 10:35:23 -07:00
Alexander Aprelev 7ebf2728dc
Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295)" (#19322)
This reverts commit cc122f1672.
2018-07-12 14:59:22 -07:00
Zachary Anderson e22f99743b
Revert "Use runTests in fuchsia tester. (#19178)" (#19321)
This reverts commit 032f8cdb8b.

The test runner hangs on exit after all tests pass when trying
to roll this into Fuchsia.
2018-07-12 14:18:29 -07:00
Alexander Aprelev b075229d85
Preserve original kernel file for isolate spawn requests. (#18127)
* Preserve original kernel file for isolate spawn requests.

This change gives incremental kernel files ".incremental.dill" extension thereby preserving original kernel file.

Bug: https://github.com/flutter/flutter/issues/16084
Bug: https://github.com/flutter/flutter/issues/17012
Bug: https://github.com/flutter/flutter/issues/17983

* Factor out naming logic into separate function

* Fix string vs uri
2018-07-12 13:41:15 -07:00
Danny Tuppeny 1363bd1795
Ensure timeouts in flutter_tools integration tests include all messages received (#19253)
* Allow a longer timeout for app launches

* Include timings in errors when waiting for events

* Extract a helper that adds a timeout and includes message logging

* Ensure all timeouts include messages

* Ensure logs are set up before we invoke actions

* Ensure all messages are logged during timeout periods

This adds a new stream _allMessages that collects all output (as routed through debugPrint) and updates _timeoutWithMessages to use that instead of stdin/out of only the flutter run process (since that was missing stdin - the sends, and both input/output to the VM service).
2018-07-12 18:17:33 +01:00
Danny Tuppeny 2e215fdfe4
Align expressions better (#19256) 2018-07-12 16:24:39 +01:00
Hans Muller fbf9044867
Update translation descriptions: alertDialogLabel, searchFieldLabel (#19234) 2018-07-12 08:21:59 -07:00
Alexander Aprelev cc122f1672
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295)
This reverts commit 700cb767c9 as it
breaks Windows tests.
2018-07-11 19:52:28 -07:00
Alexander Aprelev 700cb767c9
Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)
* Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276)"

This reverts commit cf932490b7 as it also
includes fix for type error that broke tests.

* Add type cast for dart2 type checks.

* Move up to latest goldens

* Make inDirectory() type-parameterized.

* Add typecasting to transitions_perf_test.dart and microbenchmarks.

* Add boolean flag initialization in save_catalog_screenshots.dart

* Add type conversion to gallery transition test
2018-07-11 19:26:33 -07:00
Chris Bracken 379a2d5654
Push /usr/bin to front of PATH for ios-deploy runs (#19281)
ios-deploy relies on LLDB.framework, which relies on /usr/bin/python and
the 'six' module that's installed on the system. However, it appears to
use the first version of Python on PATH, rather than explicitly
specifying the system install.  If a user has a custom install of Python
(e.g., via Homebrew or MacPorts) ahead of the system Python on their
PATH, LLDB.framework will pick up that version instead. If the user
hasn't installed the 'six' module, ios-deploy will fail with a
relatively cryptic error message.

This patch pushes /usr/bin to the front of PATH for the duration of the
ios-deploy run to avoid this scenario.

This patch also removes checks for package six.

Neither Flutter nor any of its direct dependencies/tooling relies on
package six. ios-deploy depends on LLDB.framework (included with Xcode),
which relies on a Python script that imports this package but uses
whichever Python is at the front of the path. Flutter now invokes
ios-deploy with a PATH with /usr/bin forced to the front in order to
avoid this problem.

We could have retained the check out of paranoia, but this seems
unnecessary since it's entirely possible LLDB.framework may one day drop
this dependency, in which case I'd expect the base system install of
Python would likely drop it as well.
2018-07-11 17:33:06 -07:00
xster 2c00e5f218
Add a doc describing where CupertinoSliverRefreshControl should be in a list of slivers (#19282) 2018-07-11 17:05:24 -07:00
jslavitz 94959a340c Fixed code sign error message width (#19026)
* Fixed codesign error message width

* Fixed mac_test

* Removed snackbar code
2018-07-11 16:51:25 -07:00
Ian Hickson 418b15354d
Update style for CupertinoRefreshControl. (#19025)
All slivers must start with Sliver (or CupertinoSliver).
All widgets must have a key argument.

Also, some minor tweaks here and there to style and docs.
2018-07-11 15:40:19 -07:00
Alexander Aprelev cf932490b7
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276)
This reverts commit f4a038da63 as it breaks microbenchmark tests.
2018-07-11 12:48:55 -07:00
Alexander Aprelev f4a038da63
Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)
* Roll engine to rolled dart
Add connectionTimeout property to class that extends HttpOverrides.
Upgrade packages.
Add more type fixes.
Update goldens hash.
Add more type fixes.
Upgrade packages.
Fix tests.
Remove strong-mode from analysis options yaml file.
Increase dev/devicelab timeout from 2 to 10 seconds.
Added getVM to waitForViews. Fix type errors in compileExpression.

* Pick up engine revision with fix for microbenchmarks regression.
Increase default timeout from 20/30 to 60s.
2018-07-11 12:13:28 -07:00
Michael Goderbauer 36e16e7544
Do not assert when semantics are on and app draws on 0x0 surface (#19059)
Instead, if the surface is 0x0 semantics will just generate one root semantics node with size of 0x0. The node will have no children because all children are invisible and (except for the root node with this change) invisible children are dropped.
2018-07-11 09:46:24 -07:00
shrike69 2c070363c2
Use binary name to locate .packages file on Fuchsia (#19217) 2018-07-11 08:49:57 -07:00
Danny Tuppeny 437731409e
Remove note about port being removed (#19263)
Some things require a port (eg. `flutter attach`) and will forward it on to the device, so we shouldn't force clients to parse it out of a uri.
2018-07-11 15:22:51 +01:00
Greg Spencer 2d76b465ef
Make HotRunner call pub get automatically if the pubspec is out of date. (#19183)
This adds a call to 'pub get' if the pubspec.yaml is out of date wrt the .packages file when a hot reload is requested.

Fixes #15879
2018-07-10 18:14:52 -07:00
Alexander Aprelev acf3f3d839
Fix 'are there any views available' check (#19231) 2018-07-10 17:58:36 -07:00
Chris Bracken 02f4f32b5b
Revert "Roll engine to 4466d61a993fdbde2cb092b4da9bbef33d1962fe (#192… (#19233)
…30)"

Causes microbenchmarks to start failing. This included the following
engine PR, which appears to be the culprit:
* Remove vmservice_io.main from entry points. (flutter/engine#5625)

This reverts commit 3643790437.
2018-07-10 16:46:31 -07:00
Ian Hickson b3a6eda2d1
Remove hacks that make macOs, Linux, and Windows not fail. (#19187)
They should fail, because we don't have real support yet.

Also, make the debug override work in release builds, so that people
on those platforms have a workaround.
2018-07-10 16:33:40 -07:00
Chris Bracken 3643790437
Roll engine to 4466d61a993fdbde2cb092b4da9bbef33d1962fe (#19230)
Includes:
* Remove vmservice_io.main from entry points. (flutter/engine#5625)
* Roll src/third_party/skia 7e2327b133db..723b1f6ef941 (1 commits) (flutter/engine#5642)
* Roll src/third_party/skia 24d18ced1ad7..7e2327b133db (6 commits) (flutter/engine#5641)
* Roll src/third_party/skia a1e5630183c1..24d18ced1ad7 (7 commits) (flutter/engine#5639)
2018-07-10 16:12:56 -07:00
liyuqian 160d92e350
Increase image cache to 100MB (#19220)
This should fix #18952 and #813
2018-07-10 15:28:47 -07:00
Chris Bracken 59d6527f07
Roll engine to ce06bbac58d7c68487dd09616864c904e2f71a72 (#19213)
* ensure a11y state is communicated back to flutter (flutter/engine#5631)
* Roll src/third_party/skia b1b87d9df81e..a1e5630183c1 (10 commits) (flutter/engine#5637)
* Roll src/third_party/skia 385804514edf..b1b87d9df81e (6 commits) (flutter/engine#5636)
* Roll src/third_party/skia e97bb26893a1..385804514edf (1 commits) (flutter/engine#5635)
* Roll src/third_party/skia e2e52e46ca63..e97bb26893a1 (1 commits) (flutter/engine#5634)
* Roll src/third_party/skia 14de25dfc7c4..e2e52e46ca63 (2 commits) (flutter/engine#5633)
* Roll src/third_party/skia 551dc3e91143..14de25dfc7c4 (2 commits) (flutter/engine#5630)
* libtxt: apply an offset to drawing operations instead of translating the canvas (flutter/engine#5628)
* Roll src/third_party/skia 059a9ab4bcd0..551dc3e91143 (5 commits) (flutter/engine#5629)
* Roll src/third_party/skia 45c9dab4c3ec..059a9ab4bcd0 (8 commits) (flutter/engine#5627)
* Remove some unused code from the Android host (flutter/engine#5619)
* Roll src/third_party/skia 37b7e4714558..45c9dab4c3ec (1 commits) (flutter/engine#5626)
* Roll src/third_party/skia c421ca1d6e41..37b7e4714558 (2 commits) (flutter/engine#5624)
* Roll src/third_party/skia 5b201e3b0ba8..c421ca1d6e41 (3 commits) (flutter/engine#5623)
* Roll src/third_party/skia d47fe095cf88..5b201e3b0ba8 (6 commits) (flutter/engine#5622)
* Roll src/third_party/skia 9c0ce41cf711..d47fe095cf88 (12 commits) (flutter/engine#5618
* Roll src/third_party/skia d4b2adeaa929..9c0ce41cf711 (7 commits) (flutter/engine#5617)
* Roll src/third_party/skia f46710802ad5..d4b2adeaa929 (1 commits) (flutter/engine#5616)
2018-07-10 15:16:53 -07:00
Chris Bracken 32af169946
Revert "Add segmented control to gallery (#19192)" (#19227)
This appears to trigger an error during AOT snapshot of the gallery as
follows:

```
stdout: [   +6 ms] Building AOT snapshot in release mode (ios-release)...
stdout: [  +15 ms] Extra gen_snapshot options: [--print_snapshot_sizes]
stdout: [   +7 ms] /usr/bin/arch -x86_64 /Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/gen_snapshot --await_is_keyword --causal_async_stacks --packages=.packages --url_mapping=dart:ui,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/lib/ui/ui.dart --url_mapping=dart:vmservice_io,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/sdk_ext/vmservice_io.dart --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_vm_entry_points.txt --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_io_entries.txt --print_snapshot_sizes --snapshot_kind=app-aot-assembly --assembly=build/aot/arm64/snapshot_assembly.S /Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/main.dart
stderr: [+9324 ms] Error: 'file:///Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/demo/cupertino/cupertino_segmented_control_demo.dart': error: line 19 pos 1: circular dependency for function _CupertinoSegmentedControlDemoState
stderr: [        ] class _CupertinoSegmentedControlDemoState extends State {
stderr: [        ] ^
stderr: [  +33 ms] Dart snapshot generator failed with exit code 254
stderr: [        ] Snapshotting (IOSArch.arm64) exited with non-zero exit code: 254
stdout: [        ] Built to build/aot/.
stdout: [  +10 ms] "flutter aot" took 9,485ms.
```

This reverts commit 9d49ee3bf0.
2018-07-10 14:38:52 -07:00
Natalie Sampsell 9d49ee3bf0
Add segmented control to gallery (#19192)
* Adding segmented control to gallery
2018-07-10 11:17:47 -07:00
Leaf Petersen 3397338cdd
Fix use of Future<void> as a Future<bool> (#18843)
* Fix use of Future<void> as a Future<bool>
2018-07-10 11:10:48 -07:00
Danny Tuppeny 127d1f85dd
Improve error message in microbenchmarks when flutter run lives too long (#19200)
This should make it more obvious from the error what's gone wrong if we see a repeat of #19096 (previously the error was something like "Bad state: future already completed").
2018-07-10 17:09:39 +01:00
Danny Tuppeny b931640c1d
Improve flutter tools integration tests (#18865)
* Rename util -> test_utils

* Rename flutter_test_driver -> test_driver

* Switch testWithContext -> test

* Remove unused import

* Move test project into a class to make it easier to have multiple of these

Each "TestProject" class can contain its files and things like named breakpoint locations.

* Split expression evaluation tests into own file

* Include last response in error messages

* Update expectations based on current bugs

* Fix async-ness in tests

* Fix incorrect expectation in test

* Fix incorrect evaluations

* Remove skips for tests that are now passing on master

* Expect pass on Linux

🤷‍♂️

* Call the code

* Skip expression evaluation tests on Windows

* Skip whole group, not just one test

* Remove duplicated method from merge

* Fix misplaced close of group

* Remove code that was duplicated from test we copied

Not sure how this ended up in here?

* Re-fix typo
2018-07-10 06:51:12 +01:00
Natalie Sampsell 236acb5219
Segmented control animation (#18811)
Added animation to segmented control widget.
2018-07-09 18:55:23 -07:00
Ian Hickson 03a1f4acb3
Remove bogus SDK constraint lines. (#19013) 2018-07-09 17:27:33 -07:00
Jonah Williams 35291ae3b9
Add ignoringFeedbackSemantics to Draggable/LongPressDraggable (#18643) 2018-07-09 17:02:21 -07:00
Hans Muller d65acfc867
Updated the material localizations (#19174) 2018-07-09 16:47:45 -07:00
Hans Muller 8b5cbca765
Rebuilding BottomNavigationBar when items.length changes (#19179) 2018-07-09 16:47:12 -07:00
Gary Miguel 032f8cdb8b Use runTests in fuchsia tester. (#19178)
This allows us to collect code coverage for Fuchsia tests.
2018-07-09 16:13:10 -07:00