Commit graph

19801 commits

Author SHA1 Message Date
Gary Qian 69a542dade
Apply multidex config in kotlin dsl gradle file (#114660)
* Apply multidex login in kotlin dsl gradle file

* Cleanup

* Remove plugin parameter passing

* Cleanup

* Restore dependencies block

* Analyzer

* Compiles

* Cleanup

* Cleanup
2022-11-09 01:52:08 +00:00
Jesús S Guerrero 530324d232
Build command dependency injection (#114383)
* update flutter build command

* update tests

* fix analyze suggestions
2022-11-08 23:38:10 +00:00
Alex Wallen 7020f59ace
[tool] Support --flavor option for flutter install. (#114048)
* Alphabetize setup calls

* Add --flavor as an option for install

* Add verbose logging in install command

* Test that flavors build succeeds with proper flavor and fails with bogus one.

* Remove unused import

* The import was used...

* SQUASH

* Add flavor install test

* Rename test

* Add flavors install integration tests

* correct error message

* remove unused imports

* Delete copy test

* update test target

* Refactor mechanism to read buildInfo

* Remove unused import

* Set affected test targets to bringup: true

Co-authored-by: a-wallen <stephenwallen@google.com>
2022-11-08 22:53:23 +00:00
Naud Ghebre 1725a26e29
Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114834) 2022-11-08 17:54:18 +00:00
Zachary Anderson a84e369bd2
Revert "Allow Flutter golden file tests to be flaky (#114450)" (#114902)
This reverts commit 53e6876226.
2022-11-08 09:26:55 -08:00
Kate Lovett a1432a9c5d
Refactor fix_data.yaml (#114192)
* Refactor fix_data.yaml

* ++

* lib, not lib/src

* Nit

* Nit

* Update packages/flutter/test_fixes/material/app_bar_theme.dart

Co-authored-by: Alexander Dahlberg <dustbin4ever@gmail.com>

* Fix copy paste errors

Co-authored-by: Alexander Dahlberg <dustbin4ever@gmail.com>
2022-11-08 01:17:03 +00:00
Kate Lovett 53e6876226
Allow Flutter golden file tests to be flaky (#114450)
* allow marking a golden check as flaky

* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib

* Pause

* ++

* ++

* Analyzer therapy

* Once more with feeling

* Nits

* Review feedback

* Silly oops

* Test progress

* More tests

* Finish

* Nits

* Analyzer

* Review feedback

Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
Greg Spencer 1ca2e0b5b2
Fix CastError in StadiumBorder.lerpTo and StadiumBorder.lerpFrom when using BorderRadiusDirectional (#114826)
* Fix casting in StadiumBorder lerp

* Add tests

* Fix made-up names
2022-11-07 23:29:52 +00:00
Jonah Williams e4e902dced
[flutter_tools] add compilation failure tests for new cases added in impellerc (#114757) 2022-11-07 20:59:13 +00:00
Bruno Leroux f1cdfa289d
Use AppBar.systemOverlayStyle to style system navigation bar (#104827)
* Use upper AnnotatedRegion properties when no bottom one found (and vice versa)

* Update comments

Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2022-11-07 20:42:56 +00:00
Bruno Leroux 5628ebf662
[RawKeyboard] Allow inconsistent modifiers for Web (#114499)
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2022-11-07 20:41:09 +00:00
Pedro Massango e1adc96d5e
feat: provide a way to set the initial child's alignment (#114745)
InteractiveViewer.alignment parameter
2022-11-07 12:08:22 -08:00
Justin McCandless 3cde69e8d9
Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)
Relands the "Scribble mixin" PR, which was reverted due to breaking a Google test in the last roll.
Breaks the Scribble feature out of TextInputClient in order to avoid breaking changes.
2022-11-07 11:28:27 -08:00
Victoria Ashworth 378387b139
when getting xcworkspace, exclude hidden files (#114099)
* exclude xcworkspace that begins with a period

* fix if spacing, add comment

* add unit test for when no xcworkspace found

* update to use xcodeWorkspace, make it nullable and refactor

* check if hostAppRoot exists before trying to get xcworkspace

* use local variables to take advantage of type promotion

* only check if not null, don't need to check if exists

* readd exist check for migrate

* readd missing line at end of file
2022-11-07 18:48:52 +00:00
Justin McCandless 7e36cf17e7
Mac Page Up / Page Down in text fields (#105497)
Adds support for Mac/iOS's behavior of scrolling (but not moving the cursor) when using page up/down in a text field.
2022-11-07 10:43:09 -08:00
陈昱 497a52809d
Fix TextField/CupertinoTextField hint style overflow not work. (#114335)
* fix text field hint style overflow not work, keep default ellipsis.

* fix cupertino text field hint style overflow not work, keep default ellipsis.

* add Cupertino placeholder style test.
2022-11-07 17:45:56 +00:00
Jason Simmons 496cf627e6
Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (#114733)
This restores the updateSemantics capability in TestWindow that had been
removed in https://github.com/flutter/flutter/pull/113382
2022-11-07 17:27:50 +00:00
Hans Muller d6a8e92cd6
Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (#114819)
This reverts commit a6da1042a8.
2022-11-07 08:50:56 -08:00
Chris Bracken 3c9288c6d3
Increase minimum supported macOS version from 10.13 to 10.14 (#114713)
Increases the minimum macOS deployment target from macOS 10.13 (High Sierra) to 10.14 (Mojave) in the macOS app templates.

Includes:
* Update migration for macOS 10.11 apps to upgrade to 10.14
* Adds migration for macOS 10.13 apps to upgrade to 10.14
* Apply migration to all examples, and integration tests

This does not increase version in the plugin templates since those will need to wait until the 10.14 framework rolls to stable channel, so new plugins can build with apps created with `flutter create` on stable channel.

Issue: https://github.com/flutter/flutter/issues/114445
See RFC: http://flutter.dev/go/flutter-drop-macOS-10.13-2022-q4
See previous patch: https://github.com/flutter/flutter/pull/107689
2022-11-07 11:32:42 +01:00
Hans Muller a6da1042a8
Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) 2022-11-06 17:21:08 -08:00
Chris Bracken 5bc50c136b
Fix macOS migration nothing-to-upgrade test (#114703)
When testing whether a macOS deployment target version migration is
unnecessary due to already being at the target version, we were
previously checking the iOS deployment target version rather than the
macOS version. This updates it to test MACOSX_DEPLOYMENT_TARGET instead.
2022-11-05 17:02:46 -07:00
Tae Hyung Kim cef4c2aac8
ICU Message Syntax Parser (#112390)
* init

* code generation

* improve syntax error, add tests

* add tests and fix bugs

* code generation fix

* fix all tests :)

* fix bug

* init

* fix all code gen issues

* FIXED ALL TESTS :D

* add license

* remove trailing spaces

* remove print

* tests fix

* specify type annotation

* fix test

* lint

* fix todos

* fix subclass issues

* final fix; flutter gallery runs

* escaping for later pr

* fix comment

* address PR comments

* more

* more descriptive errors

* last fixes
2022-11-05 10:26:46 -07:00
xubaolin 1aada6fc5c
[New Feature]Support mouse wheel event on the scrollbar widget (#109659)
* rebase master and add a test

* fix the test

* fix the test

* fix the test
2022-11-05 00:57:52 +00:00
Chris Bracken 01507bab56
Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (#114715)
Causes analysis errors:

```
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:513:5 • always_specify_types
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:514:10 • always_specify_types
   info • Avoid method calls or property accesses on a "dynamic" target • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:515:11 • avoid_dynamic_calls
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:515:48 • always_specify_types
   info • Separate the control structure expression from its statement • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:515:77 • always_put_control_body_on_new_line
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:516:7 • always_specify_types
   info • Avoid method calls or property accesses on a "dynamic" target • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:518:11 • avoid_dynamic_calls
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:518:51 • always_specify_types
   info • Separate the control structure expression from its statement • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:518:77 • always_put_control_body_on_new_line
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:519:7 • always_specify_types
   info • Avoid method calls or property accesses on a "dynamic" target • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:521:11 • avoid_dynamic_calls
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:522:21 • always_specify_types
   info • Separate the control structure expression from its statement • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:522:58 • always_put_control_body_on_new_line
  error • The argument type 'dynamic' can't be assigned to the parameter type 'String' • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:524:38 • argument_type_not_assignable
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:540:5 • always_specify_types
   info • Avoid escaping inner quotes by converting surrounding quotes • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:541:14 • avoid_escaping_inner_quotes
   info • Specify type annotations • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:542:5 • always_specify_types
  error • The argument type 'dynamic' can't be assigned to the parameter type 'List<dynamic>' • packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart:544:45 • argument_type_not_assignable
   info • Remove unnecessary backslashes in strings • packages/fuchsia_remote_debug_protocol/test/fuchsia_remote_connection_test.dart:114:55 • unnecessary_string_escapes
   info • Remove unnecessary backslashes in strings • packages/fuchsia_remote_debug_protocol/test/fuchsia_remote_connection_test.dart:204:55 • unnecessary_string_escapes
   info • Remove unnecessary backslashes in strings • packages/fuchsia_remote_debug_protocol/test/fuchsia_remote_connection_test.dart:289:55 • unnecessary_string_escapes
```

This reverts commit b187bc474e.
2022-11-04 14:00:16 -07:00
Naud Ghebre b187bc474e
Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)
* [fuchsia_remote_debug_protocol] Switch the way we retrieve the vm_service_port from /hub to iquery, on device.

* [fuchsia_remote_debug_protocol] Switch the way we retrieve the vm_service_port from /hub to iquery, on device.
2022-11-04 16:39:53 -04:00
chunhtai 80bf355192
Support keyboard selection in SelectabledRegion (#112584)
* Support keyboard selection in selectable region

* fix some comments

* addressing comments
2022-11-04 10:55:28 -07:00
Jenn Magder c1d2b854ef
Change some required nullable parameters in tool to non-null (#114115) 2022-11-04 17:36:01 +00:00
Callum Moffat 48457d736b
WidgetController.startGesture trackpad support (#114631) 2022-11-04 17:13:53 +00:00
Casey Hillers 9f6090c9ad
Revert "Fix text field label animation duration and curve" (#114646)
* Revert "Fix text field label animation duration and curve (#105966)"

This reverts commit d5c53b82e9.

* Add doubleTapTimer.cancel back
2022-11-03 18:47:54 -07:00
Casey Hillers 009fa69f3c
Revert "Scribble mixin (#104128)" (#114647)
This reverts commit b571abfbfd.
2022-11-03 17:17:30 -07:00
hellohuanlin 8a9ddade9a
[tools]validation basic Xcode settings for build ipa (#113412) (#114634) 2022-11-03 22:29:07 +00:00
Phil Quitslund 33b81ed954
fixes for incoming linter (#113794)
* fixes for incomming linter

* + todo

* todo format fix

* justify ignore

* --
2022-11-03 10:56:59 -07:00
Jason Simmons a440c4689f
Do not assume that pub is the first command run by "flutter create" (#114621)
The "flutter create" command on macOS may run other commands such as
openssl when it calls _getCodeSigningIdentityDevelopmentTeam
2022-11-03 10:46:18 -07:00
Zachary Anderson 0943693e85
Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (#114615)
This reverts commit e6300da2c3.
2022-11-03 15:23:03 +00:00
hellohuanlin e6300da2c3
[tools]validation basic Xcode settings for build ipa (#113412) 2022-11-03 02:38:17 +00:00
Christopher Fujino 0211df9cfc
[flutter_tools] provide --timeout option to flutter drive (#114458) 2022-11-02 18:43:42 +00:00
Danny Tuppeny 3b0f8335ee
[flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (#114533) 2022-11-02 18:38:46 +00:00
Danny Tuppeny 307987339e
[flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (#114369) 2022-11-02 17:07:58 +00:00
Kate Lovett 0e70a97e2e
Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (#113793) 2022-11-02 16:54:11 +00:00
Jonah Williams 1cfdac4b23
Always invoke impeller ios shader target (#114451) 2022-11-02 16:43:07 +00:00
htoor3 9f23391733
[web] Changes to web keyboard selection shortcuts for more consistent behavior (#114264) 2022-11-02 15:41:05 +00:00
Darren Austin 6a66aa282f
Add Material 3 support for BottomAppBar (reland #106525) (#114439)
* Revert "Revert "Add Material 3 support for BottomAppBar" (#114421)"

This reverts commit 210a2aa371.

* Regenerated the defaults from tokens and fixed tests.

* Fixed the tests.

* Updated the shape token template to optimize the a common case.
2022-11-02 10:54:19 +00:00
Taha Tesser 97d0247d59
Add Material 3 support for Slider - Part 1 (#114079) 2022-11-01 19:31:00 -07:00
Elias Yishak 17ec3b1d15
[flutter_tools] Introducing arg option for specifying the output directory for web (#113076) 2022-11-01 22:50:02 +00:00
fzyzcjy 61deaef5df
Fix bug thattimeDilation is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (#113830) 2022-11-01 22:50:00 +00:00
fzyzcjy c23b5ca7db
Fix addToScene documentation (#113987) 2022-11-01 22:18:52 +00:00
fzyzcjy e37ab48bca
Introduce debugWithActiveLayoutCleared to avoid duplicated code (#114003) 2022-11-01 22:17:11 +00:00
fzyzcjy fb9065fe00
Layer ... was previously used as oldLayer assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (#113998) 2022-11-01 22:17:08 +00:00
Taha Tesser eadda3c393
Add Material 3 Popup Menu example and update existing example (#114228) 2022-11-01 22:10:45 +00:00
Justin McCandless 93b0042559
Handle dragging improvements (#114042)
Improves the feel of dragging text selection vertically between lines on mobile.
2022-11-01 12:36:51 -07:00