Commit graph

9132 commits

Author SHA1 Message Date
Chris Bracken 65e3df8869 Fix a minor typo in the TextField.controller docs (#12267) 2017-09-26 13:37:53 -07:00
asaarnak 97dd12cf83 Seems like a lint was renamed. (#12034)
* Seems like a lint was renamed.

Lint `- unnecessary_brace_in_string_interp` is not in the list here: http://dart-lang.github.io/linter/lints/

In linter [0.1.30](9652dd44b6/CHANGELOG.md (0130)): [http://dart-lang.github.io/linter/lints/unnecessary_brace_in_string_interp.html](unnecessary_brace_in_string_interp)
In linter [0.1.2](9652dd44b6/CHANGELOG.md (012)): [http://dart-lang.github.io/linter/lints/unnecessary_brace_in_string_interps.html](unnecessary_brace_in_string_interps)

* Fix lint tests. analyze_once_test.dart and create_test.dart
2017-09-26 11:03:45 -07:00
jiamingc 8a441ae72b Make switch widget accept 3 other colors. (#12118)
* Make switch widget accept 3 other colors: inactiveThumbColor, inactiveTrackColor, activeTrackColor.

* Make switch widget accept 3 other colors.

* Make switch widget accept 3 other colors.
2017-09-26 10:05:51 -07:00
Kyle Bradshaw 7a35db1f99 _SaltedKey solution to ExpansionPanelList (#11902)
* _SaltedKey solution to `ExpansionPanelList`

_SaltedKey implementation courtesy of @Hixie
Tested and confirmed working.
Fixes #11166

* Added a simple test

* Style correction to test
2017-09-26 10:04:17 -07:00
Todd Volkert bb0a724a1d Don't require .packages file for flutter packages command (#12258)
(it's the command that populates the .packages file)
2017-09-26 09:12:40 -07:00
Adam Barth 3433f42b09 Attempt to fix Fuchsia build (#12259) 2017-09-26 08:50:41 -07:00
Sarah Zakarias a0e91bf9e8 Update Flutter Gallery to use new asset api for package assets (#12254) 2017-09-26 15:21:01 +02:00
Sarah Zakarias 49ba974710 Factor out flutter manifest logic (#12237) 2017-09-26 14:48:52 +02:00
Todd Volkert a08b5e00af Run command validation on all commands. (#12246)
This makes command validation happen as part of `verifyThenRunCommand()`,
using a newly introduced protected method (`validateCommand()`) rather than
a `commandValidator` property (that subclasses were responsible for manually
invoking).
2017-09-25 18:56:37 -07:00
Jason Simmons 6420c75f26 Handle cancellation of the date/time picker in the Gallery full screen dialog demo (#12248) 2017-09-25 13:59:05 -07:00
Michael Goderbauer 48e644057a Roll engine to 005212683c9cdc1c580b83aec70f25b4aba9872b (#12244)
This picks up a skia roll, which fixes some black screens on Android emulator.
2017-09-25 12:16:29 -07:00
Sarah Zakarias 82ec7a2af5 update pubspec.yaml.tmpl of package and plugin (#12238) 2017-09-25 13:09:28 +02:00
Ian Hickson e04bf3285d Image RTL (#12230) 2017-09-24 16:14:55 -07:00
Todd Volkert ff45d50655 Remove explicit width in ListTile trailing element (#12221)
It was incorrectly added in #11858
2017-09-24 13:21:28 -07:00
Ian Hickson 47c387b6c7 positionDependentBox (#12232)
Fix the documentation (it was just wrong before).

Add an explicit code path to handle horizontal overflow so that we
don't have a left bias.
2017-09-24 01:40:54 -07:00
Ian Hickson 953dabc70b Fix some typos (#12233) 2017-09-24 01:40:42 -07:00
Adam Barth 260353f292 RTL support for DataTable (#12229)
Just some very minor tweaks to remove subtle LTR bias.

We use the same arrow rotation animation in RTL and LTR, but I think
that's correct. Usually, rotations are either clockwise or
anitclockwise, which are the same in RTL and LTR. We might need to check
with someone who reads an RTL language to confirm.

Fixes #11845
2017-09-24 00:33:21 -07:00
Ian Hickson 78a29260ff Some more tests for AnimatedPositionedDirectional and more debugging checks (#12231) 2017-09-24 00:29:21 -07:00
Adam Barth 824db696b8 Add AnimatedPositionedDirectional (#12228)
This widget makes it easier to animated Positioned widgets with
awareness of the ambient Directionality.

Fixes #11998
2017-09-23 23:20:46 -07:00
Ian Hickson 36e7138e4f Update some places that mentioned the old update-packages --upgrade (#12218) 2017-09-23 22:23:09 -07:00
Adam Barth ebffe15994 Clean up TableBorder#paint API (#12226)
Previously, the rows and columns arguments had different semantics. Now
they have the same semantics. The new API also uses Iterable rather than
List to give clients more flexiblity in how they construct these
arguments. For example, RenderTable no longer needs to reify the
reversed list of column positions.
2017-09-23 13:39:49 -07:00
Adam Barth 1a0bdb9619 Add RTL support to Table (#12225)
Also, fix asserts in TableBorder#paint to match documentation.

Fixes #12009
2017-09-23 12:31:55 -07:00
Ian Hickson fe27f86403 Clean up the file names in the painting/ library (#12217)
After all my recent refactorings, some of the names were not really reasonable any more.
2017-09-23 00:00:46 -07:00
Hans Muller c44aa2665d Aborted Hero push transitions should retrace their flight path (#12203) 2017-09-22 15:33:50 -07:00
Yegor f2d096010d Internationalize time numerals in the time picker and TimeOfDay (#12166)
* internationalize time numerals

* tests

* use foundation.dart instead of meta.dart

* address comments
2017-09-22 14:35:25 -07:00
Ian Hickson 441b5c2031 Pin all dependencies ONCE AND FOR ALL (#12210)
* Pin all dependencies ONCE AND FOR ALL

This replaces the secret `flutter update-packages --upgrade` with a destructive `flutter update-packages --force-upgrade` that actually goes and pins every dependency and transitive dependency in every flutter package to the same version.

* Add comments.
2017-09-22 13:35:35 -07:00
Yegor b9e1be9ace introduce localized text geometry in MaterialLocalizations (#11829)
* introduce localized text geometry in MaterialLocalizations

* remove geometry from color text themes

* fix merge conflict

* optional Localizations

* fix fallback; test; docs
2017-09-22 13:15:01 -07:00
Yegor f4f20c2909 misc .arb fixes; localizations validator (#12197)
* misc .arb fixes; localizations validator

* regenerate localizations

* address comments

* do not treat plural variations as invalid keys
2017-09-22 12:26:47 -07:00
Hans Muller d3d6198852 Make the Hero transition animation configurable (#12215) 2017-09-22 11:34:44 -07:00
Ian Hickson fde26cd14c Extract BoxShadow from box_painter.dart (#12207)
This is the last class other than BoxDecoration in this file, so by
extracting it we finally have all the parts of BoxDecoration
extracted.
2017-09-22 11:34:09 -07:00
Ian Hickson ae690bec86 Revert "Revert "LinearGradient and RadialGradient RTL" (#12209)" (#12216)
This reverts commit 4a04de5e6d.
2017-09-22 11:33:10 -07:00
Yegor 8c3d5838dd Fix inherited widget notifications in Localizations (#12213)
* Fix inherited widget notifications in Localizations

* address comments
2017-09-22 10:49:19 -07:00
Ian Hickson 4a04de5e6d Revert "LinearGradient and RadialGradient RTL" (#12209)
* Revert "Pin args to 0.13.7 to avoid version conflict (#12208)"

This reverts commit 63802b3dff.

* Revert "LinearGradient and RadialGradient RTL (#12204)"

This reverts commit daedbc84a2.
2017-09-22 09:18:13 -07:00
Alexander Aprelev 63802b3dff Pin args to 0.13.7 to avoid version conflict (#12208) 2017-09-21 18:29:16 -07:00
Ian Hickson daedbc84a2 LinearGradient and RadialGradient RTL (#12204) 2017-09-21 14:06:46 -07:00
Alexander Aprelev 4f6e350b6e Roll engine forward with attempt to fix ios perf regression (#12205) 2017-09-21 14:04:50 -07:00
Ian Hickson 998d65b0b2 Factor out ImageDecoration and paintImage (#12202)
To make it cleaner when we RTLify these.
2017-09-21 12:52:42 -07:00
Ian Hickson 5e71de0878 Minor cleanup to FlutterLogo. (#12156) 2017-09-21 11:02:57 -07:00
Ryan Macnak 03121ffa79 Roll engine to 4aee64f6be1f20a1d68b6897ae1946d2bac0dd9c. 2017-09-21 10:23:20 -07:00
Ryan Macnak b083d72b51 Roll engine to dd68239b436da462da6fcbc59b94d5b34b305986. 2017-09-21 10:23:20 -07:00
Alexandre Ardhuin 2958d7d0fc use bool in assert (#12170) 2017-09-21 09:33:01 +02:00
Alexandre Ardhuin cde6b669b3 unnecessary statements (#12189) 2017-09-21 08:33:56 +02:00
xster f9e8da6d32 Create a CupertinoTab to support parallel navigation trees in iOS (#12130)
* Refactor CupertinoScaffold

* Rename rootTabPageBuilder to tabBuilder

* fix tab transparency padding

* add a CupertinoTab

* Add default background color

* Add a bunch of examples

* A bunch of tests

* Refactor CupertinoScaffold

* Rename rootTabPageBuilder to tabBuilder

* fix tab transparency padding

* Add default background color

* review notes

* fix test

* review

* Rename CupertinoTab to CupertinoTabView

* remove final ; in sample code for analyzer
2017-09-20 21:01:03 -07:00
xster 6d47092772 Split CupertinoScaffold into CupertinoTabScaffold and CupertinoPageScaffold (#12106)
* Refactor CupertinoScaffold

* Rename rootTabPageBuilder to tabBuilder

* fix tab transparency padding

* Add default background color

* review notes

* fix test
2017-09-20 17:58:53 -07:00
xster e28765a997 Delinting future awaits round 3 (#10791)
* round 3

* partially address comments

* merge

* review notes

* review

* review

* review
2017-09-20 17:24:43 -07:00
xster 8475e0b290 Split Cupertino nav bar into a static one and a slivers one (#12102) 2017-09-20 16:26:49 -07:00
xster 987b205665 Delinting future awaits round 2 (#10790)
* round 2

* deal with null futures

* review

* review

* review

* review
2017-09-20 16:25:16 -07:00
Ian Hickson d15907b50b Uniform rectangular borders were drawing in the wrong place. (#12179)
I inflated instead of deflating. Oops.
2017-09-20 16:08:03 -07:00
Chris Bracken 1a62c28b6f Correct handling for nulling TextField controller (#12190)
Correctly handle the case where the TextEditingController associated
with a TextField is set to null. Due to a typo (= vs ==), previously
this was a no-op and the existing TextEditingController was retained,
rather than copied.
2017-09-20 15:38:14 -07:00
Zev Youra cb2204d1c4 Add IconThemeData adjustment to ListTile trailing element (#11858)
* Add IconThemeData adjustment to ListTile trailing element (makes consistent with leading element)

* Add test for ListTile theme changes

* Pull out and share IconThemeData variable between leading and trailing

* remove extra comma

* fix style nit
2017-09-20 14:45:06 -07:00