Commit graph

20971 commits

Author SHA1 Message Date
Jonah Williams 10c78c264a
[flutter_tools] fold executable resolution into flutter (#67669)
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. Fold the resolution logic into the tool and use where/which instead of the package:process specific logic.
2020-10-12 12:51:37 -07:00
Jonah Williams ac614de7ac
[flutter_tools] validate that SkSL bundle path exists (#67883)
Fixes #61772

tool exit if there is no file at the path provided when building/running with sksl
2020-10-12 12:49:51 -07:00
Jonah Williams fd11d149f7
[flutter_tools] teach flutter drive to uninstall if install fails (#67936)
Work towards #39925

Currently flutter run will uninstall and reinstall if the initial install fails and the APK was previously installed. Allow drive to share this same logic by moving it into installApp and out of startApp.

This should reduce the occurrence of the error in the devicelab.
2020-10-12 12:49:36 -07:00
Sergey Solodukhin 3e069a433b
fix issue #55400 PopupMenuButton positions menu incorrectly with nest… (#65832) 2020-10-12 11:52:04 -07:00
Darren Austin 7ce0dce2e5
Migrate even more Material framework tests to null safety. (#67849) 2020-10-12 11:30:26 -07:00
nturgut fda735cf31
add links missed in the first pr (#67780) 2020-10-12 11:23:34 -07:00
Michael Goderbauer 18795b471e
Migrate some widget tests to NNBD (#67776) 2020-10-12 11:18:52 -07:00
Jonah Williams b4e4e8d965
[flutter_tools] do not crash validator if intellij JAR file is missing (#67931)
This failure has been happening for a while but was covered by the overly broad catch. Removing that revealed that newer intellij versions have a different plugins file. The tool still can't find the file, but it won't crash now

Fixes #67918
2020-10-12 10:34:05 -07:00
Per Classon 7668f06ffe
[Material] Use primary color for selected rows and checkboxes in DataTable (#67919) 2020-10-12 10:17:03 -07:00
Justin McCandless b93f71f9c8
NNDB TextField tests (#67696)
Just another nnbd conversion PR.
2020-10-12 09:59:05 -07:00
Sam Rawlins 23c7ee9deb
Bump meta to 1.3.0-nullsafety.4 (#67744) 2020-10-12 09:50:30 -07:00
Jonah Williams 10a1a7016a
[flutter_tool] prepend module name on Windows pwr shell (#67801)
In case different powershell module is installed over the default name. Fixes #22896
2020-10-12 09:49:41 -07:00
nturgut 0bc87a5816
make the new e2e tests blocker (#67788) 2020-10-12 09:48:24 -07:00
Jonah Williams 0afddf3578
[flutter_tools] use fixed entry for dill uploads (#67837)
For historical reasons, the flutter tool uploads dill files to paths based on the entrypoint URI. This isn't actually necessary, and the tool can use specific files : main.dart.incremental.dill for incremental dills, and main.dart.dill/main.dart.swap.dill for full dills. This allows hot restarting applications with an entrypoint outside of lib/ and simplifies the devFS code.

Fixes #63243
2020-10-12 09:47:41 -07:00
xubaolin 8538b4f546
Fix TextField bug when the formatter repeatedly format (#67892) 2020-10-12 09:37:03 -07:00
chunhtai 345188d40e
make Router.of nullable (#67683) 2020-10-12 09:32:07 -07:00
Jonah Williams 08576cb671
[flutter_tools] HACKTOBERFEST (#67882)
HACKTOBERFEST
2020-10-12 09:31:02 -07:00
xubaolin 8211aaa2ae
Fix ListTile assert when layout at zero size (#66798)
* Fix ListTile assert when layout at zero size #66636
2020-10-12 17:25:38 +08:00
xubaolin d914d5d2f9
Fix typos in the [BottomNavigationBar] document (#67811) 2020-10-12 02:22:01 -07:00
Alexandre Ardhuin eefcff900c
Final definite assignment (#67682) 2020-10-10 14:42:02 -07:00
Jonah Williams 1a9d635f64
[flutter_tools] remove --with-driver-test (#67783)
Remove flutter create --with-driver-test . Fixes #64095
2020-10-09 21:03:37 -07:00
engine-flutter-autoroll da92fc92e9
Roll Engine from 5aed0ee7f6e8 to 11d756a62ed0 (2 revisions) (#67793) 2020-10-09 18:57:03 -07:00
engine-flutter-autoroll c596e685e3
Roll Engine from a1a89797b9c7 to 5aed0ee7f6e8 (4 revisions) (#67784) 2020-10-09 17:52:03 -07:00
Dan Field 8bb61c3801
Reland ensure visible fix for nested viewports (#67773)
* Revert "Revert "Improve the behavior of Scrollable.ensureVisible when Scrollable nested (#65226)" (#66918)"

This reverts commit e8812c409b.

* Fix for page views

* comment
2020-10-09 17:40:33 -07:00
Marcin Jeleński 439992472a
Export finder factory (#67779) 2020-10-09 16:50:54 -07:00
Alexander Markov 1973cf2d6c
Remove uses of bytecode mode of Dart VM (#67755) 2020-10-09 16:33:06 -07:00
keyonghan 2639ac1d2e
Enable build_gallery tests in try/prod builders (#67749) 2020-10-09 15:57:04 -07:00
James D. Lin e4206ac5dd
[flutter tools] Add a DelegatingLogger class (#67581)
[flutter tools] Add a DelegatingLogger class

Move most of `DelegateLogger` `from test/src/testbed.dart` to
`lib/src/base/logger.dart` to better formalize the common practice of
chaining `Logger`s together.  I renamed the class since it isn't
itself the delegate and to better match the `Delegating...` classes
from `package:collection`.

Additionally, add a freestanding `asLogger<T>` function to "cast" a
`Logger` into a matching delegate if possible.  This will allow
`Logger` chains to be ordered a *bit* more freely (e.g.
`NotifyingLogger` and `AppRunLogger` will no longer required to be
at the end of the chain, an unwritten rule that has led to breakage in
google3).  Chain order still matters since lack of virtual dispatch
means that parent `Logger`s can never invoke child methods, however.

I made `asLogger<T>` a freestanding function because I didn't want to
make it part of the `Logger` interface (and I thought that making it
an extension method might be weird).

Bonus cleanup:
There no longer appears to be a way to construct an `AppRunLogger`
with a null parent, so remove all of code paths for that case and
make the `parent` construction parameter required.
2020-10-09 15:55:24 -07:00
Jonah Williams bdb830a833
[flutter_tools] pretty print hot reload rejection error (#66701)
If the vm of an attached device rejects a hot reload, pretty print the reason. Suggest a hot restart so that users are aware that they do not have to detach and rebuild. Also resets the last compilation time, so a subsequent restart would still apply the last change. Adds an integration test for the const field removal.

Fixes #64027
2020-10-09 15:44:52 -07:00
Jonah Williams 5fa801718f
[flutter_tools] remove train and inject-plugins command (#67766)
The train command does nothing and was originally added to provide a no-output default for generating app-jit snapshots. The inject-plugins command is only for a repo-only analysis check, which is not necessary since we regenerate during pub get.

#29805
2020-10-09 15:43:39 -07:00
Jonah Williams 92702a28ec
Revert "Flutter driver patch: export finder factory (#67769)" (#67777)
This reverts commit be5830cdf0.
2020-10-09 15:16:24 -07:00
Greg Spencer c083f02f3a
Migrate more material tests to NNBD (#67674)
This migrates more material tests to NNBD.
2020-10-09 14:58:13 -07:00
engine-flutter-autoroll dcb5975d49
Roll Engine from 36769af31038 to a1a89797b9c7 (5 revisions) (#67767) 2020-10-09 14:52:03 -07:00
Marcin Jeleński be5830cdf0
Flutter driver patch: export finder factory (#67769) 2020-10-09 14:49:45 -07:00
Marcin Jeleński 759ddb1ccd
Reland "Flutter Driver - Create widget finders from serialized finders extensions" with null safety (#67711)
* Flutter Driver - Create widget finders from serialized finders extensions
2020-10-09 13:28:25 -07:00
Matej Knopp 24abe59f38
Provide oldLayer where possible (#67320) 2020-10-09 13:07:05 -07:00
Jonah Williams cba84d5127
[flutter_tools] remove globals from IntelliJ validator, refactor tests to remove dependency on JAR (#67240)
Move the intellij validator to its own file, and split off the tests. Remove globals from each, and remove dependency on a real jar/filesystem by creating a minimal version of the manifest xml and setting it up in the memory file system.

#47161
2020-10-09 13:05:42 -07:00
Jonah Williams e53bb74694
Revert "Revert "Delete fast start unit test (#67757)" (#67763)" (#67765)
This reverts commit b33bfcef0f.
2020-10-09 13:04:20 -07:00
Jonah Williams b33bfcef0f
Revert "Delete fast start unit test (#67757)" (#67763)
This reverts commit 3eb2335a4e.
2020-10-09 13:01:42 -07:00
Jonah Williams 3eb2335a4e
Delete fast start unit test (#67757)
Now that fast-start syncs assets by default, this isn't testing anything. Retire the test
2020-10-09 12:41:32 -07:00
Jonah Williams 9a3a0dc18f
[flutter_tools] hot reload/restart update for asset manager change (#66742)
Do not upload all assets on initial devFS sync. This should increase the reliability of the initial connection, even in the face of flaky devfs behavior, in addition to a moderate perf improvement.

Updates fast-start to build assets as part of the initial bundle

Requires flutter/engine#21436
Requires flutter/engine#21586
Requires flutter/engine#21611
2020-10-09 12:25:15 -07:00
nturgut a755c03819
Add web e2e to the flutter/flutter repo (#67693)
* adding tests that uses integration_test (e2e) package to flutter

* change the package name for the import

* fix licenses. fix README commands. add links

* adding dependency change auto generated by the tool

* more analyzer error fixes
2020-10-09 12:24:36 -07:00
Michael Goderbauer 0dc10deb79
Fix tree (#67751) 2020-10-09 11:12:57 -07:00
Michael Goderbauer 793678d50e
Migrate tests to null-safety (#67692) 2020-10-09 10:42:02 -07:00
engine-flutter-autoroll 9360bbbb53
36769af31 Roll Fuchsia Mac SDK from zhRBO0hCr... to LyP59nILn... (flutter/engine#21720) (#67709) 2020-10-09 09:27:03 -07:00
Nan Kim 28a9a6b48c
Add sample code for CupertinoActionSheet (#65274) 2020-10-09 09:08:13 -07:00
Per Classon 8d80592d46
Add tristate to parent checkbox for DataTable (#67414)
* Add tristate to parent checkbox for DataTable to follow Material specifications
2020-10-09 16:33:39 +02:00
Rami bbf1b5579f
[Material] Time picker semantics updates (#67562) 2020-10-09 10:28:20 -04:00
Per Classon ee08c2278a
Add decoration parameter to DataTable and DataTableTheme (#66640)
* Add decoration parameter to DataTable and DataTableTheme
2020-10-09 14:11:17 +02:00
engine-flutter-autoroll 0d8696f655
Roll Engine from 2eac514f26a6 to 349889833c6f (39 revisions) (#67705) 2020-10-08 22:12:02 -07:00