Commit graph

7693 commits

Author SHA1 Message Date
Sarah Zakarias 616a7bed0f Update Android part of flutter_view to use the new platform message c… (#8729)
* update Android part of flutter_view to use the new platform message channel.

* addressed comments

* addressed comments
2017-03-14 09:38:09 +01:00
Mikkel Nygaard Ravn 789c2f1f7a Fixed endianness unit test (#8753) 2017-03-14 01:01:49 +01:00
Ian Hickson 8eac6cd0da Test API improvements: pumpAndSettle, autogenerate pointer IDs (#8751) 2017-03-13 16:27:15 -07:00
Mikkel Nygaard Ravn 898b6f8549 Enable iOS use of platform channels (#8695)
Changed standard encoding to use host endianness. Engine roll.
2017-03-14 00:24:41 +01:00
Adam Barth cbb495c16d Add more dartdocs for the sliver render objects (#8749)
This patch covers multi-box adaptor and the viewports.
2017-03-13 22:57:05 +00:00
Chris Bracken cb2b89c389 Set derived dir Flutter.framework directory readonly (#8748)
Provides a strong hint to developers that editing Flutter framework
headers isn't supported.
2017-03-13 15:26:35 -07:00
Ian Hickson 0edc4d2a76 Make hot mode a little less aggressive about catching errors. (#8743)
It was resulting in weird situations where the tool would dump an
error message and stack but not quit, or would fail hard but then just
hang.

Instead, specifically catch errors you expect. As an example of this,
there's one error we expect from the DartDependencySetBuilder, so we
catch that one, turn it into a dedicated exception class, then in the
caller catch that specific exception.
2017-03-13 14:50:30 -07:00
Hans Muller 8a36588627 Fixed scrollable TabBar flashing (#8741) 2017-03-13 14:07:47 -07:00
Devon Carew 71aaa5db91 add --offline to flutter packages get (#8707) 2017-03-13 14:04:27 -07:00
Adam Barth f5a6c432fc Add docs for RenderSliverGrid (#8737)
Most of these docs were already in place, but this patch adds the remaining
missing ones.
2017-03-13 20:11:34 +00:00
Dan Rubel b10e60bc15 do not forward errors if stream is closed (#8739) 2017-03-13 15:07:13 -04:00
John McCutchan 31dc3c4722 Try all possible Android SDK locations before giving up (#8730)
Fixes #8618
2017-03-13 11:21:34 -07:00
Jason Simmons 3d5d63a8aa Accept any nonzero exit code as a signal of failure in the missing dependency test (#8738) 2017-03-13 11:17:09 -07:00
Adam Barth fecc4e6584 Docs for RenderSliverFixedExtentList (#8733)
Also, some renames for more accuracy.
2017-03-13 18:12:33 +00:00
Dan Rubel 8742fb09fa Fix tests (#8736)
* do not forward status if stream is closed
* remove devfs test timeout
2017-03-13 13:47:29 -04:00
Chris Bracken 74e2243ca4 Add details of how to test run a build bot change (#8734)
Add the minimum set of required properties for run_recipe.py and where
to look them up.
2017-03-13 10:14:02 -07:00
Adam Barth f075cf4450 Make some symbols private (#8731)
These symbols were not intended to be public. Also, remove some bogus dartdocs
for PhysicalModeLayer.
2017-03-13 17:04:14 +00:00
Todd Volkert a4c58292b2 Fix and enable broken flutter_tools tests (#8720)
(follow-on to #8698)
2017-03-10 15:34:20 -08:00
Michael Goderbauer 7ede6b530e Use 7-Zip to unzip SDK, if available. (#8721)
Windows' built-in unzippers are painfully slow. It drives me mad!

Unzip SDK with 7-Zip: ~10s
Unzip SDK with Windows: ~90s
2017-03-10 15:21:08 -08:00
Todd Volkert 5d29737a04 Bump mockito to version 2.0.2 (#8713) 2017-03-10 13:53:22 -08:00
Seth Ladd 01ac75f5e4 Callback wasn't clear what the type of the function was (#8712)
Changing to an inline function, making the type more clear.
2017-03-10 13:49:47 -08:00
Alexandre Ardhuin 16d800b204 normalize setter format (#8708) 2017-03-10 21:52:30 +01:00
Yegor 9f020d6104 upgrade package:http so we no longer need custom MultipartRequest (#8715) 2017-03-10 11:05:06 -08:00
Michael Goderbauer 03d3186531 Transfer URIs instead of platform-dependent file paths (#8701) 2017-03-10 10:13:53 -08:00
Todd Volkert 34ed3d2d24 Pay off some technical debt. (#8710)
* Rename `Device.platform` to `Device.targetPlatform` to avoid
  collision with the exported variable from `platform.dart`
2017-03-10 10:11:05 -08:00
Todd Volkert 83d411f979 Change flutter_tools tests to run via pub (#8698)
`all.dart` is no longer needed. Furthermore, it causes tests to
be skipped, or to silently fail to run anything.

Fixes #7941
2017-03-10 09:39:01 -08:00
Chris Bracken 1a2e6f3389 Support Xcode builds in project dirs with spaces (#8709)
Use line-based iteration in place of word-based iteration over the
framework directories, to avoid breaking on spaces.
2017-03-10 09:32:58 -08:00
Jakob Andersen 60c0c3d323 Revert "Eliminate CocoaPods install step (#8694)" (#8705)
* Revert "Eliminate CocoaPods install step (#8694)"

This reverts commit f4a13bc72b.

If the developer is relying on CocoaPods and hasn't done a pod install, we will do it for them. This is needed for a smooth native plugin experience, similar to what Gradle is doing on the Android side.

There's no hard dependency on CocoaPods. We only run pod install if the project uses CocoaPods, so developers are still free to use alternatives if they prefer (and if they don't want to use native plugins).

Fixes #8685
Fixes #8657
Fixes #8526

* Require CocoaPods 1.0.0 or newer.

And make sure we don't get a crash if running `pod install` fails.

* Address review feedback
2017-03-10 13:43:57 +01:00
Alexandre Ardhuin c22812e0ea Flutter style guide: Prefer naming the argument to a setter 'value' (#8691) 2017-03-10 09:00:29 +01:00
Chris Bracken 7b9cefb3be Add brew update step before install/upgrade (#8703)
This avoids unintentionally installing an older version if the
developer's homebrew installation is out-of-date.
2017-03-09 20:45:40 -08:00
Chris Bracken 1bb0d7728e Eliminate brew tap flutter/flutter instruction (#8702)
The flutter tap was deleted as part of the resolution to #7783.
2017-03-09 18:26:38 -08:00
Chris Bracken f4a13bc72b Eliminate CocoaPods install step (#8694)
If the developer is relying on CocoaPods and hasn't done a pod install,
they'll get a build failure indicating the issue.

This also avoids a hard dependency on CocoaPods in the tool and allows
developers to customize their Xcode steps to use alternatives such as
Carthage if they prefer.
2017-03-09 17:57:45 -08:00
Yegor 3146e13414 print less in flutter_tool tests (fixes #8641) (#8699) 2017-03-09 16:51:46 -08:00
Yegor d09591bf7d consistently accept timeout in driver API (#8667) 2017-03-09 16:31:48 -08:00
Todd Volkert 1ada132ee8 Add first replay test (#8628) 2017-03-09 12:58:31 -08:00
Michael Goderbauer 5571cb1140 remove unneded deps to pub_semver (#8688) 2017-03-09 12:57:56 -08:00
Michael Goderbauer f613fef23b Fix tests to pass internally (#8683) 2017-03-09 12:09:20 -08:00
Michael Goderbauer edbfb17b62 remove remaining references to sky_snapshot (#8665) 2017-03-09 11:40:59 -08:00
Michael Goderbauer d7ab9be2bd Be explicit about typed_data deps (#8680) 2017-03-09 11:03:45 -08:00
Hans Muller 00c9e326db Additional Hero tests: destination moves midflight (#8668) 2017-03-09 10:36:53 -08:00
Jason Simmons a97eb12147 Use only Linux workers on Travis (#8678) 2017-03-09 10:06:42 -08:00
Sarah Zakarias 43281de36b Add flutter_view sample (#8486)
* Add flutter_view sample

* Removed platform_services files

* Addressed comments

* update README.md

* Addressed comments.
2017-03-09 12:53:01 +01:00
Sarah Zakarias f0e71cb15c Add support for earlier Android versions in platform_services example (#8621)
* Add support for earlier Android versions

* Addressed comments
2017-03-09 10:41:39 +01:00
Chris Bracken cabd58dbb2 Correct instructions for libimobiledevice install (#8675)
As of the latest Xcode versions, the latest published libimobiledevice
is out-of-date and build from HEAD is required.

This fixes two bugs:
1. Update initial install instructions to add --HEAD flag.
2. Update uninstall, reinstall instructions to include
   --ignore-dependencies flag, since other brew formulae depend on
   libimobiledevice.
2017-03-08 21:24:00 -08:00
Chris Bracken bf6b6e188d Check for CocoaPods installation if required (#8666) 2017-03-08 16:42:31 -08:00
Ian Hickson 54b80cca0d Add a file describing Google's commitments with regard to patents and this project (#8632) 2017-03-08 16:40:36 -08:00
Chris Bracken 2bbdacce35 Improve ideviceinstaller error message (#8662)
Homebrew is an expected part of the iOS toolchain. Update the error
message to assume that.
2017-03-08 15:31:32 -08:00
Alexandre Ardhuin 6a2148dde9 prefer const constructors (#8594)
* prefer const constructors

* fix double throw
2017-03-08 14:58:14 -08:00
Alexandre Ardhuin ce734e8f24 apply the upcoming rule : directives_ordering (#8582) 2017-03-08 14:58:09 -08:00
Alexandre Ardhuin 329e52c02c apply upcoming rule use_collection_literals_when_possible (#8649) 2017-03-08 14:57:31 -08:00