Commit graph

992 commits

Author SHA1 Message Date
Zachary Anderson 6c5606bea7
Run new_gallery__transition_perf on mokey in staging (#147339) 2024-04-24 16:33:15 -07:00
keyonghan 1df1c84dbe
Mark firebase tests as bringup: true (#147338)
This helps green the tree considering firebase outage:
https://github.com/flutter/flutter/issues/147335
2024-04-24 15:38:17 -07:00
Jackson Gardner 51e70fa16b
Fix skwasm tests (#145570)
Skwasm tests are now running as `bringup: true` in postsubmit, but failing. Let's get them fixed.
2024-04-09 19:35:07 +00:00
Gray Mackall 22e0c89f0a
Reland "Bump to AGP 8.1/Gradle 8.3 (almost) everywhere" (#146307)
Relands https://github.com/flutter/flutter/pull/146181.

Just 3 commits:
1. a revert of the revert
2. the fix described in https://github.com/flutter/flutter/pull/146181#issuecomment-2038238869
3. updating two postsubmit tests from Java 11 to 17, as that is required for this new AGP version.

I've verified that `flutter build apk --flavor paid --debug` fails in `dev/integration_tests/flavors/` with the error in ci without (2), and succeeds with it. 

I've also verified that the `dev/benchmarks/complex_layout` app builds successfully with Java 17.

That covers all the postsubmits that failed according [to the dashboard](https://flutter-dashboard.appspot.com/#/build).
2024-04-05 19:09:20 +00:00
Gray Mackall 29ed214e7f
Set up Kotlin linting step in ci with ktlint (#143478)
Adds a kotlin linting step to the linux analyze check, using a version of [ktlint](https://github.com/pinterest/ktlint) hosted on [CIPD](https://chrome-infra-packages.appspot.com/p/flutter/ktlint/linux-amd64/+/version_1_1_1).

Configured to disallow trailing commas, because of (and now acting as a test for) https://github.com/flutter/flutter/pull/145718. Because of this configuration the PR also removes some trailing commas in some kotlin files.

Also checks in a baseline file.
2024-04-03 21:21:00 +00:00
Flutter GitHub Bot 3a3026c5c9
Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller__timeline_summary to be unflaky (#140038)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro complex_layout_scroll_perf_impeller__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20complex_layout_scroll_perf_impeller__timeline_summary%22).
This test can be marked as unflaky.
2024-04-02 22:54:42 +00:00
Polina Cherkasova e10049b2ff
Turn off randomization for leak detection bots. (#145624) 2024-03-24 17:47:23 +00:00
Jackson Gardner 31209d04ff
flutter test --wasm support (#145347)
* Adds support for `flutter test --wasm`.
  * The test compilation flow is a bit different now, so that it supports compilers other than DDC. Specifically, when we run a set of unit tests, we generate a "switchboard" main function that imports each unit test and runs the main function for a specific one based off of a value set by the JS bootstrapping code. This way, there is one compile step and the same compile output is invoked for each unit test file.
* Also, removes all references to `dart:html` from flutter/flutter.
* Adds CI steps for running the framework unit tests with dart2wasm+skwasm
  * These steps are marked as `bringup: true`, so we don't know what kind of failures they will result in. Any failures they have will not block the tree at all yet while we're still in `bringup: true`. Once this PR is merged, I plan on looking at any failures and either fixing them or disabling them so we can get these CI steps running on presubmit.

This fixes https://github.com/flutter/flutter/issues/126692
2024-03-21 20:08:07 +00:00
Ricardo Amador 71c1aba10b
Switch hot_mode_dev_cycle_linux__benchmark to run in postsubmit (#145343)
Switch hot_mode_dev_cycle_linux__benchmark to run in postsubmit.

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Part of https://github.com/flutter/flutter/issues/145242

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-18 19:15:22 +00:00
Victoria Ashworth 7f368f7ed4
Add --no-dds to Mac_arm64_ios version of hot_mode_dev_cycle_ios__benchmark (#145335)
Attempting to debug https://github.com/flutter/flutter/issues/142305.
2024-03-18 18:51:26 +00:00
Jenn Magder a2678be7ad
Platform view devicelab ad banner scroll list real ads (#145239)
Reland https://github.com/flutter/flutter/pull/144745, which was reverted due to a the Android app ads not being set up correctly, crashing on launch: https://github.com/flutter/flutter/pull/145228

Add the missing [`com.google.android.gms.ads.APPLICATION_ID` `meta-data` tag](https://developers.google.com/admob/android/quick-start#import_the_mobile_ads_sdk) to the manifest.

Validated both `platform_views_scroll_perf__timeline_summary` and `platform_views_scroll_perf_impeller__timeline_summary` ran locally on an Android emulator.

Successful presubmit runs:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/4/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf_impeller__timeline_summary/4/overview

Original commit message:
_________
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257
2024-03-16 05:44:21 +00:00
yusuf-goog 1c153c38d2
Renaming the virtual device Nexus5 name to Nexus5.gce_x86 (#145225)
This is required to match a rename being made for the devices in firebase lab.

Also removed `version=24` entry, since thats not supported on Nexus5x, per the firebase team.

Bug:b/322830672

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-15 22:50:21 +00:00
auto-submit[bot] ca2d4865cf
Reverts "Reland: "Platform view devicelab ad banner scroll list real ads" (#145224)" (#145228)
Reverts: flutter/flutter#145224
Initiated by: hellohuanlin
Reason for reverting: breaks the tree
Original PR Author: hellohuanlin

Reviewed By: {gmackall, jmagman}

This change reverts the following previous change:
Reland https://github.com/flutter/flutter/pull/144745, which got reverted due to Android lockfile. Fixed by `dart dev/tools/bin/generate_gradle_lockfiles.dart`

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-15 20:09:18 +00:00
hellohuanlin da4d0e4fab
Reland: "Platform view devicelab ad banner scroll list real ads" (#145224)
Reland https://github.com/flutter/flutter/pull/144745, which got reverted due to Android lockfile. Fixed by `dart dev/tools/bin/generate_gradle_lockfiles.dart`

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-15 19:20:25 +00:00
Jackson Gardner a97af2093b
Run gradle_plugin_*_apk_test on presubmit on flutter_tool changes. (#142090)
These tests were failing in postsubmit after a change to `packages/flutter_tools`. We should run these in presubmit when `packages/flutter_tools` changes.
2024-03-15 17:52:52 +00:00
auto-submit[bot] 7f1c93d732
Reverts "Platform view devicelab ad banner scroll list real ads (#144745)" (#145189)
Reverts: flutter/flutter#144745
Initiated by: gspencergoog
Reason for reverting: appears to have broken the build.

Original PR Author: hellohuanlin

Reviewed By: {jmagman, jonahwilliams}

This change reverts the following previous change:
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-15 00:21:25 +00:00
hellohuanlin be78542d6c
Platform view devicelab ad banner scroll list real ads (#144745)
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-03-14 21:41:07 +00:00
Loïc Sharma 349cbb4a1e
Reduce Windows_arm64 plugin_test_windows test timeout (#145110)
Windows Defender sometimes kills the `Windows_arm64 plugin_test_windows` test process, causing the test to hang until it times out after 30 minutes. This reduces the test timeout to 900 seconds (15 minutes) to recover from this scenario faster.

Test timeout duration was chosen by looking at successful duration percentiles in the last 100 days:

duration_seconds_p90 | duration_seconds_p99 | duration_seconds_max
-- | -- | --
532 | 545 | 576

BigQuery SQL:

```sql
WITH
  successful_steps AS (
    SELECT
      b.id,
      TIMESTAMP_DIFF(s.end_time, s.start_time, SECOND) AS duration_seconds,
    FROM cr-buildbucket.flutter.builds AS b, UNNEST(steps) AS s
    WHERE
      create_time > TIMESTAMP_SUB(CURRENT_TIMESTAMP(), INTERVAL 100 DAY)
      AND regexp_substr(input.gitiles_commit.project, '[^\\/]+$') = 'flutter'
      AND builder.project || '/' || builder.bucket || '/' || builder.builder
        = 'flutter/prod/Windows_arm64 plugin_test_windows'
      AND name = 'run plugin_test_windows'
      AND s.status = 'SUCCESS'
  )
SELECT
  percentiles[offset(90)] AS duration_seconds_p90,
  percentiles[offset(99)] AS duration_seconds_p99,
  duration_seconds_max
FROM (
  SELECT
    APPROX_QUANTILES(duration_seconds, 100) AS percentiles,
    MAX(duration_minutes) AS duration_seconds_max
  FROM successful_steps
);
```

`test_timeout_secs` is documented here: https://github.com/flutter/cocoon/blob/main/CI_YAML.md

Part of https://github.com/flutter/flutter/issues/145072
2024-03-14 00:14:06 +00:00
Jenn Magder 6f175f1fcb
Mark Mac_arm64_ios module_test_ios not flaky (#145044)
Revert https://github.com/flutter/flutter/pull/144861

https://github.com/flutter/flutter/issues/144860 was resolved by https://github.com/openid/AppAuth-iOS/pull/825

I'm just going to mark this as unflaky instead of waiting for the bot.
2024-03-13 20:17:09 +00:00
godofredoc 5ee0bc0f14
Revert "Remove unused drone_dimension field" (#145024)
Reverts flutter/flutter#143984
2024-03-12 22:24:06 +00:00
Zachary Anderson 7bf84d0c6c
Mark Mac_arm64_ios module_test_ios bringup: true (#144861)
For https://github.com/flutter/flutter/issues/144860
2024-03-08 17:01:40 -08:00
Flutter GitHub Bot ea1ef751e0
Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (#144677)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android new_gallery_opengles_impeller__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20new_gallery_opengles_impeller__transition_perf%22).
This test can be marked as unflaky.
2024-03-08 18:07:21 +00:00
Flutter GitHub Bot d0287cc1c0
Marks Mac_x64 module_test_ios to be flaky (#144681)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_x64 module_test_ios"
}
-->
Issue link: https://github.com/flutter/flutter/issues/144680
2024-03-07 18:17:55 +00:00
keyonghan bc867ec757
Bring back firebase tests to prod (#144703)
Context: https://github.com/flutter/flutter/issues/144183
2024-03-06 21:33:40 +00:00
Jonah Williams ec8fcbcecc
[devicelab] fix motog4 tests and update comment. (#144410)
Fixes https://github.com/flutter/flutter/issues/144406

The A02 have also been running Vulkan for quite a while.
2024-02-29 19:29:01 +00:00
Victoria Ashworth d1d9605974
Remove force Xcode debug workflow (#144185)
Now that all tests are on Xcode 15 and iOS 17, we no longer need to force test Xcode debug workflow.

Related https://github.com/flutter/flutter/issues/144020.
2024-02-27 18:18:07 +00:00
keyonghan d319625329
Mark two other firebase targets as bringup: true (#144234)
https://github.com/flutter/flutter/issues/144183
2024-02-27 17:51:24 +00:00
Jonah Williams b2a3075fa5
Re-enable Impeller goldens blocking. (#144210)
The issues in flutter/flutter#144115 should be fixed with the removal of the incorrect render pass caching behavior in https://github.com/flutter/engine/pull/50976
2024-02-27 16:20:19 +00:00
keyonghan c82ca469a3
Mark firebase_release_smoke_test as bringup: true (#144186)
https://github.com/flutter/flutter/issues/144183
2024-02-26 15:47:17 -08:00
Jason Simmons f0e92a2bdc
Revert "Re-enable Impeller goldens blocking. (#144023)" (#144115)
On the current head some tests (such as test/widgets/shadow_test.dart) are segfaulting in the Impeller Vulkan back end.

This reverts commit 39585e66c1.

See https://github.com/flutter/flutter/issues/144116
2024-02-26 01:50:33 +00:00
Jonah Williams 39585e66c1
Re-enable Impeller goldens blocking. (#144023)
Part of https://github.com/flutter/flutter/issues/143616

Without this these tests only run on postsubmit which means we can't get gold results on PRs.

This was reverted because it landed after an engine change that broke flutter tester. That change has since been reverted.
2024-02-23 18:30:08 +00:00
Victoria Ashworth bb856079c4
Run tests on iOS 17 exclusively (#144022)
Almost all of our devicelab devices are on iOS 17 now, so let's use them exclusively so we can verify that tests pass consistently on iOS 17.

Fixes https://github.com/flutter/flutter/issues/144020.
2024-02-23 17:15:16 +00:00
keyonghan 91a6ec9a06
Remove unused drone_dimension field (#143984)
The drone_dimensions is expected to be defined under property only. The field level definition has never been used.

part of https://github.com/flutter/flutter/issues/143671
2024-02-23 00:13:51 +00:00
Zachary Anderson d13bc10aca
Shift Moto G4 staging tests to A02s (#143957)
https://github.com/flutter/flutter/issues/143915

cc @yusuf-goog
2024-02-22 11:26:09 -08:00
auto-submit[bot] c3e786f3f3
Reverts "[Impeller] Make impeller goldens test blocking. (#143864)" (#143896)
Reverts flutter/flutter#143864

Initiated by: goderbauer

Reason for reverting: The test is consistently failing in post-submit, e.g. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755443299639610049/+/u/run_test.dart_for_framework_tests_shard_and_subshard_impeller/stdout

Original PR Author: jonahwilliams

Reviewed By: {matanlurey}

This change reverts the following previous change:
Original Description:
Part of https://github.com/flutter/flutter/issues/143616

Without this these tests only run on postsubmit which means we can't get gold results on PRs.
2024-02-21 23:23:22 +00:00
Jonah Williams 0be6668418
[Impeller] Make impeller goldens test blocking. (#143864)
Part of https://github.com/flutter/flutter/issues/143616

Without this these tests only run on postsubmit which means we can't get gold results on PRs.
2024-02-21 21:08:07 +00:00
godofredoc 77c6a86ebf
Remove bringup from win arm64 builds. (#143548)
The Windows arm64 builds were all moved to bringup because new test beds not properly provisioned were added to the production pool.

Those new test beds are now fully validated but still running on staging pool to ensure they are not introducing noise in the prod pools.

Bug: https://github.com/flutter/flutter/issues/143180
2024-02-15 23:34:31 +00:00
Matan Lurey 7082ae1517
Swap the tasks that have been running fine for a while. (#143544)
Closes https://github.com/flutter/flutter/issues/142178.
2024-02-15 22:21:35 +00:00
godofredoc c530276f78
Remove certs dependency. (#143495)
The dependency was added as temporary workaround and was never removed.

Bug: https://github.com/flutter/flutter/issues/143489
Bug: https://github.com/flutter/flutter/issues/143490
2024-02-15 18:23:07 +00:00
godofredoc dde76f4961
Remove certs installation from win_arm builds. (#143487)
The certs dependency was added in 2020 as a workaround for missing certificates in win 10 images. These dependency is not required for windows arm64 builds because they are running on win 11.
2024-02-15 04:39:14 +00:00
Flutter GitHub Bot dc1f9f183f
Marks Linux_pixel_7pro integration_ui_keyboard_resize to be unflaky (#143440)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro integration_ui_keyboard_resize"
}
-->
The issue https://github.com/flutter/flutter/issues/140645 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20integration_ui_keyboard_resize%22).
This test can be marked as unflaky.
2024-02-14 16:20:09 +00:00
Matan Lurey 56387c0111
Rename external_ui to external_textures. (#143406)
My understanding is I can do this safely because the task is marked `bringup: true`?

Next PR will remove `bringup` and take down the old tasks.

Partial work towards https://github.com/flutter/flutter/issues/142178.
2024-02-13 23:22:23 +00:00
Zachary Anderson 9f832218da
Move Windows arm64 tests to bringup true (#143272)
For https://github.com/flutter/flutter/issues/143271
2024-02-10 21:21:09 +00:00
Victoria Ashworth d60b681ef7
Move Mac_build_test flutter_gallery__transition_perf_e2e_ios out of staging (#142987)
Move test out of staging now that https://github.com/flutter/flutter/issues/142917 is fixed.
2024-02-07 19:24:44 +00:00
Jenn Magder fee1868d89
Run Mac x64 build tests in postsubmit only (#142334)
It shouldn't be very common for x64 example projects to not build if they built on arm64.  We have other tool tests that would probably catch those issues in presubmit.

Instead run them on postsubmit only to free up limited x64 staging resources.

Follow up from #141206
2024-02-07 06:41:25 +00:00
Andrew Kolos bf9aa556d2
Mark Windows_android hot_mode_dev_cycle_win__benchmark as no longer flaky (#143016)
Marked flaky in flutter/flutter#142609

Per the reasons I discuss in [this comment](https://github.com/flutter/flutter/issues/142608#issuecomment-1930868003) on the corresponding issue, I believe this test is probably not actually flaky.

Fixes https://github.com/flutter/flutter/issues/142608
2024-02-07 03:36:02 +00:00
Victoria Ashworth 809a27ea67
Move Mac_build_test flutter_gallery__transition_perf_e2e_ios to staging (#142918)
Temporary solution for https://github.com/flutter/flutter/issues/142917.
2024-02-05 17:29:22 +00:00
Ricardo Amador 3f30dc2e0a
Add a link the different possible Android virtual device configs (#142765)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-02-02 16:13:40 +00:00
Victoria Ashworth 822ebc48e0
Allow all iOS tests to use either iOS 16 or 17 (#142714)
Undoing https://github.com/flutter/flutter/pull/142323 to allow all iOS tests to use iOS 16 or 17.
2024-02-02 16:02:08 +00:00
Ricardo Amador c13ebf1e78
Use proto name for emulator version and show cipd package version (#142262)
Changes to use the proto.textpb config file as the version of the emulator device and show the cipd dependency version in the dependencies so devs know it can be updated.

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Fixes https://github.com/flutter/flutter/issues/142261

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-02-01 23:48:19 +00:00