Commit graph

1250 commits

Author SHA1 Message Date
Jonah Williams 938fae9c99
remove --machine flag (#68538) 2020-10-19 17:06:28 -07:00
Jonah Williams a152c0f429
[devicelab] reland: reduce iterations of startup test, use application binary (#68532)
These devicelab tests are incredibly flaky. Currently they will build & install the same application 15 times. This causes the temp storage to fill up on android, and has a good chance of flaking on iOS due to install issues.

The change from 3 to 15 increased total test time for 2 -> 12 minutes on iOS, or roughly 5 more test equivalents for every single iOS test. Reduce the iteration count back to 5

Uninstall the app after each run so temp storage does not fill up.
2020-10-19 16:51:28 -07:00
Yuqian Li 91a5a1e7f9
Mark e2e ios32 warmup test as nonflaky (#68511) 2020-10-19 15:52:05 -07:00
Jonah Williams 4a3e2a1af5
Revert "[devicelab] reduce iterations, uninstall at end, and use --application-binary in all startup tests (#68516)" (#68531)
This reverts commit a4c2075a45.
2020-10-19 15:05:46 -07:00
Jonah Williams 8262f808ba
Revert "[devicelab] fix flutter gallery app name (#68528)" (#68530)
This reverts commit 0f69f8e53b.
2020-10-19 15:05:10 -07:00
Jonah Williams 0f69f8e53b
[devicelab] fix flutter gallery app name (#68528) 2020-10-19 14:48:05 -07:00
Jonah Williams a4c2075a45
[devicelab] reduce iterations, uninstall at end, and use --application-binary in all startup tests (#68516)
These devicelab tests are incredibly flaky. Currently they will build & install the same application 15 times. This causes the temp storage to fill up on android, and has a good chance of flaking on iOS due to install issues.

The change from 3 to 15 increased total test time for 2 -> 12 minutes on iOS, or roughly 5 more test equivalents for every single iOS test. Reduce the iteration count back to 5

Uninstall the app after each run so temp storage does not fill up.
2020-10-19 14:16:04 -07:00
Casey Hillers 1c35091a13
[devicelab] Cocoon client (#68333) 2020-10-19 13:12:04 -07:00
Jonah Williams e8dc7a2e17
[devicelab] update hostonly tests to use flutter directly or precache deps (#68487)
Fixes #67370

By running most of these executions through flutter, we get the benefit of the flutter error handling and precaching. IN the test where this is not feasible, call pre-cache directly.
2020-10-19 13:01:50 -07:00
Jonah Williams 03db9bf918
[devicelab] migrate defines test to DriverTest (#68407)
Removes one-off handling for defines test and forces it to run through the DriverTest interface
2020-10-19 12:28:43 -07:00
Jonah Williams 223df0c351
[devicelab] split end to end tests into driver targets (#68410)
Split the integration_ui target into individual driver tests. Remove disabled screenshot tests
2020-10-19 12:28:13 -07:00
Jonah Williams e422d5c724
[flutter_tools] reland: --no-android-gradle-daemon in devicelab (#68491)
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.

Example:

flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 10:27:58 -07:00
Jonah Williams ed5482de19
Revert "[flutter_tools] add --android-gradle-daemon option, use in devicelab (#68409)" (#68489)
This reverts commit ddab72e79f.
2020-10-19 09:33:52 -07:00
Jonah Williams ddab72e79f
[flutter_tools] add --android-gradle-daemon option, use in devicelab (#68409)
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.

Example:

flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 09:12:21 -07:00
Alexandre Ardhuin c0176c9ee5
use_is_even_rather_than_modulo (#68301) 2020-10-16 20:20:00 +02:00
Martin Kustermann 6fae89c8b5
Update package:stack_trace dependency to 1.10.0-nullsafety.4 (#68132) 2020-10-16 16:35:20 +02:00
Jonah Williams 35c364053b
Fix screenshotting code (#68261) 2020-10-15 19:03:28 -07:00
Jonah Williams d7f80fcdd3
[flutter_tools] configure screenshot on failure for all tasks (#68260) 2020-10-15 18:53:00 -07:00
Jonah Williams ef205f7ebf
[devicelab] mark catalina not flaky and list iproxy processes before tet (#68239) 2020-10-15 14:21:40 -07:00
Dan Field 12f54e17f4
reland List queue search optimization (#68214)
* Revert "Revert "Improve performance of collectAllElements (#68065)" (#68207)"

This reverts commit 46ff57d6f1.

* use fewer elements for benchmark
2020-10-15 13:46:50 -07:00
Jonah Williams 0f88644883
[devicelab] allow the devicelab to take a screenshot if the iOS connection fails with FLUTTER_IOS_SCREENSHOT_ON_CONNECTION_FAILURE (#68156)
More attempts to remote diagnose the issues in the iOS devicelab
2020-10-15 13:13:28 -07:00
Jenn Magder 25857ce513
Use --device-timeout instead of deprecated --timeout in devicelab (#68230) 2020-10-15 12:45:59 -07:00
Jonah Williams f5608f2b33
[devicelab] track any leaked processes (#68218) 2020-10-15 10:54:31 -07:00
Jonah Williams 2321b72dfb
[flutter_tools] move gradle download failure handling into tool (#68140)
This crash affects anyone using flutter, so move it into the tool where it can be tested and documented. Ensure it works on windows devicelab too.
2020-10-15 09:20:52 -07:00
Jonah Williams 46ff57d6f1
Revert "Improve performance of collectAllElements (#68065)" (#68207)
This reverts commit 8ba5732c4c.
2020-10-15 08:04:59 -07:00
Dan Field 8ba5732c4c
Improve performance of collectAllElements (#68065) 2020-10-14 21:32:04 -07:00
Jonah Williams 83e99f75c6
[devicelab] move test from flaky (#68141) 2020-10-14 14:47:41 -07:00
Jonah Williams c11a64e944
[devicelab] turn down android X migration gradle tests (#68110)
These androidx migration tests require downloading firebase, which is a large library with a number of dependencies - this causes frequent enough flakes.

AndroidX migration is ~2 years in the past, and while it would be nice to confirm this still works, ideally that would be done in a reduced manner.
2020-10-14 13:24:22 -07:00
Jonah Williams 33903c17e1
[devicelab] delete disabled or not useful benchmarks (#68107)
- run_without_leak_tests: have been disabled for months
- build_benchmark: the tooling work here is mostly done and we're not tracking further improvements, free up more devicelab capacity
- system_debug_ios: does not work post iOS13
- mac_enable_twc: not adding more mac tests to devicelab
- hello_world_start_up: disabled

Any tests that we think will be valuable in the future can be resurrected from the git history.
2020-10-14 10:30:10 -07:00
Jonah Williams 06722679da
[devicelab] mark ios catalina as flaky (#68109) 2020-10-14 08:52:28 -07:00
Jonah Williams 751459df24
[flutter_tool] support --use-application-binary in flutter drive (#68060)
--use-application-binary allows running with an already built APK. This can be useful for speeding up CI test cases, or in our case eventually supporting some sort of build server. Demonstrate that this works by updating the old gallery test to use it. Fixes #56604

Co-authored-by: Jenn Magder <magder@google.com>
2020-10-13 19:27:30 -07:00
Jonah Williams eb24393efe
remove missing argument (#67974) 2020-10-12 17:18:09 -07:00
Jonah Williams 5dfe7e6d51
[flutter_tools] attempt to stabilize hot restart benchmark the old fashioned way (#67971)
A change which sped up hot restart locally caused many of the devicelab measures to regress. I think this is because we do not measure when the isolate is actually "ready", so starting a reload or restart prematurely can cause time spent doing initialization to be registered as part of the reload operation.

A fix for this would be to have the framework include some sort of "initialization complete" event ... but it is not clear what the correct trigger would be. Perhaps after the first frame is successfully registered?

(9a3a0dc caused the benchmark regression - possibly since we spend less time syncing files now so we start the restart earlier)
2020-10-12 17:00:26 -07:00
Sam Rawlins 23c7ee9deb
Bump meta to 1.3.0-nullsafety.4 (#67744) 2020-10-12 09:50:30 -07:00
Jonah Williams e53bb74694
Revert "Revert "Delete fast start unit test (#67757)" (#67763)" (#67765)
This reverts commit b33bfcef0f.
2020-10-09 13:04:20 -07:00
Jonah Williams b33bfcef0f
Revert "Delete fast start unit test (#67757)" (#67763)
This reverts commit 3eb2335a4e.
2020-10-09 13:01:42 -07:00
Jonah Williams 3eb2335a4e
Delete fast start unit test (#67757)
Now that fast-start syncs assets by default, this isn't testing anything. Retire the test
2020-10-09 12:41:32 -07:00
nturgut a755c03819
Add web e2e to the flutter/flutter repo (#67693)
* adding tests that uses integration_test (e2e) package to flutter

* change the package name for the import

* fix licenses. fix README commands. add links

* adding dependency change auto generated by the tool

* more analyzer error fixes
2020-10-09 12:24:36 -07:00
Jenn Magder 98aeef2d98
Build xcarchive command (#67598) 2020-10-08 19:51:35 -07:00
Yuqian Li 98d1ad0195
Purge persistent cache for perf test runs (#67697) 2020-10-08 19:17:02 -07:00
Yuqian Li e1e12fa658
Mark nonflaky tests as such (#67592) 2020-10-08 12:20:14 -07:00
Yuqian Li 684449a841
Remove measureIosCpuGpu (#67363) 2020-10-08 12:02:03 -07:00
Casey Hillers 9e206a0c93
Refactor devicelab logic to use TaskResult instead of JSON (#67550) 2020-10-07 16:37:09 -07:00
Jenn Magder e5131fa31b
Increase device discovery timeout in devicelab health check (#67337) 2020-10-06 12:23:02 -07:00
Ming Lyu (CareF) 76c0d69b14
migrate textfield_perf to e2e (#64503) 2020-10-02 14:47:03 -07:00
Yuqian Li e45157fc08
5x startup test repitition to reduce noise (#67147) 2020-10-02 12:22:05 -07:00
Ming Lyu (CareF) db2532a949
migrate color_filter_and_fade_perf (#64484) 2020-10-01 17:32:02 -07:00
Yuqian Li b92d250116
Let perf tests measure memory by default (#66570)
Fixes https://github.com/flutter/flutter/issues/66569
2020-10-01 15:20:17 -07:00
Jacob MacDonald b95c3d7d56
update stack_trace dep (and others) (#67057) 2020-10-01 09:54:07 -07:00
Chris Yang 2d26bafec2
remove --trace-startup (#66568) 2020-09-29 17:22:04 -07:00