Commit graph

706 commits

Author SHA1 Message Date
Chris Yang b05210c707
Move ios screenshot test to flutter gold. (#52553) 2020-03-19 16:27:41 -07:00
Ben Konyi 3edd3eb4a2
Updated package:test, package:test_core, package:coverage, package:package_config (#51946)
This is required to roll forward package:vm_service to 3.0.0 and is
blocking a DevTools release.
2020-03-04 11:40:52 -08:00
Miguel Beltran 7ff3a50fe7
Set highContrast value from AccessibilityFeatures into MediaQueryData (#48811) 2020-02-26 13:36:02 -08:00
Greg Spencer c5dd3ec47a
Fix stuck keys when shift is released before the letter. (#51095)
This fixes a problem where if you press "Shift" and then "A", then release "Shift" and then "a", then the "A" key will be "stuck" on because the logical key for the key down message is different (capital "A") from the logical key for the key up message (lowercase "a").

This PR changes the pressed keys logic so that it uses the physical key to add/remove keys from the list of pressed keys, but keeps the associated logical key.

This does mean that after the "Shift" key goes up, the pressed keys contains a capital "A" and it doesn't switch to be a lowercase "a", but there isn't currently any mechanism we can use to do that remapping. This is far less surprising than the current behavior, but is still not quite correct.

I fixed the event simulation code to take a physicalKey so that it could be matched with the logical key, but the event simulation code isn't up to the task, since it can only simulate keys that appear in the key maps. The new platform key event design should fix that (added TODOs).
2020-02-21 14:13:38 -08:00
Kate Lovett 52ee8a6c65
Remove highContrast from FakeAccessibilityFeatures (#51130) 2020-02-20 10:28:49 -08:00
Albertus Angga Raharja aad941e3fa
Avoid using FlutterError.fromParts when possible (#43696)
This PR is a follow up of https://github.com/flutter/flutter/pull/42640
Some changes of that PR includes redundant changes using FlutterError.fromParts constructor even though it's not necessary.

Some minor changes are:

- Remove one unnecessary todo
- Fix indent consistencies
2020-02-20 07:51:53 -08:00
Miguel Beltran d295fbb6a1
Add highContrast to FakeAccessibilityFeatures test (#48486) 2020-02-19 13:26:05 -08:00
Jonah Williams 9b4cb4da72
[versions] reland update test to 1.12.0 (#50879) 2020-02-18 10:38:54 -08:00
Jonah Williams e481fcae52
Revert "[version] update to package:test 1.12.0 (#50818)" (#50853)
This reverts commit d3387bc916.
2020-02-14 22:34:30 -08:00
Jonah Williams d3387bc916
[version] update to package:test 1.12.0 (#50818) 2020-02-14 21:51:47 -08:00
Alexandre Ardhuin f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Emmanuel Garcia 8c398a8ddd
Reland: Skia gold driver test (#50160) 2020-02-06 17:14:50 -08:00
Emmanuel Garcia 9b3e1639db
Revert "Reland: Skia gold driver test (#49905)" (#50127)
This reverts commit e03f439145.
2020-02-04 13:28:55 -08:00
Emmanuel Garcia e03f439145
Reland: Skia gold driver test (#49905) 2020-01-31 14:50:50 -08:00
Emmanuel Garcia 1eb5bb653c
Revert "Use skia golden files in driver test (#49750)" (#49900) 2020-01-31 12:14:08 -08:00
Emmanuel Garcia a50743f658
Use skia golden files in driver test (#49750) 2020-01-31 11:05:29 -08:00
Alexandre Ardhuin b5f328e37e
remove unnecessary string interpolations (#49622) 2020-01-31 18:30:21 +01:00
Dan Field b2a27c109c
Be clearer about when and why we override HttpClient in tests (#49844) 2020-01-31 09:22:30 -08:00
ZichangG 0be9127dfd
add preserveHeaderCase for classes extends HttpHeaders (#49766) 2020-01-30 11:43:02 -08:00
Dan Field fabeb2a16f
Revert string interp (#49602) 2020-01-28 07:56:51 -08:00
Dan Field 8b2993337a
revert #48985 (#49572) 2020-01-27 14:36:02 -08:00
Alexandre Ardhuin 92cbaa3efe remove unnecessary string interpolations (#49352) 2020-01-23 20:43:01 -08:00
Tianguang e2aa9e13ce Achieve Color Contrast Accessibility for Menu Demo (#49099) 2020-01-23 18:43:01 -08:00
Tong Mu d3a835e661 Fix template syntax error in WidgetController doc (#49255) 2020-01-21 19:58:02 -08:00
Alexandre Ardhuin 3800bb7b10 fix missing spaces in adjacent strings (#49159) 2020-01-21 16:43:03 -08:00
Anthony b67d5ec6e9 [a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985) 2020-01-17 15:13:01 -08:00
Greg Spencer bf1d822198 Add TargetPlatform.macOS tests to cupertino, foundation, rendering, and services libraries. (#45644) 2020-01-16 19:38:01 -08:00
Alexandre Ardhuin 003541499b use isA<Xxx>() matcher (#48482) 2020-01-16 12:43:03 -08:00
Ian Hickson e2b169ebd3 Apply void_checks lint. (#48267) 2020-01-13 10:03:01 -08:00
Alexandre Ardhuin 82262d8896 format operator== according to flutter style guide (#48449) 2020-01-09 08:23:02 -08:00
Greg Spencer fabf4e3d0d Reverse the sense of the terms snippet and sample. (#48254) 2020-01-08 15:28:02 -08:00
David Iglesias f65f7f0118 Change video_demo slightly so it works on web. (#46719) 2020-01-08 12:28:01 -08:00
Sam Rawlins 5005824763 Mark unused but desired private constructors as such (#46200) 2020-01-07 12:03:03 -08:00
Alexandre Ardhuin 4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Greg Spencer 19b9206add
Add variant testing to testWidgets (#45646)
This adds the ability to define variants of tests with different environmental values for a particular testWidgets test.

This allows you to run the same test multiple times with a different test environment. One test variant has been implemented that allows running a test with different settings of the TargetPlatform.
2019-12-20 15:00:16 -08:00
Dan Field 4ad8271bf5 Reland text state (#47464) 2019-12-19 13:43:02 -08:00
Alexandre Ardhuin 78db965642 Reland implicit-casts: false (#47431) 2019-12-19 02:23:01 -08:00
Lau Ching Jun a4858782da
Revert "implicit-casts: false (#47199)" (#47428)
This reverts commit c235998acf.
2019-12-18 23:53:00 -08:00
Alexandre Ardhuin c235998acf implicit-casts: false (#47199) 2019-12-18 23:23:01 -08:00
Lau Ching Jun d51956a9ea
Revert "Call setEditingState when text changes. (#47177)" (#47397)
This reverts commit d4b49ce9fc.
2019-12-18 18:03:24 -08:00
Kate Lovett c281369356 Fix subdirectory output (#47256) 2019-12-18 16:33:01 -08:00
Shouichi Kamiya 0764548231 s/v-sync/Vsync/g (#46660) 2019-12-17 19:43:03 -08:00
Dan Field d4b49ce9fc
Call setEditingState when text changes. (#47177) 2019-12-17 14:03:04 -08:00
Lau Ching Jun 535526b03c
Enable web for some of the golden tests (#46820)
* Make golden test timeout longer, some tests are flaky if the timeout is too short

* Enable some golden tests for web
2019-12-12 10:36:41 -08:00
Tong Mu a4f7a0dfb9
Revert changes to TestPointer; MouseTracker no longer relies on Add events (#46285)
* Revert test pointer

* Synthesize new state
2019-12-09 15:12:11 -08:00
Lau Ching Jun c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Michael Goderbauer 1ac17c14fc Re-land "Add option to delay rendering the first frame (#45135)" (#45941) 2019-12-03 19:48:01 -08:00
Kate Lovett cd052a56cb
Revert "Re-land "Add option to delay rendering the first frame (#45135)" (#45588)" (#45939)
This reverts commit c59151b1cd.
2019-12-02 15:08:35 -08:00
Michael Goderbauer c59151b1cd Re-land "Add option to delay rendering the first frame (#45135)" (#45588) 2019-12-02 13:33:45 -08:00
Tong Mu afb8f38211
Improve MouseTracker lifecycle: Move checks to post-frame (#44631)
This PR rewrites MouseTracker's lifecycle, so that mouse callbacks are all triggered in post frame, instead of the current one where some are triggered during the build phase. This PR also changes the onExit callback to MouseRegion, RenderMouseRegion, and MouseTrackerAnnotation, so that it is no longer triggered on dispose.
2019-12-02 13:00:48 -08:00