Commit graph

8283 commits

Author SHA1 Message Date
Todd Volkert 9c1aba2abe Skip adb server restarts during device discovery (#9693) 2017-05-01 10:10:16 -07:00
Adam Barth c6b0f833af Document more scrolling classes (#9684) 2017-04-30 08:59:06 -07:00
Adam Barth a4ba761bea Document remaining non-scrolling symbols (#9667)
This patch finishes documenting all the symbols except for those related to
scrolling.
2017-04-28 16:01:14 -07:00
Mikkel Nygaard Ravn bba043bab3 Roll engine to da8ebf40bd5fc76774bc4d291094344074fa432c (#9680) 2017-04-29 00:53:32 +02:00
xster f65fea8e2e Create a text validator/formatter mechanism (#9535)
* Add a text formatter interface used by EditingText. Provide some default implementations.

* self nits

* Handle -1 selection offsets

* review notes

* simplify regular expression

* Add whitelisting formatters. Use a custom phone number formatter in text demo.

* review notes

* not being able to addAll(null) is pretty annoying

* review notes

* partial tests

* Add tests

* didn’t end up needing mockito

* move to services
2017-04-28 15:33:38 -07:00
xster b717963b43 Change Cupertino page transition box shadow to a simple custom gradient (#9673)
Creates another Decoration for drawing outside the decorated box with a gradient to emulate the shadow.

Lets the cupertino transition page's background be transparent.

Fixes #9321
2017-04-28 12:50:20 -07:00
Hans Muller acf102be95 AnimatedList (#9649) 2017-04-28 11:37:36 -07:00
Devon Carew 6716904385 return the result from calling a service extension (#9636) 2017-04-28 07:39:14 -07:00
Ian Hickson f2e89681d9 Mark microbenchmarks_ios as flaky (#9656)
...because it clearly is.
2017-04-27 19:55:54 -07:00
Chris Bracken 9da22bd92f Roll engine to 7c699ce7721b32d7893e68e260474a7eec811fd5 (#9660) 2017-04-27 16:51:09 -07:00
xster 3a0ce961ca lerp LinearGradient (#9628)
* Implement

* Don’t scale the fractional offsets since it’s easier to use

* review notes

* fix nit
2017-04-27 15:52:41 -07:00
xster 66ed8de745 Record flutter run success/fail, build mode, platform, start time in analytics (#9597)
FlutterCommand.runCommand subclasses can optionally return a FlutterCommandResult which is used to append additional analytics. 

Fix flutter run timing report and add a bunch of dimensional data
2017-04-27 15:28:15 -07:00
Jason Simmons a4992f0eac Fix the sizing of the stack containing the Gallery preview banner (#9657) 2017-04-27 15:16:05 -07:00
Mikkel Nygaard Ravn a33832617b Document channel message value conversions (#9635) 2017-04-28 00:04:51 +02:00
Ian Hickson 11fa80bb78 MediaQuery.of shouldn't give a default return value (#9596) 2017-04-27 15:02:59 -07:00
Michael Goderbauer b432af51fd Don't crash when ADB exits with non-zero exit code (#9653) 2017-04-27 14:57:56 -07:00
Ian Hickson 36052e68dd BoxDecoration API changes: backgroundColor -> color et al (#9648)
backgroundColor -> color
backgroundImage -> image
BackgroundImage -> DecorationImage
2017-04-27 14:19:01 -07:00
Jason Simmons 1d6a8249f8 roll engine (#9650) 2017-04-27 13:34:48 -07:00
Todd Volkert ffdca6f7e8 Fix getDevicesById() (#9646)
If the user specified a non-exact device id, it was producing
an exception whereby we were trying to listen to the
`getAllConnectedDevies()` stream twice.
2017-04-27 13:12:59 -07:00
Adam Barth 744c91265b Add NestedScrollView (#9640)
A NestedScrollView lets you implement patterns where you have a header, tabs,
and additional scrollers inside the tabs.

Fixes #8359
2017-04-27 12:29:40 -07:00
Jason Simmons 834c142d04 Fix the sizing of the image in Gallery/Contacts (#9625) 2017-04-27 11:32:53 -07:00
Jason Simmons 0439bf25d9 Fix an analyzer warning (#9643) 2017-04-27 11:16:00 -07:00
Adam Barth 4bac259617 Shift more code to ScrollPosition (#9637)
Previously, ScrollPosition did not know about ScrollActivities. However, all
the concrete subclasses of ScrollPosition that we know about need to use
ScrollActivities, so they ended up with a bunch of delegate boilerplate code.

This patch teaches ScrollPosition about ScrollActivities but doesn't have any
opinion about how to start or interact with those activities.

This patch is more refactoring to prepare for nested and linked scrolling.
2017-04-27 10:30:53 -07:00
Michael Goderbauer 36f7a26641 Disable AAPT cruncher on Windows for channel integration test (#9639)
It causes the test to be flaky, see https://github.com/flutter/flutter/issues/8986.
2017-04-27 09:59:31 -07:00
Adam Barth 2891772846 Refactor ScrollDragActivity into two pieces (#9629)
This will make it easier to implement nested scrolling.
2017-04-27 09:39:12 -07:00
Devon Carew 9ac2e44ee7 add a regression test for daemon device notification (#9618)
* add a regression test for daemon device notification

* revert event send simplification
2017-04-27 09:30:47 -07:00
P.Y. Laligand d2c6b0a637 Get rid of unnecessary flutter_root argument. (#9622) 2017-04-27 09:10:48 -07:00
Mikkel Nygaard Ravn 23b8e1f115 Make profile provisioning manual for channel_integration_test_ios (#9633) 2017-04-27 12:14:43 +02:00
Mikkel Nygaard Ravn 60bc1cfde7 Remove personal dev team from ios code sigining (#9631)
* Mark channels_integration_test_ios flaky

* Removed personal dev team from ios code siging

* Removed provisioning profile diffs against other samples
2017-04-27 11:07:52 +02:00
Mikkel Nygaard Ravn 70ff50f929 Integration test for channel communication (#9621) 2017-04-27 08:44:28 +02:00
Zachary Anderson 0770c3c14f [flutter_tools] Adds some support for '-d all' (#9585) 2017-04-26 21:49:38 -07:00
Todd Volkert 9558ac7d55 Assert that url is non-null in NetworkImage (#9626) 2017-04-26 21:35:58 -07:00
Ian Hickson 2e194d5b44 Allow ChangeNotifiers to be CustomPainters (#9584)
Fixes https://github.com/flutter/flutter/issues/7648
2017-04-26 14:30:20 -07:00
Mehmet Fidanboylu 4e7a38b118 Add a tile scrolling test to complex_layout app (#9537)
* Add a tile scrolling test to complex_layout app

* - Review comments and fix analyzer failures.

* Use ListView.builder pattern.
2017-04-26 14:22:11 -07:00
xster f645245ffd Add a convenience test task for vscode (#9570) 2017-04-26 13:48:28 -07:00
Todd Volkert e2cd78358f Fix missing await (#9617)
Fixes #9612
2017-04-26 13:14:31 -07:00
Adam Barth 0f900116f0 Rename Stack.sizing to Stack.fit (#9615)
The enum is called StackFit, so the property name "fit" makes more sense.
2017-04-26 11:12:38 -07:00
Hans Muller 3c3b003f8b Handle ListView item size changes that cause underflow (#9586) 2017-04-26 10:44:35 -07:00
Michael Goderbauer b7ec82014d move collection to dev dependency (#9613) 2017-04-26 10:38:11 -07:00
Michael Goderbauer 460561bad8 Make Flutter plugins usable from a Windows host (#9599)
Note: In a cross-platform context `Uri.path` is not a valid file path. Allways use `fs.path.fromUri` to convert.
2017-04-26 10:02:22 -07:00
Todd Volkert aaaae265ae Run async when calling adb shell getprop (#9611)
Also, add a timeout so a hung `adb` will not cause the
tools process to hang.

Fixes #9567
2017-04-26 09:58:20 -07:00
Todd Volkert 21f57a85e8 Wait for stderr in runCommandAndStreamOutput() (#9598) 2017-04-25 17:40:28 -07:00
Todd Volkert 60c5ffc1a9 Switch many Device methods to be async (#9587)
`adb` can sometimes hang, which will in turn hang the Dart isolate if
we're using `Process.runSync()`. This changes many of the `Device` methods
to return `Future<T>` in order to allow them to use the async process
methods. A future change will add timeouts to the associated calls so
that we can properly alert the user to the hung `adb` process.

This is work towards #7102, #9567
2017-04-25 17:23:00 -07:00
Ian Hickson 596eb033c7 Loosen the constraints for Stack non-positioned children. (#9581)
Also:

 * Add three explicit sizing modes to Stack for non-positioned
   children: loose, expand, and passthrough. (All three are used.)

 * Fix a bug whereby layers would try to paint in the same frame as
   they were removed from layout (but not detached).

 * Fix a bug whereby Offstage wasn't properly marking the parent dirty
   when changing its sizedByParent flag.

 * Explicitly make Overlay expand non-positioned children.

 * Explicitly have InputDecoration pass through the constraints from
   its Row to its Stack children.
2017-04-25 15:06:02 -07:00
Ian Hickson 24b40d87d6 Make getVelocity never return null (#9583)
Fixes https://github.com/flutter/flutter/issues/8425
2017-04-25 12:23:43 -07:00
Michael Goderbauer ad1c497c03 Do not lower-case paths during canonicalization. (#9571)
* Do not lower-case paths during canonicalization.

This breaks hot reload on some platfroms with case insensitive file systems.

* Add unit tests
2017-04-25 10:34:43 -07:00
Alexandre Ardhuin 31828609dc add @required (#9579) 2017-04-25 08:59:43 +02:00
Adam Barth c288c7064f Refactor scrolling code to prepare for nested scrolling (#9575)
This patch reworks some of the guts of scrolling to make it easier to
implement nested scrolling effects. The actually nested scrolling effect
will be included in a later patch.
2017-04-24 23:32:55 -07:00
Ian Hickson 57648ba0e4 New Placeholder widget. (#9565) 2017-04-24 14:06:07 -07:00
Ian Hickson 3492350653 Remove Placeholder. It has no clients. (#9563) 2017-04-24 12:40:27 -07:00