Commit graph

14163 commits

Author SHA1 Message Date
Mehmet Fidanboylu 473744df2c
Revert "fix wrap intrinsic height calculation (#63420)" (#64046)
This reverts commit 72619b8642.
2020-08-18 08:07:14 -07:00
Jonah Williams 262c48d2ea
[flutter_tools] add cache busting query param (#63818) 2020-08-17 22:41:05 -07:00
Andre 9e0ad9b6b5
Fix FittedBox BoxFit.scaleDown sizing (#63668) 2020-08-17 22:36:02 -07:00
Albert Viilik 654022aecb
Make deprecation notice link to website downloads (#63829) 2020-08-17 17:01:02 -07:00
Ming Lyu (CareF) 2c716c4d49
add vsync overhead to FrameTimingSummarizer (#63835) 2020-08-17 16:51:04 -07:00
Ian Hickson 8f3805f5af
Build routes even less. (#62588) 2020-08-17 15:16:06 -07:00
Jonah Williams 042fa8cf66
[flutter_tools] trim trailing newline from vm service logging events (#63976) 2020-08-17 12:26:03 -07:00
Ming Lyu (CareF) 04759e8559
doc typo spelling fix (#63817) 2020-08-17 12:21:08 -07:00
Zachary Anderson 1884920e30
[flutter_tool] Handle Windows line endings in packages_test.dart (#63806) 2020-08-17 11:41:08 -07:00
LongCatIsLooong 579cab8a86
Prevent material switch from recreating its render object when it becomes disabled (#61398) 2020-08-17 11:36:02 -07:00
stuartmorgan 70bd819c52
Separate blkid in the Linux library checks (#63810) 2020-08-17 10:51:03 -07:00
Helin Shiah 3d3b5349a7
Return host and port from devtools launcher (#63795) 2020-08-17 10:46:05 -07:00
server-developer 8a4ada25cd
DecoratedBoxTransition sample code (#63775) 2020-08-17 10:41:04 -07:00
chenjianguang f45cdd57e2
Add debug flag debugProfileLayoutsEnabled. (#63652) 2020-08-17 10:36:03 -07:00
Jonah Williams 08254b2156
Revert "Remove TODOs added for HTTP abort() change in dart sdk (#63924)" (#63972)
This reverts commit b1c17313f6.
2020-08-17 10:25:01 -07:00
zichangg b1c17313f6
Remove TODOs added for HTTP abort() change in dart sdk (#63924) 2020-08-17 09:46:08 -07:00
Ming Lyu (CareF) c2368bdd6f
bug fix for pointer id in test gestures (#63816) 2020-08-15 10:41:02 -07:00
Konstantin Scheglov 236507f058
Provide the argument for a required parameter 'data'. (#63728) 2020-08-14 16:46:03 -07:00
LongCatIsLooong 64d76f2fb7
Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413) 2020-08-14 16:41:03 -07:00
Nolan Scobie ede1b15b76
Add viewport documentation breadcrumbs (#63192) 2020-08-14 15:56:02 -07:00
Zachary Anderson f360d8b8e8
[flutter_tool] Fix some create_test.dart tests on Windows (#63796) 2020-08-14 15:26:29 -07:00
Paul Berry d80aa48001
Ignore/fix dead_code checks for weak-only null checks. (#63794)
Now that https://github.com/dart-lang/sdk/issues/41985 is fixed, the
analyzer detects dead code due to "unnecessary" null checks.  Since we
want to retain null checks in Flutter even when they appear
unnecessary (in order to preserve runtime behavior in weak mode), we
need to suppress these dead code hints.

Note that one assertion is removed by this PR (`heightFactor != null
|| (heightFactor == 1.0 && heightDelta == 0.0)`).  This is because
`heightFactor == 1.0 && heightDelta == 0.0` can only be true if
`heightFactor != null`, so this assertion is equivalent to simply
asserting that `heightFactor != null`, which is already asserted two
lines above.
2020-08-14 14:18:38 -07:00
Michael Goderbauer f512e86c2a
Use reportError (over onError) everywhere (#63784) 2020-08-14 12:03:18 -07:00
Michael Goderbauer 37ddad61ca
Make textfields restorable (#63401) 2020-08-14 12:02:38 -07:00
Declan Woods 03dcd1bd5a
Fix SafeArea and SliverSafeArea debug flag properties (#63455) 2020-08-14 12:01:05 -07:00
Juyeong Lee 5ec7426be7
Remove enableR8=true from gradle.properties (#63339) 2020-08-14 10:26:03 -07:00
Rami a609bb374c
Mention time picker theme in showTimePicker documentation (#63776) 2020-08-14 10:06:02 -07:00
Alexandre Ardhuin 96f3645037
migrate painting to nullsafety (#63703)
* migrate painting to nullsafety

* address review comments
2020-08-14 17:40:00 +02:00
MH Johnson bee9522f18
[Text Scaling][Material] Update BottomNavigationBar to show tooltips on long press. (#59127) 2020-08-13 22:53:27 -04:00
stuartmorgan 6f0cfc9524
Surface Windows build errors in non-verbose mode (#63707) 2020-08-13 19:46:02 -07:00
Wikiwix 88118bcbd1
Fix sort indicator for DataTables (#62795)
* Fix sort indicator for DataTables

As per material spec ascending order should be shown via an upward arrow
This commit changes the displayed arrows accordingly.

* Test sort indicator orientation in DataTable
2020-08-13 15:17:43 -07:00
Yuqian Li 3ff76f47fb
Add clipBehavior to ListView, GridView, PageView (#63147)
These widgets are missing from
https://github.com/flutter/flutter/pull/59364

With this change, developers can use clipBehavior for
https://github.com/flutter/flutter/issues/59424
2020-08-13 15:01:41 -07:00
Michael Goderbauer 39a46bedad
Remove decommission from RestorationBuckets (#63687) 2020-08-13 15:01:04 -07:00
Jonah Williams 06c3de3285
[flutter_tools] remove most globals from build system and tests (#63697)
Remove globals and testbed to simplify test cases, using the existing environment configuration. This is some pre-factoring work to make landing #63610 easier
2020-08-13 15:00:27 -07:00
renyou 32ee00849c
Revert "Fix RangeMaintainingScrollPhysics" (#63611) 2020-08-13 14:46:04 -07:00
Paul Berry 8f896c9027
Ignore another dead_code hint for a weak-only null check. (#63602) 2020-08-13 14:36:08 -07:00
Jonah Williams 9e162cb310
Revert "Add native stacktrace field for PlatformException (#63502)" (#63705)
This reverts commit c67eafa87d.
2020-08-13 14:03:11 -07:00
LI DONGZE c67eafa87d
Add native stacktrace field for PlatformException (#63502)
* Add native stacktrace field for PlatformException

* Mute the readValue check for stacktrace.

* polish

* Add unit test and further polish

* Added more comments

* remove unnecessary import

* fill in stacktrace to JSONMethodCodec and fix tests

* fix style

* Fix format

* Remove unnecessary TODO since not all explicitly declared errors have stacktrace in it from native side.

* Handle case for exception without stacktrace on jsonMethodCodec

* Add more unit tests

* format test

Co-authored-by: Ben Li <libe@google.com>
2020-08-13 11:43:50 -07:00
stuartmorgan fcbee10da9
[windows] Propagate startup errors in template (#63612) 2020-08-13 11:31:03 -07:00
Nils Reichardt 337c5cfc52
Update finders.dart (#63600) 2020-08-13 11:30:34 -07:00
Jonah Williams 2526ef1235
[flutter_tools] update size analysis (#63617) 2020-08-13 11:28:52 -07:00
Chase Latta b1a9f56487
remove fuchsia_entrypoint_shim directory (#63605) 2020-08-13 11:26:05 -07:00
Haeseok Lee 0174af8bd7
Update LinearGradient docs (#63604) 2020-08-13 11:21:04 -07:00
Rami 1de673bcda
Ensure time picker input mode lays out correctly in RTL (#63599) 2020-08-13 14:16:15 -04:00
Konstantin Scheglov bd1a58a991
Add arguments for required parameters. (#63598) 2020-08-13 08:16:33 -07:00
Shi-Hao Hong 0a7c6243fa
[gen_l10n] Absolute project path parameter (#63368) 2020-08-13 05:11:05 -07:00
Ming Lyu (CareF) 0629030a05
WidgetTester.drag with time duration (#63410) 2020-08-12 21:01:03 -07:00
Justin McCandless 441d7f3fb8
InteractiveViewer scale interpretation improvement (#63543) 2020-08-12 15:31:09 -07:00
Alexandre Ardhuin afc9509996
allow null in compute for weak mode (#63515) 2020-08-12 15:31:05 -07:00
Alexandre Ardhuin be868397be
migrate part of painting to nullsafety (#63495) 2020-08-12 15:26:09 -07:00
chunhtai 72619b8642
fix wrap intrinsic height calculation (#63420) 2020-08-12 15:21:07 -07:00
Markus Aksli 41d41b3223
Add gaplessPlayback docs default discussion (#62859) 2020-08-12 13:46:05 -07:00
Jonah Williams 04bc6123a9
[null-safety] update to several framework test cases/APIs for null assertions (#62946) 2020-08-12 13:41:09 -07:00
Jason C.H 7d1842bf4f
Deprecate iOS13 style ActivityIndicator (#62741) 2020-08-12 13:41:05 -07:00
Jenn Magder 6b2ef0df7b
Fix App.framework path in Podfile (#63412) 2020-08-12 13:36:12 -07:00
LongCatIsLooong cea055ef00
Make Scrollable's free scroll initial velocity matches that of iOS (#60501) 2020-08-12 13:31:05 -07:00
Jonah Williams 9225d8d5b7
[flutter_tools] move to fake_async, skip failing tests (#63536) 2020-08-11 19:36:05 -07:00
Jonah Williams 16df32b1eb
[flutter_tools] handle invalid yaml in plugin dependency (#63526) 2020-08-11 19:31:03 -07:00
Christopher Fujino 8dcb4c338a
Fix version parsing to use git tag --points-at (#63505) 2020-08-11 17:29:35 -07:00
Shi-Hao Hong c36b75e45b
Remove Special Handling of Norwegian Locales (#63034)
* Regenerate _no.arb and _nb.arb from scratch

* Revert no <--> nb synonym logic
2020-08-12 07:29:17 +08:00
Darren Austin eb941ce9d6
Removed the inputFormatters from the text input fields used by the Date Pickers (#63461) 2020-08-11 14:56:03 -07:00
xster df8e537f96
move compile/target sdk versions to 29 (#62799) (#63008) 2020-08-11 14:51:02 -07:00
Filip Hracek 54cdb6fc3f
Add “See also” links to favorite class API docs (#62805) 2020-08-11 14:46:04 -07:00
Greg Spencer a344fb1e2c
Update prepare_package.dart to use the process_runner package instead having duplicate code. (#62710)
Updates the prepare_package.dart script to use the process_runner package (which is where the ProcessRunner implementation was moved to).
2020-08-11 14:44:57 -07:00
Greg Spencer 54095e1b61
Make modifier key side handling consistent among platforms (#63417)
This makes the processing of RawKeyboardEventData.getModifierSide consistent among the platforms.

Before this change, some platforms (Android) didn't handle the case where the "either" flag was set, but no side flag was set (e.g. "shift" was set, but not "shift left"), and instead said that no keys were down by returning null (which was wrong).

Some platforms (Linux, Windows) also returned KeyboardSide.any from getModifierSide, when the contract says that it will never return KeyboardSide.any. Those methods now return KeyboardSide.all in the case where no side is specified, as macOS and Fuchsia already did.

Now, all platforms will return KeyboardSide.all from getModifierSide when it's not clear which side the key was on.
2020-08-11 14:44:40 -07:00
Jonah Williams 49fac9a885
[flutter_tools] add more error context to tree shaker failure (#63446) 2020-08-11 11:44:03 -07:00
Jonah Williams c86d090e6f
[flutter_tools] add --null-assertions flag for debugging with null safety (#63416) 2020-08-11 11:36:03 -07:00
guolinaileen cbe0999d1f
Introduce onAppPrivateCommand to TextField (#62712) 2020-08-11 11:31:02 -07:00
Pragya 8c795e3e07
Updated Row API doc for RTL in textDirection (#61323) 2020-08-11 10:06:03 -07:00
Michael Goderbauer 7dfb997e41
Add dispose to restoration example (#63497) 2020-08-11 10:04:33 -07:00
Greg Spencer 0ec0bf505e
Make RawKeyboard assert when no keys are in keysPressed when sending a key down event. (#63426)
This adds an assert in RawKeyboard that catches the case where it tries to send a key down event, but (after synchronizing modifiers) there are no keys in keysPressed. This state can occur if the modifier flags are not set properly for the platform.

Also prevents shortcuts attempting to handle a key down when no keys are pressed at the moment (which was causing a crash in release mode).
2020-08-11 09:37:30 -07:00
Ian Hickson e3c7fb5bef
Fix RangeMaintainingScrollPhysics (#63146)
It now uses the scroll metrics as they stood at the end of the last frame.

It previously used a weird combination of the old extents and the newish position, which led to some weird effects when the position had been changed in expectation of a viewport or content dimension change.
2020-08-11 08:59:20 -07:00
Rami fafeb6c647
Ensure cupertino time picker positions hours and minutes correctly for RTL (#63405) 2020-08-11 10:35:16 -04:00
Alexandre Ardhuin e8c942104b
migrate part of painting to nullsafety (#62951) 2020-08-11 07:16:03 -07:00
Ming Lyu (CareF) b09dee59bf
add FrameTimingSummarizer (#63434) 2020-08-11 06:21:04 -07:00
Paul Berry a4254c788f
Ignore dead_code hints for weak-only null checks. (#63007)
* Ignore dead_code hints for weak-only null checks.

When https://github.com/dart-lang/sdk/issues/41985 is fixed, the
analyzer will begin detecting dead code due to "unnecessary" null
checks.  Since we want to retain null checks in Flutter even when they
appear unnecessary (in order to preserve runtime behavior in weak
mode), we need to suppress these dead code hints.

* Add comments explaining why we're ignoring dead_code hints
2020-08-11 06:18:39 -07:00
Ian Hickson d7883e3fb0
Clean up some test formatting and comments (#63306) 2020-08-11 06:16:03 -07:00
Ming Lyu (CareF) 2965d81ae9
update for WidgetTester.move and WidgetTester.fling doc (#63390) 2020-08-10 21:21:03 -07:00
Rustom Ichhaporia 111f76b6a4
Small documentation typo fix (#63313) 2020-08-10 21:16:03 -07:00
Panmari 9542a47e44
Fixing code snippet example for meetsGuideline. (#63273) 2020-08-10 21:11:04 -07:00
James D. Lin ec58182b3b
[flutter tools] Make SizeAnalyzer support .apk files that don't use libapp.so (#63250) 2020-08-10 21:06:05 -07:00
Michael Goderbauer 25de941927
Make Scrollables restorable (#63131) 2020-08-10 21:01:10 -07:00
Jonah Williams f4e442fe80
Revert "Add native stacktrace field for PlatformException (#62828)" (#63431)
This reverts commit 74b5051cd6.
2020-08-10 15:16:29 -07:00
LI DONGZE 74b5051cd6
Add native stacktrace field for PlatformException (#62828)
* Add native stacktrace field for PlatformException

* Mute the readValue check for stacktrace.

* polish

* Add unit test and further polish

* Added more comments

* remove unnecessary import

* fill in stacktrace to JSONMethodCodec and fix tests

Co-authored-by: Ben Li <libe@google.com>
2020-08-10 13:29:58 -07:00
Ian Hickson a49ba95af8
Some minor improvements to the AsyncSnapshot API (#63347) 2020-08-10 11:11:02 -07:00
Ming Lyu (CareF) fb544659a7
update for frametiming (#62933) 2020-08-10 10:56:03 -07:00
Michael Klimushyn cb69bbb4d5
Remove unused l and --isolate-filter tools (#63336) 2020-08-10 10:51:04 -07:00
xubaolin ba92cbedd8
fix SingleChildScrollView clip bug (#63054) 2020-08-10 10:46:04 -07:00
Hans Muller 94319c7a62
Fixed an ElevatedButton API doc typo (#63396) 2020-08-10 10:43:55 -07:00
Hans Muller 4500a451dc
Enable InkWell to sync its hovered state when its enabled or disabled (#62913) 2020-08-08 18:21:45 -07:00
Hans Muller e86caf7a08
Updated use of OutlineButton in FocusTraversalPolicy API doc (#63236) 2020-08-08 18:21:25 -07:00
Hans Muller 73ce3f21d0
Updated old button references in packages/flutter_test (#63230) 2020-08-08 18:20:53 -07:00
Ian Hickson 5d91d0484c
Unskip a widget inspector test that doesn't seem flaky anymore. (#62824) 2020-08-08 15:31:04 -07:00
creativecreatorormaybenot 96b6aafb49
Add onTertiaryTap* to TapGestureRecognizer and GestureDetector (#62788) 2020-08-08 15:21:02 -07:00
Phil Quitslund 58ec73fad4
API doc additions (#63194) 2020-08-07 21:31:04 -07:00
Adam Bahr 5cf3c8728c
Update "shortcut icon" to "icon" (#63154) 2020-08-07 21:26:03 -07:00
chunhtai 58e839223d
reland fix intrinsic height and width for widget span #61485 (#63118) 2020-08-07 21:01:03 -07:00
Jonah Williams c2e85e67c9
[null-safety] remove more usage of mockito from the framework tests (#62936) 2020-08-07 20:31:08 -07:00
Pragya 191c7cbe0b
Updated dataTable API doc to explicitly point sorting (#61356) 2020-08-07 20:31:05 -07:00
chunhtai f9fd71bc78
Implement Router widget and widgets app api (#60299) 2020-08-07 20:26:05 -07:00
Pascal Welsch 12b8d9db80
Reduce iOS scroll damping for lists with differently sized items (#59623) 2020-08-07 20:21:07 -07:00
Ian Hickson 77b4505c80
Fix a crash when disposing tabs (#63142) 2020-08-06 18:51:02 -07:00
John Ryan c7e63113b2
Fix grammar in Route doc comment (#63132) 2020-08-06 16:26:04 -07:00
Ming Lyu (CareF) 99ea866247
update packages (#63017) 2020-08-06 16:21:05 -07:00
Nolan Scobie 43c1b34cf5
Add punctuation for unterminated sentences in doc comments (#62755)
* Add punctuation for unterminated sentences in doc comments

* Addressing review nit
2020-08-06 19:18:52 -04:00
chunhtai 3af97d228c
Fix the flexible space bar to still create a rendering object even if… (#62690) 2020-08-06 16:16:15 -07:00
Kate Lovett 79146fd0a6
Fix SliverList scrollOffsetCorrection 0 case (#62615) 2020-08-06 16:11:16 -07:00
Ayaan Khan 4680ff3a79
fix: MaterialColor Swatch Map comparison (#61974) 2020-08-06 16:06:10 -07:00
Hans Muller 050b0302a7
Fixed a typo in the DataRow API doc (#63094) 2020-08-06 13:54:56 -07:00
Ming Lyu (CareF) 033d138078
using named constructor to FrameTiming (#63030) 2020-08-06 13:51:04 -07:00
Jenn Magder 0aafdf9aa9
Change minimum iOS version from 8.0 to 9.0 (#62902) 2020-08-06 13:46:15 -07:00
Norbert Kozsir 848cb83b83
Make _isLocalCreationLocation public (#62891) 2020-08-06 09:06:07 -07:00
Alexandre Ardhuin c54b15b6b2
unnecessary null check (#63083) 2020-08-06 18:05:36 +02:00
Alexandre Ardhuin 18ed041d18
handler can be null in platform_channel (#63057) 2020-08-06 18:05:21 +02:00
Darren Austin e9117c1902
Updated tests to use new button classes. (#63040) 2020-08-06 08:15:25 -07:00
Hans Muller f3b1e31c1e
Remove old button references from the Stepper widget (#63012) 2020-08-05 19:41:41 -07:00
Shi-Hao Hong bd3a4cc517
Update to the latest localizations (#63026) 2020-08-05 19:41:04 -07:00
Justin McCandless d69ddc47f3
Incomplete app widget error (#63005) 2020-08-05 19:31:03 -07:00
stuartmorgan f534d6e669
Add flutter_engine.cc to Windows wrapper build (#62999) 2020-08-05 19:26:05 -07:00
Ian Hickson 522d19e2ad
Unskip the bidi semantics test. (#62823) 2020-08-05 19:21:11 -07:00
Mouad Debbar d13b56a0cd
Don't move to word edge when tapping with a mouse (#60177) 2020-08-05 19:16:06 -07:00
Hans Muller 6338181428
Remove old button references from routes_test (#63013) 2020-08-05 15:26:10 -07:00
creativecreatorormaybenot b631013a87
Fix GestureDetector long press callback handling (#62897)
* Allow GestureDetector to use long press and secondary long press at the same time.
2020-08-05 15:22:41 -07:00
Chris Yang c9cd825fca
[flutter_tools] flutter version reports picks up release versions (#63019) 2020-08-05 15:20:27 -07:00
xubaolin ca660aad09
fix some comments for clipBehavior's default value (#62954) 2020-08-05 15:16:24 -07:00
Jonah Williams 762d9f7f4e
[flutter_tools] warn when main library is relocated (#62930) 2020-08-05 15:11:15 -07:00
Ian Hickson ef62463e9c
Update link to bug (#62893) 2020-08-05 15:06:24 -07:00
Ian Hickson 8ad4da4a4e
There's a bug filed about this now, so update comment. (#62892) 2020-08-05 15:01:21 -07:00
Marcus Tomlinson 145df39953
Explicitly find and link blkid using pkg-config (#62979) 2020-08-05 14:56:19 -07:00
Ian Hickson 2939c209aa
Update error message for bad UTF-8 decoding (#62888) 2020-08-05 14:56:14 -07:00
includecmath 3c12279f50
[widgets] Refactor Overlay insert methods entries assert (#62407) 2020-08-05 14:46:51 -07:00
Alexandre Ardhuin f724ec028f
non-nullable LicenseEntry.packages (#62972) 2020-08-05 18:34:54 +02:00
Ayush Bherwani 263de65f48
[ExpansionPanelList] adds elevation property (#62840) 2020-08-05 09:26:04 -07:00
Jonah Williams 6393c5b2c3
[flutter_tools] remove reference to flutter tool test from user generated gitignores (#62926) 2020-08-04 19:06:04 -07:00
Ian Hickson b045c14eb5
Make the Skia expectation parser more resilient and update to "master_str". (#62898) 2020-08-04 18:53:31 -07:00
Ming Lyu (CareF) 8081455394
revert widgettester breaking change (#62914) 2020-08-04 17:26:05 -07:00
Jonah Williams 732083018c
[null-safety] remove mockito from text control a11y test (#62869) 2020-08-04 16:56:03 -07:00
Darren Austin bebc119ce5
TextSelectionTheme support (step 1 of 3) (#62014)
Create a new TextSelectionTheme for text selection properties.
2020-08-04 16:06:28 -07:00
Michael Goderbauer 3b887bec47
Reland "migrate part of painting to nullsafety (#62696)" (#62872) 2020-08-04 16:06:04 -07:00
Jonah Williams 428be90768
[null-safety] revert export of Fake from test_api (#62894) 2020-08-04 14:31:05 -07:00
Jonah Williams 9be31e26ef
[null-safety] remove quiver from flutter tests (#62866) 2020-08-04 14:26:04 -07:00
Ian Hickson 18e2c16718
Update skipped test comment to point to an open bug (#62820) 2020-08-04 13:41:05 -07:00
Jason Simmons 3ed6b206d2
Fix text escaping in the AboutListTile sample code (#62707) 2020-08-04 13:36:05 -07:00
Ian Hickson 4a4e9bad84
Enable a scrolling fling test. (#62825) 2020-08-04 12:46:07 -07:00
LongCatIsLooong 3bc3ea51ed
longestLine layout width (#62657) 2020-08-04 12:43:17 -07:00
Rami f29f05ed17
Address misc time picker design issues (#62803) 2020-08-04 12:41:05 -07:00
Juyeong Lee 8497496838
Upadte systemNavigationBarIconBrightness docs (#62729) 2020-08-04 12:36:04 -07:00
Chris Yang 2459f5c513
plugin template min flutter sdk version to 1.20 (#62605) 2020-08-04 12:31:05 -07:00
Jonah Williams e8ad863a08
Revert "move compile/target sdk versions to 29 (#62799)" (#62884)
This reverts commit 5b3dc5251b.
2020-08-04 11:20:16 -07:00
Michael Goderbauer 4c7fae93aa
Revert "migrate part of painting to nullsafety (#62696)" (#62868)
This reverts commit 4518a72ffd.
2020-08-04 10:44:43 -07:00