Commit graph

91 commits

Author SHA1 Message Date
Alexandre Ardhuin 71c1f6c3e4
enable lint unnecessary_nullable_for_final_variable_declarations (#66387) 2020-09-23 06:39:47 +02:00
Ian Hickson 8a6a76a334
migrate rendering to nullsafety (#64621) 2020-08-27 16:38:10 -07:00
Christopher Fujino 5cfb16b193
Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59876)
This relands #59120, which was reverted in #59870.
2020-06-19 12:03:38 -07:00
Christopher Fujino 0d7ff7a9e7
Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59870)
This reverts commit 8665e13801.
2020-06-19 10:52:52 -07:00
Ian Hickson 8665e13801
Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120) 2020-06-18 18:08:01 -07:00
Alexandre Ardhuin f5a9902577
enable avoid_equals_and_hash_code_on_mutable_classes (#52507) 2020-04-06 13:36:01 -07:00
Alexandre Ardhuin c2ae654ddf
enable avoid_single_cascade_in_expression_statements (#51944) 2020-03-05 08:03:26 +01:00
Alexandre Ardhuin 0bd45bc222
update lint list + enable unnecessary_string_interpolations (#50593) 2020-02-14 09:43:52 +01:00
Ian Hickson e2b169ebd3 Apply void_checks lint. (#48267) 2020-01-13 10:03:01 -08:00
Alexandre Ardhuin a541934125 enable lint prefer_for_elements_to_map_fromIterable (#47726) 2020-01-08 08:03:02 -08:00
Alexandre Ardhuin 4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Alexandre Ardhuin 4adad2c652
update list of lints (#47661) 2019-12-23 18:40:56 +01:00
Alexandre Ardhuin 78db965642 Reland implicit-casts: false (#47431) 2019-12-19 02:23:01 -08:00
Lau Ching Jun a4858782da
Revert "implicit-casts: false (#47199)" (#47428)
This reverts commit c235998acf.
2019-12-18 23:53:00 -08:00
Alexandre Ardhuin c235998acf implicit-casts: false (#47199) 2019-12-18 23:23:01 -08:00
Alexandre Ardhuin e6935efdf6
remove avoid_as lint for the upcoming implicit-casts: false (#45527) 2019-11-25 21:03:29 +01:00
Shi-Hao Hong 3e4bf5757d
Update Stocks example using i18n tool (#44223)
* Use l10n tool to generate stocks i18n files

* Rename *_en_EN.arb to *_en_US.arb

* Fix l10n script
2019-11-06 12:52:03 -08:00
Alexandre Ardhuin df4bf453ab
more UI-as-code (#35516) 2019-09-17 16:23:44 +02:00
Alexandre Ardhuin b041a589c8
enable lint prefer_if_null_operators (#35745) 2019-07-09 10:53:35 +02:00
Alexandre Ardhuin 919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds (#35189) 2019-06-27 21:23:16 +02:00
Alexandre Ardhuin b5ce06163c
enable lint use_full_hex_values_for_flutter_colors (#35056) 2019-06-25 17:58:19 +02:00
Alexandre Ardhuin fecf99ff1e
enable lint avoid_bool_literals_in_conditional_expressions (#35055) 2019-06-25 17:40:05 +02:00
Alexandre Ardhuin 9a3a7490c8
sync lint list (#35017) 2019-06-25 15:59:15 +02:00
Alexandre Ardhuin c0125cb44a
fix bad lint commented out (#33026) 2019-05-20 17:00:45 +02:00
Alexandre Ardhuin 4fa32df141
use null aware operators (#32711)
* use null aware operators

* rollback changes about null-aware operator

* disable lint prefer_is_not_empty
2019-05-16 22:25:51 +02:00
Alexandre Ardhuin 41b9abdc32
enable lint prefer_null_aware_operators (#32686) 2019-05-14 22:34:49 +02:00
Dan Field fe9512fa72
Re-enable const (#31600)
* Re-enable const
2019-04-29 16:02:42 -07:00
Dan Field 06e1f8fc15
Roll engine to 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06 (#31569)
* Manual roll with updated test
2019-04-24 17:20:02 -07:00
Phil Quitslund 802eca29d2
set literal conversions (#27811) 2019-03-06 11:05:16 -08:00
Jason Simmons b6996ef326 Disable prefer_collection_literals in the analyzer until we can update to using set literals (#28024) 2019-02-15 15:54:16 -08:00
Phil Quitslund 9e3a0d30c9
remove super_goes_last (#27690)
In Dart 2, it is a compile-time error if a superinitializer
appears in an initializer list at any other position than at the end so this
rule is made redundant by the Dart analyzer's basic checks and is no longer
necessary.
2019-02-08 13:46:01 -08:00
Dan Field 8af3e480a9
Revert "move analysis_options to package" (#26436)
* Revert "move analysis_options to package (#26244)"

This reverts commit d4d1b29a35.
2019-01-11 13:38:02 -08:00
Dan Field d4d1b29a35
move analysis_options to package (#26244)
* move analysis_options to package
2019-01-10 18:53:01 -08:00
Alexandre Ardhuin 3a37b9e0f5
update lint list (#25922) 2019-01-06 21:07:41 +01:00
Siva b1109226d8
Address code review comment. (#25995) 2019-01-03 10:55:50 -08:00
Alexander Aprelev fe1a51ab89
Flutter engine roll with dart roll (#25815) 2018-12-27 14:55:07 -08:00
Paul Berry 280bbefd29
Remove deprecated lint "prefer_bool_in_asserts". (#24890)
In Dart 2, asserts no longer accept non-bool values so this rule is
made redundant by the Dart analyzer's basic checks and is no longer
necessary.

The rule will be removed in a future Linter release.
2018-12-10 13:43:02 -08:00
Alexandre Ardhuin 79b5e5bc8a
Add missing lints (#24381)
* update lint list

* enable sort_pub_dependencies

* enable avoid_returning_null_for_void

* enable flutter_style_todos
2018-11-19 10:37:55 +01:00
Yegor 3fbd140e77
Use new mixin syntax for super-mixins (#22870)
This re-lands 3c56e6c on top of a new Dart SDK that contains new mixin syntax fixes.
2018-10-17 13:10:05 -07:00
Alexandre Ardhuin 936dea28da
enable lint prefer_void_to_null (#23174)
* enable lint prefer_void_to_null

* replace last Null by void
2018-10-17 08:09:29 +02:00
Yegor 3184b7cb66
Revert "Use mixin syntax for Flutter's super-mixins (#22435)" (#22748)
This reverts commit 3c56e6c77d.

It breaks the AOT build.
2018-10-05 15:09:38 -07:00
Yegor 3c56e6c77d
Use mixin syntax for Flutter's super-mixins (#22435)
* first pass

* revert WidgetsBindingObserver

* disable prefer_mixin

* docs and more mixins

* newer engine; binding fixes

* upgrade dependencies

* fix test binding

* remove whitespace

* remove the obsolete `enableSuperMixins: true`

* upgrade dartdoc to 0.22.0

* temporarily use git version of dartdoc

* fix pub global activate syntax

* use dartdoc 0.23.0
2018-10-05 14:54:41 -07:00
Alexandre Ardhuin a07d3719a1
enable lint prefer_generic_function_type_aliases (#21680) 2018-09-14 21:06:19 +02:00
Alexandre Ardhuin d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Alexandre Ardhuin 774ca2f197
enable lint avoid_void_async (#21652) 2018-09-11 07:14:04 +02:00
Alexandre Ardhuin bd1e5a361b
add missing lints (#21620) 2018-09-10 10:27:01 +02:00
Ian Hickson 53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00
Ian Hickson b7261586e5
Audit TODO syntax (#20837)
Fixes the pattern for some TODOs to match our style guide.

(Also, a couple of minor code order fixes.)
2018-08-21 14:02:11 -07:00
Ian Hickson ad1eaff45a
flutter analyze cleanup (#20490)
* `flutter analyze` cleanup

* Make `--dartdocs` work in all modes.
* Make `analyze-sample-code.dart` more resilient.
* Add a test for `analyze-sample-code.dart`.
* Minor cleanup in related code and files.

* Apply review comments

* Fix tests
2018-08-20 12:51:07 -07:00
Ian Hickson 8c79f40d71
Fixes resulting from audit of issues links (#20772)
* Fixes resulting from audit of issues links

I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.

* Update run_test.dart

skip this test again since it failed on linux and macos bots
2018-08-18 16:44:39 -07:00