Commit graph

1928 commits

Author SHA1 Message Date
Dan Field 0f705b7e25
fix new test (#47010) 2019-12-13 14:21:38 -08:00
Jim Graham fa190a8685
New benchmark to measure performance of animations after removing a BackdropFilter. (#46924) 2019-12-13 13:27:53 -08:00
Shi-Hao Hong e7fec2bc33
Add helpful message about how to use localizationsDelegates list (#46250) 2019-12-13 12:00:35 -08:00
Shi-Hao Hong 2eed59c1d5
Add gen_l10n sorting tests (#46247)
* Add tests for sorting arbPathString, supportedLocales and supportedLanguageCodes alphabetically

* Plural arbPathStrings

* Factor out singleZhMessageArbFileString

* Make translations more accurate and generic
2019-12-13 10:03:56 -08:00
Jenn Magder dfa6eb31a0
Revert "flutter run FULL_PRODUCT_NAME (#46838)" (#46925) 2019-12-12 17:34:54 -08:00
Jenn Magder 7a7e2bb247 flutter run FULL_PRODUCT_NAME (#46838) 2019-12-12 17:03:01 -08:00
Sean Freiburg 418b814555 Add buildNumber param to "flutter build aar" command (#46291) 2019-12-12 10:28:01 -08:00
Jonah Williams 78951b0c01
[benchmarks] Add time to development benchmark for Android (#46717) 2019-12-10 15:03:06 -08:00
Jonah Williams dfcd6568e8
re-enable build runner tooling tests (#46708) 2019-12-10 13:10:09 -08:00
Chris Yang 4a0049627f
Reland "Add a FlutterDriver screenshot test to device lab. #45411" (#46620) 2019-12-10 12:43:36 -08:00
Jonah Williams bda9d90804
[flutter_tool] Reland: support --fast-start for Android applications (as an opt-in) (#46140) 2019-12-10 10:26:14 -08:00
Jonah Williams 523ac7b6f5
[flutter_tool] Always re-copy Framework/podspec when regenerating iOS module project (#45877) 2019-12-09 21:18:09 -08:00
Ian Hickson 14145a4ec9 Try re-enabling all these tests. (#46615) 2019-12-09 18:58:02 -08:00
liyuqian 69728097bd Remove unused observer and raise the waiting time (#46626) 2019-12-09 15:18:02 -08:00
Ian Hickson 05862ff968 Fix platform-specif test logic. (#46623) 2019-12-09 12:58:03 -08:00
Todd Volkert 55f0bdc033
Fix docker tag during upload as well (#46252)
In https://github.com/flutter/flutter/pull/46035, we fixed the docker
tag to be a legal tag during build.  This PR makes the corresponding
change to the tag during upload.  Without this, we build the right tag,
but then we try to upload the wrong tag.
2019-12-09 12:56:47 -08:00
Emmanuel Garcia f264d6c277
Allow plugins that don't support the Android platform (#46282) 2019-12-08 20:04:19 -08:00
Jenn Magder e58dc16d7b
Revert "Add a FlutterDriver screenshot test to device lab. (#45411)" (#46281)
This reverts commit adec6977be.
2019-12-06 18:21:52 -08:00
Lau Ching Jun c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Chris Yang adec6977be
Add a FlutterDriver screenshot test to device lab. (#45411) 2019-12-06 14:17:02 -08:00
Shi-Hao Hong 37e66b2179
gen_l10n.dart tool testing (#44856)
* Add tests to gen_l10n.dart tool

* Separate out LocalizationsGenerator class to improve testability of code

* Add testing dependencies to dev/tools

* Integrate dev/tools testing to flutter CI

* Restructure dev/tools folder for testing

* Fix license headers
2019-12-06 11:35:08 -08:00
Jonah Williams 7f235ea8bc
Mitigation for current tool test skips on CI (#46181) 2019-12-05 23:16:25 -08:00
liyuqian a2005eaf9a Memory test on scrolling large images quickly (#46184) 2019-12-05 19:28:00 -08:00
Greg Spencer bc7ed36db5
Add visualDensity to checkbox, radio, icon button, and chip. (#46091)
This adds a visualDensity attribute to checkbox, radio, icon button, and chip.
2019-12-05 17:36:42 -08:00
Alexandre Ardhuin ec1a015045
implicit-casts:false in dev (#45787) 2019-12-05 22:34:06 +01:00
Jenn Magder fb69a393b8
Add bitcode and architectures to App.framework build ios framework command (#46130) 2019-12-05 12:16:54 -08:00
Jenn Magder d01de941b9
Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138)
This reverts commit 2a113165c0.
2019-12-04 18:12:57 -08:00
Jonah Williams 2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
godofredoc 1657075914
Move technical_debt_cost to use a cloud vm. (#45996) 2019-12-04 16:26:41 -08:00
Greg Spencer 09927b94c3
Add a VisualDensity manual test (#46083)
Adds a manual test that allows testing of density for buttons. Also updates some of the button tests to be somewhat simpler and to test the child positions in the test to make sure they are consistent.
2019-12-04 10:48:06 -08:00
Janice Collins 50c8e6b2d6
Update dartdoc to 0.29.2. (#46014) 2019-12-04 09:59:16 -08:00
Todd Volkert 066a992a5c
Ensure that docker tag is legal (#46035) 2019-12-03 19:53:39 -08:00
Jonah Williams 0b2bf99491
Reland: Update macOS configuration settings (#45966) 2019-12-03 08:13:08 -08:00
godofredoc 4c4cdbfc2b
Move dartdocs to devicelab vm. (#45952)
We added support linux VMs to devicelab and we will be moving some of
the machine independent benchmarks there.
2019-12-02 19:45:04 -08:00
Kate Lovett 2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00
Dan Field 088fa24463
Set the LANG when invoking cocoapods (#45710) 2019-12-02 13:26:32 -08:00
Ian Hickson a78fb87dfe
Relicense Shrine demo to match rest of repository (#45718)
* Relicense Shrine demo to match rest of repository

The Shrine demo was Apache-licensed. The code was mostly
Google-written, with contributions from:

 - Michelle Dudley (@michdud)

 - Abhijeeth Padarthi <rkinabhi@gmail.com> (@rkinabhi)

 - @a14n

I contacted all three, and they confirmed their approval for this
change, as described below.

Abhijeeth Padarthi said by e-mail on Thu, Nov 21, 2019 at 5:48 PM:

> hi Ian,
>
> sure :)
>
> let me know if I need to do anything on my end..

Michelle Dudley wrote by e-mail on Sun, Nov 24, 2019 at 2:07 PM:

> Hi Ian,
>
> That would be ok with me.
>
> Thanks,
>
> Michelle

@a14n said on Discord's Flutter server in the #hackers channel at 10:44PM on Thursday, November 21, 2019:

> @Hixie no problem I agree with this relicensing

* Remove shrine loophole from license checker.
2019-11-27 16:25:56 -08:00
Ian Hickson 449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Kaushik Iska d1805aa22a
update-packages after dwds updates (#45633) 2019-11-26 18:34:06 -08:00
Greg Spencer 245d1b51ce
Add macOS to TargetPlatform (#43457)
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
2019-11-26 18:32:34 -08:00
Emmanuel Garcia 943f98d3c3
Add integration test for transitive plugin dependencies (#45579) 2019-11-26 08:58:43 -08:00
Todd Volkert bae92c32e5
Disable tests that fail on non-master branches from running on those branches (#45455)
https://github.com/flutter/flutter/issues/45453
2019-11-24 22:29:28 -08:00
Emmanuel Garcia b6e92003c8
Add .flutter-plugins-dependencies to the project, which contains the app's plugin dependency graph (#45379) 2019-11-22 15:02:20 -08:00
Greg Spencer a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Alexandre Ardhuin fcb40a05bb
make some BuildContext methods generics (#44189)
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic

* make BuildContext.inheritFromWidgetOfExactType generic

* make BuildContext.ancestorInheritedElementForWidgetOfExactType generic

* make BuildContext.ancestorWidgetOfExactType generic

* fix snippet

* bump scoped_model on temp version

* update names

* Revert "bump scoped_model on temp version"

This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0.

* address review comments

* fix ci

* address review comments

* repeat the deprecation notice

* fix uppercase

* use of recommanded deprecation syntax

* address review comment
2019-11-22 17:35:20 +01:00
liyuqian c61ef90f94
Upgrade gauge for debugging (#45212)
For https://github.com/flutter/flutter/issues/45194
and see also https://github.com/flutter/packages/pull/47.
2019-11-21 13:03:02 -08:00
Christopher Fujino 45953a12bb dev/ci/README.md update (#44010) 2019-11-21 12:09:02 -08:00
sjindel-google 43a8a1902e
Fix erroneous comments referring to blobs snapshots. (#41378) 2019-11-21 12:09:43 +01:00
Sangmin Lee 60c7cc25e9 Fix typo in README.md (#43173) 2019-11-20 16:14:10 -08:00
Michael Goderbauer f8cafd9dbc
Remove URLs in deprecation annotation (#45215) 2019-11-20 12:45:04 -08:00
Jonah Williams 0e36a91d18
Add macOS hot reload test (#45264) 2019-11-20 12:35:53 -08:00
Danny Tuppeny 927fbe5500
Re-enable asserts on Windows integration tests (#42637)
* Enable asserts

See https://github.com/flutter/flutter/issues/36476

* Remove comment
2019-11-20 17:50:37 +00:00
Jonah Williams f20471d081 Revert "reland add lifecycle enum and fix the scheduleforcedframe (#45133)" (#45260)
This reverts commit 99324105da.

It was implicated in https://github.com/flutter/flutter/issues/45258
2019-11-20 09:43:15 -08:00
liyuqian a32fc986f3
Add a perf test for picture raster cache (#45050)
This will catch issues like
https://github.com/flutter/flutter/issues/44252, and this test is
inspired by the `list_demo` sample app in
https://github.com/flutter/flutter/issues/43083#issue-509586473

This is tested locally on a Moto G4 before and after the fix
https://github.com/flutter/engine/pull/13710

The `average_frame_rasterizer_time_millis` of this test drops from
~5.4ms to ~4.9ms after that fix.
2019-11-19 15:48:41 -08:00
chunhtai 99324105da
reland add lifecycle enum and fix the scheduleforcedframe (#45133)
* reland add lifecycle enum and fix the scheduleforcedframe
2019-11-19 15:45:37 -08:00
Greg Spencer a3186fbaa1
Analyze dartpad (#45124)
This fixes the sample code analysis to treat dartpad snippets in the same way as snippet snippets, which it wasn't until now (the snippet generator was treating them as "samples"), and some errors crept in. This PR also fixes those errors.

Also, added a --verbose option to the sample analyzer.
2019-11-19 15:16:12 -08:00
Greg Spencer 29ab6b549a
Update manual_tests to be able to run on macOS/web (#44830)
I updated the build files for manual_tests, as well as adding in a macos and web directory to allow the manual tests to be run on the web or on desktop.

The main change here are the parts that I added to the files in manual_tests/lib/... (the addition of kIsWeb to "if (!kIsWeb && Platform.isMacOS) {") The rest is just an update of the auto-generated code from flutter create.
2019-11-19 11:29:35 -08:00
Jonah Williams df3505c1f3
Improve performance of build APK (~50%) by running gen_snapshot concurrently (#44534) 2019-11-19 11:26:07 -08:00
Jenn Magder 6e5769d425
Remove FLUTTER_DEVICELAB_XCODE_PROVISIONING_CONFIG code paths (#45136) 2019-11-19 11:19:44 -08:00
Per Classon b5a85fcf48
Allow plural localized strings to not specify every case (#45168)
* Allow plural localized strings to not specify every case
2019-11-19 18:58:28 +01:00
chunhtai 7e1920b817
revert added lifecycle enum (#45119) 2019-11-18 13:38:47 -08:00
chunhtai 439d798712
fix ios_add2app_life_cycle license (#45115) 2019-11-18 11:33:42 -08:00
chunhtai af48f71497
reland add new enum change (#45012)
This reverts commit 75f310791f.
2019-11-18 10:04:09 -08:00
Ian Hickson 62e4ab87b3
Update our deprecation style. (#44618) 2019-11-15 19:21:53 -08:00
Kate Lovett 7aa5b07537
Adding flutter_goldens package tests (#44479) 2019-11-15 10:29:19 -08:00
Greg Spencer dcc4b82540
Fix snippets to include element ID in the output sample. (#44787)
This fixes the snippet code output so that it includes the name of the element that it is a snippet for in the first line.
2019-11-15 10:23:04 -08:00
Kaushik Iska 75f310791f Revert "reland add new enum change (#44281) (#44487)" (#44947)
This reverts commit f0794917fc.
2019-11-14 16:49:43 -08:00
chunhtai f0794917fc
reland add new enum change (#44281) (#44487)
* reland add new enum change (#44281)

This reverts commit ed82bb821c.
2019-11-14 13:27:38 -08:00
Ian Hickson eae05c7daf
Test framework for analyze.dart (#44772)
* Prepare analyze.dart for testing.

* Reorder the file for easier understanding

* Add a test for analyze.dart

* Fix review comments
2019-11-14 13:19:40 -08:00
Jonah Williams e77c24ef91
Update package test (#44882) 2019-11-14 09:31:36 -08:00
Ian Hickson 66821916dc
More license header fixes (#44776) 2019-11-13 13:17:22 -08:00
Shi-Hao Hong a872a701c3
Canonicalize locale string in gen_l10n.dart (#44758)
* Canonicalize locale string for gen_l10n.dart script

* Refresh stocks example to use canonicalized locale
2019-11-13 10:15:24 -08:00
Shi-Hao Hong 0d348138aa
Sort locales and method/properties/getters alphabetically (#44761)
* Sort locales and method/properties/getters alphabetically

* Refresh stocks example to show proper sorting
2019-11-13 10:14:53 -08:00
Jenn Magder 2d42b43a50
Turn on bitcode for integration tests and add-to-app templates (#44633) 2019-11-12 18:00:31 -08:00
Jonah Williams 9acf10541b
disable chrome devicelab test (#44746) 2019-11-12 15:25:08 -08:00
Jonah Williams a901b650b6
Update meta to 1.1.8 (#44584) 2019-11-12 13:48:42 -08:00
Shi-Hao Hong 2b498567a4
Sort Localization generation output (#44743)
* Sort Localization generation output

- When creating locales that were assumed from existing locales, the
file that is used is non-deterministic. This adds a sort to the iterator
to ensure that the same existing locale is used to generate the assumed
locale
- When generating material, cupertino and date localizations, the generated getters were not sorted. This
introduces an alphabetic sort

* remove main.dart.snapshot
2019-11-12 12:50:51 -08:00
Shi-Hao Hong 159a47da64
l10n tool improvements, stocks app i18n refresh (#44473)
* Add check for placeholders being an empty map

* Remove unnecessary properties from en_ES.arb in the stocks example

* Use getter instead of methods in the stocks example

* Fixed "annotating types for function expression parameters" lint issue from generated localizations delegate code
2019-11-11 14:42:29 -08:00
Janice Collins cf08a995f6
Update dartdoc to 0.29.1 (#44466) 2019-11-11 13:23:05 -08:00
Shi-Hao Hong e7d78b69a1
Use raw string for l10n description (#44451)
* Use raw string for l10n description

* Stock app refresh
2019-11-08 19:34:37 -08:00
Jenn Magder 856a90e67c
Add swift_versions to plugin template podspec, include default CocoaPod version (#44324) 2019-11-08 18:00:01 -08:00
Ian Hickson 1ce4a4f36f
Make sure all our .dart files have license headers (#44467) 2019-11-08 16:53:21 -08:00
Greg Spencer c921c5ae67
Add macOS fn key support. (#44410)
This adds support for the fn key on macOS. It adds it to the key mappings as a supplemental mapping that overwrites the one from the Chrome headers, since the chrome headers have a TODO, but no implementation of the key.

Also, ignore the fn key entirely on macOS. This is because On macOS laptop keyboards, the fn key is used to generate home/end and f1-f12, but it ALSO generates a separate down/up event for the fn key itself. Other platforms hide the fn key, and just produce the key that it is combined with, so to keep it possible to write cross platform code that looks at which keys are pressed, the fn key is ignored.
2019-11-08 16:30:38 -08:00
Collin Jackson 03ac37af08
Re-enable docs uploading (#44454)
* Revert "Turn off docs upload temporarily (#44365) (#44413)"

This reverts commit 8f2ea9d0e9.

* Re enables docs upload
2019-11-08 12:47:26 -08:00
Jonah Williams eeb88f4385
Revert "Demonstrate that artifact invalidation works (#44312)" (#44463)
This reverts commit c1d029b84f.
2019-11-08 12:44:24 -08:00
Jonah Williams 69a783b806
switch web test to macOS (#44421) 2019-11-08 12:43:08 -08:00
Jonah Williams 978fada33c
Refactor flutter.gradle to use assemble directly (#43876)
Removes multiple re-entrant calls of bundle and aot and replaces them with a single call to assemble. This restores full caching and will allow follow-up performance improvements when building multiple ABIs
2019-11-08 12:41:24 -08:00
Jonah Williams c1d029b84f
Demonstrate that artifact invalidation works (#44312) 2019-11-08 12:32:55 -08:00
Jonah Williams cc51ad5d08
Reland: enable usage of experimental web compiler (#44400) 2019-11-07 20:13:02 -08:00
Jenn Magder 8f2ea9d0e9
Turn off docs upload temporarily (#44365) (#44413) 2019-11-07 19:16:04 -08:00
Jonah Williams 7535ef735f
Revert "Enable usage of experimental incremental compiler for web (#43576)" (#44396)
This reverts commit e5d6d92498.
2019-11-07 16:32:20 -08:00
Jonah Williams e5d6d92498
Enable usage of experimental incremental compiler for web (#43576) 2019-11-07 16:29:51 -08:00
Collin Jackson 62b7ce306d
Revert "Turn off docs upload temporarily (#44365)" (#44371)
* Revert "Turn off docs upload temporarily (#44365)"

This reverts commit 3dd6741078.

* show contents of firebase-debug.log
2019-11-07 15:21:45 -08:00
Emmanuel Garcia 2c80bc973d
Flip enable-android-embedding-v2 flag (#44369) 2019-11-07 15:18:56 -08:00
xster 604f176194 Add more flutter build ios-framework tests before the impending jonahpocalypse (#44308) 2019-11-07 13:12:56 -08:00
Greg Spencer 3dd6741078
Turn off docs upload temporarily (#44365)
Turning off Docs upload temporarily until Firebase outage is over.
Landing on red to fix the build.
2019-11-07 11:29:49 -08:00
Shi-Hao Hong b883624c75
l10n tool improvements, stocks app refresh (#44313)
* Add pubspec.yaml comment

* Add --help flag
2019-11-06 18:52:24 -08:00
xster d2e87a5d2c
Build ios framework (#44065) 2019-11-06 14:54:15 -08:00
Shi-Hao Hong 3e4bf5757d
Update Stocks example using i18n tool (#44223)
* Use l10n tool to generate stocks i18n files

* Rename *_en_EN.arb to *_en_US.arb

* Fix l10n script
2019-11-06 12:52:03 -08:00
chunhtai ed82bb821c
revert add new enum change (#44281) 2019-11-06 11:07:24 -08:00