Commit graph

6605 commits

Author SHA1 Message Date
Ian Hickson 44ded0fe91 Revert "Fix the maths for floating pinned app bars. (#11996)" (#12071)
This reverts commit da0602fe9b.
2017-09-13 09:41:09 -07:00
Ian Hickson da0602fe9b Fix the maths for floating pinned app bars. (#11996) 2017-09-13 09:30:09 -07:00
Alexander Aprelev 35c47611b9 Recreate outputFileName completer, handle process launch errors. (#11980)
* Recreate outputFileName completer, handle process launch errors.

* Fix formatting

* Updated comment
2017-09-13 07:33:52 -07:00
Alexander Aprelev b91e8f97ef Remove trailing comma from assert (#12064) 2017-09-12 21:57:37 -07:00
xster fa0bcce708 Add iOS 11 style large titles to cupertino nav bar (#12002)
* Things lay out but the effects not right yet

* Remaining functionalities and tests

* one line large title only

* Add more docs

* review
2017-09-12 16:11:43 -07:00
Collin Jackson e830c5ebf6 Update versions after releasing alpha (#12057) 2017-09-12 15:53:29 -07:00
Ian Hickson 90841c9617 Factor out Border and BorderRadius into their own files. (#12055)
This will make it more tractable to convert them for RTL.
2017-09-12 14:21:27 -07:00
Collin Jackson 701d534ba9 Release 0.0.15 (#12056) 2017-09-12 14:01:51 -07:00
Hans Muller 96a70e89b6 More Localizations (#12021) 2017-09-12 13:15:33 -07:00
gspencergoog 3e21c07087 Adding a default title for Title widget (#12015)
Adds a default title to the Title widget, fixes #6802.
2017-09-12 12:35:44 -07:00
Michael Goderbauer ecb56927de Show accessibility frame while scrolling (#12039)
* Show accessibility frame while scrolling

* ++

* fix test
2017-09-12 10:09:02 -07:00
Michael Thomsen fd6b9c7943 Update pubspec.yaml.tmpl (#12031)
Update to reflect https://github.com/flutter/flutter/pull/11751 and https://github.com/flutter/website/pull/663
2017-09-12 13:29:16 +02:00
Sarah Zakarias e5aead03cc Comments to PR #12032 (#12045) 2017-09-12 12:53:03 +02:00
Sarah Zakarias 0b95e9c278 Support transitive asset dependency (#12032) 2017-09-12 09:13:41 +02:00
Mikkel Nygaard Ravn a1f03977ca Engine artifacts used for snapshots also specified as build inputs (#12014) 2017-09-12 08:35:02 +02:00
Jacob Richman f2ab841ac4 Add DiagnosticLevel used to filter how verbose toStringDeep output for (#11995)
Diagnostics object is.
2017-09-11 19:01:05 -07:00
Adam Barth 2d949ab69d Improve RTL support (#12008)
Fix a bunch of obvious RTL bugs from code inspection.
2017-09-11 12:58:12 -07:00
Michael Goderbauer e2c6ba1b5c Improve readability of _SemanticsGeometry (#12038) 2017-09-11 11:02:15 -07:00
gspencergoog 267514346a Remove legacy --plugin option from flutter create (#12020)
Removed the legacy --plugin option from flutter create.  Fixes #11815.
2017-09-11 10:01:07 -07:00
Yegor ba5b5e7f6f only tap on widgets reachable by hit testing (#11767)
* only tap on widgets reachable by hit testing

* use FractionalOffset

* added tests

* check finder finds correct widget

* undo unintentional changes

* address comments

* style fix

* add Directionality in test

* fix analysis warning
2017-09-11 09:46:42 -07:00
Jacob Richman 0229711ba1 Refactor SemanticsData and SemanticsNode to use Diagnosticable. (#11957)
* Refactor SemanticsData and SemanticsNode to use Diagnosticable.

* Switch toStringDeep to take named parameters.
2017-09-11 09:25:58 -07:00
Sarah Zakarias ff90ba5b3a Add schema for plugin (#12013) 2017-09-11 16:24:41 +02:00
Ian Hickson e7fbee6624 Fix clip debugPaint (TextPainter RTL fallout) (#12026) 2017-09-10 22:59:26 -07:00
Hans Muller 4262c1e9d3 Make an app's supported locales configurable (#11946)
* Make an app's supported locales configurable

* Added an supportedLocales.isNotEmpty assert

* WidgetsApp no longer const because supportedLocales.isNotEmpty

* updated per review feedback

* tweaked dartdoc to restart the build

* updated per review feedback

* Updated per review feedback
2017-09-08 16:47:40 -07:00
Michael Goderbauer 3bf3df33ea Add SemanticsEvents and send them for scrolling (#11909)
* ++

* ++

* ++

* ++

* ++

* dart docs

* test fix

* undo unintended change

* fix test

* fix test

* review feedback
2017-09-08 16:08:40 -07:00
Ian Hickson fad36baa6f Fix WidgetsApp to wrap its contents in a Directionality (#12018)
...rather than only wrapping the children.

Also, improvements to Banner to better support RTL, and mock_canvas to
make debugging things easier.
2017-09-08 14:29:35 -07:00
Adam Barth c46347b6df Add RTL support to Stack (#11973)
Notice that the default alignment for Stack needs to know the
directionality.
2017-09-07 22:52:36 -07:00
Adam Barth 1792766a88 Rename BannerLocation enum values (#11960)
* Rename BannerLocation enum values

 * topLeft -> topStart
 * topRight -> topEnd
 * bottomLeft -> bottomStart
 * bottomRight -> bottomEnd

These names will make it easier for us to adjust the location of the
banner in right-to-left mode.

See the discussion on flutter-dev.

* Add RTL support for Banner

Fixes #11905
2017-09-07 21:12:28 -07:00
Mehmet Fidanboylu d868044e50 Selectively apply margin between middle and leading (#11964)
* Selectively apply margin between middle and leading

If ToolbarLayout does not have a leading widget, we should not put a margin between leading and middle areas since it ends up being blank space that looks odd. Fixes https://github.com/flutter/flutter/issues/11963

* Fix the failing test which is a good test case for missing leading widget
2017-09-07 17:40:58 -07:00
Hans Muller 60c4ff9360 More localizations for Material (#11989) 2017-09-07 16:58:12 -07:00
Ian Hickson ca7d2d23cf TextPainter RTL (#11888) 2017-09-07 16:57:38 -07:00
xster 038981bed9 Mini doc addition to mention that slivers must be filled with RenderSlivers (#11972) 2017-09-07 10:56:17 -07:00
Chris Bracken 8c61116c00 Eliminate iOS log blacklist (#11981)
This was introduced to suppress libMobileGestalt noise originating from
libsystem_asl.dylib. Commit 39680ebfbd
suppresses all application log messages not originating from the
app/engine iteself on iOS 10 and above. Since the log message in
question is only emitted on devices running iOS >= 10.3.0, this
blacklist no longer necessary.
2017-09-07 10:25:41 -07:00
Mikkel Nygaard Ravn 14016523ed Ensure snapshot rebuild logic takes main path into account (#11924) 2017-09-07 14:45:42 +02:00
Chris Bracken 39680ebfbd Suppress non-Flutter log messages in terminal (#11969)
On iOS 10 and above, suppress engine log messages from system components
other than Flutter. This eliminates a large amount of keyboard/plugin
related noise during edit-refresh development.
2017-09-06 19:46:40 -07:00
Michael Goderbauer a67d648742 Roll engine to 883f81c8448e483c51cf1d978dffb332bf47603d (#11966) 2017-09-06 16:30:13 -07:00
Adam Barth 0d454724d3 Improve DatePicker RTL (#11922)
This patch just fixes the next and previous buttons to be in the proper
place. There might be other issues with the DatePicker, but this one was
obvious.

See #11377
2017-09-06 15:35:19 -07:00
Collin Jackson 020029acfd Increment version after rolling alpha (#11893) 2017-09-06 15:18:15 -07:00
Chris Bracken 0244f5dd6a Revert "Roll engine to ceb6d05c2fb3bd5c31a25d4b08be9fd97b55a446 (#11933)" (#11959)
This roll caused performance regressions in benchmarks:
* complex_layout_scroll_perf
* flutter_gallery_transition_perf

This reverts commit f430a45a5b.
2017-09-06 11:39:10 -07:00
Mikkel Nygaard Ravn de6488f5f1 Fix dartdoc typo (#11950) 2017-09-06 14:52:12 +02:00
Mikkel Nygaard Ravn 8303fff8f9 Run pub in interactive mode in flutter packages pub (#11700) 2017-09-06 11:53:39 +02:00
Michael Goderbauer f430a45a5b Roll engine to ceb6d05c2fb3bd5c31a25d4b08be9fd97b55a446 (#11933)
* Roll engien to 79332e5c42555875c7070c33810dab3f0012ace1

* Remove deprecated @proxy

* Roll engine to ceb6d05c2fb3bd5c31a25d4b08be9fd97b55a446
2017-09-05 21:12:46 -07:00
Chris Bracken ce08bf9a21 Log checksum validation errors at trace level (#11944)
Checksum validation is intended only as a performance improvement.
Checksum de-serialization errors (typically framework version mismatch) are
expected on framework updates and shouldn't be user-visible except for
informational purposes when --verbose is set.
2017-09-05 17:03:56 -07:00
Chris Bracken de736f0d43 Update minimum ios-deploy version to 1.9.2 (#11936)
ios-deploy 1.9.2 includes fixes for a common source of Xcode breakage
(flutter/flutter#4326) with Xcode 8.3.3 + iOS 10.3.3, and is required to
to support Xcode 9 (flutter/flutter#11875).
2017-09-05 16:26:36 -07:00
Chris Bracken 93438245f0 Update DevToolsSecurity doctor message (#11935)
Opening Xcode is no longer sufficient to enable develop mode in Xcode 9.
Update the message to run the command-line tool. Alternatively users can
launch an app in the Xcode debugger to do this.
2017-09-05 13:28:13 -07:00
Michael Goderbauer 30fd06f787 getOffsetToReveal deals with pinned slivers (#11878)
* getOffsetToReveal deals with pinned slivers

If a Sliver can potentially be pinned at the edge of a viewport, getOffsetToReveal will take that into account and scroll further up/down to ensure that the object to reveal doesn't end up covered by a pinned sliver.

This is important for accessibility scrolling with app bars.

Since how much a pinned sliver is covering is dynamic (it can change with scroll offset, etc), getOffsetToReveal deals with the worst case and tries to ensure that the object to uncover is visible when the pinned slivers are at their max pinned extent.

* name fixes

* review feedback

* typos

* renaming

* fix analyzer

* fix test

* analyzer fixes
2017-09-05 12:42:28 -07:00
Adam Barth 8eb6ad2776 Add RTL support to GridView (#11921)
Fixes #11855
2017-09-05 11:29:20 -07:00
Chris Bracken c896fe2f6e Invalidate snapshot when entrypoint changes (#11913)
Adds the app entrypoint as a key in the checksum file.

This change eliminates the assumption that checksummed files change when
the main entrypoint changes. In the case where there are two
entrypoints, a.dart and b.dart and a.dart imports b.dart and b.dart
imports a.dart, building the app with entrypoint a.dart followed by a
build of the app with entrypoint b.dart would result in the same
files list and checksums, but should invalidate the build.
2017-09-05 11:19:09 -07:00
Alexander Aprelev 59bc0a0fce Move host build check until it's actually used. (#11926)
* Move host build check until it's actually used

* Elaborate diagnostic message
2017-09-05 11:12:15 -07:00
Michael Goderbauer 7ee0b6a574 Clear tags on SemanticsNode.reset() (#11903) 2017-09-05 10:37:53 -07:00