Commit graph

38834 commits

Author SHA1 Message Date
engine-flutter-autoroll 2216a78095
Roll Flutter Engine from efd0eb62f4aa to ecdaed76f284 (1 revision) (#141359)
efd0eb62f4...ecdaed76f2

2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 5d4f12f3f12d to c46008e5a839 (1 revision) (flutter/engine#49708)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 08:51:26 +00:00
engine-flutter-autoroll 60f503db0d
Roll Flutter Engine from ade9f18fa008 to efd0eb62f4aa (2 revisions) (#141356)
ade9f18fa0...efd0eb62f4

2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from e80a6830eb4d to 5d4f12f3f12d (1 revision) (flutter/engine#49706)
2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from ae45496c55e2 to e80a6830eb4d (2 revisions) (flutter/engine#49705)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 08:09:29 +00:00
engine-flutter-autoroll 3e5cad037c
Roll Flutter Engine from 42e3e0236112 to ade9f18fa008 (2 revisions) (#141337)
42e3e02361...ade9f18fa0

2024-01-11 dnfield@google.com [Impeller] Vulkan runtime effects/fragment program API (flutter/engine#49543)
2024-01-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f5a6a2ccace to 3245b92a5930 (1 revision) (flutter/engine#49700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 03:42:23 +00:00
engine-flutter-autoroll 085aaa5d63
Roll Flutter Engine from f39f5ca18328 to 42e3e0236112 (2 revisions) (#141327)
f39f5ca183...42e3e02361

2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 596053dde5f0 to ae45496c55e2 (1 revision) (flutter/engine#49695)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from d1fbb9177115 to 596053dde5f0 (1 revision) (flutter/engine#49694)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 02:13:27 +00:00
engine-flutter-autoroll d1f3ae73eb
Roll Flutter Engine from 431d64dbb4b8 to f39f5ca18328 (1 revision) (#141322)
431d64dbb4...f39f5ca183

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 2f254f5d41f2 to d1fbb9177115 (1 revision) (flutter/engine#49692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-11 00:11:02 +00:00
Kate Lovett 9785718031
Add dart fix support to flutter_driver (#141300)
Part of https://github.com/flutter/flutter/issues/139249

This adds dart fix support plus fixes for APIs that are currently deprecated in the flutter_driver package.
2024-01-11 00:07:49 +00:00
Polina Cherkasova 13684ca471
Fix a leak. (#141312) 2024-01-11 00:00:10 +00:00
Kate Lovett a94c14e063
Add covariants to reduce subclass casts in 2D APIs (#141318)
While working in https://pub.dev/packages/two_dimensional_scrollables, I found I could eliminate some casts if we added covariants here in the framework.
Much of the 2D aPI in the framework is abstract, so I think it make sense to add these and make it easier/cleaner for subclasses using the APIs.
I made a similar change in https://github.com/flutter/flutter/pull/131358, this would cover all of the cases I could find so its nice and accommodating now.
2024-01-10 23:28:48 +00:00
engine-flutter-autoroll 30b0f729d6
Roll Flutter Engine from a045134c910d to 431d64dbb4b8 (2 revisions) (#141316)
a045134c91...431d64dbb4

2024-01-10 jonahwilliams@google.com [Impeller] reland: write directly to device buffer. (flutter/engine#49691)
2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from c2862d44e108 to 9f5a6a2ccace (1 revision) (flutter/engine#49689)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 23:25:09 +00:00
engine-flutter-autoroll f961fdf2ba
Roll Flutter Engine from 6810c9a57460 to a045134c910d (2 revisions) (#141313)
6810c9a574...a045134c91

2024-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] have Hostbuffer write directly to block allocated device buffers." (flutter/engine#49688)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 0443e02cdfd3 to 2f254f5d41f2 (1 revision) (flutter/engine#49685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 22:37:07 +00:00
Justin McCandless 865825c3c1
Call onPopInvoked when pages API is used (#141221)
(Predictive Back) Fixes a bug where when using PopScope and Navigator.pages together, onPopInvoked wasn't being called.
2024-01-10 14:29:30 -08:00
Polina Cherkasova 420b15a75a
Fix mechanism to pass flag for leak tracking. (#141226) 2024-01-10 22:08:06 +00:00
engine-flutter-autoroll 94e7c9fc75
Roll Flutter Engine from 5d252831e62c to 6810c9a57460 (2 revisions) (#141308)
5d252831e6...6810c9a574

2024-01-10 jason-simmons@users.noreply.github.com [Impeller] Make the shaders loaded by the GLES playground consistent with other playgrounds (flutter/engine#49684)
2024-01-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pUQrgMfXgU8RmLuL4... to gJuGKaWsKazIrvQeO... (flutter/engine#49682)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from pUQrgMfXgU8R to gJuGKaWsKazI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 21:49:10 +00:00
engine-flutter-autoroll d9545c002a
Roll Flutter Engine from 6cb256fc4985 to 5d252831e62c (1 revision) (#141302)
6cb256fc49...5d252831e6

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 334160c0eede to 0443e02cdfd3 (2 revisions) (flutter/engine#49681)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 21:02:54 +00:00
engine-flutter-autoroll 612ad45abb
Roll Flutter Engine from 52aedc6c9153 to 6cb256fc4985 (1 revision) (#141297)
52aedc6c91...6cb256fc49

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from b3d7097aa10f to c2862d44e108 (1 revision) (flutter/engine#49677)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 20:08:26 +00:00
Polina Cherkasova 34f1f5f19e
Improve testing for leak tracking. (#140553) 2024-01-10 11:04:28 -08:00
engine-flutter-autoroll 0409a55076
Roll Flutter Engine from d1a2007a28b4 to 52aedc6c9153 (2 revisions) (#141291)
d1a2007a28...52aedc6c91

2024-01-10 jonahwilliams@google.com [Impeller] have Hostbuffer write directly to block allocated device buffers. (flutter/engine#49505)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 9271dcdade42 to 334160c0eede (1 revision) (flutter/engine#49675)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 18:57:50 +00:00
Christopher Fujino 0f5cd7855d
[flutter_tools] fix flutter create -t skeleton (#141233)
Fixes https://github.com/flutter/flutter/issues/139138

This had been broken since https://github.com/flutter/flutter/pull/130090 merged, however, the test happened run with flutter_tools/pubspec.yaml in the current working directory.
2024-01-10 18:50:07 +00:00
engine-flutter-autoroll 1f11f13e21
Roll Flutter Engine from b361a60ae224 to d1a2007a28b4 (1 revision) (#141285)
b361a60ae2...d1a2007a28

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from efd053daa2a6 to b3d7097aa10f (1 revision) (flutter/engine#49673)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 18:13:26 +00:00
Derek Xu eff2e7dbb1
Unpin package:vm_service (#141279) 2024-01-10 12:47:25 -05:00
stuartmorgan 267ca02db2
Collapse pubspec.lock by default (#141282)
We recently added `open` to this as part of changing all the templates, but the lock file is often quite large, and is often ancillary to the important issues details (unlike cases like code or screenshots), so it's better to leave this one collapsed by default.
2024-01-10 17:35:21 +00:00
engine-flutter-autoroll ee4afd7179
Roll Packages from 09205ca19bd2 to 378e70006863 (2 revisions) (#141275)
09205ca19b...378e700068

2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter from c6ddb73f97 to 126302dfb4 (32 revisions) (flutter/packages#5852)
2024-01-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.22.12 to 3.23.0 (flutter/packages#5849)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 15:45:31 +00:00
engine-flutter-autoroll b840a60d7d
Roll Flutter Engine from 3269fd84460d to b361a60ae224 (1 revision) (#141271)
3269fd8446...b361a60ae2

2024-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate to Flutter mirrors for Google-owned Github repositories" (flutter/engine#49671)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 14:27:25 +00:00
engine-flutter-autoroll b73b460ebd
Roll Flutter Engine from a5d446da5495 to 3269fd84460d (1 revision) (#141264)
a5d446da54...3269fd8446

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 51a0ad17b147 to 9271dcdade42 (1 revision) (flutter/engine#49669)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 11:59:18 +00:00
engine-flutter-autoroll 2df75b735a
Roll Flutter Engine from 3ccf66bed335 to a5d446da5495 (2 revisions) (#141252)
3ccf66bed3...a5d446da54

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from d4b1939dffa6 to efd053daa2a6 (1 revision) (flutter/engine#49666)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from ae30afc7b79a to 51a0ad17b147 (1 revision) (flutter/engine#49665)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 10:31:08 +00:00
engine-flutter-autoroll 3d5b200916
Roll Flutter Engine from e57e418c02ae to 3ccf66bed335 (1 revision) (#141241)
e57e418c02...3ccf66bed3

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 2a77dffd384f to ae30afc7b79a (1 revision) (flutter/engine#49663)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 08:35:11 +00:00
engine-flutter-autoroll b23cf316bf
Roll Flutter Engine from 7e6f3d847e01 to e57e418c02ae (1 revision) (#141240)
7e6f3d847e...e57e418c02

2024-01-10 matanlurey@users.noreply.github.com Follow various best practices in `FlutterRenderer` (flutter/engine#49651)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 07:48:04 +00:00
engine-flutter-autoroll a103002496
Roll Flutter Engine from 1cf2e0a603c7 to 7e6f3d847e01 (1 revision) (#141237)
1cf2e0a603...7e6f3d847e

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 0e8023dc0a1a to 2a77dffd384f (1 revision) (flutter/engine#49662)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 07:02:12 +00:00
engine-flutter-autoroll eeebee623e
Roll Flutter Engine from 32bbf8be8d2c to 1cf2e0a603c7 (1 revision) (#141232)
32bbf8be8d...1cf2e0a603

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 727ea68c62d8 to d4b1939dffa6 (1 revision) (flutter/engine#49657)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 03:25:40 +00:00
engine-flutter-autoroll 3bcf779f32
Roll Flutter Engine from 5b9d2132b7cd to 32bbf8be8d2c (1 revision) (#141229)
5b9d2132b7...32bbf8be8d

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 4ef1837c2958 to 0e8023dc0a1a (1 revision) (flutter/engine#49655)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 02:40:32 +00:00
engine-flutter-autoroll 9c3e6ef278
Roll Flutter Engine from 941f268fc8bb to 5b9d2132b7cd (1 revision) (#141228)
941f268fc8...5b9d2132b7

2024-01-10 jacksongardner@google.com Refactor flutter.js to do dart2wasm bootstrapping and CanvasKit/Skwasm preloading. (flutter/engine#49037)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 01:51:25 +00:00
engine-flutter-autoroll 92f2df562c
Roll Flutter Engine from 542fea9edae4 to 941f268fc8bb (3 revisions) (#141224)
542fea9eda...941f268fc8

2024-01-09 30870216+gaaclarke@users.noreply.github.com [Impeller] made sure to scale the blur radius by the effect transform (flutter/engine#49645)
2024-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Refactors RBE support" (flutter/engine#49654)
2024-01-09 zanderso@users.noreply.github.com Refactors RBE support (flutter/engine#49416)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 01:07:14 +00:00
Igor Hnízdo 7efed85b35
NestedScrollView's outer scrollable jumping with BouncingScrollPhysics due to double precision errors (#138319)
This PR fixes scrolling issues with `NestedScrollView` using the `BouncingScrollPhysics`. In one of the steps of the calculation, we can reach a state where the position of the inner scrollable is set to a `double` value that falls within `precisionErrorTolerance` of `0` but we were using `==` with `0` rather than checking for a precision. My posts in the linked issue show the current behavior, and how I reached to conclusion (the code in this PR). This PR only addresses the "jumping" of the outer scrollable.  

Fixes #136199

I have not finished a test for this since I have never done so and therefore have 0 experience writing tests in Flutter, so any help there would be appreciated. I am also not sure how to test double precision errors in general. I did run all the nested_scroll_view_tests.dart locally and there are no failures.
2024-01-10 00:28:09 +00:00
engine-flutter-autoroll 34e8890eec
Roll Flutter Engine from 8c1501f3956d to 542fea9edae4 (1 revision) (#141217)
8c1501f395...542fea9eda

2024-01-09 31859944+LongCatIsLooong@users.noreply.github.com Fix macOS text composing (flutter/engine#49314)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-10 00:17:35 +00:00
Polina Cherkasova 0f2618ff4f
Fix or except leaks. (#141081)
Contributes to https://github.com/flutter/devtools/issues/6909.
2024-01-10 00:17:33 +00:00
engine-flutter-autoroll e58f43fb23
Roll Flutter Engine from 693af0c699c5 to 8c1501f3956d (1 revision) (#141215)
693af0c699...8c1501f395

2024-01-09 matanlurey@users.noreply.github.com Make `shell/platform/android` IDE-friendly, and add documentation (flutter/engine#49612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-09 23:37:17 +00:00
Chris Bobbe 8d2aca385f
TextStyle: In copyWith, stop ignoring debugLabel when receiver has none (#141141)
Fixes #141140.

This ensures that if you call `.copyWith` and pass a `debugLabel`, the `debugLabel` won't be ignored, even if the receiver (the TextStyle you're calling `.copyWith` on) doesn't have a `debugLabel`.

The debugLabel field was added in #12552. I skimmed the discussion there and didn't find anything indicating that the param was being ignored on purpose.

I added a test case that passes with the new code and fails with the old code.
2024-01-09 23:21:24 +00:00
engine-flutter-autoroll 84e1086c4e
Roll Flutter Engine from a35e3b026e1d to 693af0c699c5 (5 revisions) (#141209)
a35e3b026e...693af0c699

2024-01-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 721fccffc708 to 727ea68c62d8 (1 revision) (flutter/engine#49647)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 77534b672363 to 4ef1837c2958 (1 revision) (flutter/engine#49643)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 8c8be76a62c0 to 77534b672363 (1 revision) (flutter/engine#49641)
2024-01-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 6z4cZ6HUidtgmhvdk... to pUQrgMfXgU8RmLuL4... (flutter/engine#49640)
2024-01-09 bdero@google.com [Flutter GPU] Track HostBuffer emplacements by offset. (flutter/engine#49618)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 6z4cZ6HUidtg to pUQrgMfXgU8R

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-09 22:51:14 +00:00
stuartmorgan 32fd2cbf73
Replace deprecated exists in podhelper.rb (#141169)
The recently landed https://github.com/flutter/flutter/pull/140222 accidentally used the deprecated `exists?` instead of the non-deprecated `exist?` (which other code in this file is already, correctly, using).

Fixes https://github.com/flutter/flutter/issues/141167
2024-01-09 22:25:57 +00:00
Kevin Moore 0cef3f1629
Correctly handle null case in ProcessText.queryTextActions (#141205)
Replace `as Map<Object?, Object?>` to handle nullable case
Fixes runtime issue in Wasm

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-01-09 22:25:54 +00:00
Polina Cherkasova 988d1a0679
Add environment variable to leak tracking bots. (#141137) 2024-01-09 14:14:53 -08:00
Michael Goderbauer 4534a24c09
Reapply "Dynamic view sizing" (#140165) (#140918)
This reverts commit
d24c01bd0c.

The original change was reverted because it caused some apps to get
stuck on the splash screen on some phones.

An investigation determined that this was due to a rounding error.
Example: The device reports a physical size of 1008.0 x 2198.0 with a
dpr of 1.912500023841858. Flutter would translate that to a logical size
of 527.0588169589221 x 1149.2810314243163 and use that as the input for
its layout algorithm. Since the constraints here are tight, the layout
algorithm would determine that the resulting logical size of the root
render object must be 527.0588169589221 x 1149.2810314243163.
Translating this back to physical pixels by applying the dpr resulted in
a physical size of 1007.9999999999999 x 2198.0 for the frame. Android
now rejected that frame because it didn't match the expected size of
1008.0 x 2198.0 and since no frame had been rendered would never take
down the splash screen.

Prior to dynamically sized views, this wasn't an issue because we would
hard-code the frame size to whatever the requested size was.

Changes in this PR over the original PR:

* The issue has been fixed now by constraining the calculated physical
size to the input physical constraints which makes sure that we always
end up with a size that is acceptable to the operating system.
* The `ViewConfiguration` was refactored to use the slightly more
convenient `BoxConstraints` over the `ViewConstraints` to represent
constraints. Both essentially represent the same thing, but
`BoxConstraints` are more powerful and we avoid a couple of translations
between the two by translating the` ViewConstraints` from the
`FlutterView` to `BoxConstraints` directly when the `ViewConfiguration`
is created.

All changes over the original PR are contained in the second commit of
this PR.

Fixes b/316813075
Part of https://github.com/flutter/flutter/issues/134501.
2024-01-09 14:10:43 -08:00
SharbelOkzan 0c40f21fc5
Introduce new Form validation method (#135578)
Introduced `validateGranually` which, apart from announcing the errors to the UI, returns a `Map<Key, bool>` providing more granular validation details: The results of calling `validate` on each `FormField` and their corresponding widget keys.

* related issue: #135363
2024-01-09 21:10:04 +00:00
Taha Tesser 536de5ed91
Update RouteObserver example and fix an error thrown (#141166)
fixes [`RouteObserver` example throws an error](https://github.com/flutter/flutter/issues/141078)

### Description
This updates the `RouteObserver` example from snippet to Dartpad example and fixes the error when running the code snippet
2024-01-09 20:48:56 +00:00
Polina Cherkasova 1f3103e50d
Upgrade leak_tracker. (#141153) 2024-01-09 12:02:35 -08:00
Casey Hillers 51af82d3db
[ci.yaml] Do not run packaging test on presubmit (#141192)
This test doesn't support presubmit as runs a separate git clone, which won't contain the presubmit hash.

Fixes https://github.com/flutter/flutter/issues/141188
2024-01-09 20:02:15 +00:00
engine-flutter-autoroll 8834186741
Roll Flutter Engine from 036b39fa47fa to a35e3b026e1d (6 revisions) (#141191)
036b39fa47...a35e3b026e

2024-01-09 john@johnmccutchan.com Simplify PlatformViewRenderTarget interface (flutter/engine#49639)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 05039d6ed8d8 to 8c8be76a62c0 (3 revisions) (flutter/engine#49638)
2024-01-09 zanderso@users.noreply.github.com Skip flaky test on mac in http_disallow_http_connections_test.dart (flutter/engine#49635)
2024-01-09 john@johnmccutchan.com Resize the RenderTarget before creating and passing its Surface to the VirtualDisplay (flutter/engine#49619)
2024-01-09 103135467+sealesj@users.noreply.github.com Migrate to Flutter mirrors for Google-owned Github repositories (flutter/engine#49203)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from ee263c34e03d to 05039d6ed8d8 (2 revisions) (flutter/engine#49636)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-09 19:51:00 +00:00
Victoria Ashworth 1ec9daa9c2
Run tests on iOS 16 or iOS 17 (#141178)
Fixes https://github.com/flutter/flutter/issues/141177
2024-01-09 19:49:21 +00:00
Polina Cherkasova 188d4d1fdf
Remove conditions that depend on order. (#141183) 2024-01-09 11:19:04 -08:00
engine-flutter-autoroll 7bf375b58c
Roll Flutter Engine from b3c8597df0e2 to 036b39fa47fa (1 revision) (#141179)
b3c8597df0...036b39fa47

2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from f9f73082740e to ee263c34e03d (3 revisions) (flutter/engine#49631)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-09 18:23:09 +00:00