Flutter GitHub Bot
defa2b7443
Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky ( #138472 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_android hot_mode_dev_cycle__benchmark"
}
-->
The issue https://github.com/flutter/flutter/issues/138072 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_android%20hot_mode_dev_cycle__benchmark%22 ).
This test can be marked as unflaky.
2023-11-15 11:32:08 +00:00
Victoria Ashworth
c0ca261e07
Only run tests on macOS 12 ( #138260 )
...
There's an https://github.com/flutter/flutter/issues/138238 with mac_toolchain that makes Xcode installs flakey and an https://github.com/flutter/flutter/issues/138246 that makes Xcode installs more frequent on macOS 13, which is causing presubmit tests to fall frequently. In the meantime, we'll only have tests run on macOS 12.
2023-11-10 23:53:23 +00:00
Victoria Ashworth
4eda3b96c5
Move Mac_build_test flutter_gallery__transition_perf_e2e_ios to staging ( #138196 )
...
Seems that bots recently upgraded to macOS 13 are missing certs (https://github.com/flutter/flutter/issues/138194 ). Temporarily move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to staging.
2023-11-10 00:12:06 +00:00
Victoria Ashworth
46dcb32c23
Use specific version of mac_toolchain ( #138115 )
...
Newer versions of mac_toolchain increase Xcode install times by ~2 minutes (https://github.com/flutter/flutter/issues/138109 ). As a temporary solution, we're using an older version of mac_toolchain.
2023-11-08 23:37:54 +00:00
Flutter GitHub Bot
35ca279ce9
Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky ( #138073 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_android hot_mode_dev_cycle__benchmark"
}
-->
Issue link: https://github.com/flutter/flutter/issues/138072
2023-11-08 20:24:04 +00:00
Victoria Ashworth
076846c7fe
Run a couple of iOS tests in presubmit ( #138089 )
...
Run a couple of iOS tests in presubmit to validate macOS 13 bots in the try pool are working successfully and consistently.
2023-11-08 17:57:15 +00:00
Zachary Anderson
2e50a54128
Move Skia new_gallery_transition_perf on a02 from staging to prod ( #138013 )
...
cc @yusuf-goog
2023-11-07 19:07:00 +00:00
godofredoc
90c73055b2
Migrate api docs from master to main. ( #137726 )
...
This is the first of a series of changes to migrate to remove master-docs-flutter-dev GCP project.
Bug: https://github.com/flutter/flutter/issues/133877
2023-11-02 18:56:47 +00:00
Flutter GitHub Bot
87c8e2417a
Marks Windows build_tests_1_6 to be unflaky ( #137673 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_1_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_1_6%22 ).
This test can be marked as unflaky.
2023-11-02 15:53:53 +00:00
Flutter GitHub Bot
41e9235181
Marks Windows build_tests_4_6 to be unflaky ( #137674 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_4_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_4_6%22 ).
This test can be marked as unflaky.
2023-11-02 15:03:55 +00:00
yusuf-goog
c617937009
Bumping version tag of provisioning profile cipd package. ( #137710 )
...
Bug:https://github.com/flutter/flutter/issues/137166
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-11-01 19:44:02 +00:00
Kate Lovett
fbc145167a
Bump goldctl in .ci.yaml ( #137441 )
...
Related to https://github.com/flutter/flutter/issues/137177
2023-10-27 19:27:09 +00:00
Victoria Ashworth
e75f85bffd
Run tests on either macOS 12 or 13 ( #137365 )
...
In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.
I have run all tests on macOS 13: https://docs.google.com/spreadsheets/d/1-KOSOSF7uVA4KuqSMn9xz3IIJW78u8SXLYK2OAfe_Qg/edit?usp=sharing&resourcekey=0-df8Bj5PRS1IPBccPDdvRCQ
2023-10-27 15:19:05 +00:00
Flutter GitHub Bot
f13196e3f6
Marks Windows_arm64 windows_startup_test to be unflaky ( #137228 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 windows_startup_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20windows_startup_test%22 ).
This test can be marked as unflaky.
2023-10-26 22:35:22 +00:00
Flutter GitHub Bot
4a97a57831
Marks Windows_arm64 flutter_tool_startup__windows to be unflaky ( #137229 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 flutter_tool_startup__windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_tool_startup__windows%22 ).
This test can be marked as unflaky.
2023-10-26 22:09:12 +00:00
Flutter GitHub Bot
e262926881
Marks Windows_arm64 windows_home_scroll_perf__timeline_summary to be unflaky ( #137221 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 windows_home_scroll_perf__timeline_summary"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20windows_home_scroll_perf__timeline_summary%22 ).
This test can be marked as unflaky.
2023-10-26 22:05:50 +00:00
Flutter GitHub Bot
6f093b1db8
Marks Windows_arm64 complex_layout_win_desktop__start_up to be unflaky ( #137225 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 complex_layout_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20complex_layout_win_desktop__start_up%22 ).
This test can be marked as unflaky.
2023-10-26 22:05:44 +00:00
Flutter GitHub Bot
6f3c3a3f2a
Marks Windows_arm64 hot_mode_dev_cycle_win_target__benchmark to be unflaky ( #137217 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 hot_mode_dev_cycle_win_target__benchmark"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20hot_mode_dev_cycle_win_target__benchmark%22 ).
This test can be marked as unflaky.
2023-10-26 21:34:06 +00:00
Flutter GitHub Bot
b6cde8f720
Marks Windows_arm64 flutter_view_win_desktop__start_up to be unflaky ( #137226 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 flutter_view_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_view_win_desktop__start_up%22 ).
This test can be marked as unflaky.
2023-10-26 21:34:03 +00:00
Flutter GitHub Bot
dfd003abb0
Marks Windows_arm64 platform_view_win_desktop__start_up to be unflaky ( #137227 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 platform_view_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20platform_view_win_desktop__start_up%22 ).
This test can be marked as unflaky.
2023-10-26 21:34:00 +00:00
Flutter GitHub Bot
71bc3b02f2
Marks Windows_arm64 flutter_gallery_win_desktop__start_up to be unflaky ( #137224 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 flutter_gallery_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_gallery_win_desktop__start_up%22 ).
This test can be marked as unflaky.
2023-10-26 21:11:52 +00:00
Flutter GitHub Bot
dc16104b35
Marks Windows_arm64 hello_world_win_desktop__compile to be unflaky ( #137222 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 hello_world_win_desktop__compile"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20hello_world_win_desktop__compile%22 ).
This test can be marked as unflaky.
2023-10-26 21:08:01 +00:00
Flutter GitHub Bot
3836988980
Marks Windows_arm64 flutter_gallery_win_desktop__compile to be unflaky ( #137223 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 flutter_gallery_win_desktop__compile"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_gallery_win_desktop__compile%22 ).
This test can be marked as unflaky.
2023-10-26 21:07:59 +00:00
Flutter GitHub Bot
fdd38d30d7
Marks Windows_arm64 run_release_test_windows to be unflaky ( #137220 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 run_release_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20run_release_test_windows%22 ).
This test can be marked as unflaky.
2023-10-26 21:06:19 +00:00
Flutter GitHub Bot
d737038f39
Marks Windows_arm64 platform_channel_sample_test_windows to be unflaky ( #137218 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 platform_channel_sample_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20platform_channel_sample_test_windows%22 ).
This test can be marked as unflaky.
2023-10-26 20:55:14 +00:00
Flutter GitHub Bot
17797ba50b
Marks Windows_arm64 run_debug_test_windows to be unflaky ( #137219 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 run_debug_test_windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20run_debug_test_windows%22 ).
This test can be marked as unflaky.
2023-10-26 18:15:56 +00:00
Victoria Ashworth
341af51391
Run test with older version of Xcode ( #137293 )
...
Xcode Debug tests require an older version of Xcode to run in CI.
New test is failing due to incompatible Xcode version: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_arm64_ios%20flavors_test_ios_xcode_debug/1/overview
2023-10-26 14:42:17 +00:00
Victoria Ashworth
5dd2a4e0aa
Ensure Xcode project is setup to start debugger ( #136977 )
...
Some users have their Xcode settings set to not debug (see example here https://github.com/flutter/flutter/issues/136197#issuecomment-1766834195 ). This will cause the [engine check for a debugger](22ce5c6a45/runtime/ptrace_check.cc (L56-L71)
) to fail, which will cause an error and cause the app to crash.
This PR parses the scheme file to ensure the scheme is set to start a debugger and warn the user if it's not.
Fixes https://github.com/flutter/flutter/issues/136197 .
2023-10-25 17:08:57 +00:00
Flutter GitHub Bot
9366170e84
Marks Windows build_tests_6_6 to be unflaky ( #137216 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_6_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_6_6%22 ).
This test can be marked as unflaky.
2023-10-25 17:07:19 +00:00
Flutter GitHub Bot
cd2c08ee51
Marks Windows build_tests_3_6 to be unflaky ( #137214 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_3_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_3_6%22 ).
This test can be marked as unflaky.
2023-10-25 14:49:32 +00:00
Flutter GitHub Bot
7db948cfdb
Marks Windows build_tests_5_6 to be unflaky ( #137215 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_5_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_5_6%22 ).
This test can be marked as unflaky.
2023-10-25 14:40:12 +00:00
Flutter GitHub Bot
1001a0a3d0
Marks Windows build_tests_2_6 to be unflaky ( #137213 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_2_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_2_6%22 ).
This test can be marked as unflaky.
2023-10-25 14:37:57 +00:00
Jackson Gardner
4afdfca264
Remove bringup: true
from realm_checker and remove the redundant tool test. ( #137186 )
...
Now that the realm checker is no longer in bringup, we can remove the tool test that checks for the empty realm file.
2023-10-25 01:09:18 +00:00
Jackson Gardner
cdd1ae994d
Check the realm file in its own shard. ( #137160 )
...
This way, it is easier to differentiate between a real failure in the tools tests vs. just the realm check that blocks the merge.
2023-10-24 18:35:13 +00:00
godofredoc
69d0ca60ef
Migrate mac builds to ruby dep. ( #136929 )
...
The ruby dependency has been automated to include cocoapods.
Bug: https://github.com/flutter/flutter/issues/136377
2023-10-24 17:10:02 +00:00
Casey Hillers
347ae937cf
[ci_yaml] Remove back_fill=false on roller ( #137076 )
...
Follow up from https://flutter-review.googlesource.com/c/50200 which removed the issue with inconsistencies
https://github.com/flutter/flutter/issues/112127
2023-10-23 20:39:01 +00:00
Michael Goderbauer
997a94fd1f
Bump dartdoc to 7.0.1 and clean-up ( #136975 )
...
These warnings/errors have been removed from dartdoc. Removing them from the flutter config as well.
Also fixes CI to actually test doc generation for all documented packages and on dartdoc config changes.
2023-10-20 22:13:28 +00:00
Gray Mackall
f8c00983d6
Unmark linux_android platform_channels_benchmarks as flaky ( #136838 )
...
Unmarking this test as flaky in favor of a fix for the [underlying issue](https://github.com/flutter/flutter/issues/135035 ). None of the other impacted tests have been marked as flaky, so I think it is better for this one to not be treated differently.
2023-10-19 17:09:13 +00:00
Gray Mackall
b136ddc68b
Add Android 14 physical devices to firebase tests ( #136736 )
...
I've been keeping an eye on the device list, and android 14 devices recently became available. For reviewing purposes (and anyone who comes across this in the future), you can check the available devices here at the third option without needing a firebase login:
https://firebase.google.com/docs/test-lab/android/available-testing-devices
The "shiba" device is high capacity. There are no api 34 virtual devices yet.
2023-10-17 19:42:00 +00:00
Ricardo Amador
d42b4bb55a
Reenable NexusLowRes API 29 ( #136686 )
...
Reenable the NexusLowRes API version 29 tests.
*List which issues are fixed by this PR. You must list at least one issue.*
fixes https://buganizer.corp.google.com/issues/302753598
fixes flutter/flutter#135784
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-10-17 18:04:11 +00:00
Ricardo Amador
c76761ea8a
Reenable the nexus 6p tests ( #136689 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-10-17 18:02:26 +00:00
Christopher Fujino
bcc795a029
increase windows build test sharding, revert timeout 30 mins ( #136474 )
...
In https://github.com/flutter/flutter/pull/136300 I increased the timeout. This is a revert of that, which also adds an additional shard.
2023-10-14 00:42:55 +00:00
engine-flutter-autoroll
33db5d7a87
Manual roll Flutter Engine from 6605151b4d0a to a4e62581525c (9 revisions) ( #136564 )
...
Manual roll requested by jacksongardner@google.com
Cannot build log URL because revision "a4e62581525c" is invalid: Luci builds of "Mac mac_ios_engine" for a4e62581525c1864a3cd23a67539a3615717eb98 was STARTED
2023-10-13 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c8143a7c026f to 5844b34768ce (1 revision) (flutter/engine#46909 )
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from c9601553b0f3 to 4bc4b4d22866 (1 revision) (flutter/engine#46908 )
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 8dc8e21a4dec to c9601553b0f3 (3 revisions) (flutter/engine#46907 )
2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SDPa6SfaKvRRSUCij... to 4DwpR2CMJECZJ8EKz... (flutter/engine#46903 )
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from b50d7f9aa743 to 8dc8e21a4dec (4 revisions) (flutter/engine#46902 )
2023-10-13 jonahwilliams@google.com [Impeller] fix clear color optimization for large subpasses. (flutter/engine#46887 )
2023-10-13 matanlurey@users.noreply.github.com Oops, allow files in opted-in third_party directories. (flutter/engine#46897 )
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from e10e6765480a to b50d7f9aa743 (1 revision) (flutter/engine#46899 )
2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pI1BVH08V0eG0M7sw... to wBb32R567S1alWbfn... (flutter/engine#46898 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pI1BVH08V0eG to wBb32R567S1a
fuchsia/sdk/core/mac-amd64 from SDPa6SfaKvRR to 4DwpR2CMJECZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-13 23:04:25 +00:00
Victoria Ashworth
9c791f465e
Remove bringup from tests and move some back to presubmit. Reorganize TESTOWNERS. ( #136498 )
...
We renamed a few tests and therefore had to run them in bringup first
(https://github.com/flutter/flutter/pull/136463 ). This removes bringup
and moves some of them back to presubmit. Also, reorganize TESTOWNERS
since they're running on hostonly now.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-13 10:12:02 -07:00
Victoria Ashworth
d6ec0cf564
Change some tests to run on macs without iOS devices attached ( #136463 )
...
Some tests have been running on devicelab bots with iOS devices attached, however, they don't require an iOS device. So moving them to run on bots without iOS devices.
Fixes https://github.com/flutter/flutter/issues/136415 .
2023-10-12 16:52:16 +00:00
Loïc Sharma
50b56de215
[Windows Arm64] Add the 'platform_channel_sample_test_windows' Devicelab test ( #136401 )
...
â
Successful run: 2a327123e9/+/build.proto
?server=chromium-swarm.appspot.com
Part of https://github.com/flutter/flutter/issues/129806
2023-10-11 23:07:29 +00:00
Jackson Gardner
a277c5faaf
Switch to Chrome for Testing instead of vanilla Chromium. ( #136214 )
...
This switches over to using Chrome for Testing instead of Chromium. This should ensure that we are consistently using an official and consistent build of Chrome on all platforms, rather than whatever we can get from the continuous builds archive, which can potentially put platforms out of sync with each other.
2023-10-11 20:51:14 +00:00
Loïc Sharma
f2931dbd8c
Remove the 'Windows_arm64 plugin_test' Devicelab test ( #136379 )
...
This removes the `Windows_arm64 plugin_test` as Devicelab tests aren't able to target Android from a Windows Arm64 host yet. I opened https://github.com/flutter/flutter/issues/136378 to track this work.
2023-10-11 18:31:04 +00:00
Christopher Fujino
5a4497d47f
extend timeout from default 30 min to 1 hour for windows build tests ( #136300 )
...
Fixes https://github.com/flutter/flutter/issues/136299
2023-10-11 18:10:52 +00:00
Loïc Sharma
c6aeab930a
[Windows] Add Arm64 benchmarks ( #135514 )
...
Part of: https://github.com/flutter/flutter/issues/129806
Test runs kicked off using `led`:
* â
[hot_mode_dev_cycle_win_target__benchmark](2079b030ac/+/build.proto
?server=chromium-swarm.appspot.com)
* â
[windows_home_scroll_perf__timeline_summary](56a3b258e4/+/build.proto
?server=chromium-swarm.appspot.com)
* â
[flutter_tool_startup](fa6a1056fc/+/build.proto
?server=chromium-swarm.appspot.com)
/cc @pbo-linaro
2023-10-11 16:36:20 +00:00
Jonah Williams
a106b81cc5
[framework] restore old zoom page transition for benchmarking. ( #133346 )
...
In the past I switched the implementation of the zoom page transition because the performance of the old transition was terrible, but I'm hopeful that with Impeller we'll be able to identify and fix the issues that made it so slow. In order to evaluate this though, we need to be able to opt into the old transition for benchmarks on CI.
https://github.com/flutter/flutter/issues/129742
https://github.com/flutter/flutter/issues/121325
2023-10-10 22:27:07 +00:00
Loïc Sharma
39b9d8fd6d
[Windows] Add first Arm64 plugin tests ( #135512 )
...
Part of: https://github.com/flutter/flutter/issues/129806
Test runs kicked off using `led`:
* â
[plugin_test_windows](277ffb2c7b/+/build.proto
?server=chromium-swarm.appspot.com)
* â ï¸ [plugin_test](c9daccd5b3/+/build.proto
?server=chromium-swarm.appspot.com) - This test fails as no existing Windows Arm64 builder install the `android_sdk` and `open_jdk` dependencies
I will add `plugin_dependencies_test` and `gradle_plugin_bundle_test` in a follow-up pull request. These tests also depend on `android_sdk` and `open_jdk`, I'll be able to test them manually using the new `plugin_test` builder added by this pull request.
/cc @pbo-linaro
2023-10-06 22:28:08 +00:00
Zachary Anderson
68d47e55d4
Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" ( #136097 )
...
Reverts flutter/flutter#135566
2023-10-06 15:10:49 -07:00
Flutter GitHub Bot
420ec92e72
Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky ( #135566 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_samsung_a02 new_gallery__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_samsung_a02%20new_gallery__transition_perf%22 ).
This test can be marked as unflaky.
2023-10-06 20:27:15 +00:00
Flutter GitHub Bot
8796955e98
Marks Windows module_custom_host_app_name_test to be unflaky ( #135961 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22 ).
This test can be marked as unflaky.
2023-10-06 11:19:14 -07:00
Flutter GitHub Bot
c6d884ea7e
Marks Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary to be unflaky ( #135960 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary"
}
-->
The issue https://github.com/flutter/flutter/issues/135118 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary%22 ).
This test can be marked as unflaky.
2023-10-04 22:46:40 +00:00
Ricardo Amador
d7739dff68
Temporarily disable NexusLowRes, version=29 ( #135785 )
...
There are too many flakes to leave this version enabled. Temporarily disabled and following up with FTL.
*List which issues are fixed by this PR. You must list at least one issue.*
Related to https://github.com/flutter/flutter/issues/135784
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-09-30 01:57:05 +00:00
keyonghan
951653a1c0
Add arch property for windows_arm64 platform ( #135725 )
...
Window arm64 bots are using x64 built python, which gave incorrect arch info. This PR adds the arch info explicitly so that recipes can get this value and populate to benchmark tags.
Part of https://github.com/flutter/flutter/issues/135722
2023-09-29 00:57:06 +00:00
Flutter GitHub Bot
55c7a2efc4
Marks Linux_android flutter_gallery__start_up_delayed to be unflaky ( #135565 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
The issue https://github.com/flutter/flutter/issues/134631 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20flutter_gallery__start_up_delayed%22 ).
This test can be marked as unflaky.
2023-09-28 22:44:52 +00:00
auto-submit[bot]
f76c150cc8
Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" ( #135692 )
...
Reverts flutter/flutter#135567
Initiated by: ricardoamador
This change reverts the following previous change:
Original Description:
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22 ).
This test can be marked as unflaky.
2023-09-28 18:36:26 +00:00
Flutter GitHub Bot
c35515a079
Marks Windows module_custom_host_app_name_test to be unflaky ( #135567 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22 ).
This test can be marked as unflaky.
2023-09-28 17:38:51 +00:00
godofredoc
d3c45f1499
Config changes for linux coverage. ( #135604 )
...
This build runs for over and hour and it does not need to run on presubmit or release candidate branches.
2023-09-27 16:42:54 +00:00
Flutter GitHub Bot
9fedb1a6ce
Marks Linux_pixel_7pro hello_world_impeller to be unflaky ( #135564 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro hello_world_impeller"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20hello_world_impeller%22 ).
This test can be marked as unflaky.
2023-09-27 08:35:32 -07:00
Loïc Sharma
7143284102
[Windows] Add more Arm64 compile and run tests ( #135475 )
...
Part of: https://github.com/flutter/flutter/issues/129806
Test runs kicked off using `led`:
* Compile tests
* â
[flutter_gallery_win_desktop__compile](a23b73ca25/+/build.proto
?server=chromium-swarm.appspot.com&fbclid=IwAR2Yv8iS9YbTxMZKS2i5zmAz9E8FCNjW6waLq4e8HwtaFtMlapl66UHf73w)
* Start up tests
* â
[windows_startup_test](e615b28993/+/build.proto
?server=chromium-swarm.appspot.com&fbclid=IwAR1YtPTpAr6FRq71fy392orp6PO8t9jN8n-mpWvlDF0xRnnOsq3zsAPabWg)
* â
[flutter_gallery_win_desktop__start_up](a0148122f8/+/build.proto
?server=chromium-swarm.appspot.com&fbclid=IwAR29O3jW-LyaVAwD54jUmnhfZ2mswqtaZascRoGvteT5gaHihxKI4IastgM)
* â
[flutter_view_win_desktop__start_up](6dac552365/+/build.proto
?server=chromium-swarm.appspot.com&fbclid=IwAR2_irHDuoZ0V-PSjYDW082yx8ZeDVhOIk0yjQBAZNVa5iKVIGAWZs8v4lo)
* â
[platform_view_win_desktop__start_up](e6522c77bc/+/build.proto
?server=chromium-swarm.appspot.com&fbclid=IwAR2X7KJDGjQUWJtpq7KY-nUFK-LA6LvmrAinzj0QuF8pEbpwfsAz6Kv3OkM)
* â
[complex_layout_win_desktop__start_up](a811334185/+/build.proto
?server=chromium-swarm.appspot.com&fbclid=IwAR0gIiXFMnB_MSaqUxVyTpgpJqc37xSKqOzEsf2oD_oU-AhKPqrGQ-ZD7IY)
* `flutter run` console output tests
* â
[run_debug_test_windows](1b275a8b16/+/build.proto
?server=chromium-swarm.appspot.com&fbclid=IwAR1IlBr0824cq9UKi46j_11eto6HTEQ9KVXF5Is1ZxcSIO7G6IlN-slsyI8)
* â
[run_release_test_windows](5b259bb5e2/+/build.proto
?server=chromium-swarm.appspot.com&fbclid=IwAR3DSHzCGL-KN26E-7hQL58qxV2p0Dtb9hE4AZ0HvEY4hp8mCMzX9jznsFQ)
/cc @pbo-linaro
2023-09-26 19:27:00 +00:00
Zachary Anderson
16ae8c0109
Revert "Marks Linux_pixel_7pro hello_world_impeller to be unflaky" ( #135388 )
...
Reverts flutter/flutter#135372
2023-09-25 14:13:30 +00:00
godofredoc
07ce6a76a0
Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" ( #135399 )
...
Reverts flutter/flutter#135373
2023-09-25 04:29:39 +00:00
Flutter GitHub Bot
2f56288a4e
Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky ( #135373 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_samsung_a02 new_gallery__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_samsung_a02%20new_gallery__transition_perf%22 ).
This test can be marked as unflaky.
2023-09-25 01:49:07 +00:00
Flutter GitHub Bot
797d34e5af
Marks Linux_pixel_7pro hello_world_impeller to be unflaky ( #135372 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro hello_world_impeller"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20hello_world_impeller%22 ).
This test can be marked as unflaky.
2023-09-24 16:40:10 +00:00
Flutter GitHub Bot
a6e98d3006
Marks Windows_android channels_integration_test_win to be unflaky ( #135374 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_android channels_integration_test_win"
}
-->
The issue https://github.com/flutter/flutter/issues/134636 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20channels_integration_test_win%22 ).
This test can be marked as unflaky.
2023-09-24 16:40:07 +00:00
Flutter GitHub Bot
8bc223e3e5
Marks Mac_ios draw_atlas_perf_ios__timeline_summary to be unflaky ( #134626 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios draw_atlas_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_atlas_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
2023-09-24 05:14:20 +00:00
Flutter GitHub Bot
2c1f517d10
Marks Mac_ios draw_vertices_perf_ios__timeline_summary to be unflaky ( #134625 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios draw_vertices_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_vertices_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
2023-09-24 05:06:26 +00:00
Flutter GitHub Bot
417aaf5b2b
Marks Windows module_test to be unflaky ( #134121 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows module_test"
}
-->
The issue https://github.com/flutter/flutter/issues/133639 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_test%22 ).
This test can be marked as unflaky.
2023-09-24 04:12:53 +00:00
Flutter GitHub Bot
c0bde99e0f
Marks Mac_ios dynamic_path_tessellation_perf_ios__timeline_summary to be unflaky ( #133128 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios dynamic_path_tessellation_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20dynamic_path_tessellation_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
2023-09-24 04:11:19 +00:00
Flutter GitHub Bot
6240c899b9
Marks Mac_ios draw_points_perf_ios__timeline_summary to be unflaky ( #127933 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios draw_points_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_points_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
2023-09-24 04:07:20 +00:00
Flutter GitHub Bot
260c16cfb8
Marks Linux_pixel_7pro picture_cache_perf__timeline_summary to be unflaky ( #134118 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro picture_cache_perf__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20picture_cache_perf__timeline_summary%22 ).
This test can be marked as unflaky.
2023-09-24 04:04:54 +00:00
Flutter GitHub Bot
82a972bf1a
Marks Mac_ios very_long_picture_scrolling_perf_ios__e2e_summary to be unflaky ( #134629 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios very_long_picture_scrolling_perf_ios__e2e_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20very_long_picture_scrolling_perf_ios__e2e_summary%22 ).
This test can be marked as unflaky.
2023-09-24 03:52:33 +00:00
Flutter GitHub Bot
389d482aac
Marks Mac_ios animated_advanced_blend_perf_ios__timeline_summary to be unflaky ( #132630 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios animated_advanced_blend_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20animated_advanced_blend_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
2023-09-24 02:49:37 +00:00
Flutter GitHub Bot
3ba8472a15
Marks Mac_ios static_path_tessellation_perf_ios__timeline_summary to be unflaky ( #133127 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios static_path_tessellation_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20static_path_tessellation_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
2023-09-24 02:49:35 +00:00
Flutter GitHub Bot
4f5c815559
Marks Linux_android platform_channels_benchmarks to be flaky ( #135106 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android platform_channels_benchmarks"
}
-->
Issue link: https://github.com/flutter/flutter/issues/135105
2023-09-23 23:07:08 +00:00
Flutter GitHub Bot
6d4a5e3d31
Marks Linux_android flutter_gallery__start_up_delayed to be flaky ( #134632 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
Issue link: https://github.com/flutter/flutter/issues/134631
2023-09-23 23:07:06 +00:00
Flutter GitHub Bot
6d88ade70a
Marks Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary to be flaky ( #135119 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary"
}
-->
Issue link: https://github.com/flutter/flutter/issues/135118
2023-09-23 23:03:13 +00:00
Zachary Anderson
70fd335041
Move some tests from staging to prod ( #135333 )
...
This PR moves tests running on Pixel 7 Pro that use Skia from staging to prod.
2023-09-23 00:32:16 +00:00
Ricardo Amador
76a938bfa6
Reenable 'Linux packages_autoroller' in prod with kms key update ( #135316 )
...
The Github token was recreated and uploaded to GCS. I have verified a passing run with the new key here:
bc5d1e6662/+/build.proto
And the bot is now generating pull requests: https://github.com/flutter/flutter/pull/135315
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/131968
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-09-22 18:23:14 +00:00
Daco Harkes
2def951924
Reland "Native assets support for Linux" ( #135097 )
...
Reland of #134031 . (Reverted in #135069.) Contains the fix for b/301051367 together with cl/567233346.
Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.
For more info see:
* https://github.com/flutter/flutter/issues/129757
### Implementation details for Linux.
Mainly follows the design of https://github.com/flutter/flutter/pull/130494 .
Some differences are:
* Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
* Linux has no add2app.
The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.
### Tests
This PR adds new tests to cover the various use cases.
* packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
* Unit tests the Linux-specific part of building native assets.
It also extends various existing tests:
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
* Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.
2023-09-22 06:07:06 +00:00
Gray Mackall
b433b17539
Upgrade AGP version in tracing_tests ( #134671 )
...
Related to https://github.com/flutter/flutter/issues/134419
2023-09-20 20:56:25 +00:00
Xilai Zhang
52ef9d8827
[flutter roll] Revert "Native assets support for Linux" ( #135069 )
...
Reverts flutter/flutter#134031
context: b/301051367
Looked at the error message from the broken TAP target, but seems like the failure might be non trivial to resolve. Would it be okay if we revert this for now while it is being triaged?
2023-09-20 00:06:45 +00:00
Zachary Anderson
5c6b031c10
Retry Linux web tests 1 time on roll presubmit ( #135073 )
...
Reland of https://github.com/flutter/flutter/pull/134552
2023-09-19 23:17:25 +00:00
Jackson Gardner
d3c60569d1
Update CI to Chrome 117. ( #134761 )
2023-09-19 16:26:16 +00:00
Daco Harkes
f246dc7ae0
Bring native_assets ios tests out of staging ( #135015 )
...
Move test added in https://github.com/flutter/flutter/pull/130494 out of staging.
* https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_ios%20native_assets_ios
* https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_ios%20native_assets_ios_simulator
> Monitor the CI results of the new shard on the [Flutter build dashboard](https://flutter-dashboard.appspot.com/#/build ). After 50 consecutive passing builds without any flakes, the flake bot will create a PR to remove the bringup: true parameter from .ci.yaml in the Framework tree. This will allow the test to block the tree, preventing breakages. With this change, the new shard will start running in presubmit automatically, unless specify presubmit: false.
https://github.com/flutter/flutter/wiki/Adding-a-new-Test-Shard#steps-to-add-a-new-framework-test-shard
Umbrella issue:
* https://github.com/flutter/flutter/issues/129757
2023-09-19 15:48:26 +00:00
Daco Harkes
2337c64d0c
Native assets support for Linux ( #134031 )
...
Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.
For more info see:
* https://github.com/flutter/flutter/issues/129757
### Implementation details for Linux.
Mainly follows the design of https://github.com/flutter/flutter/pull/130494 .
Some differences are:
* Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
* Linux has no add2app.
The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.
### Tests
This PR adds new tests to cover the various use cases.
* packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
* Unit tests the Linux-specific part of building native assets.
It also extends various existing tests:
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
* Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.
2023-09-18 11:13:37 +00:00
gaaclarke
43260cced9
moved hello_world_impeller to a 7pro ( #134830 )
...
arm64 is necessary for this test
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-15 12:28:16 -07:00
Zachary Anderson
1e4a1be681
Move two tests on Pixel 7 from staging to prod ( #134784 )
...
Related https://github.com/flutter/flutter/issues/134698
2023-09-14 19:10:37 -07:00
Victoria Ashworth
eb4b97d63c
Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test ( #134693 )
...
Test added in https://github.com/flutter/flutter/pull/134493 requires an
older version of Xcode because default version of Xcode is not
compatible with macOS version in CI.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-14 13:56:00 -05:00
gaaclarke
57ad4ff018
Added a devicelab test for vulkan validation layers ( #134685 )
...
This makes sure validation layers are being used and that there are no
validation errors
fixes https://github.com/flutter/flutter/issues/134175
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-14 09:13:35 -07:00
Victoria Ashworth
af5ac930d8
Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device ( #134493 )
...
Xcode uses the CONFIGURATION_BUILD_DIR build setting to determine the location of the bundle to build and install. When launching an app via Xcode with the Xcode debug workflow (for iOS 17 physical devices), temporarily set the CONFIGURATION_BUILD_DIR to the location of the bundle so Xcode can find it.
Also, added a Xcode Debug version of the `microbenchmarks_ios` integration test since it uses `flutter run --profile` without using `--use-application-binary`.
Fixes https://github.com/flutter/flutter/issues/134186 .
2023-09-13 18:08:35 +00:00
Flutter GitHub Bot
f38dcb1229
Marks Windows module_custom_host_app_name_test to be flaky ( #134645 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows module_custom_host_app_name_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/134644
2023-09-13 09:36:18 -07:00
Flutter GitHub Bot
639c092b5d
Marks Windows_android channels_integration_test_win to be flaky ( #134637 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_android channels_integration_test_win"
}
-->
Issue link: https://github.com/flutter/flutter/issues/134636
2023-09-13 09:35:22 -07:00
keyonghan
3e1e869a54
Revert "Retry Linux web tests 1 time on roll presubmit" ( #134586 )
...
Reverts flutter/flutter#134552
2023-09-12 22:20:39 +00:00
Zachary Anderson
64c1223b9c
Retry Linux web tests 1 time on roll presubmit ( #134552 )
...
A flake in this shard caused an engine roll to fail here https://github.com/flutter/flutter/pull/134526
2023-09-12 18:29:02 +00:00
Flutter GitHub Bot
bdd96032a0
Marks Windows_android channels_integration_test_win to be unflaky ( #133129 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_android channels_integration_test_win"
}
-->
The issue https://github.com/flutter/flutter/issues/130732 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20channels_integration_test_win%22 ).
This test can be marked as unflaky.
2023-09-12 15:37:30 +00:00