Commit graph

8910 commits

Author SHA1 Message Date
Michael Thomsen 41378e2032 Break long line in flutter create help output (#11756) 2017-08-23 13:13:26 -07:00
Ian Hickson ce035d09c6 Fix non-flexible Chip in a Row. (#11669) 2017-08-23 12:59:01 -07:00
Brenton Simpson 58163e0c39 Rename springConstant to stiffness (#11686)
`stiffness` is the name of a spring's `k` input on [iOS](https://developer.apple.com/documentation/quartzcore/caspringanimation), [Android](https://developer.android.com/topic/libraries/support-library/preview/spring-animation.html), and the [Web](bbc0f831e2/src/index.js (L11-L22)).  To ensure the API is familiar to and easily understood by developers coming from other platforms, Flutter should follow this convention as well.

This is a minimally-breaking change.  Across [all of GitHub](https://github.com/search?l=Dart&q=springConstant&type=Code&utf8=%E2%9C%93), there are only 2 uses of the `springConstant` API (in Mondrian).  Those can be easily changed to use this name.

Closes #11684
2017-08-23 12:58:33 -07:00
Michael Goderbauer f969b777b5 a11y and scrolling with slivers (#11711)
* refactor to assembleSemanticNode

* ++

* cleanup

* fix test

* add note

* review comments

* review feedback

* import fix

* another import fix

* refactor to ensure tag

* tests, tests, tests

* analyzer fixes

* review comments
2017-08-23 12:36:32 -07:00
Chris Bracken b4f6e56720 Include main entrypoint in FLX snapshot checksum (#11762)
During FLX snapshotting, changes to (or absence of) any of the following
should trigger re-snapshot:

  1. main() entrypoint source
  2. transitive closure of sources reachable from the entrypoint source
  3. the output snapshot
2017-08-23 12:10:52 -07:00
Jason Simmons bb2554abcd Fix the continue-at flag in the curl command used to download the Dart SDK (#11757)
Fixes https://github.com/flutter/flutter/issues/11722
2017-08-23 11:28:19 -07:00
Chris Bracken dc5d2937bb Suppress libmobilegestalt noise from iOS device logging (#11745)
This patch supports basic filtering of log lines from physical iOS
devices, similar to existing functionality for iOS simulator logging.

This patch also suppresses the following two log messages which are
emitted at app startup on iOS 10.3 devices:
  libMobileGestalt MobileGestaltSupport.m:153: pid 123 (Runner) does not have sandbox access for frZQaeyWLUvLjeuEK43hmg and IS NOT appropriately entitled
  libMobileGestalt MobileGestalt.c:550: no access to InverseDeviceID (see <rdar://problem/11744455>)
2017-08-23 10:50:07 -07:00
Ian Hickson 02bdb97b43 Update manual_tests to run on Android again (#11743) 2017-08-23 10:34:37 -07:00
Ian Hickson bf47b34b60 Directionality widget (#11739) 2017-08-23 10:34:20 -07:00
Ian Hickson 9d4dd10f63 Remove a bunch of useless global configuration options. (#11726)
These properties had a high cost in the documentation because they're
all top-level properties, and there's really very little reason for
these values to be configurable in the first place.
2017-08-23 10:33:41 -07:00
Chris Bracken 1962b61b67 Roll engine to 0062701c7c10029e86394e2599047ae993f7f492 (#11746) 2017-08-23 09:31:37 -07:00
Jakob Andersen 5d0d6126a1 Add --template=<type> option to create command. (#11105)
Allows the user to specify the kind of project to create. The default is 'app'. Other choices are 'plugin' (the old '--plugin' behavior), and 'package'.

A Flutter 'package' is a Dart package that depends on Flutter, but does not contain native code.

Fixes #10377.
2017-08-23 13:29:31 +02:00
Mikkel Nygaard Ravn 32ab3dbee0 Support Xcode projects with no schemes (#11750) 2017-08-23 11:58:21 +02:00
Mikkel Nygaard Ravn 9496e6dfa7 Support for app flavors in flutter tooling, #11676 retake (#11734) 2017-08-23 10:55:35 +02:00
Jason Simmons e843cb342d roll engine (#11740) 2017-08-22 17:11:34 -07:00
Jacob Richman 5066750063 Add comments to 3 methods that were missing comments. (#11737)
* Add comments to 3 methods that were missing comments.

Fix out of order (getter, private field, setter) tuple

* Code review fix.
2017-08-22 16:06:22 -07:00
Carlo Bernaschina a8aff38811 Add log to understand flakiness of commands_test (#11720)
The flakiness of commands_test is generally visible via:

```
drive:stdout:   Expected: 'log: paint'
drive:stdout:     Actual: ''
drive:stdout:      Which: is different. Both strings start the same, but the actual value is missing the following trailing characters: log: paint ...
```

By returning the name of the test we will be able to understand if
another test is running by reading the `Actual` value
2017-08-22 09:54:51 -07:00
Mikkel Nygaard Ravn 7c3a45dc6e Revert "Support for app flavors in flutter tooling (#11676)" (#11729)
This reverts commit 8d07d3f652.
2017-08-22 12:24:29 +02:00
Mikkel Nygaard Ravn 8d07d3f652 Support for app flavors in flutter tooling (#11676) 2017-08-22 10:38:23 +02:00
Devon Carew f25e2f5213 Revert "fire service protocol events for frames (#11565)" (#11727)
This reverts commit 5f9acc4125.
2017-08-22 01:06:48 -07:00
Devon Carew 4d0debd4c7 fix some call sites of printError (#11724)
* fix some call sites of printError

* review comments
2017-08-21 23:38:16 -07:00
Devon Carew 5f9acc4125 fire service protocol events for frames (#11565) 2017-08-21 22:12:19 -07:00
Jacob Richman 5462ddb917 Bare bones widget inspector support. (#10332)
Bare bones widget inspector support.

Toggle the widget inspector from the flutter tool by pressing 'i'.
When the widget inspector is select mode:
Pointer down to to inspect a widget.
Pointer click to finalize selection of a widget. You can now interact
with the application as you normally would but with the inspected widget
highlighted.
Click the inspect icon in bottom left corner of screen to reactivate
select mode.
2017-08-21 16:17:54 -07:00
Chris Bracken 9c04aa15b3 Fix a FormState documentation typo (#11712) 2017-08-21 15:54:02 -07:00
Carlo Bernaschina a24c90d789 Set commands_test flaky (#11710) 2017-08-21 15:31:32 -07:00
Carlo Bernaschina 6643db0106 Add documentation to waitForServiceExtension (#11708)
Addresses
3b4687bf69 (r134325222)
2017-08-21 14:16:30 -07:00
Chris Bracken 1e0b1f11c8 Roll engine to 600567ef152452ded9914aa6aa441ce8cc66b74b (#11707) 2017-08-21 13:41:54 -07:00
Carlo Bernaschina 937b98e1b9 Fix flakiness of commands_test (#11705)
- Wait for full Hot Reload
- Wait for full Restart
- Fallback if checkHealth throws METHOD_NOT_FOUND.
  We try to wait for the service extensions to be registered and retry.
2017-08-21 13:21:00 -07:00
Carlo Bernaschina 79d08f683a Roll engine to e40d4a9fa6315ddc3617ea41e61f93bb45f7c5e1 (#11693) 2017-08-21 12:45:48 -07:00
Jacob Richman 4ce8c94e0d Use the phrase "must not be null" everywhere instead of "cannot be null" (#11683)
when describing non-nullable method arguments.
2017-08-18 13:37:31 -07:00
Zachary Anderson 47fe630e4e Roll Dart SDK forward for analyzer fix for Fuchsia (#11637) 2017-08-16 19:31:59 -07:00
Carlo Bernaschina 272b0b956d Remove unnecessary closures (#11647)
Some widgets are using closures even if the only values that are
captured are this, context or widget, that can be accessed even from
methods of the State object.
2017-08-16 17:11:27 -07:00
Carlo Bernaschina 2e57189aa4 Roll engine to a246501917b8b77e856db253817ce7c2cc25b9c2 (#11643) 2017-08-16 16:19:45 -07:00
Ian Hickson 0799ff5b6c Revert "Revert "Rollback patch that broke microbenchmarks" (#11641)" (#11645)
This reverts commit 1705bf3c73.
2017-08-16 14:59:01 -07:00
Ian Hickson 1705bf3c73 Revert "Rollback patch that broke microbenchmarks" (#11641)
* Revert "Fix a typo in the saved certificate error message (#11640)"

This reverts commit bfda885a9d.

* Revert "Rollback patch that broke microbenchmarks (#11616)"

This reverts commit 70fe6f4c23.
2017-08-16 14:46:50 -07:00
xster bfda885a9d Fix a typo in the saved certificate error message (#11640) 2017-08-16 13:59:05 -07:00
Ian Hickson 70fe6f4c23 Rollback patch that broke microbenchmarks (#11616)
* Revert "Extract snapshotting logic to Snapshotter class (#11591)"

This reverts commit 309a2d78fb.

* Revert "Minor whitespace formatting fix (#11590)"

This reverts commit bf69c3c69b.

* Revert "Avoid rebuilding snapshots if no change to source (#11551)"

This reverts commit 74835db563.
2017-08-15 17:53:58 -07:00
xster 946a28580c Add some doc about the page route's T type (#11627) 2017-08-15 15:38:42 -07:00
Jacob Richman 0c158d549e Cleanup DiagnosticsProperty documentation. (#11514) 2017-08-15 12:16:27 -07:00
xster 5f52457f1b Let android create template have an explicit flutter splash screen flag (#11622)
* Let android create template have an explicit flutter splash screen flag

* minor language tweak
2017-08-15 11:19:21 -07:00
Dan Rubel 3a31c35ba0 Rename .analysis_options to analysis_options.yaml (#11594) 2017-08-15 08:46:42 -04:00
xster 225da92342 Revert engine roll (#11621)
* Revert "Create template splash screens for Android and iOS (#11505)"

This reverts commit 1ad4a088f1.

* Revert "Roll engine (#11619)"

This reverts commit ea78f448e4.
2017-08-14 18:41:56 -07:00
xster 1ad4a088f1 Create template splash screens for Android and iOS (#11505)
* Add iOS template

* Android

* Let the engine reset the theme without the activity knowing

* Small tweak

* Replace assets with different vectors

* Let the template hookup have no actual image assets

* Add back placeholder assets with 1px transparent pngs

* Fix drawable xml

* clean up an extraneous line in the storyboard xml
2017-08-14 17:20:36 -07:00
xster ea78f448e4 Roll engine (#11619)
* roll

* kick the tests again

* Revert "kick the tests again"

This reverts commit 4480a02ce2.
2017-08-14 17:17:49 -07:00
xster 4cb3a98f2c [Discuss] Let the initial date picker mode be selectable (#11614)
* Let the initial date picker mode be selectable

* Doc for enum

* Add a test

* Add a comment for test

* actually decouple test from setup state
2017-08-14 14:54:23 -07:00
Mikkel Nygaard Ravn 3b8159564f Alpha post-roll work (#11608) 2017-08-14 20:28:34 +02:00
ameiyil b156a0f054 Wrap the label widget of the Chip in a Flexible. (#11523) (#11554)
* Wrap the label widget of the Chip in a Flexible. (#11523)

* This allows the Chip to constrain the size of its content after taking into account the space occupied by the avatar and delete icon (if they are present)

* Adding unit tests to evaluate correct size constraints of the Chip widget's label. (#11523)

* Minor change in formatting.

* Adjust function formatting.
2017-08-11 22:01:40 -07:00
Chris Bracken 309a2d78fb Extract snapshotting logic to Snapshotter class (#11591)
First step in eliminating code duplication between script snapshotting
(in FLX build) and AOT, assembly AOT snapshotting.
2017-08-11 12:58:35 -07:00
Sarah Zakarias f1f5d4f3a8 Add integration test for platform interaction (#11580) 2017-08-11 10:38:12 +02:00
Jason Simmons 4f61061733 Roll engine to fef7d827d6e22830ee6c88e8260f118a6b3fbcd9 (#11588) 2017-08-10 18:03:19 -07:00