Commit graph

17836 commits

Author SHA1 Message Date
Jonah Williams 421056ee54
Revert "[flutter_tools] initialize frontend server with build (#49405)" (#51476)
This reverts commit 59cc3cdf01.
2020-02-26 07:24:18 -08:00
Vyacheslav Egorov c0565c417b
Revert "Retry cURL downloads (#50731)" (#51466)
This reverts commit 492fb6381e.

Reason for revert: Dart HHH infrastructure including Golem builders are using older images which have older curl which does not support these flags. Upgrading images takes long time - so in the interim we are forced to revert to avoid accumulating gap in coverage.
2020-02-26 12:10:41 +01:00
Fedor Korotkov 492fb6381e
Retry cURL downloads (#50731)
Retry downloading Dart SDK at least 3 times with a 5 seconds wait in between retries
2020-02-25 22:29:16 -05:00
Christopher Fujino 23757c28e3
Run verify-binaries-signed on pre-submit when merging to release branches (#51221) 2020-02-25 18:12:29 -08:00
Alexandre Ardhuin a4054938ce
unnecessary multiline strings (#50806) 2020-02-25 18:12:17 -08:00
Dan Field 419a2853a8
Revert "Live image cache" (#51441)
* Revert "Live image cache (#51249)"

This reverts commit e2dcdb60e3.

* fix tests for other commit
2020-02-25 16:52:47 -08:00
Dan Field 7cbe55cf1a
Avoid caching image load failures that are retriable (#51398) 2020-02-25 14:56:04 -08:00
Zachary Anderson bc4bd7bd55
[flutter_tools] Don't try to run pub before the version command (#51436) 2020-02-25 17:19:47 -05:00
stuartmorgan 22c807773a
Automatically add plugin projects to Windows .sln (#51246)
Adds utility code for managing list of plugin projects within a solution file, updating them as the plugins change.

This is a prototype of an approach to solution-level portion of Windows plugin tooling; it may not be what the final plugin handling on Windows uses, but it makes things much better in the short term, and gives us a baseline to evaluate other possible solution management systems against.

Part of #32719
2020-02-25 14:16:27 -08:00
Greg Spencer c71978f600
Remove deprecated DefaultFocusTraversal widget (#51240)
Remove deprecated DefaultFocusTraversal widget
2020-02-25 14:15:35 -08:00
Ferhat 69080e07e6
[Perf/codesize] Reduce constraint member reads during layout (#51418) 2020-02-25 13:50:21 -08:00
Nate Bosch 9228b87eb3
Don't use a default test randomize ordering seed (#51018)
Fixes #51010

The test package differentiates between passing and not passing this
argument. A previous version had a bug that treated passing `0`
identically to not passing the argument, and the flutter test runner
relied on this bug by always passing a value and using a default of `0`.

- Remove the argument defaults throughout to make it clear that `null`
  is a valid value and the default.
- Remove the argument defaulting on the argument parser.
- Update the wording of the usage for this argument, this will also be
  updated on the `package:test` side.
2020-02-25 13:01:40 -08:00
Zachary Anderson d73dd6b356
[flutter_tools] Rework iOS vmservice handshake failure usage event (#51419) 2020-02-25 15:22:17 -05:00
Christopher Fujino 1ec2a43672
Remove usage of ideviceinstaller in favor of ios-deploy (#50772) 2020-02-25 09:10:31 -08:00
Christopher Fujino 805f7ec9f4
Remove usage of ideviceinstaller in favor of ios-deploy (#50772) 2020-02-25 09:10:01 -08:00
Christopher Fujino 704fb4cbc7
Remove usage of ideviceinstaller in favor of ios-deploy (#50772) 2020-02-25 09:09:40 -08:00
engine-flutter-autoroll 2078cc4d5f
Roll engine f2f8c342be32..888a62cf2298 (67 commits) (#51391)
* 5b0cbbe50 Roll fuchsia/sdk/core/mac-amd64 from _jvYk... to WZgbp... (flutter/engine#16692)

* cbb0ff8fd Roll src/third_party/skia c5ff41f2976e..7dfb46e7f397 (20 commits) (flutter/engine#16691)

* ab454ea08 Roll src/third_party/dart 0f141be8bd52..7469b87b042a (9 commits) (flutter/engine#16693)

* 1b7378494 fix param (flutter/engine#16694)

* bdd2cf869 Roll src/third_party/skia 7dfb46e7f397..9baef3593c3c (3 commits) (flutter/engine#16696)

* 8f0bbfad3 Roll src/third_party/skia 9baef3593c3c..ed1ff23c2768 (5 commits) (flutter/engine#16699)

* f052d2e03 Roll fuchsia/sdk/core/linux-amd64 from VHyDa... to YPr0t... (flutter/engine#16701)

* 3fe33257b Roll src/third_party/dart 7469b87b042a..e187e42593e8 (11 commits) (flutter/engine#16702)

* f83092a95 Roll src/third_party/skia ed1ff23c2768..a5097354217b (1 commits) (flutter/engine#16703)

* 6b3d43963 Roll src/third_party/skia a5097354217b..2c2db2762809 (1 commits) (flutter/engine#16704)

* fdabcaddf Enable lazy-async-stacks by-default in all modes (flutter/engine#16556)

* 02aa865da Fix the newline on some keyboards (flutter/engine#16560)

* cde7d47cb Roll src/third_party/dart e187e42593e8..81d4cc6bc99a (3 commits) (flutter/engine#16705)

* 14a2b03db Roll fuchsia/sdk/core/mac-amd64 from WZgbp... to 78ZcV... (flutter/engine#16706)

* 7b0453e40 Roll src/third_party/skia 2c2db2762809..9d4e31d6cda5 (1 commits) (flutter/engine#16707)

* 5cef6d0a8 Roll fuchsia/sdk/core/linux-amd64 from YPr0t... to CZTpy... (flutter/engine#16708)

* 0ef67b5e7 opt out dart:ui from nnbd (flutter/engine#16473)

* bc4a27fc2 [shell tests] Integrate Vulkan with Shell Tests (flutter/engine#16621)

* 2fdba5267 Roll src/third_party/skia 9d4e31d6cda5..62076977a0b7 (11 commits) (flutter/engine#16710)

* 969cfc17a Roll src/third_party/skia 62076977a0b7..1d589a578ca4 (6 commits) (flutter/engine#16712)

* 8eb727ec3 Flush the SkCanvas when submitting a frame in ShellTestPlatformViewVulkan::OffscreenSurface (flutter/engine#16717)

* e44f99bbe Roll src/third_party/skia 1d589a578ca4..706851dc99d9 (2 commits) (flutter/engine#16714)

* 60b27fd54 Reland "Remove usage of Dart_AllocateWithNativeFields" (flutter/engine#16713)

* 7a50e4de9 Roll src/third_party/dart 81d4cc6bc99a..fd20c7b92bb8 (31 commits) (flutter/engine#16716)

* 4aaafe0d2 Roll src/third_party/skia 706851dc99d9..df283d01cabb (3 commits) (flutter/engine#16719)

* e18aba332 Refactor of ClaimDartHandle -> AssociateWithDartWrapper (flutter/engine#16720)

* 66742b6d3 Roll src/third_party/skia df283d01cabb..3ffa7af75301 (1 commits) (flutter/engine#16722)

* e0303b03c Roll src/third_party/dart fd20c7b92bb8..6ef9131d82c4 (7 commits) (flutter/engine#16723)

* 0bd69f9d5 Roll src/third_party/skia 3ffa7af75301..77521d9e06e8 (2 commits) (flutter/engine#16725)

* 3e692865f Roll fuchsia/sdk/core/mac-amd64 from 78ZcV... to iYYAH... (flutter/engine#16726)

* 704396b32 Roll fuchsia/sdk/core/linux-amd64 from CZTpy... to -u-iU... (flutter/engine#16727)

* 645d4e631 Roll src/third_party/dart 6ef9131d82c4..5829fc7829d5 (3 commits) (flutter/engine#16728)

* b73dfed39 Roll src/third_party/skia 77521d9e06e8..392846665c40 (1 commits) (flutter/engine#16729)

* 2724727b1 Roll src/third_party/skia 392846665c40..bf5cb0f539e7 (1 commits) (flutter/engine#16730)

* ab0dd1297 [web] Running safari tests on LUCI (flutter/engine#16715)

* e5091a8ca Enable Vulkan-related shell unittests on Fuchsia (flutter/engine#16718)

* 930a80ac8 Fix some compiler warnings in newer versions of Clang. (flutter/engine#16733)

* 941aee35b [web] add comment to skipped safari test (flutter/engine#16737)

* 136a057f2 [web] Rename LineMetrics.text to LineMetrics.displayText (flutter/engine#16734)

* afe7968e6 [web] Paragraph.longestLine doesn't need to check for `isSingleLine` anymore (flutter/engine#16736)

* c3f4c1a08 Migrate Path to AssociateWithDartWrapper (flutter/engine#16753)

* d0c2418df Add support for Increase Contrast on iOS (flutter/engine#15343)

* 6d2cbb2db Roll src/third_party/skia bf5cb0f539e7..46f5c5f08b61 (2 commits) (flutter/engine#16732)

* f758eb97c Roll fuchsia/sdk/core/linux-amd64 from -u-iU... to 3rB22... (flutter/engine#16752)

* a4a1f4f6b Roll fuchsia/sdk/core/mac-amd64 from iYYAH... to 5B5jq... (flutter/engine#16744)

* 8caf6d1d3 Roll src/third_party/skia 46f5c5f08b61..9e8f60534464 (29 commits) (flutter/engine#16754)

* 340f85559 Roll fuchsia/sdk/core/mac-amd64 from 5B5jq... to g1vJn... (flutter/engine#16755)

* 9a9abb78f Roll src/third_party/skia 9e8f60534464..d1c90e10f0ca (1 commits) (flutter/engine#16757)

* 2e12cdc90 Roll src/third_party/skia d1c90e10f0ca..998066127e0d (1 commits) (flutter/engine#16759)

* 566cfae1b Roll src/third_party/skia 998066127e0d..57bc977e124c (3 commits) (flutter/engine#16762)

* 73fdff1e2 Roll fuchsia/sdk/core/linux-amd64 from 3rB22... to PGfiE... (flutter/engine#16763)

* ecca1750d Roll fuchsia/sdk/core/mac-amd64 from g1vJn... to mcI8X... (flutter/engine#16764)

* 4d505170a Roll src/third_party/skia 57bc977e124c..cc5415a8ce36 (1 commits) (flutter/engine#16767)

* 237ddb1be Roll src/third_party/skia cc5415a8ce36..1cec4d5e3d92 (2 commits) (flutter/engine#16769)

* 8da64e067 Roll src/third_party/dart 5829fc7829d5..c75256299280 (43 commits) (flutter/engine#16770)

* 0d87160bd Roll src/third_party/skia 1cec4d5e3d92..7d252302268a (2 commits) (flutter/engine#16771)

* 1aef7a436 Delete FlutterAppDelegate_Internal.h (flutter/engine#16772)

* b87bb0a16 [web] Fix canvas leak when dpi changes. Evict from BitmapCanvas cache under… (flutter/engine#16721)

* e0e24f579 Roll src/third_party/skia 7d252302268a..03b8ab225fd7 (8 commits) (flutter/engine#16773)

* 38dc2ea67 [i18n] Deprecates fuchsia.timezone.Timezone (flutter/engine#16700)

* 92abb22c6 Reland "Lift restriction that embedders may not trample the render thread OpenGL context in composition callbacks." (flutter/engine#16711)

* 971122b31 [web] Reduce the usage of unnecessary lists in pointer binding (flutter/engine#16745)

* d67005945 [web] Respect maxLines when calculating boxes for a range (flutter/engine#16749)

* 5496bb48c Roll src/third_party/skia 03b8ab225fd7..659cc1c90705 (4 commits) (flutter/engine#16774)

* bad1fbe3c Roll src/third_party/dart c75256299280..73f6d15665a3 (9 commits) (flutter/engine#16776)

* d2e2cc9d4 Roll fuchsia/sdk/core/mac-amd64 from mcI8X... to O6w2L... (flutter/engine#16777)

* 888a62cf2 Revert "Enable lazy-async-stacks by-default in all modes (#16556)" (flutter/engine#16781)
2020-02-24 22:02:26 -08:00
Hans Muller 13e1336e6c
Generate message lookup in gen_l10n (#50733) 2020-02-24 20:17:13 -08:00
Hans Muller 9b3754d56f
Extend the gen_l10n integration test (#51375) 2020-02-24 16:42:30 -08:00
LongCatIsLooong eb00c56205
fix symobol refs in the dynamic color doc (#46003) 2020-02-24 16:21:17 -08:00
Yegor d95a1a70a2
add WidgetBuildRecorder for benchmarking building widgets (#51088) 2020-02-24 16:08:40 -08:00
Dan Field 889e606ceb
Script to find Flutter earliest Flutter revision that contains an engine revision (#50948) 2020-02-24 14:49:12 -08:00
Jonah Williams 59cc3cdf01
[flutter_tools] initialize frontend server with build (#49405) 2020-02-24 14:21:33 -08:00
Jonah Williams e6e79bce6f
[flutter_tools] remove vm_service_client dependency from flutter tool (#51227) 2020-02-24 14:19:43 -08:00
Dan Field e2dcdb60e3
Live image cache (#51249)
* Revert "Revert "Live image cache (#50318)" (#51131)"

This reverts commit 2f09d601b5.

* Fix eviction of a pending image
2020-02-24 13:47:53 -08:00
Nurhan Turgut 9ba4eb04dd
[web] Smoke tests for web engine (#51003)
* smoke test for web

* fix comments and remove logs

* addressing reviewer comments

* fix analyzer issue

* running the test on cirrus

* cirrus yaml syntax error

* pub get for web_drivers

* go to the examples directory before running the flutter app

* cirrus is not able to find chromedriver. add a sleep to see if timing is the issue.

* run chrome driver in the background

* After PR #51084, flutter drive command can build and run a web app. Clean flutter run command from cirrus.yml

* enable web
2020-02-24 13:09:21 -08:00
Jonah Williams 3411129cc5
[flutter_tools] don't fix chrome window size, add more logs (#51346) 2020-02-24 12:26:05 -08:00
Jonah Williams 7572ec47bd
[flutter_tools] add more search paths for source maps (#51307) 2020-02-24 10:40:08 -08:00
Dmitry Ratushnyy a70e4aec93
Material DataTable: added support of setting table row border thickness (#49692) 2020-02-24 09:46:03 -08:00
Michel Feinstein 92a028cf6d
Removed the unecessary "new" keyword from the docs (#51075) 2020-02-24 09:22:18 -08:00
sjindel-google 6f9ed76faf
Update covariant_templates_test after changes to TypeError. (#51330)
TypeError no longer implements AssertionError after https://github.com/dart-lang/sdk/issues/40317.
2020-02-24 16:52:11 +01:00
Aadarsh Patel 1d4667bb38
Fixed a typo (#51302) 2020-02-23 19:26:02 -08:00
Dan Field 4df8fdb7df
update cache for flutter test/fast command (#51235) 2020-02-22 18:24:03 -08:00
Greg Spencer c4345d2a0a
Add a sample for FocusTraversalGroup (#51161) 2020-02-22 16:54:06 -08:00
Shi-Hao Hong 6d4121c075
Fix tests that rely on FadeTransition incorrectly and depend on implementation details of FadeUpwardsTransitionBuilder (#51150) 2020-02-22 16:54:02 -08:00
Angjie Li 5ee4147283
Allow developers to run flutter driver web test directly (#51084) 2020-02-22 16:49:03 -08:00
shihchanghsiungsonos 3f9d08a002
Fix the issue of Can't find \android\app${assetsDirectory} #50913 (#51158) 2020-02-22 17:06:01 -07:00
Tanat Boozayaangool bf8e2c1449
Fix typo in description for PointerEvent.radiusMax (#51149) 2020-02-21 14:21:25 -08:00
Shouichi Kamiya e8e99e49f9
Fix TextEditingController doc to call super.initState first (#51089) 2020-02-21 14:16:04 -08:00
Jonah Williams bb74a328b5
[flutter_tools] adds etag/cache control header to debug asset server (#51143) 2020-02-21 14:15:54 -08:00
Greg Spencer c5dd3ec47a
Fix stuck keys when shift is released before the letter. (#51095)
This fixes a problem where if you press "Shift" and then "A", then release "Shift" and then "a", then the "A" key will be "stuck" on because the logical key for the key down message is different (capital "A") from the logical key for the key up message (lowercase "a").

This PR changes the pressed keys logic so that it uses the physical key to add/remove keys from the list of pressed keys, but keeps the associated logical key.

This does mean that after the "Shift" key goes up, the pressed keys contains a capital "A" and it doesn't switch to be a lowercase "a", but there isn't currently any mechanism we can use to do that remapping. This is far less surprising than the current behavior, but is still not quite correct.

I fixed the event simulation code to take a physicalKey so that it could be matched with the logical key, but the event simulation code isn't up to the task, since it can only simulate keys that appear in the key maps. The new platform key event design should fix that (added TODOs).
2020-02-21 14:13:38 -08:00
Jason Simmons 479e27c9f1
Update stack trace test goldens to handle engine builds with lazy async stacks (#51216)
The next engine roll will introduce --lazy-async-stacks, which affects the
contents of stack traces.  This updates test expectations to match both the
old and new stack trace formats.
2020-02-21 12:05:30 -08:00
Yegor d5844e8a4a
Enable TextStyle hash test on the Web (#50985) 2020-02-21 11:26:03 -08:00
Dan Field f79963c675
Revert "Roll engine 77c5812d48b8..84dc383b6428 (16 commits) (#51072)" (#51212)
This reverts commit 0b5667ac12.
2020-02-21 11:17:03 -08:00
Dan Field d46d77dc05
Make test more flexible for new args from vm (#51217) 2020-02-21 10:35:54 -08:00
Dan Field 7034bc57df
Reduce duration of benchmark to avoid timeout (#51214) 2020-02-21 09:59:23 -08:00
Clement Skau 3275adb7fb
Updates test expectations for stack traces. (#51185)
With --lazy-async-stacks the stack output has changed slightly so updating the expect files to match.

This is a follow-up to https://github.com/flutter/flutter/pull/51047 as a preparation for the next engine roll which will start enabling --lazy-async-stacks in JIT mode.
2020-02-21 13:38:56 +01:00
engine-flutter-autoroll 0b5667ac12
Roll engine 77c5812d48b8..84dc383b6428 (16 commits) (#51072)
* 48d64c13e update hash code logic on the web (flutter/engine#16624)

* 110c1c9ad Lift restriction that embedders may not trample the render thread OpenGL context in composition callbacks. (flutter/engine#16653)

* ca6165f91 Roll src/third_party/skia c1bb9cba16be..7281a8623799 (9 commits) (flutter/engine#16665)

* c264e1cf9 Roll src/third_party/dart 999eeea5a3ff..3883c6070942 (5 commits) (flutter/engine#16666)

* 1cd130444 Control test timeouts based on debugger status or command line flags. (flutter/engine#16375)

* 9309ff549 Roll src/third_party/skia 7281a8623799..fe6fe6c5a8a8 (7 commits) (flutter/engine#16667)

* d03582d18 URL-encode asset URLs so assets are properly loaded (flutter/engine#16630)

* 40e3ab12b Roll fuchsia/sdk/core/mac-amd64 from 06MUz... to _jvYk... (flutter/engine#16668)

* ef9e7b1a1 Revert "Lift restriction that embedders may not trample the render thread OpenGL context in composition callbacks. (#16653)" (flutter/engine#16674)

* 16eeac54c Roll src/third_party/skia fe6fe6c5a8a8..799a23cf0602 (1 commits) (flutter/engine#16669)

* c79620580 Roll fuchsia/sdk/core/linux-amd64 from 2W9Xr... to VHyDa... (flutter/engine#16670)

* 4f4a1d503 Roll src/third_party/dart 3883c6070942..c11c0ae3fdca (9 commits) (flutter/engine#16673)

* 80f73eeaf Roll src/third_party/skia 799a23cf0602..d0d033a12556 (3 commits) (flutter/engine#16675)

* 151688ceb Roll src/third_party/skia d0d033a12556..a037445e07a7 (4 commits) (flutter/engine#16676)

* 8e82311e3 Roll src/third_party/skia a037445e07a7..c5ff41f2976e (1 commits) (flutter/engine#16677)

* 84dc383b6 Roll src/third_party/dart c11c0ae3fdca..707ecda05e14 (1 commits) (flutter/engine#16678)
2020-02-20 14:27:02 -08:00
Jonah Williams 3cee8e0eb0
[flutter_tools] include depfile outputs in gradle outputs (#50877) 2020-02-20 13:24:36 -08:00
Dan Field 2f09d601b5
Revert "Live image cache (#50318)" (#51131)
This reverts commit 1602be6ab6.
2020-02-20 13:20:28 -08:00