Commit graph

12381 commits

Author SHA1 Message Date
Dan Field 3d812c1b96
Reduce gradle deps (#50691)
* drop unnecessary test deps

* bump to junit 4.13
2020-02-12 21:14:54 -08:00
stuartmorgan 7bdd4757ec
Create plugin symlinks for Windows and Linux (#50599)
This makes ephemeral symlinks to each plugin, for use by build systems.
This is similar to the logic implemented in the Podfile on iOS and
macOS, but managed internally to the Flutter tool.

Exploration for addressing #32719 and #32720
Related to #41146
2020-02-12 16:23:27 -08:00
gaaclarke d3c318ed49
Made xcode_backend stop on error. (#50664) 2020-02-12 16:23:01 -08:00
Greg Spencer d57d493507
Reland: Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50672)
This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree.

The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup.

- Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
2020-02-12 16:22:01 -08:00
Greg Spencer b2a7ff36a9
Fix lack of ancestor notification when a focus node is unfocus… (#50319)
This fixes a problem when unfocusing focus nodes where the ancestor focus nodes and scopes don't receive notification that a child was unfocused.

Fixes #43497
2020-02-12 16:20:08 -08:00
Jenn Magder 24017e761e
Revert "AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)" (#50674) 2020-02-12 15:20:13 -08:00
Michel Feinstein 508c35940b
Added linking to viewInsets and viewPadding in MediaQuery padding docs (#50659) 2020-02-12 14:58:05 -08:00
Shi-Hao Hong 23d61a81dc
AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)
* Add ButtonBar.overflowButtonSpacing

* Add AlertDialog overflow button spacing functionality
2020-02-12 14:53:59 -08:00
chunhtai 7168421e9f
fixes route name annoucement in navigator (#50495) 2020-02-12 14:53:05 -08:00
Jacob Richman 7820641a05
Fix Diagnostics subclasses that had the wrong default value for the named parameter. (#50645) 2020-02-12 14:52:50 -08:00
Dan Field 24f8f799da
add an --enable-vmservice flag (#50663) 2020-02-12 14:52:09 -08:00
Dan Field 58a4122b97
update packages (#50666) 2020-02-12 14:51:38 -08:00
Greg Spencer c132c0faa9
Revert "Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50660)
This reverts commit 8ef5e2f046 because it breaks some semantics tests.
2020-02-12 13:37:36 -08:00
sanni prasad 7f819c935b
Update cupertino_icons dependency version in pubspec.yaml template (#50479) 2020-02-12 13:28:03 -08:00
Josh Burton 2b16202ea2
Adds shadowColor property to the Card widget (#47273) 2020-02-12 13:23:02 -08:00
Zachary Anderson b9ecebf101
Reland: [flutter_tools] Disable analytics for more bots (#50641) 2020-02-12 10:58:02 -08:00
sjindel-google 3aa72cc2f2
Use ELF for AOT snapshots on Fuchsia. (#50468) 2020-02-12 10:53:04 -08:00
Arthur Denner d3e1e29375
SimpleDialogOption: support custom padding (#50035) 2020-02-12 08:58:03 -08:00
Anthony Mansour 4c1045c0f8
Fixed preferredSize getter in TabBar (#41299) 2020-02-12 08:53:02 -08:00
Zachary Anderson 1903ce012e
Revert "[flutter_tools] Disable analytics for more bots (#50579)" (#50622)
This reverts commit 0a38f29c0d.
2020-02-11 22:47:41 -08:00
Jenn Magder 7c24ebc79b
Map arm64e devices to arm64 devices (#50612) 2020-02-11 19:43:43 -08:00
Gary Qian cad08149ca
Remove invalid assert for TextHeightBehavior (#50603) 2020-02-11 19:08:05 -05:00
Jonah Williams 953df281ea
Revert "Revert "Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480)" (#50502)" (#50512)
This reverts commit 9bc0e6a991.
2020-02-11 16:05:53 -08:00
Jonah Williams 5406258fc6
[flutter_tools] fix crash when IsolateRef returns sentinel (#50611) 2020-02-11 16:03:45 -08:00
Jenn Magder bfbb347682
Use BUILD_LIBRARY_FOR_DISTRIBUTION build setting for generating add-to-app frameworks (#50536) 2020-02-11 15:53:02 -08:00
Zachary Anderson 0a38f29c0d
[flutter_tools] Disable analytics for more bots (#50579) 2020-02-11 15:48:02 -08:00
Jonah Williams 18f38cd45b
Switch flutter_tools to use frontend_server for web compilation (#50365) 2020-02-11 15:43:46 -08:00
Jason Simmons 324e20de09
Update TextStyle.hashCode to handle list fields (#50520) 2020-02-11 14:38:03 -08:00
LongCatIsLooong 48d5fcabbd
evict _SliverFractionalPadding cache on constraint change (#50523) 2020-02-11 12:52:53 -08:00
Alexandre Ardhuin f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Lamonte fd1062debd
Exposed optional scrollController property in ReorderableListView (#49148) 2020-02-11 10:58:02 -08:00
Jenn Magder e002698c35
Turn back on macOS shard Cirrus caching (#50496) 2020-02-11 10:37:53 -08:00
Jonah Williams fa44a1cf37
[flutter_tools] fix path escaping on in depfile generation (#50538) 2020-02-11 09:31:58 -08:00
Greg Spencer 8ef5e2f046
Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235)
This change adds a way to provide explicit focus order for a part of the widget tree.

It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.

It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.

As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.

I was able to do this without breaking the API (AFAICT).
2020-02-11 09:18:39 -08:00
Gary Qian f769bcc5c4
Reland "Track lastKnownRemoteTextEditingValue separately from received data" (#50307) 2020-02-10 20:55:48 -05:00
Amir Hardon bcef4edfc8
Make the template plugin example depend on the plugin as a real dependency (#50485) 2020-02-10 16:03:02 -08:00
Mouad Debbar bf551a31fe
EditableText's autofocus:true should not crash (#50372) 2020-02-10 15:58:02 -08:00
Shi-Hao Hong 67826bdce5
Revert "Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616)" (#50516)
This reverts commit 801a6a7e5e.
2020-02-10 14:59:32 -08:00
Greg Spencer 18f8002ec8
Make FocusManager a ChangeNotifier that notifies when the prim… (#50392)
This makes FocusManager a ChangeNotifier that notifies when the primaryFocus changes so that an app can track the current focus.

Fixes #50501
2020-02-10 14:33:31 -08:00
Dan Field 9cb2953e10
Fix image tests that make faulty assumptions about lifecycle of image provider (#50297) 2020-02-10 14:23:01 -08:00
Jonah Williams 568172793c
Add "flutter symbolize" command (#49465) 2020-02-10 14:18:03 -08:00
Dan Field ffc85591c8
more gradle upgrades (#50388) 2020-02-10 14:16:49 -08:00
Michael Goderbauer 6d87337f51
Remove some obsolete // ignore: (#50481) 2020-02-10 14:08:09 -08:00
Jonah Williams 9bc0e6a991
Revert "Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480)" (#50502)
This reverts commit 9020642772.
2020-02-10 13:26:59 -08:00
Zachary Anderson c23d9cd4ce
[flutter_tools] Print emojis in Windows Terminal (#50446) 2020-02-10 10:23:35 -08:00
Per Classon 5f4658973b
Update RefreshIndicator documentation to clarify the need for the child for be scrollable (#50345) 2020-02-10 10:08:02 -08:00
liyuqian b277534026
Assert cache hints are not set for null painters (#49771) 2020-02-10 10:03:03 -08:00
Greg Spencer 9fb781a54a
Update samples to work with Dartpad, and convert all that make… (#50377)
This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site.

It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally.

I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level).

I modified a few of the examples so that they looked nicer, and fit better on the page.

I added the sample description text above each DartPad instance, since that often defines the context of the example.

I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
2020-02-10 10:00:20 -08:00
Jonah Williams 2a6bc617b8
[framework] minimize performance effect of stateless/stateful swap (#50394) 2020-02-10 10:00:11 -08:00
Jonah Williams 6146cd72e4
[flutter_tools] add missing vm_service dep to BUILD.gn (#50454) 2020-02-10 09:59:48 -08:00