Commit graph

7681 commits

Author SHA1 Message Date
Jason Simmons 3d5d63a8aa Accept any nonzero exit code as a signal of failure in the missing dependency test (#8738) 2017-03-13 11:17:09 -07:00
Adam Barth fecc4e6584 Docs for RenderSliverFixedExtentList (#8733)
Also, some renames for more accuracy.
2017-03-13 18:12:33 +00:00
Dan Rubel 8742fb09fa Fix tests (#8736)
* do not forward status if stream is closed
* remove devfs test timeout
2017-03-13 13:47:29 -04:00
Chris Bracken 74e2243ca4 Add details of how to test run a build bot change (#8734)
Add the minimum set of required properties for run_recipe.py and where
to look them up.
2017-03-13 10:14:02 -07:00
Adam Barth f075cf4450 Make some symbols private (#8731)
These symbols were not intended to be public. Also, remove some bogus dartdocs
for PhysicalModeLayer.
2017-03-13 17:04:14 +00:00
Todd Volkert a4c58292b2 Fix and enable broken flutter_tools tests (#8720)
(follow-on to #8698)
2017-03-10 15:34:20 -08:00
Michael Goderbauer 7ede6b530e Use 7-Zip to unzip SDK, if available. (#8721)
Windows' built-in unzippers are painfully slow. It drives me mad!

Unzip SDK with 7-Zip: ~10s
Unzip SDK with Windows: ~90s
2017-03-10 15:21:08 -08:00
Todd Volkert 5d29737a04 Bump mockito to version 2.0.2 (#8713) 2017-03-10 13:53:22 -08:00
Seth Ladd 01ac75f5e4 Callback wasn't clear what the type of the function was (#8712)
Changing to an inline function, making the type more clear.
2017-03-10 13:49:47 -08:00
Alexandre Ardhuin 16d800b204 normalize setter format (#8708) 2017-03-10 21:52:30 +01:00
Yegor 9f020d6104 upgrade package:http so we no longer need custom MultipartRequest (#8715) 2017-03-10 11:05:06 -08:00
Michael Goderbauer 03d3186531 Transfer URIs instead of platform-dependent file paths (#8701) 2017-03-10 10:13:53 -08:00
Todd Volkert 34ed3d2d24 Pay off some technical debt. (#8710)
* Rename `Device.platform` to `Device.targetPlatform` to avoid
  collision with the exported variable from `platform.dart`
2017-03-10 10:11:05 -08:00
Todd Volkert 83d411f979 Change flutter_tools tests to run via pub (#8698)
`all.dart` is no longer needed. Furthermore, it causes tests to
be skipped, or to silently fail to run anything.

Fixes #7941
2017-03-10 09:39:01 -08:00
Chris Bracken 1a2e6f3389 Support Xcode builds in project dirs with spaces (#8709)
Use line-based iteration in place of word-based iteration over the
framework directories, to avoid breaking on spaces.
2017-03-10 09:32:58 -08:00
Jakob Andersen 60c0c3d323 Revert "Eliminate CocoaPods install step (#8694)" (#8705)
* Revert "Eliminate CocoaPods install step (#8694)"

This reverts commit f4a13bc72b.

If the developer is relying on CocoaPods and hasn't done a pod install, we will do it for them. This is needed for a smooth native plugin experience, similar to what Gradle is doing on the Android side.

There's no hard dependency on CocoaPods. We only run pod install if the project uses CocoaPods, so developers are still free to use alternatives if they prefer (and if they don't want to use native plugins).

Fixes #8685
Fixes #8657
Fixes #8526

* Require CocoaPods 1.0.0 or newer.

And make sure we don't get a crash if running `pod install` fails.

* Address review feedback
2017-03-10 13:43:57 +01:00
Alexandre Ardhuin c22812e0ea Flutter style guide: Prefer naming the argument to a setter 'value' (#8691) 2017-03-10 09:00:29 +01:00
Chris Bracken 7b9cefb3be Add brew update step before install/upgrade (#8703)
This avoids unintentionally installing an older version if the
developer's homebrew installation is out-of-date.
2017-03-09 20:45:40 -08:00
Chris Bracken 1bb0d7728e Eliminate brew tap flutter/flutter instruction (#8702)
The flutter tap was deleted as part of the resolution to #7783.
2017-03-09 18:26:38 -08:00
Chris Bracken f4a13bc72b Eliminate CocoaPods install step (#8694)
If the developer is relying on CocoaPods and hasn't done a pod install,
they'll get a build failure indicating the issue.

This also avoids a hard dependency on CocoaPods in the tool and allows
developers to customize their Xcode steps to use alternatives such as
Carthage if they prefer.
2017-03-09 17:57:45 -08:00
Yegor 3146e13414 print less in flutter_tool tests (fixes #8641) (#8699) 2017-03-09 16:51:46 -08:00
Yegor d09591bf7d consistently accept timeout in driver API (#8667) 2017-03-09 16:31:48 -08:00
Todd Volkert 1ada132ee8 Add first replay test (#8628) 2017-03-09 12:58:31 -08:00
Michael Goderbauer 5571cb1140 remove unneded deps to pub_semver (#8688) 2017-03-09 12:57:56 -08:00
Michael Goderbauer f613fef23b Fix tests to pass internally (#8683) 2017-03-09 12:09:20 -08:00
Michael Goderbauer edbfb17b62 remove remaining references to sky_snapshot (#8665) 2017-03-09 11:40:59 -08:00
Michael Goderbauer d7ab9be2bd Be explicit about typed_data deps (#8680) 2017-03-09 11:03:45 -08:00
Hans Muller 00c9e326db Additional Hero tests: destination moves midflight (#8668) 2017-03-09 10:36:53 -08:00
Jason Simmons a97eb12147 Use only Linux workers on Travis (#8678) 2017-03-09 10:06:42 -08:00
Sarah Zakarias 43281de36b Add flutter_view sample (#8486)
* Add flutter_view sample

* Removed platform_services files

* Addressed comments

* update README.md

* Addressed comments.
2017-03-09 12:53:01 +01:00
Sarah Zakarias f0e71cb15c Add support for earlier Android versions in platform_services example (#8621)
* Add support for earlier Android versions

* Addressed comments
2017-03-09 10:41:39 +01:00
Chris Bracken cabd58dbb2 Correct instructions for libimobiledevice install (#8675)
As of the latest Xcode versions, the latest published libimobiledevice
is out-of-date and build from HEAD is required.

This fixes two bugs:
1. Update initial install instructions to add --HEAD flag.
2. Update uninstall, reinstall instructions to include
   --ignore-dependencies flag, since other brew formulae depend on
   libimobiledevice.
2017-03-08 21:24:00 -08:00
Chris Bracken bf6b6e188d Check for CocoaPods installation if required (#8666) 2017-03-08 16:42:31 -08:00
Ian Hickson 54b80cca0d Add a file describing Google's commitments with regard to patents and this project (#8632) 2017-03-08 16:40:36 -08:00
Chris Bracken 2bbdacce35 Improve ideviceinstaller error message (#8662)
Homebrew is an expected part of the iOS toolchain. Update the error
message to assume that.
2017-03-08 15:31:32 -08:00
Alexandre Ardhuin 6a2148dde9 prefer const constructors (#8594)
* prefer const constructors

* fix double throw
2017-03-08 14:58:14 -08:00
Alexandre Ardhuin ce734e8f24 apply the upcoming rule : directives_ordering (#8582) 2017-03-08 14:58:09 -08:00
Alexandre Ardhuin 329e52c02c apply upcoming rule use_collection_literals_when_possible (#8649) 2017-03-08 14:57:31 -08:00
Michael Goderbauer 906103dd10 eliminate sky snapshot (#8631)
* eliminate sky snapshot

* roll engine
2017-03-08 13:33:06 -08:00
Michael Goderbauer e2dccc5e48 Ensure compatibility with older PowerShell versions and better error handling (#8652)
This should make our scripts compatible with PowerShell 2 or newer. PowerShell 2 was released in October 2009 and shipped with Windows 7 as default. (I suspect the scripts are now also compatible with PowerShell 1, but that's unconfirmed). This fixes #8606.

The PR also introduces better error handling when Flutter fail to download the Dart SDK to fix #8627.
2017-03-08 10:52:07 -08:00
mikejurka 0136b965e8 Add http to Fuchsia flutter dependencies (#8647) 2017-03-07 22:51:05 -08:00
Chris Bracken eb14385297 Update CocoaPods install instructions to use Homebrew (#8644)
This is consistent with the rest of the iOS toolchain.
2017-03-07 21:52:40 -08:00
Chris Bracken 53daa55f93 Rollback example Xcode project changes (#8645)
* Revert "Update Hello World to latest iOS project template (#8634)"

This reverts commit 6dc6ed4e97.

* Revert "Update Gallery to latest iOS project template (#8637)"

This reverts commit 84c42aac0e.

* Revert "Update Stocks to latest iOS project template (#8640)"

This reverts commit 90774c188a.
2017-03-07 21:16:34 -08:00
Jakob Andersen a4883de38f Run 'pod install' before building iOS app. (#8609)
Since iOS builds are CocoaPods enabled by default, we should make sure to run `pod install` to get pods wired up before building the app.

Also added a check to `flutter doctor` to verify CocoaPods is installed.

I'm passing FLUTTER_FRAMEWORK_DIR to the `pod install` command, so we can have the app's Podfile link in Flutter.framework as a pod instead of having to copy it over in xcode_backend.sh.
2017-03-07 20:34:38 -08:00
Ian Hickson 68fb3e4868 Farewell, local fork of the http package. (#8642) 2017-03-07 18:08:36 -08:00
Chris Bracken 90774c188a Update Stocks to latest iOS project template (#8640) 2017-03-07 17:42:31 -08:00
Ian Hickson 944ee24b94 Report GlobalKey duplicates (#8593) 2017-03-07 17:17:02 -08:00
Hans Muller 20d401de1b Revert the new "physical model" shadow rendering code (#8636) 2017-03-07 17:15:29 -08:00
Chris Bracken 19ad3ea456 Enable landscape mode in Flutter Gallery (iOS) (#8638)
Already enabled on Android.
2017-03-07 17:13:20 -08:00
Chris Bracken 84c42aac0e Update Gallery to latest iOS project template (#8637) 2017-03-07 17:13:10 -08:00