Tong Mu
fea2c7d671
Redo: Add buttons to gestures ( #31819 )
...
* Revert "Revert "Add buttons to gestures (#30339 )" (#31801 )"
This reverts commit 8fd7fa492a
2019-04-30 09:56:24 -07:00
liyuqian
71a89a469a
Reland "Fix text field selection toolbar under Opacity ( #31097 )" ( #31802 )
...
This reverts commit 120a1fc47f
2019-04-30 09:47:32 -07:00
liyuqian
7cab6d5e1c
Support clipBehavior changes in hot reload ( #31761 )
...
## Description
Make `_RenderCustomClip`'s `clipBehavior` non-final so we can update it during `updateRenderObject`. This will support `clipBehavior` changes in hot reload.
## Related Issues
Fixes #30863
## Tests
I added the following tests:
* ClipRect updates clipBehavior in updateRenderObject
* ClipRRect updates clipBehavior in updateRenderObject
* ClipOval updates clipBehavior in updateRenderObject
* ClipPath updates clipBehavior in updateRenderObject
* PhysicalModel updates clipBehavior in updateRenderObject
* PhysicalShape updates clipBehavior in updateRenderObject
2019-04-30 09:46:38 -07:00
Keerti Parthasarathy
eae67f05df
Make const available for classes that override AssetBundle ( #31807 )
2019-04-30 09:10:04 -07:00
engine-flutter-autoroll
9937d3dfb1
59b91392e Roll src/third_party/skia a6d723f32f32..494aa3db9e78 (1 commits) (flutter/engine#8787) ( #31847 )
...
64b1d38081...59b91392e2flutter/engine#8787 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-30 10:40:53 -04:00
engine-flutter-autoroll
8e7c7fcbd4
64b1d3808 Roll src/third_party/skia 79e53712a05f..a6d723f32f32 (3 commits) (flutter/engine#8785) ( #31830 )
...
c0036315d4...64b1d38081flutter/engine#8785 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-30 06:30:38 -04:00
Greg Spencer
0245a29a04
Keycode generation doc fix ( #31493 )
...
Fixes a typo in the key generator readme.
Updated the examples in the readme to reflect that the examples were for physical key codes, where we're actually talking about logical key codes there.
2019-04-29 21:45:30 -07:00
engine-flutter-autoroll
bc9b56a35d
Roll engine 1ecf924ff861..c0036315d4ca (5 commits) ( #31823 )
...
1ecf924ff8...c0036315d4flutter/engine#8783 )
5aa5b6cbf VirtualDisplay size constraint - add a comment explaining the reason (flutter/engine#8780 )
ee3f04ac8 Roll src/third_party/skia 037884e5080b..bd425405f3aa (3 commits) (flutter/engine#8781 )
ab01d7396 Roll src/third_party/skia d425dee662d1..037884e5080b (10 commits) (flutter/engine#8778 )
a0bb23aad Fix header include guards for fml/thread_local.h (flutter/engine#8721 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-30 00:43:38 -04:00
Dan Field
eac2104bc6
remove assert for Flutter Driver ( #31815 )
2019-04-29 17:03:25 -07:00
Shi-Hao Hong
39712854fc
Fix ExpansionPanelList Duplicate Global Keys Exception ( #31228 )
...
- Move `setState` to only be invoked when guarded by `widget._allowMultiplePanelsOpen`, fixing the case for `ExpansionPanelList`
- Remove setting `_currentOpenPanel` to `widget.initialOpenPanelValue` in `didUpdateWidget`, since this should only occur on `initState` and not every time the widget is updated. This fixes the problem for `ExpansionPanelList.radio`
- Added a `didUpdateWidget` condition for when `ExpansionPanelList` changes into `ExpansionPanelList.radio` to open the panel at `widget.initialOpenPanelValue`
- Added test cases for regression, expansionCallback cases, and `didUpdateWidget` transitions between `ExpansionPanelList` and `ExpansionPanelList.radio`
2019-04-29 16:55:05 -07:00
Jonah Williams
37e25238a8
Attempt to reduce usage of runtimeType ( #31696 )
2019-04-29 16:44:50 -07:00
Dan Field
fe9512fa72
Re-enable const ( #31600 )
...
* Re-enable const
2019-04-29 16:02:42 -07:00
Jonah Williams
8fd7fa492a
Revert "Add buttons to gestures ( #30339 )" ( #31801 )
...
This reverts commit 727e7e829f
2019-04-29 12:59:30 -07:00
Jonah Williams
120a1fc47f
Revert "Fix text field selection toolbar under Opacity ( #31097 )" ( #31800 )
2019-04-29 12:57:35 -07:00
liyuqian
e427c2dd86
Fix text field selection toolbar under Opacity ( #31097 )
...
## Description
As we've introduced offset to the Opacity layer, we have to override
`applyTransform` to make Leader/FollowerLayer work correctly.
## Related Issues
Fixes https://github.com/flutter/flutter/issues/30587
Together with https://github.com/flutter/engine/pull/8585 ,
this test will also exercise test against
https://github.com/flutter/flutter/issues/30586 .
## Tests
I added the following tests:
* text field selection toolbar renders correctly inside opacity
2019-04-29 11:25:41 -07:00
xster
d12f359991
fix edge swiping and dropping back at starting point ( #31623 )
2019-04-29 11:05:24 -07:00
Tong Mu
727e7e829f
Add buttons to gestures ( #30339 )
...
* Callbacks of tap, long press, drag, and double tap GR respond to only primary events.
* Add "secondary" callbacks to tap.
* Recognizers only compete on events if there are any related callbacks.
* Add "kSecondaryButton" constant.
2019-04-29 10:46:33 -07:00
Jonah Williams
c1c15dd702
Revert "update packages and unpin build ( #31736 )" ( #31795 )
2019-04-29 09:56:55 -07:00
engine-flutter-autoroll
2e1c5f2bfa
Roll engine 48a5ce87aeb6..1ecf924ff861 (2 commits) ( #31794 )
...
48a5ce87ae...1ecf924ff8flutter/engine#8773 )
ae724f132 colormatrix is now 0...1 (flutter/engine#8772 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-29 12:17:38 -04:00
Jonah Williams
41b18422df
update packages and unpin build ( #31736 )
2019-04-29 09:10:01 -07:00
Jonah Williams
4ff467191b
make FlutterProject synchronous ( #31757 )
2019-04-29 08:21:32 -07:00
MH Johnson
5412ef07f2
[Material] Update TabController to support dynamic Tabs ( #30884 )
...
* Update TabController to support dynamic tabs.
* Added test for single Tab showing correct color.
2019-04-29 10:35:55 -04:00
Dmitriy Zaitsev
8e66c53f3d
Fix the documentation for UiKitView#creationParams ( #31619 )
...
It looks like the documentation for UiKitView has been copy-pasted from AndroidView or so.
This PR fixes the word 'Android' to 'iOS' for the `creationParams`.
2019-04-29 14:50:44 +02:00
Sander Kersten
9d16b84b35
Fix calculation of hero rectTween when Navigator isn't fullscreen ( #29677 )
2019-04-29 14:43:44 +02:00
James D. Lin
ae5749819b
Make the matchesGoldenFile docs link to an explanation of how to create golden image files ( #31093 )
2019-04-29 14:43:24 +02:00
Antti Ahti
bf8262d85b
Remove trailing whitespace from README template ( #31762 )
2019-04-29 13:04:55 +02:00
Kent Boogaart
392d5b2c28
Fix typo ( #31771 )
2019-04-29 13:04:30 +02:00
Ian Hickson
a17e2a4e2f
Add "feature request" issue template ( #30327 )
2019-04-29 12:39:10 +02:00
engine-flutter-autoroll
e62b06a3ea
48a5ce87a Roll src/third_party/skia d1be9450c7e2..bc94e79eb7b6 (3 commits) (flutter/engine#8771) ( #31776 )
...
c75e09c529...48a5ce87aeflutter/engine#8771 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-29 05:58:18 -04:00
engine-flutter-autoroll
131e2bb6ee
c75e09c52 Roll src/third_party/skia 7056ce14dd15..d1be9450c7e2 (1 commits) (flutter/engine#8770) ( #31770 )
...
98039f78a7...c75e09c529flutter/engine#8770 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-29 02:27:18 -04:00
engine-flutter-autoroll
34bf0c4164
Roll engine 3b1bebf2898b..98039f78a784 (3 commits) ( #31748 )
...
3b1bebf289...98039f78a7flutter/engine#8769 )
8aa51ef92 Roll src/third_party/skia 4732dd31588b..a5dc0f2d7a59 (1 commits) (flutter/engine#8768 )
2c5d35827 Roll src/third_party/skia d7082a5805c8..4732dd31588b (1 commits) (flutter/engine#8767 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com ), and stop
the roller if necessary.
2019-04-28 07:25:18 -04:00
engine-flutter-autoroll
3cd15b52d4
Roll engine 7f753f8f528a..3b1bebf2898b (3 commits) ( #31721 )
...
7f753f8f52...3b1bebf289flutter/engine#8766 )
5846027dc Roll src/third_party/skia 3349fb0195ff..e178c0586cd6 (1 commits) (flutter/engine#8763 )
3493dcfba Rename tightWidth to longestLine (flutter/engine#8706 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-04-27 04:52:18 -04:00
Shi-Hao Hong
cbfa4e5483
Improve canvas example in sample dart ui app ( #31634 )
2019-04-26 20:25:02 -07:00
Shi-Hao Hong
7c4ccb349e
Improve ThemeData.accentColor connection to secondary color ( #31295 )
2019-04-26 19:39:22 -07:00
K. P. Sroka
59f4e92b6e
Update onChange docs to Radio and RadioListTile
...
Added note that onChange callback will not be invoked if the radio is already selected
2019-04-26 19:36:22 -07:00
xster
26d7f502a9
Add some docs to StatefulBuilder ( #31291 )
2019-04-26 18:10:18 -07:00
engine-flutter-autoroll
81af5a76dd
Roll engine e0bda0685e61..7f753f8f528a (2 commits) ( #31703 )
...
e0bda0685e...7f753f8f52flutter/engine#8747 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-04-26 20:31:20 -04:00
engine-flutter-autoroll
5e09d8706c
e0bda0685 Roll src/third_party/skia ee90eb42fe4f..3349fb0195ff (1 commits) (flutter/engine#8761) ( #31698 )
...
50de4692a5...e0bda0685eflutter/engine#8761 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-04-26 19:41:18 -04:00
engine-flutter-autoroll
c15d48e298
50de4692a Check the matrix in pushTransform (flutter/engine#8758) ( #31694 )
...
7df8b7af73...50de4692a5flutter/engine#8758 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-04-26 18:41:18 -04:00
Greg Spencer
7565093f3e
Revert "Add support for Tooltip hover ( #31561 )" ( #31692 )
...
This reverts commit eca9364069
2019-04-26 14:29:19 -07:00
engine-flutter-autoroll
6ed442a927
7df8b7af7 Roll src/third_party/dart 832668ff6c..6c3a91f281 (2 commits) ( #31689 )
...
8b2d80f833...7df8b7af73https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-04-26 17:15:18 -04:00
Dan Field
6a48e663ef
Bottom sheet scrolling ( #21896 )
2019-04-26 14:12:11 -07:00
Danny Tuppeny
fdcc8aafa7
Allow adb stdout to contain the port number without failing ( #31491 )
...
* Allow adb stdout to contain the port number without failing
* Add tests that port forwarder correctly responds to known ADB output
2019-04-26 21:03:25 +01:00
engine-flutter-autoroll
173e800351
Roll engine 0b6a4be5f1d5..8b2d80f83351 (3 commits) ( #31684 )
...
0b6a4be5f1...8b2d80f833flutter/engine#8757 )
c9f327b78 Roll src/third_party/dart 7adad2a245..832668ff6c (5 commits) (flutter/engine#8756 )
84be6ad1c Roll src/third_party/skia f82158fb7fdc..d3aeecd01069 (2 commits) (flutter/engine#8755 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-04-26 15:35:18 -04:00
Jonah Williams
9d364043af
Refactor the test compiler into a separate library ( #31642 )
2019-04-26 12:33:41 -07:00
chunhtai
d121df9987
fix 31511: Test performance has regressed ( #31582 )
2019-04-26 09:02:38 -07:00
Shi-Hao Hong
14f2f98f9d
Add InkWell docs on transitions and ink splash clipping ( #31316 )
2019-04-26 07:55:29 -07:00
engine-flutter-autoroll
d51c6b5094
0b6a4be5f Roll src/third_party/skia ad1a0ca8be29..f82158fb7fdc (5 commits) (flutter/engine#8752) ( #31657 )
...
2cfe5af8f9...0b6a4be5f1flutter/engine#8752 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-04-26 05:01:20 -04:00
Dan Field
81803cacf3
Remove engine tests ( #31452 )
2019-04-26 01:01:51 -07:00
engine-flutter-autoroll
1ece6233f5
2cfe5af8f Roll src/third_party/dart 9a07ad88f4..7adad2a245 (4 commits) ( #31648 )
...
1b20489287...2cfe5af8f9https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com ), and stop
the roller if necessary.
2019-04-26 03:38:20 -04:00
