Commit graph

5388 commits

Author SHA1 Message Date
Yegor 39e741dfb7 [tools] remove --flutter-repo flag in flutter test (#3728) 2016-05-04 14:08:16 -07:00
Phil Quitslund 32bbbc6458 Merge pull request #3738 from pq/annotate_literals_3
Last literals get their types.
2016-05-04 13:59:09 -07:00
Adam Barth 8da98105b4 Skip the gallery smoke test (#3736)
This test hangs occationally on the bots and the bots aren't smart enough to
recover, which means the whole project gets blocked.

Filed #3735 about the hang.
2016-05-04 13:42:29 -07:00
Devon Carew 61c003734b checked mode fix; add type annotation (#3737) 2016-05-04 13:41:46 -07:00
pq 98ef58396a Last literals get their types.
Last fixes to get the repo running clean checking for annotations on list and map literals.
2016-05-04 13:37:23 -07:00
Adam Barth a5eb4c04c7 Remove ModalPosition (#3734)
Clients of getPosition should just use a one-child custom layout delegate
instead.

Fixes #2484
2016-05-04 12:40:50 -07:00
Matt Perry a5920c3d52 First pass at a material-style copy/paste toolbar. (#3698)
* First pass at a material-style copy/paste toolbar.

This mimics the toolbar you see when selecting text in an Android
material app. There's still more to do (like integration with the system
clipboard), but this seemed like a good stopping point.

BUG=https://github.com/flutter/flutter/issues/1567
2016-05-04 15:37:04 -04:00
Devon Carew f34d31717c complain on missing entries in flutter.yaml (#3731)
* complain on missing entries in flutter.yaml

* change to a hard failure
2016-05-04 12:33:34 -07:00
Phil Quitslund 04e892a457 Merge pull request #3729 from pq/annotate_literals_2
More type annotations for literals.
2016-05-04 12:32:54 -07:00
Devon Carew e365453eac better parsing of adb devices output (#3726)
* better parsing of adb devices output

* re-order lines
2016-05-04 12:32:46 -07:00
Ian McKellar b04670699e Fix case of 'GET' HTTP method. (#3732)
Fixes #3730
2016-05-04 12:24:04 -07:00
Devon Carew e464a81998 remove the packages/flutter_tools/.analysis_options file (#3733) 2016-05-04 11:43:01 -07:00
krisgiesing 07b5f83e55 Add analysis options near the root of the repository (#3700)
This aligns the analysis options used by 'flutter analyze' with the
options used by Atom.
2016-05-04 10:15:15 -07:00
pq 8bc06aa9b3 More type annotations for literals.
The `flutter` package gets more types!

Follow-up from: https://github.com/flutter/flutter/pull/3727.
2016-05-04 10:10:08 -07:00
Devon Carew 1d4cda5d13 fix the benchmark file written by the analyze command (#3725) 2016-05-04 10:01:39 -07:00
Phil Quitslund c2363c88a6 Merge pull request #3727 from pq/annotate_literals
Literals get type annotations.
2016-05-04 09:37:53 -07:00
pq bcede8dffb Literals get type annotations.
As per the recent fix to the `always_specify_types` lint (https://github.com/dart-lang/linter/issues/199), literal maps and lists are now expected to be explicitly typed.

Running that lint on the repo identifies quite a few spots to update.  This focuses on `flutter_driver` and `flutter_sprites` (somewhat arbitrarily) but the changes are fairly representative.

Note there are a number of places where I made a quick judgement on how specific to make the types.  Feedback on those is welcome.  (Especially as we move forward with more.)
2016-05-04 09:18:31 -07:00
Ian Hickson 1e093701b7 Save some memory by only storing one copy of the animation object... (#3724)
Turns out we were storing the same object in the base class and the
subclass. For pretty much every AnimatedWidget subclass.
2016-05-03 23:49:35 -07:00
Adam Barth 7712e583a4 Add missing dartdocs from material.dart (#3709)
Making progress towards document all public APIs in material.dart. We're still
missing a few odds and ends (as well as missing docs in tabs.dart,
tooltip.dart, and two_level_list.dart).
2016-05-03 21:07:29 -07:00
Hans Muller a9b965cb9b Gallery demo start-time performance test (#3655)
*  Gallery demo start-time performance test
2016-05-03 17:37:10 -07:00
Viktor Lidholt 76b04cddde Refactor sprite physics, part 1 (#3711) 2016-05-03 17:16:36 -07:00
Yegor 4d88752c39 [tools] delete profile_startup.dart (#3703)
The same can now be achieved using `flutter run --trace-startup --no-checked`.
2016-05-03 15:52:15 -07:00
Devon Carew 713830964c make the usage text more visible (#3693)
* make the usage text more visible

* update the look of the usage text
2016-05-03 15:17:30 -07:00
Adam Barth bf0f38c615 Add more dartdoc to material.dart (#3702)
This patch completes the circuit on this library. The next step is to go
through and add docs to anything we missed.
2016-05-03 15:01:46 -07:00
Ian Hickson 50626e9b21 ClipPath (#3695)
* ClipPath

* Add a test for ClipOval and ClipPath
2016-05-03 14:45:36 -07:00
Ian Hickson 961f5cd266 Fix framework-side time in profile data (#3706) 2016-05-03 14:45:22 -07:00
Adam Barth 00e0075f8b PathProvider.getTemporaryDirectory() never resolves (#3705)
We were looking for this service in the wrong service provider.

Fixes #3683
2016-05-03 14:35:00 -07:00
Ian Hickson d8522191ba Update engine.version (#3704) 2016-05-03 14:16:07 -07:00
Collin Jackson 57d6e8514b Merge pull request #3701 from collinjackson/assets
Support for putting assets in android/assets folder (like ios/Resources)
2016-05-03 14:08:47 -07:00
Ian Hickson 4b401a3e75 Track the worst frame in perf tests (#3642)
* Track the worst frame in perf tests

* Use backticks in "/// Returns `null` if"
2016-05-03 14:00:10 -07:00
Ian Hickson 4b6af7a42f Provide framework-only timing information (#3699)
This makes it easier to generate charts that show the engine time and
the framework time separately.
2016-05-03 13:51:22 -07:00
Collin Jackson 80ef81422d Support for putting assets in android/assets folder (like ios/Resources) 2016-05-03 13:32:35 -07:00
Devon Carew 00062761be filter an assertiond log message from ios (#3692) 2016-05-03 12:46:46 -07:00
Adam Barth 93926d2220 More dartdoc for material.dart (#3690)
Also, move the default theme transition duration into theme.dart.
2016-05-03 12:25:51 -07:00
Hans Muller 1a2f19b7fa Add a non-null builder assert to Builders, renamed IndexedBuilder (#3694) 2016-05-03 11:22:26 -07:00
Hans Muller b38927e70e LayoutBuilder widget (#3670)
* LayoutBuilder Widget
2016-05-03 10:35:24 -07:00
Devon Carew c9010c91f6 fix analysis errors (#3677)
* fix analysis errors

* review comments; fix test

* re-add an export for debugPrint
2016-05-03 09:09:00 -07:00
Eric Seidel 76724e857f Merge pull request #3679 from eseidelGoogle/aot_error
Add note about explicit `pub get` needed.
2016-05-03 08:30:55 -07:00
Ian Hickson 7020e6cb93 Fix Inherited bugs (#3657)
Fixes https://github.com/flutter/flutter/issues/3493

 - rebuild stateless widgets that have dependencies when their ancestors change but they don't

Fixes https://github.com/flutter/flutter/issues/3120

 - rebuild widgets that tried to inherit from a widget that didn't exist, when the widget is added

This adds a pointer and a bool to Element, which isn't great. It also adds a more or less complete tree walk when you add a new Inherited widget at the top of your tree, which isn't cheap.
2016-05-03 00:06:29 -07:00
Eric Seidel f58fa766c3 Add note about explicit pub get needed.
@devoncarew @jason-simmons
2016-05-02 16:14:35 -07:00
Adam Barth 6072552868 AspectRatio has incorrect intrinsic sizing (#3666)
If there's a max height or width, we should factor that into the intrinsic
sizing for the other dimension.
2016-05-02 15:51:45 -07:00
Adam Barth 0910a78fd6 Improve dartdoc for SystemChrome and SystemSound (#3669)
We need to import these enums in order for the dartdoc to linkify correctly.

Fixes #3668
2016-05-02 15:51:35 -07:00
Devon Carew cd8f65dfb3 add an infra/docs.sh script (#3674) 2016-05-02 14:33:39 -07:00
Jason Simmons 30d8dc1399 Check the adb install output for errors and stop "flutter run" if package installation fails (#3672) 2016-05-02 14:11:40 -07:00
Adam Barth 5460e94488 Add docs to Element.performRebuild (#3667) 2016-05-02 13:38:07 -07:00
Jason Simmons f161f239ef Download Android AOT tools to the artifacts cache and build APKs using these tools (#3649)
Also update the engine to a build where these tools have been uplaoded
2016-05-02 11:40:32 -07:00
Adam Barth 21f1827bad Add a sensible error message when jarsigner is missing (#3665)
Fixes #3624
2016-05-02 10:27:34 -07:00
Devon Carew a807b009ad Re add large sample (#3661)
* Revert "Revert "Mega gallery (#3647)" (#3659)"

This reverts commit ea62d31fde.

* fix the dev/dartdoc.dart script
2016-05-01 15:52:51 -07:00
Adam Barth 5a3327bb7b Update engine.version (#3660) 2016-05-01 15:37:41 -07:00
Adam Barth ea62d31fde Revert "Mega gallery (#3647)" (#3659)
This reverts commit 9497fb56d4.

This patch broke the dartdoc step on the bots.
2016-05-01 14:58:40 -07:00