Commit graph

11779 commits

Author SHA1 Message Date
LongCatIsLooong 37f9c54116
Use RenderSliverPadding to inset SliverFillViewport (#45432) 2019-11-27 11:33:38 -08:00
Kate Lovett 1374a41313
Provide debug output for Gold uploads on post-submit (#45704) 2019-11-27 11:29:53 -08:00
Zachary Anderson e4b809b7c8
[flutter_tool] Crash less when git fails during 'version' (#45628) 2019-11-27 10:18:43 -08:00
Takeshi Tsukamoto 876303b3f9 Fix comment (#45325) 2019-11-27 10:01:57 -08:00
Danny Tuppeny 4741e9c3fe
Retry Xcode builds if they fail due to concurrent builds running (#45608)
* Retry Xcode builds if they fail due to concurrent builds running

Fixes #40576.

* Add tests for concurrent iOS launches

* Increase number of retries to account for the initial build being slow
2019-11-27 09:44:05 +00:00
Kaushik Iska d1805aa22a
update-packages after dwds updates (#45633) 2019-11-26 18:34:06 -08:00
Greg Spencer 245d1b51ce
Add macOS to TargetPlatform (#43457)
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
2019-11-26 18:32:34 -08:00
Jonah Williams 831163f0d0
Register memory info command on vmservice for Android devices (#45568) 2019-11-26 14:49:56 -08:00
Dan Field 2d3d220988
Implicit scrolling for pageview (#45598) 2019-11-26 14:12:34 -08:00
Jenn Magder 7d8f82051b
Suggest GitHub template when flutter tool crashes (#45360)
* On flutter tool crash suggest GitHub template

* Shorten GitHub URLs

* Whitespace

* Wording tweak from @InMatrix

* Review edits
2019-11-26 14:06:31 -08:00
Albertus Angga Raharja e1512b4dd7
Add additional properties callback in Inspector Serialization Delegate (#45531)
* Add additional properties callback in Inspector Serialization Delegate

* Rename _SerializationDelegate to InspectorSerializationDelegate and add test

* Fix indentation

* Remove trailing whitespace

* Handle case when addAdditionalPropertiesCallback returns null

* Improve docs and minor renames

* Improve docs

* Improve documentation
2019-11-26 13:57:41 -08:00
Greg Spencer 0190e40457
Keyboard scrolling of Scrollable (#45019)
This adds the ability to scroll and page up/down in a Scrollable using the keyboard. Currently, the macOS bindings use Platform.isMacOS as a check, but we'll switch that to be defaultTargetPlatform == TargetPlatform.macOS once that exists.
2019-11-26 09:56:25 -08:00
Danny Tuppeny 459c7fb884
Resume isolate before terminating tests to prevent flutter_tester leaks in integration tests (#45248)
* Resume isolate before terminating tests to prevent flutter_tester leak

* Fix lint

* Catch exceptions from resume() as well as timeout()

* Formatting fixes

* Don't try to resume if there's no vm service

* Fix handling of timeouts to not leak futures
2019-11-26 17:04:51 +00:00
Christopher Fujino dc68d5700b
Fix flutter run cache (#45267) 2019-11-26 09:02:34 -08:00
Kate Lovett 8a48a27847
Performance Improvement for SliverFillRemaining (#44471) 2019-11-26 08:04:22 -08:00
Kate Lovett cd94cd886a
SliverOffstage Fix (#45580) 2019-11-26 08:01:03 -08:00
Alexandre Ardhuin a2c3f6c567
implicit-casts:false in flutter/lib/src/animation (#45501) 2019-11-26 16:53:14 +01:00
Alexandre Ardhuin 4055e19680
implicit-casts:false in flutter/lib/src/foundation (#45503) 2019-11-26 16:52:37 +01:00
Alexandre Ardhuin f6dc4db2e0
implicit-casts:false in flutter/lib/src/gestures (#45504)
* implicit-casts:false in flutter/lib/src/gestures

* address review comments
2019-11-26 07:03:34 +01:00
Dan Field e766ae740e
Automatically caching viewport (#45327) 2019-11-25 21:05:46 -08:00
Jonah Williams 84ce3f6097
Serve web source maps in release runner (#45318) 2019-11-25 17:09:36 -08:00
Greg Spencer 46632f9edc
Handle bare modifier flags on macOS (#45438)
This fixes an unreported bug in the macOS key handling where for some remote access situations, the modifier mask is set to the "any modifier" mask without any side specified (e.g. modifierShift bit is specified and not modifierLeftShift bit).
2019-11-25 17:06:16 -08:00
Jenn Magder 8eb6a925f9
Always compile with isysroot on iOS to point to SDK root (#45436) (#45560) 2019-11-25 12:49:18 -08:00
Kate Lovett d0ea9ed244
SliverOffstage (#45128) 2019-11-25 12:49:10 -08:00
Kate Lovett 1160c8fd29
Re-Staged: Fixing ContinuousRectangleBorder bottom radius (#45304) 2019-11-25 12:43:58 -08:00
Jonah Williams cf37c2cd07
Add assert for negative child count in ListView.builder (#45506) 2019-11-25 12:04:30 -08:00
Jonah Williams 1888fa3526
Allow flutter run to run release/profile x64 (#45511) 2019-11-25 12:04:17 -08:00
Alexandre Ardhuin e6935efdf6
remove avoid_as lint for the upcoming implicit-casts: false (#45527) 2019-11-25 21:03:29 +01:00
Emmanuel Garcia 81724bd60f
Fallback to protocol discovery if mdns returns null (#45439) 2019-11-25 11:51:54 -08:00
Michael Klimushyn 901eb0fc81
Add a note to generated plugins files (#45557)
There has been some confusion about whether or not
.flutter-plugins-dependencies should be tracked in version control or
not. Added a comment to both it and .flutter-plugins explaining that
it's generated and shouldn't be.

.flutter-plugins-dependencies is parsed through JSON, and the JSON spec
doesn't support comments. So unfortunately the note is living in an
arbitrary "_info" key instead of an obvious top level comment.
2019-11-25 11:47:20 -08:00
Jenn Magder 4cc10a1fb8
Revert "Always compile with isysroot on iOS to point to SDK root (#45436)" (#45555)
Analyzer warning.
2019-11-25 10:46:42 -08:00
Jenn Magder 6b11f18bc0
Always compile with isysroot on iOS to point to SDK root (#45436) 2019-11-25 10:27:22 -08:00
Alexandre Ardhuin 980f14e0c5
implicit-casts:false on flutter_tools (#45153)
* implicit-casts:false on flutter_tools

* use castStringKeyedMap

* address review comments

* address review comments

* fix issues after rebase
2019-11-24 06:54:43 +01:00
Takeshi Tsukamoto a3eeb51a1b Fix draggable scrollable sheet scroll notification (#45083) 2019-11-22 21:48:38 -08:00
chunhtai f15f69a8b8
Drops detached message until we can handle it properly (#45430) 2019-11-22 16:10:46 -08:00
Emmanuel Garcia b6e92003c8
Add .flutter-plugins-dependencies to the project, which contains the app's plugin dependency graph (#45379) 2019-11-22 15:02:20 -08:00
Jonah Williams b54bb6abbb
Dont crash if the tool cannot delete asset directory during debugging (#45407) 2019-11-22 14:06:05 -08:00
Jonah Williams 35b571ccfc
Revert "Improve time to development by initializing frontend_server concurrently with platform build (#45236)" (#45422) 2019-11-22 13:36:12 -08:00
Jonah Williams c63c576bca
Reland handle corrupt config file (#45414) 2019-11-22 12:26:51 -08:00
Jonah Williams 60869e0a93
Improve time to development by initializing frontend_server concurrently with platform build (#45236) 2019-11-22 12:26:31 -08:00
Alexandre Ardhuin 0a66d8a7a4
implicit-casts:false in fuchsia_remote_debug_protocol (#45239) 2019-11-22 20:33:47 +01:00
Kate Lovett e2cf2f0fa2
SliverOpacity (#44289) 2019-11-22 11:12:09 -08:00
xster 942707591d
Revert "catch parse error from corrupt config (#45319)" (#45412) 2019-11-22 10:56:16 -08:00
Jonah Williams 6640c8b9b4
catch parse error from corrupt config (#45319) 2019-11-22 10:09:23 -08:00
Jonah Williams 497ae83c82
Fix experimental incremental web compiler for Windows (#45286) 2019-11-22 10:08:38 -08:00
Kate Lovett 9f17a43ebe
SliverIgnorePointer (#45127) 2019-11-22 09:54:09 -08:00
Yegor aa3943316b
Fix dartDefines in daemon mode (#45317)
* de-null dartDefines in daemon mode
* remove daemonCommand; pipe through dartDefines into Daemon
* pass dartDefiles in attach; add test for --machine mode
2019-11-22 08:57:14 -08:00
Greg Spencer a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Alexandre Ardhuin fcb40a05bb
make some BuildContext methods generics (#44189)
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic

* make BuildContext.inheritFromWidgetOfExactType generic

* make BuildContext.ancestorInheritedElementForWidgetOfExactType generic

* make BuildContext.ancestorWidgetOfExactType generic

* fix snippet

* bump scoped_model on temp version

* update names

* Revert "bump scoped_model on temp version"

This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0.

* address review comments

* fix ci

* address review comments

* repeat the deprecation notice

* fix uppercase

* use of recommanded deprecation syntax

* address review comment
2019-11-22 17:35:20 +01:00
Todd Volkert 4c64b715d9
Revert "Add option to delay rendering the first frame (#45135)" (#45385)
This reverts commit d285b8843f.
2019-11-21 22:12:24 -08:00