Commit graph

11422 commits

Author SHA1 Message Date
Zachary Anderson 7fa5dd7454
[flutter_tools] Allows adding multiple signal handlers (#41304) 2019-09-26 08:12:48 -07:00
Hans Muller e47a1dc216
Dropdown Menu layout respects menu items intrinsic sizes (#41120) 2019-09-26 07:18:25 -07:00
Emmanuel Garcia 975e770e13
Add embedding as API dependency instead of compile only dependency (#41142) 2019-09-25 17:59:17 -07:00
Jonah Williams 89ebd700f2
Support deferred imports on profile/release builds of Flutter Web (#41222) 2019-09-25 15:12:58 -07:00
Jonah Williams 7065e43306
Allow skipping chrome launch with --no-web-browser-launch (#40627) 2019-09-25 13:55:54 -07:00
Jonah Williams 9bd02a1787
Re-Re-Re-land implement flutter build bundle with assemble (#41302) 2019-09-25 13:55:29 -07:00
Francisco Magdaleno d2a95ee344
Fix crash on vswhere query on missing installations (#40786) 2019-09-25 13:38:53 -07:00
Nurhan Turgut ae529d8be0
Fixing the editable_text unit tests by clearing the log. Add a modification for also testing cached size. (#41300) 2019-09-25 13:14:59 -07:00
Zachary Anderson 5142238c85
[flutter_tool] Report rss high watermark in command analytics events (#40988) 2019-09-25 11:26:06 -07:00
Alexandre Ardhuin 9c6f11d5d1
fix bad indentation (#41263) 2019-09-25 20:24:57 +02:00
LongCatIsLooong deb4184f63
Remove CupertinoSystemColors in favor of CupertinoColors (#40566) 2019-09-25 10:17:37 -07:00
Jonah Williams cc3ca9a916
Revert "Re-Re-land Implement flutter build bundle with assemble (#41230)" (#41295) 2019-09-25 10:57:58 -04:00
Jonah Williams 84a476a4db
Re-Re-land Implement flutter build bundle with assemble (#41230) 2019-09-25 10:17:04 -04:00
LongCatIsLooong 7bf9aea254
Fix user gesture in CupertinoPageRoute (#39590) 2019-09-25 00:37:12 -07:00
LongCatIsLooong d8ca42e211
CupertinoPageScaffold dark mode (#40690) 2019-09-25 00:31:36 -07:00
Emmanuel Garcia 48ce60824a
Revert "Revert "Use AndroidX in new projects by default (#40925)" (#40995)" (#41001)
This reverts commit 8e23179627.
2019-09-24 16:55:09 -07:00
imzyy 964dc1fc30 Add fullscreenDialog argument in PageRouteBuilder (#40161) 2019-09-24 16:54:44 -07:00
Mehmet Fidanboylu c19e553d64 Allow test beds to override defaultTestTimeout (#40806) 2019-09-24 16:53:40 -07:00
Tong Wu 28bd51f998
Force upgrade packages again. (#40997) 2019-09-24 16:51:31 -07:00
Emmanuel Garcia 16d408a7a0
Reland #40810: Re-enable AAR plugins when an AndroidX failure occurred (#41160) 2019-09-24 16:16:22 -07:00
Hans Muller 09073a08b8
Rebuild modal routes when the value of userGestureInProgress changes (#41150) 2019-09-24 16:03:31 -07:00
Michael Goderbauer 81e693a7fe
Add Sample code to SlideTransition (#41009) 2019-09-24 12:38:45 -07:00
chunhtai 0ca5e71f28
Implement system fonts system channel listener (#38930)
* Implement system fonts system channel listener
2019-09-24 12:29:03 -07:00
Jenn Magder 9a66018f0d
Make module pod headers public (#40927) 2019-09-24 12:20:00 -07:00
Todd Volkert 8699d24d42
Bump version of just package:multicast_dns (#41207) 2019-09-24 12:06:42 -07:00
Alexandre Ardhuin b873162194
fix some bad indentations (#41172) 2019-09-24 21:03:37 +02:00
Francisco Magdaleno 1ea760096a
Update toolchain description to request the latest version (#40795) 2019-09-24 12:00:05 -07:00
Nurhan Turgut f6e77a9ee5
Fixing a text editing bug happening when text field changes. (#41108)
* Carrying last size and transform information to TextInputConnection. Doing this we are making sure that the size/transform information from the previous connection will be removed, when connection changes.

* remove unused lastsize and lasttransform values

* Adding unit tests. Adressing comments.
2019-09-24 09:25:39 -07:00
Greg Spencer 0e6cb28dbe
Add fake keyboard key generation to the testing framework (#40706)
There were four or five different implementations in various tests for sendFakeKeyEvent, which roughly all did the same thing. I was going to add yet another one, and decided that it needed to be generalized and centralized. This replaces those instances with something that just takes a LogicalKeyboardKey so that it's self-documenting, and can be used with multiple platforms.

This adds two functions to widget tester: sendKeyDownEvent and sendKeyUpEvent which simulate key up/down from a physical keyboard. It also adds global functions simulateKeyDownEvent and simulateKeyUpEvent that can be called without a widget tester. All are async functions protected by the async guard.
2019-09-24 08:14:38 -07:00
LongCatIsLooong 4815b26d71
Dark mode for CupertinoSwitch and CupertinoScrollbar, Fidelity updates (#40636) 2019-09-24 00:21:44 -07:00
Alexandre Ardhuin 89427d672d
add missing trailing commas in flutter_tools (#40968) 2019-09-24 08:06:09 +02:00
Alexandre Ardhuin e9965f5636
add missing trailing commas in packages/flutter (#41076) 2019-09-24 08:05:41 +02:00
Michael Goderbauer 961f1b746d
AnimatedBuilder API Doc improvements (#40917) 2019-09-23 10:09:38 -07:00
Liam Appelbe b0563e1a3d
Unit test for build.dart::GenSnapshot (#37642)
* Unit test for build.dart::GenSnapshot

* Fix analysis errors

* Switch to testLogger
2019-09-23 10:09:22 -07:00
Emmanuel Garcia 2c8813c86c
Revert "Re-enable AAR plugins when an AndroidX failure occurred (#40810)" (#41042)
This reverts commit 96482eeb5c.
2019-09-23 09:28:38 -07:00
Emmanuel Garcia 8e23179627
Revert "Use AndroidX in new projects by default (#40925)" (#40995) 2019-09-20 13:37:10 -07:00
Alexander Aprelev bd929c4a52 Revert "Use separate isolate for image loading. (#34188)" (#40984)
This reverts commit b12bdd0ea1 as it
breaks existing tests that expect image loaded after certaing number of
pupms. With image loading done on separate isolate pumping is not
guaranteed to get image loaded.
2019-09-20 10:23:51 -07:00
Jonah Williams 57c319a9a0
Revert "Run flutter update-packages --force-upgrade. (#40766)" (#40979) 2019-09-20 12:23:19 -04:00
Emmanuel Garcia 407668f4d5
Stop using deprecated features from Gradle (#40900) 2019-09-20 08:29:53 -07:00
Emmanuel Garcia f7173dcc60
Use AndroidX in new projects by default (#40925) 2019-09-20 08:29:21 -07:00
Emmanuel Garcia 96482eeb5c
Re-enable AAR plugins when an AndroidX failure occurred (#40810) 2019-09-20 08:28:52 -07:00
Tong Wu c238045a96
Run flutter update-packages --force-upgrade. (#40766) 2019-09-20 07:58:53 -07:00
stuartmorgan 0412977e48
Support create for macOS (app and plugin) (#40851)
Adds macOS support for `flutter create`:
- Currently it is behind a hidden flag.
- Adds a TargetPlatform workaround to lib/main.dart in the standard app template when enabled.
- Supports `app` and `plugin`; `module` support doesn't yet exist for macOS in general.

This will eliminate the need to use FDE's examples as templates on macOS. The templates are based on the current state of FDE's examples, with templating support added (and with adoption of the new application delegate in the app, which hadn't been done yet in FDE, eliminating some boilerplate from the template).

Fixes #30703
2019-09-19 17:06:18 -07:00
stuartmorgan 86c342eceb
Move iOS and Android gitignore rules into folders (#40864)
Rather than have a monolithic .gitignore covering all platforms in the
app template, have each platform folder contain its own rules.

Fixes #40793
2019-09-19 17:04:53 -07:00
gaaclarke 71d75e3e0a
Channel buffers (#40165)
Started reading stored channel messages from ui.channelBuffers when handlers get set.
2019-09-19 16:58:54 -07:00
Harry Terkelsen 6911a1513c
Allow sending platform messages from plugins to the framework and implement EventChannel (#40638)
* Allow sending messages from the platform to the framework

* Add ability to send messages from the plugin to the platform.

Also adds [PluginEventChannel] which is the plugin counterpart to
EventChannel.

Fixes https://github.com/flutter/flutter/issues/39981

* fix analyzer errors

* Enhance doc comments

* Remove dead code in test
2019-09-19 10:48:57 -07:00
Jason Simmons c94a994d62
Handle CR+LF end of line sequences in the license parser (#40718) 2019-09-19 09:44:31 -07:00
chunhtai 0086243be4
Fixed Selectable text align is broken (#40709)
* Fixed Selectable text align is broken
2019-09-19 09:37:00 -07:00
Jonah Williams f8ba6756c3
Revert "Reland: implement build bundle with assemble (#40470)" (#40862) 2019-09-19 09:04:07 -07:00
Jonah Williams ea7876ae82
Reland: implement build bundle with assemble (#40470) 2019-09-19 07:46:50 -07:00
Jonah Williams 2a36ad31fa
Ensure Flutter for Web debug builds are only accessible through Flutter run (#40783) 2019-09-18 23:10:24 -07:00
stuartmorgan c32e543207
Invalidate macOS pods on plugin changes (#40730)
When the plugin list changes, iOS pods are invalidated, but that was
never wired up for macOS.

Should fix #39327
2019-09-18 21:42:57 -07:00
Alexander Aprelev b12bdd0ea1
Use separate isolate for image loading. (#34188)
* Use separate isolate for image loading. Use TransferableTypedData to const-cost receive bytes from that isolate.
2019-09-18 20:38:54 -07:00
adazh c4016aadb3
[Flutter Driver] Simplified the serialization/deserialization logic of the Descendant/… (#40715)
* Simplified the serialization/deserialization logic of the Descendant/Ancestor matchers
2019-09-18 16:58:33 -07:00
Jenn Magder d95adf999c
Move build info checks from generating files to the xcode build (#40792) 2019-09-18 16:57:31 -07:00
Amir Hardon 4e108b6f90
Exclude non Android plugins from Gradle build (#40640)
Before this change, having an Android app depend on a plugin that has no android implementation resulted in a Gradle build failure.

This scenario is likely to become more common if we're enabling federated plugins, as the package implementing just the desktop implementation of a plugin won't have an Android implementation.

This changes the Gradle plugin to not try to build any plugins that doesn't have an android/build.gradle file.
2019-09-18 16:42:20 -07:00
Robin Jespersen d4a016443b Adding onEnd callback to implicit animated widgets (#38979) 2019-09-18 14:56:18 -07:00
Michael Goderbauer 4373a31971
Reapply "Revert "Propagate textfield character limits to semantics (#40468)" (#40767) 2019-09-18 14:55:37 -07:00
chunhtai 6c457e124b
Material textselection context menu cannot disable select all (#40713) 2019-09-18 12:19:37 -07:00
Christopher Fujino 0b24a5a2ff
Implement mdns for flutter run (#40447) 2019-09-18 11:01:08 -07:00
Justin McCandless 431b82fda8
TextField docs for getting value (#40695)
Added docs examples of getting the string from a TextField
2019-09-18 10:43:23 -07:00
Greg Spencer 110db03f24
Fix a problem with disposing of focus nodes in tab scaffold (#40100)
Previously, focus nodes created in the tab scaffold were not being disposed of properly, causing possible memory leaks. Also, the builder wasn't being passed the right context so that the FocusScope.of operator inside of a builder would find the focus scope for the given tab (it was being passed the context of the overall tab scaffold).
2019-09-17 17:10:18 -07:00
Jonah Williams 5de5bb0172
fix platform environment (#40692) 2019-09-17 17:07:55 -07:00
Jenn Magder 9a68b0df3e
Warn when build number and version can't be parsed on iOS (#40611) 2019-09-17 17:07:41 -07:00
Michael Goderbauer b4324aed59
Revert "Propagate textfield character limits to semantics (#40468)" (#40714)
This reverts commit 6ad88bd5c0.
2019-09-17 16:37:11 -07:00
Michael Goderbauer 6ad88bd5c0
Propagate textfield character limits to semantics (#40468) 2019-09-17 14:39:50 -07:00
Kate Lovett 31029f9338
Doc Improvements for SliverFillRemaining (#39088) 2019-09-17 14:21:28 -07:00
Greg Spencer 63e096b4ac
Update keyboard maps (#40697)
This updates the keyboard maps to use updated HID codes for game controller buttons (from Chrome), and to encode that GLFW "super" keys are what we call "meta" keys (i.e. Windows key or Command key).
2019-09-17 13:24:54 -07:00
Michael Goderbauer 8e14fc7f72
New overview for animations library (#40607) 2019-09-17 13:03:15 -07:00
Anthony c17086a06d
Add the option to configure a chip check mark color (#40608)
Add the option to configure a chip check mark color
2019-09-17 14:17:34 -04:00
xster fab3eb21c2
Let Material BackButton have a custom onPressed handler (#39600) 2019-09-17 11:09:18 -07:00
Brian Egan a50eda8f5a Diagrams and samples for Rank 20-30 popular api docs (#40089) 2019-09-17 10:22:28 -07:00
Hans Muller 6d18c20a95
Update PopupMenu layout (#40179) 2019-09-17 08:48:27 -07:00
Emmanuel Garcia 8a1bf5b827
Reland #39157 (#39798) 2019-09-17 08:19:33 -07:00
Alexandre Ardhuin df4bf453ab
more UI-as-code (#35516) 2019-09-17 16:23:44 +02:00
stuartmorgan d03aecab58
Add an ephemeral directory for Linux (#40587)
Moves the generated config into that directory. Matches the structure of
the other desktop projects.

Also fixes #40265
2019-09-16 16:04:55 -07:00
Emmanuel Garcia 0df1594ba2
Enable the resource shrinker (#40610) 2019-09-16 15:27:05 -07:00
LongCatIsLooong 390ef60963
CupertinoNavigationBar Dark Mode(#40189) 2019-09-16 14:16:30 -07:00
Gary Qian 67e35d612e
Specify ifTrue and ifFalse for strut FlagProperty (#40609) 2019-09-16 14:08:18 -07:00
Kate Lovett e62c68c243
Fix for broken LocalFileComparator output (#40399)
* Fixing LocalFileComparator output

* Fixing path separators for windows failures

* Windows path issues

* Testing

* ++

* ++

* Fixing base directory - windows

* Clean up
2019-09-16 13:14:46 -07:00
Jonah Williams 79107e0fe2
Dont kill other processes when starting desktop application (#40472) 2019-09-16 13:12:50 -07:00
Simon Lightfoot bf216110ff Adds relayout option to CustomMultiChildLayout. (#39252) 2019-09-16 09:22:59 -07:00
Hans Muller 0f00f424fa
ModalRoutes ignore input when a (cupertino) pop transition is underway (#40466) 2019-09-16 08:02:04 -07:00
Zachary Anderson 8a33d2446d
[flutter_tool] Remove the synchronous -showBuildSettings (#40435) 2019-09-16 07:51:50 -07:00
MH Johnson 0d3bb515f3
[Docs] Create 'center' snippets template (#40367)
* Create 'center' template
2019-09-15 20:38:44 -04:00
Shi-Hao Hong cf7e7e4529
Implement DropdownButton.selectedItemBuilder (#40461)
* Implement DropdownButton.selectedItemBuilder
2019-09-14 07:56:05 -07:00
LongCatIsLooong 64300123fa
Restore offstage and ticker mode after hero pop and the from hero is null (#40306) 2019-09-13 19:46:58 -07:00
Emmanuel Garcia 4d404da6df
Update Kotlin and Gradle version (#40181) 2019-09-13 19:37:07 -07:00
Jonah Williams 6f5df21e5b
pass through --web-port in release mode too (#40465) 2019-09-13 19:15:52 -07:00
Emmanuel Garcia 2c857b9370
Enable R8 (#40453) 2019-09-13 19:06:40 -07:00
LongCatIsLooong 19b47c2dd4
Dark Mode R: Refresh Control (#40454) 2019-09-13 17:18:20 -07:00
Zachary Anderson e2340c641d
[flutter_tool] Use curly braces around single statment control structures (#40446) 2019-09-13 14:51:35 -07:00
Emmanuel Garcia f29524a150
Rename useProguard method, so Gradle doesn't get confused (#40440) 2019-09-13 13:02:16 -07:00
Jonah Williams 6ba8fa9987
Remove direct flutter tool usage of protobuf for encoding file caches (#40410) 2019-09-13 12:49:03 -07:00
Jenn Magder b80b9bea38
Set DEFINES_MODULE for FlutterPluginRegistrant to generate modulemap (#40302) 2019-09-13 11:03:46 -07:00
Jonah Williams 69a296463e
Allow skipping webOnlyInitializePlatform in Flutter for Web (#40301) 2019-09-13 10:20:30 -07:00
Michael Goderbauer 9d70c85f5a
a11y improvements for textfield (#40390) 2019-09-13 09:23:27 -07:00
Shi-Hao Hong 2bd7f9ff7d
Update ToggleButtons constraints default and add new constraints parameter (#39857)
* Add constraints property, updated default constraints for ToggleButtons to 48x48

* Add kMinInteractiveDimension constant to ToggleButtons
2019-09-13 08:19:06 -07:00
stuartmorgan a7cfdbd3f3
Convert build mode to lowercase in tool_backend (#40393)
On macOS and iOS, the build mode is converted to lowercase in the
Flutter-side script, allowing projects to pass configuration names
directly. This adds the same behavior to the tool_backend.dart script
currently used by Windows and Linux, so that Windows builds can do the
same (since the default configuration names used by VS, as in Xcode,
start with a capital letter).
2019-09-12 19:13:42 -07:00
Jenn Magder ba13aa943c
Make FlutterPluginRegistrant a static framework so add-to-app can use plugins with static frameworks (#40401) 2019-09-12 18:51:49 -07:00
Francisco Magdaleno 09bb07f8dd
Adds list required components when VS is not installed (#40397) 2019-09-12 18:44:36 -07:00
Jonah Williams 18ffb0fbc3
place conditions on same line (#40391) 2019-09-12 18:30:24 -07:00
stuartmorgan 72888c7f75
Harden macOS build use of Xcode project getInfo (#40375)
- Makes build_macos.dart handle the case where there is only one Xcode
  project in the macos/ directory, but it's not called Runner.xcodeproj
- Makes getInfo throw a tool exit when trying to get project info and it
  can't find a project, since that is a configuration error by the user
  rather than a tool bug.
2019-09-12 16:03:02 -07:00
Francisco Magdaleno 576a455a64
[windows] Refactor to optimize vswhere queries (#40197) 2019-09-12 15:48:25 -07:00
Jonah Williams 91af071570
ensure dart2js does not compile unsupported packages (#40368) 2019-09-12 15:25:21 -07:00
Jonah Williams 1667d0caa4
rename port to web-port and hostname to web-hostname (#40370) 2019-09-12 15:25:03 -07:00
Jonah Williams 1fec30efb6
Place existing dill into hot reload temp directory to boost initialization time (#40366) 2019-09-12 12:45:53 -07:00
Ryan Macnak a6138bb005
Remove dead accessors of _getUnusedChangesInLastReload. (#39837)
This was part of a disused tool to explain what did and did not run after reload.
2019-09-12 12:34:58 -07:00
Jonah Williams 925a52fa6b
add host and port to run configuration for web devices (#40191) 2019-09-12 08:58:49 -07:00
Francisco Magdaleno f5733f7a62 Fix crash on vswhere search from flutter doctor (#40263)
Fixes a crash introduced on #40011 due to an incorrect type in the vswhere search

Fixes #40238
2019-09-11 21:03:42 -07:00
Jonah Williams 270878fc50
fix copy command and remove resolve sync for macOS assemble (#40294) 2019-09-11 20:29:27 -07:00
Zachary Anderson 73c10e8ced
[flutter_tool] process.dart cleanup (#39899) 2019-09-11 18:20:42 -07:00
Emmanuel Garcia 3712ea63d8
Flip the default for proguard (#40282) 2019-09-11 17:51:51 -07:00
Michael Goderbauer 6dc9bf0a02
Fix curve for popping hero (#39844) 2019-09-11 14:55:59 -07:00
Jonah Williams 6d37867c4a
Place hot reload artifacts in a temp directory (#40171) 2019-09-11 12:57:43 -07:00
Jonah Williams 963c8a8921
Remove io and isolate from libraries for web sdk (#40259) 2019-09-11 12:40:33 -07:00
Jonah Williams 8eee93fa64
Ensure we send hot restart events for flutter web (#40175) 2019-09-11 09:38:42 -07:00
Christopher Fujino c5e2bf5cfe
catch errors during gradle update (#37526) 2019-09-11 09:21:42 -07:00
Zachary Anderson 2c94f2b4d9
[flutter_tool] Kill a timing out process before trying to drain its stdout/err streams (#40159) 2019-09-11 08:30:29 -07:00
stuartmorgan e6ae95c4ce
Add an ephemeral directory to Windows projects (#40194)
Moves files generated in windows/flutter/ as part of the build to an ephemeral/ subdirectory, matching the approach used on macOS (and in the future, Windows).

Adds that directory to the generated properties file to minimize hard-coding of paths in the project.
2019-09-11 07:46:57 -07:00
stuartmorgan ef97a69dab
Make Swift plugin template swift-format compliant (#40195)
swift-format will alphabetize import statements, so Flutter* should be
before Foundation. Also, separating the "Generated file" comment
prevents the formatter from thinking that the comment is associated with
the following import, rather than the file, if it does re-order.
2019-09-11 07:43:50 -07:00
Jonah Williams 32c946f31b
make sure we launch with dwds (#40210) 2019-09-10 20:49:27 -07:00
LongCatIsLooong da151c95ba
CupertinoAlertDialog dark mode & CupertinoActionSheet fidelity (#40007) 2019-09-10 20:40:06 -07:00
Jonah Williams 609a78fdca
Revert "build bundle with assemble (#37508)" (#40204) 2019-09-10 20:03:52 -07:00
Jonah Williams f614144f0a
Add "web" server device to allow running flutter for web on arbitrary browsers (#39951)
* add web server device

* remove extra async

* fixes to server device

* testing updates

* fix test cases

* address comments
2019-09-10 19:29:31 -07:00
Jonah Williams a7aff56741
build bundle with assemble (#37508) 2019-09-10 19:28:38 -07:00
Jonah Williams 8504f3ae13
Update the supported library set for Flutter for web (#39983) 2019-09-10 17:27:30 -07:00
Emmanuel Garcia f098de1fde
Enable Proguard by default on release mode (#39986) 2019-09-10 17:22:55 -07:00
Francisco Magdaleno 362cde43ff
[windows] Searches for pre-release and 'all' Visual Studio installations (#40011) 2019-09-10 17:01:53 -07:00
Jenn Magder 556e3d9e74
Keep Flutter.framework binaries writable so they can be code signed (#40174) 2019-09-10 15:17:56 -07:00
Jenn Magder 12229264e2
Show CocoaPods version in hint text (#40117) 2019-09-10 13:26:32 -07:00
Michael Goderbauer 3f98fb7949
Ensure frame is scheduled when root widget is attached (#40105) 2019-09-10 13:26:09 -07:00
Sam Rawlins 2bc8f999f7 Remove visibleForTesting annotation; this constructor is used outside of testing (#39997) 2019-09-10 13:12:53 -07:00
Greg Spencer a7c06e113b
Fixed passing autofocus to MaterialButton, and when rebuilding Focus widget. (#39903)
Fixed passing autofocus to MaterialButton, and when rebuilding Focus widget, and added a test for Focus and MaterialButton to test that it works properly.
2019-09-10 10:29:58 -07:00
Jonah Williams f877c97b3b
Use persisted build information to automatically clean old outputs in assemble (#39654) 2019-09-10 09:57:47 -07:00
Mouad Debbar 03e8100346
Disable the performance overlay for web (#39999) 2019-09-10 08:56:28 -07:00
Peter Lee 423a1914f6 fix typo (#40048) 2019-09-10 08:54:18 -07:00
Andrew Brogdon 691977755c
Adds DartPad option to the DartDoc snippet generator. (#39924) 2019-09-10 08:36:14 -07:00
Jonah Williams 79ec38f7f3
ensure we use pub from flutter sdk (#40131) 2019-09-10 07:41:59 -07:00
Shi-Hao Hong 2449928d7c
Add null check to _IndicatorPainter._tabOffsetsEqual() to prevent crash (#40009)
* Add tabOffsetEqual null check with TODO
2019-09-09 21:12:27 -07:00
Sarbagya Dhaubanjar 45d57e780f Added properties in DropdownButtonFormField to match DropdownButton (#36998)
* Added properties in DropdownFormField to match DropdownButton

* Minor style guide related changes
2019-09-09 21:11:23 -07:00
Slade Capasso 4c254e5e8a Updates to debugFillProperties to test all properties in slider.dart and slider_test.dart (#39632) 2019-09-09 18:31:40 -07:00
LongCatIsLooong 663d0b13bc
Fix double.infinity serialization (#40099) 2019-09-09 18:30:12 -07:00
Jonah Williams 477ae6b8ce
cleanup use of build runner internals (#40045) 2019-09-09 18:16:03 -07:00
Jonah Williams eb7eb3ce3c
use build runners script gen (#40049) 2019-09-09 18:15:17 -07:00
Jonah Williams 0f365d3add
remove dart dir chrome profile (#39934) 2019-09-09 18:14:13 -07:00
Jonah Williams f19e4ab4f7
roll dwds (#40001) 2019-09-07 15:35:14 -07:00
Christopher Fujino f945079c65
remove fallback code for ios/usb artifacts (#39585) 2019-09-06 14:23:20 -07:00
Jonah Williams b2da79ce98
roll build runner and remove delay (#39988) 2019-09-06 14:19:12 -07:00
Harry Terkelsen 83da35fbbc
If there are no web plugins, don't generate a plugin registrant (#39910) 2019-09-06 12:54:31 -07:00
Jonah Williams b4c3671718
Register reload sources call and make 'r' restart for web (#39950) 2019-09-06 10:41:15 -07:00
lisa-liao 8b90d9d045 Allow independent theming of Persistent and Modal bottom sheets Background Color (#39333) 2019-09-06 13:06:01 -04:00
LongCatIsLooong 8661dc4022
Make CupertinoDynamicColor.resolve return null when given a null color (#39927) 2019-09-06 09:58:13 -07:00
chunhtai 57d714ebb8
fix widget built twice during warm up frame (#39079) 2019-09-06 09:46:18 -07:00
Jonah Williams 296e97f322
Revert "Correct libraries path and remove dart:io and dart:isolate for web dart platform (#39364)" (#39985)
This reverts commit 3f4d27c4bc.
2019-09-06 09:24:14 -07:00
Walid Elalaouy 8601bb7b38 Add showAboutDialog sample (#39299) 2019-09-06 09:06:53 -07:00
Jonah Williams 3f4d27c4bc
Correct libraries path and remove dart:io and dart:isolate for web dart platform (#39364) 2019-09-06 08:21:41 -07:00
Konstantin Scheglov 3118ae19ff
Fix new prefer_const_constructors after analyzer fix. (#39917) 2019-09-05 19:59:24 -07:00
Jonah Williams 0167f53101
update packages --force upgrade (#39932) 2019-09-05 19:35:59 -07:00
Michael Goderbauer e2325600ea
Do not render any frames when just initializing Bindings (#39535) 2019-09-05 17:08:50 -07:00
Shi-Hao Hong abfc560b9d
ToggleButtons test improvement (#38898)
* Improve finders throughout toggle_buttons_test.dart

* Improve Material finders

* Update toggle_buttons_theme_test.dart finders to be more precise

* Refactor out textStyle and iconTheme finders

* Refactor iconTheme and buttonTextTheme logic
2019-09-05 15:12:36 -07:00
Ian Hickson a415c76b5b
Docs (#39198)
* Minor improvements to framework documentation.

* maybePop documentation fix

* Mark some flutter_test arguments required.

Without these set, we get a crash.

* Minor correction to ListView docs
2019-09-05 15:11:50 -07:00
stuartmorgan 4c2c7c417d
Switch to the Win32 Windows embedding (#39836)
Pulls the Win32 embedding artifacts instead of the GLFW versions for
Windows.

Fixes #38590
2019-09-05 10:09:12 -07:00
stuartmorgan 3948e8759e
Allow specifying a project for Xcode getInfo (#39782)
Avoids unnecessarily breaking projects that have another .xcodeproj in
their macos/ directory, which worked until the addition of the getInfo
call.
2019-09-05 10:07:03 -07:00
LongCatIsLooong 443892bd27
CupertinoButton & Bottom tab bar dark mode (#39765)
* CupertinoTabBar

* CupertinoButton

* update

* review
2019-09-05 10:06:45 -07:00
liyuqian 7c0dfd5362
Revert "Replace deprecated onReportTimings w/ frameTimings (#38861)" (#39778)
This reverts commit 6ef80b447f.
2019-09-05 09:58:08 -07:00
Jonah Williams dd7694256e
remove input files argument to target (#39769) 2019-09-05 09:56:37 -07:00
Jonah Williams 4728ef5c16
handle browser refresh (#39776) 2019-09-05 09:56:05 -07:00
Jonah Williams 06348522c3
workaround for mangled web sdk source map packages (#39774) 2019-09-05 09:55:54 -07:00
Justin McCandless 64424a6ae4
Null TextWidthBasis docs (#39761)
Docs improvement after seeing "null" showing up for TextWidthBasis.
2019-09-05 09:54:56 -07:00
Mouad Debbar 2640bfeb10
Allow gaps in the initial route (#39440) 2019-09-05 09:51:35 -07:00
Zachary Anderson 0f2af976a2
[flutter_tools] Add a timeout to another showBuildSettings command (#39579) 2019-09-05 09:50:46 -07:00
Kenzie Schmoll d50d9c5e60
Register flutterVersion service in flutter_tools. (#39524)
* Register getFlutterVersion service in flutter_tools.

* Add short revision ids to response.

* Rename method and remove obsolete comments.

* Fix broken test by adding sendPeerNotifications flag.

* Implement mockPeer.sendNotification.
2019-09-05 09:50:36 -07:00
Devon Carew 57e6042f68
update to the latest package:dwds (#39834) 2019-09-05 09:50:10 -07:00
Anthony 3932ffb1cd Revert "Show search app bar theme (#37962)" (#39786)
This reverts commit e3f8d05540.
2019-09-04 20:13:16 -07:00
Ian Hickson 2efbc11b7a
Revert "Keep Flutter.framework binaries writable so they can be code signed (#39539)" (#39859)
This reverts commit 72cacb4040.
2019-09-04 17:47:39 -07:00
rami-a af9f210443
Fix single action banner to ensure button alignment (#39583) 2019-09-04 09:41:46 -04:00
Jenn Magder 72cacb4040
Keep Flutter.framework binaries writable so they can be code signed (#39539) 2019-09-03 18:00:45 -07:00
Greg Spencer f9bc89932c
Re-Land of HighlightMode change with benchmark improvements. (#39589)
* Automatic focus highlight mode for FocusManager

This re-lands the highlight mode change.

* Review Changes
2019-09-03 17:49:41 -07:00
Emmanuel Garcia d230234d67
Revert Maven dependencies (#39747) (39157) (#39784) 2019-09-03 17:49:10 -07:00
Harry Terkelsen 6f4359d1b7
Add lib/generated_plugin_registrant.dart to gitignore (#39781) 2019-09-03 16:03:09 -07:00
LongCatIsLooong e7f608072b
CupertinoActionSheet dark mode & fidelity (#39215) 2019-09-03 13:48:09 -07:00
Jonah Williams d804097014
print launching on device message (#39748) 2019-09-03 12:55:06 -07:00
Jonah Williams af851ab6bc
Revert "remove input files argument to target (#39701)" (#39768)
This reverts commit 5e7beaf7b8.
2019-09-03 12:47:33 -07:00
Jonah Williams 5e7beaf7b8
remove input files argument to target (#39701) 2019-09-03 12:46:08 -07:00
LongCatIsLooong 63c3de1091
Timer picker fidelity revision (#38481)
* WIP

* trying out different numbers

* apply intrinsic width and height

* update

* update behavior

* documentation

* wip

* fix tests

* constants

* respect theme

* respect theme

* add new test

* add new test

* update

* review

* update golden commit hash
2019-09-03 11:54:25 -07:00
Jonah Williams 476a4de17e
Add delay to recompile request for web (#39752) 2019-09-03 11:53:46 -07:00
Jonah Williams 76ebcc8a14
remove web flag from create (#39756) 2019-09-03 11:53:27 -07:00
Emmanuel Garcia 1b429bdb47
Fix type mismatch in Gradle (#39747) 2019-09-03 11:39:30 -07:00
Jonah Williams cc9b614efd
minor cleanup and prevent multiple exit (#39751) 2019-09-03 11:00:39 -07:00
Harry Terkelsen d33cf11556
Automatically generated registrants for web plugins (#39628)
* WIP on web plugin registry

* WIP on registering plugins

* WIP on web plugin registration

* Only generate `package:flutter_web_plugins` imports if plugins are
defined

* Add parsing test

* Add documentation

* Fix analyzer warnings

* add license headers

* Add tests for package:flutter_web_plugins

* Run `flutter update-packages --force-upgrade`

* Fix analyzer errors

* Fix analyzer error in test

* Update copyright and remove flutter SDK constraints

* Enable tests since engine has rolled

* add flutter_web_plugins tests to bots

* Create an empty .packages file for WebFs test
2019-09-03 10:37:34 -07:00
Jenn Magder 0b93c96f52
Remove bitcode=NO from add-to-app flows (#39503) 2019-09-03 10:28:19 -07:00
chunhtai 36a7e3f0ef
fix sliverfixedextent with sliverchildbuilderdelegate does not correct calculate max scroll extent (#39142) 2019-09-03 10:27:37 -07:00
Tom Robinson f5fc32ff8f Update docs for GrowthDirection and scrollOffset (#39286) 2019-09-03 09:45:44 -07:00
Francisco Magdaleno deb155e89a
[macos] Check for special keys before creating a logical key (#37901) 2019-09-03 09:13:01 -07:00
Kate Lovett c8af729d1c
Golden Doc Updates (#39082) 2019-09-03 08:45:51 -07:00
Zachary Anderson b9029c7672
[flutter_tool] Add onError callback to asyncGuard. Use it in Doctor (#39445) 2019-09-03 08:14:44 -07:00
LongCatIsLooong ad47f9eea9
CupertinoActivityIndicator & CupertinoApp dark mode (#39289) 2019-09-03 07:52:36 -07:00
Greg Spencer 8daa165d01
Make disabled buttons/chips/text fields not be focusable. (#38726)
This changes the behavior of text fields, Material buttons, and Chips so that if they are disabled they lose focus. Before this change, it was possible to disable a control and then use focus traversal to reach it anyhow, and in the case of text fields, enter text into a disabled field.

Fixes #33985
2019-09-03 07:51:28 -07:00
rami-a 0ebcfe10da
Prevent exception when creating a Divider borderSide (#39572) 2019-09-03 10:15:42 -04:00
stuartmorgan 2e058142d2
Fix macOS App.framework version symlink (#39702)
The Current->A symlink in a framework shouldn't have a trailing slash;
some versions of codesigning consider the version with a trailing slash
unsignable.
2019-09-02 16:26:15 -07:00
Anthony e3f8d05540
Show search app bar theme (#37962)
Use the entire appBarTheme from the showSearch delegate for the search pages appBar theme, rather than just a select set of fields.
2019-09-02 14:23:42 -04:00
Emmanuel Garcia b63cb44105
Use new Maven artifacts from Gradle (#39157) 2019-09-02 10:35:17 -07:00
Jonah Williams 7bc4074ff3
use dpr and window size from binding (#39577) 2019-09-01 23:57:32 -07:00
Jonah Williams f12a5ec347
dont hide build commands (#39555) 2019-09-01 23:57:11 -07:00
Jonah Williams f5eb12cdc2
filter error message from skip build script checks (#39558) 2019-09-01 23:56:56 -07:00
Devon Carew e468296af3
remove a period from the service protocol printout (#39545) 2019-08-31 11:39:00 -07:00
Mouad Debbar a2957c571e
Upstream changes necessary for text editing in flutter web (#39344) 2019-08-30 10:00:03 -07:00
Anthony bb1d139c50
Replace doc example text (#39428)
The Text in the Transform.scale example is "Bad Ideas", which could be confusing as example code. This PR replaces it with something more random.
2019-08-30 10:29:32 -04:00
Matt Carroll d5c5ac62ad
Revert "Add handling of 'TextInput.clearClient' message from platform to framework (#35054). (#35100)" (#39523)
This reverts commit 324fe201b0.
2019-08-29 21:52:33 -07:00
Kaushik Iska fc05c3738c
Flutter Plugin Tool supports multi-platform plugin config (#38632) 2019-08-29 21:51:31 -07:00
Jonah Williams b2a4ebe38f
Handle single unsupported device (#39541) 2019-08-29 21:39:38 -07:00
Emmanuel Garcia 6266d5f35d
Log flags in build apk and appbundle (#39457) 2019-08-29 21:37:35 -07:00
Jonah Williams 2dbf0106d8
Create dart tool directory if it is missing (#39543) 2019-08-29 21:31:57 -07:00
Dan Field eefe9d9527
keep symbols for profile (#39530) 2019-08-29 20:54:30 -07:00
Jonah Williams 359b532570
Remove run in shell and add unit test for chrome launching (#39462) 2019-08-29 19:35:06 -07:00
Gary Qian 7e361d7461
Reland "Expose LineMetrics in TextPainter (#39282)" (#39519) 2019-08-29 17:19:14 -07:00
Phil Quitslund 37846b032f
migrate from slow async io calls (#39515)
* migrate from slow async io calls
2019-08-29 16:47:10 -07:00
LongCatIsLooong 98b9f31478
make CupertinoDynamicColor const constructible (#39430)
* make CupertinoDynamicColor const constructible

* review
2019-08-29 16:40:16 -07:00
Dan Field 632526aab9
Update validation to support Xcode11 version (#39463) 2019-08-29 15:28:05 -07:00
Harry Terkelsen 13bd52bf9e
Add HtmlElementView (the Flutter Web platform view) (#37819)
* Implement HtmlView, the platform view widget for Flutter Web

* Document HtmlView constructor

* Respond to review comments

* - Rename to HtmlElementView
- Assert running on web
- Move test to Chrome-only file
2019-08-29 12:49:04 -07:00
Jonah Williams ed4794382b
Revert "Expose LineMetrics in TextPainter through computeLineMetrics. (#39282)" (#39504)
This reverts commit d67f47b21e.
2019-08-29 12:14:02 -07:00
Gary Qian d67f47b21e
Expose LineMetrics in TextPainter through computeLineMetrics. (#39282) 2019-08-29 11:28:04 -07:00
Tong Mu 4fc11db5cc
Add IterableFlagsProperty and use it on proxy box classes (#39354)
* Add FlagsSummary and implement Listener
2019-08-29 10:07:48 -07:00
Harry Terkelsen 9f4ab273f1
Add viewType to PlatformViewLink (#39446)
* Add viewType to PlatformViewLink

Re-initialize the controller when the viewType changes.

* Re-word `PlatformViewLink` doc comment for clarity
2019-08-28 20:02:08 -07:00
Jonah Williams 4984d1a33d
update packages (#39429) 2019-08-28 17:04:07 -07:00
Jonah Williams 73b798b260
Revert "Better docs for text (#38922)" (#39447)
This reverts commit ddd31bcee7.
2019-08-28 16:01:47 -07:00
liyuqian 6ef80b447f
Replace deprecated onReportTimings w/ frameTimings (#38861)
This is the continuation of https://github.com/flutter/engine/pull/11041 and https://github.com/flutter/flutter/pull/38574

This is not a breaking change as we're not removing `onReportTimings` API.
We're simply removing the use of it in our framework.
2019-08-28 15:25:06 -07:00
Dan Field cb965495d7
Reland "Relax arguments around local engine, build hello_world with bitcode" (#39434) 2019-08-28 15:19:04 -07:00
Emmanuel Garcia 4a1c62c28b
Add missing files in the Gradle wrapper directory (#39145) 2019-08-28 14:52:08 -07:00
Ian Hickson ddd31bcee7 Better docs for text (#38922) 2019-08-28 14:41:09 -07:00
Jonah Williams f362419601
make sure profile is forwarded through build web command (#39414) 2019-08-28 14:05:01 -07:00
Kenzie Schmoll 13f18d5a66
Make inspector details subtree depth configurable. (#39085)
* Make inspector details subtree depth configurable.
2019-08-28 14:02:12 -07:00
Jonah Williams 393106fbf5
Revert "Relax requirements around local engine, build hello_world with bitcode (#39357)" (#39431)
This reverts commit 202c1b4224.
2019-08-28 13:12:45 -07:00
Dan Field 202c1b4224
Relax requirements around local engine, build hello_world with bitcode (#39357) 2019-08-28 10:27:01 -07:00
Zachary Anderson b7c714e84c
[flutter_tool] Use a timeout for xcode showBuildSettings (#39280) 2019-08-28 10:03:53 -07:00
Andrei Lesnitsky 35de8d5278 respect reversed scroll views (#39195)
This PR makes Scrollable scroll in correct direction when reverse: true on desktop and web
2019-08-28 06:49:49 -07:00
xster 4640690d0f
let flutter build aar use a local engine (#39312) 2019-08-27 23:46:33 -07:00
Jonah Williams 55a1ba761d
Use output dir instead of specific paths in assemble rules (#39274) 2019-08-27 22:52:51 -07:00
Justin McCandless d3b70c91bf
Add the textAlignVertical param to TextFormField (#39144) 2019-08-27 19:08:35 -07:00
Jonah Williams 80f96ee662
surface errors from build runner (#39358) 2019-08-27 19:08:10 -07:00
Jonah Williams 23637844a3
fix source map loading and service protocol for flutter web (#39189) 2019-08-27 19:06:48 -07:00
stuartmorgan 2476415b60
Rename macos_build_flutter_assets.sh (#39353)
The name is very misleading at this point, since it does substantially
more than build flutter_assets. Name it more generically as a wrapper
for 'assemble' for macOS builds.
2019-08-27 19:03:14 -07:00
Emmanuel Garcia 5353d5e877
Fid app bundle in Gradle 3.5 (#39126) 2019-08-27 17:08:02 -07:00
Zachary Anderson 91ae1409b9
[flutter_tool] Create a temp snapshot to run create_test.dart tests (#39338) 2019-08-27 14:28:03 -07:00
adazh 5667b78291
Added a Driver wait condition for no pending platform messages (#39196) 2019-08-27 14:26:31 -07:00
Jonah Williams 6f71ce26d6
Place terminalUi flag on terminal interface (#39214) 2019-08-27 14:20:51 -07:00
Tong Mu 7f02566ca6
Add "OneSequenceRecognizer.resolvePointer". Fix DragGestureRecognizer crash on multiple pointers (#39017)
* Add drag tests

* Add resolvePointer

* Correct monodrag implementation

* Fix some addTearDown
2019-08-26 17:44:01 -07:00
stuartmorgan 7407695816
Add profile support on macOS (#39264)
Fix some places where Debug/Release was treated as a binary switch.

Makes similar changes to Windows and Linux to simplify adding profile
support to those platforms in the future. This means `--profile` builds
will fail on Linux and Windows for now, but that's fine since they
aren't actually supported, and unlike `--release` don't provide useful
functionality at the native code level.

Also fixes 'stopApp' always using Debug on macOS, to avoid showing an
error when running Profile (or Release).

Fixes #33203
2019-08-26 16:30:30 -07:00
Tom Robinson 6204eb6445
Change SliverGeometry.maxScrollObstructionExtent for RenderSliverFloatingPersistentHeader to match docs (#39263)
RenderSliverFloatingPersistentHeader does not pin to the leading edge of the viewport so the value of maxScrollObstructionExtent in it's SliverGeometry should be 0 per the docs at https://api.flutter.dev/flutter/rendering/SliverGeometry/maxScrollObstructionExtent.html.
2019-08-26 15:42:10 -07:00