* SwitchListTile.adaptive for wrapping an adaptive Switch
* Test SwitchListTile.adaptive same as Switch.adaptive
* Remove TODO
* Comment and switch statement cleanup
* Handle a missing ListView separator as an error
* Handle missing item, and errors in itemBuilder and separatorBuilder
* CR fixes and move error handling into sliver.dart to handle all ListView constructors
* Only show an error for null separatorBuilder value in debug mode
* Revert "Add dashing config file for generating docset from flutter docs (#24374)"
This reverts commit ec8ca8606c.
* Revert "Update driver script to execute test through test_core (#24168)"
This reverts commit 6c62cf337f.
* Added support for passing in velocity and offset into Draggable.onDragCompleted.
* Fixed documentation of DragCompletedCallback.
* Spun off previous onDragCompleted breaking changes into new callback called Draggable.onDragEnd.
* Revert "Fixed documentation of DragCompletedCallback."
This reverts commit 069051f5be.
* Revert "Added support for passing in velocity and offset into Draggable.onDragCompleted."
This reverts commit 7ef744aa56.
* DraggableDetails constructor is now declared first as per Flutter code style.
* Draggable.onDragEnd will only call back if its widget is currently mounted to the tree.
* Moved "});" in DraggableDetails constructor to new line, vertically aligned with the constructor name, as per Flutter code style.
* Added space between if statement in drag_target.dart.
* widget.onDragEnd call is now formated as per flutter code style.
* Added more details to DraggableDetails documentation.
* Added brackets to if statement block as per Flutter code style.
* Fixed minor nits in DraggableDetails documentation.
* Made DraggableDetails constructor public. Also added documentation for its constructor.
* Fix multi-step build handling process.
Stop listening for new step updates after 'all done.' log message. Make sure that we don't delete file too soon, until listener had a chance to process the 'all done' message.
Fixes https://github.com/flutter/flutter/issues/18750
* Emit 'all output' explicitly when build process is done.
* Move integration tests to use vm_service_lib
* Turn off debug logging that was accidentally committed
* Run update-packages --force to fix checksum for new dev dependency
* Trim trailing whitespace
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form.
Also:
1. Fixed a minor bug in analyze-sample-code.dart
2. Made the snippet tool only insert descriptions if the description is non-empty.
3. Moved the Card diagram to before the code sample.
Should fix#22226.
Code introduced in #20890 caused a regression that broke color flooding animations in a BottomNavigationBar that has BottomNavigationBarType.shifting.
The original issue (#19653) dealt with background color changes not occurring until another tab was selected. The result is that the background color instantly changes whenever the state changes and when the widget changes, instead of allowing a new widget to animate the background color change.
This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.
It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.
I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.
For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
This stops reading from pipe-to-file log after the build is completed. Attempting to read from pipe-to-file keeps open blocked because nobody is going to write into that pipe.
It's not usual for this not to be set, but it affected at least one user (#23909) and there are a non-zero number of people online saying it's not set. It's better that we don't crash.
Fixes#23909.
`RenderEditable.paint` assumes that if the length of the text fits within the
visible region, then the text will be rendered at the start of the region and be
completely visible. This is not always true, since the text may still be
rendered at an offset if an animation is ongoing when the text begins to fit.
This fixes#22288 and #14121
* Use Xcode build configurations to drive Flutter build mode
* Proper check wrt local_engine, print error if profile mode misisng
* Remove unused code, update tests, fix template problem, update warning
* fix up warning
* add explanatory dev comment
* fix whitespace
* missing words, change lambda arrow to function body
* error indentation
* Test early exits for xcode_backend.sh
* only on macOS, use right test
* Update error messages
* case insensitive compare for build config
* Update gallery podfile
* update projects to add profile configuration
* make compatible with flavors
* add missing plist files
* add FLUTTER_FRAMEWORK_DIR back, set swift version for profile, tell Podfile about profile
Re-landing #23412 with a fix to the PlatformLayer's addToScene signature.
#23412 was broken by the change to Layer done in #23434.
It seemed green as the presubmits were done before #23434 was landed, and when #23412 landed it broke the build.
Reverts #23779
This PR adds the full framework stack (layer->render object->widget, and
service) for embedding iOS views with minimal functionality.
I allowed myself to throw the entire framework stack in one PR since we're mostly
mirroring the structure we already established for embedded Android views, so this PR
is a little bigger than usual. I'm happy to break it down to the
different pieces of the stack if reviewers prefer.
Specifically this PR adds:
* A UiKitView widget for embedding a UIView in the widget tree.
* A RenderUiKitView which is the render object for showing a
UIView.
* A PlatformViewLayer which denotes the position of a UIView in the
layer tree.
* The iOS platform_views system channel client code in services/platform_views.dart
* Splits the fake platform views controller to an Android and iOS
controllers.
TBD in following PRs:
* Plumb the layout direction all the way to the platform view (currently
there is still no engine support for it).
* Integrate with gesture arenas (engine support is still missing as
well).
This adds flutter create --sample which allows users to execute a command which will create a working sample app from samples embedded in the API docs.
The command looks something like this:
flutter create --sample=chip.DeletableChipAttributes.onDeleted mysample
Subcommand output (gradle, adb, etc) is no longer wrapped, and wrapping notices when the terminal column width changes dynamically now.
Fixes#23267.
Fixes#23266.
* Use Xcode build configurations to drive Flutter build mode
* Proper check wrt local_engine, print error if profile mode misisng
* Remove unused code, update tests, fix template problem, update warning
* fix up warning
* add explanatory dev comment
* fix whitespace
* missing words, change lambda arrow to function body
* error indentation
* Test early exits for xcode_backend.sh
* only on macOS, use right test
* Update error messages
* case insensitive compare for build config
* Update gallery podfile
* update projects to add profile configuration
* make compatible with flavors
* add missing plist files
162b2e98c036a8f8c355fd475dbe0db4f4bc886c..7be0217d6796954694753647b7a757b8e3907f64
7be0217d6 Roll back _countryCode assert - breaking change (#6693)
91a019cfd Fix popSystemNavigator (#6691)
2b2fbf0f6 Add Locale.fromSubtags and support for scriptCode. (#6518)
58c8e30e5 Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (#6690)
3b17cfb68 Flutter tester default locales (#6689)
96bbd2b36 Roll buildroot to 11a934e99eaa4aa8e278cd2772aff4f51f1f3c41 (#6687)
0e9defbd6 Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (#6688)
cc686d7ae Don't populate the external view embedder in PaintContext. (#6686)
ab782faa7 Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (#6685)
c4aa8d343 Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (#6684)
7352251eb Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (#6683)
3dac47e4d Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (#6682)
2f06a53a8 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (#6681)
a1d7cad70 Fix inconsistent include syntax (#6680)
236661cd8 Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (#6679)
c4f50611d Roll buildroot to pick up Mac toolchain updates. (#6678)
ba8f6aa71 Handle Windows headers defining ERROR to 0 in log levels. (#6677)
505d2a923 Roll buildroot to pick up updates to custom toolchains. (#6674)
6c2a0b3a6 Undefine ERROR in platform_view_layer.cc (#6675)
55e12993a Update FlutterPlugin.h docs, suppress warning for older API (#6672)
f7970048d Attach and position embedded UIVIews (#6614)
df85722fa Plumb the iOS PlatformViewsController into flow. (#6603)
2bfb893cf iOS Embedding Refactor (#6447)
Luckily this class didn't actually need to extend its superclass, it
only implements the interface. So we can change `extends` to
`implements` and that's close enough, while allowing the class to be
mixed in again.
* Avoid abbreviations
* Sample code for AppBar.leading
* Add a test for OverflowBox/FractionallySizedBox
* Minor wording improvements in the text.
The words "note that" here don't really contribute to the flow.
* Revert "Revert "Run reload asynchronously so that multiple devices can reload in parallel. (#22693)" (#23598)"
This reverts commit 0b68068d6a.
* Fix refreshViews so it sends app-wide(rather than per-isolate) service request.
Sending per-isolate request caused dead-lock in the engine in case of more-than-one ui isolate.
* Added '--check-for-remote-artifacts' option for Flutter Doctor.
This option takes a Flutter engine revision and issues HEAD requests to
determine whether or not artifacts for the provided engine revision are
available from cloud storage. This functionality is needed for the Dart
SDK autoroller to avoid creating a PR to roll the engine into the
framework while artifacts haven't finished building, which would cause
Cirrus tests to fail.
* Revert "[H] Created a variant of InheritedWidget specifically for Listenables (#23393)"
This reverts commit 931328596a.
* Revert "Fix a race condition in vmservice_test.dart (#23529)"
This reverts commit 5e7b0a366b.
Bug #1: These didn't work with directional alignments, due to an error
in the types of the constructor arguments.
Bug #2: Pretty sure RenderSizedOverflowBox never worked at all. As
soon as I wrote a test for it, the test showed that there was a
fundamental bug in its performLayout method: it didn't set
parentUsesSize, but it immediately tried to use the child's size.
* Improve documentation
* Potential performance win in hit testing
Rather than copying the list every time we access `path`, this just
exposes it as an `Iterable`. People who want to copy it can use
`toList()`.
(This isn't a breaking change since code that expects a `List` is
still going to get one.)
* Enforce the Oxford Comma.
* Revert "Revert "make LocalHistoryRoute a proper super-mixin (#23382)" (#23430)"
This reverts commit 3bbb3082b8.
This relands the LocalHistoryRoute change. The analyzer bug has been fixed.
* mark dartdocs as flaky
* Revert "Remove duplicate code comment in flutter_gallery (#23422)"
This reverts commit 8039620bb4.
* Revert "Add explicit completed status trace to hot reload and restart commands (#23338)"
This reverts commit 245ef023b2.
This creates a custom dartdoc tool that will generate snippet blocks in our API docs that allow the user to copy easily to the clipboard, and will also embed the snippet code into a template to show it in a larger context with an app.
This PR adds the snippet tool, a template, and a couple of HTML skeleton files, one for snippets that are designed to be in an application setting, and one where it simply puts a nice container around existing snippets, making them easier to copy to the clipboard.
Ensure that cached dill files for builds with --track-widget-creation
always have .track. in the file name to avoid mixing transformed and
untransformed kernel files.