Matan Lurey
2e2042ff8e
Refactor external_ui → external_textures ( #142062 )
...
This PR makes no _behavioral_ changes to executed code, and instead
focuses on organization and naming:
1. Almost[^1] anything named `external_ui` is renamed
`external_textures`
1. Extended the README to explain the intent of the test, as well as how
to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart`
and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is
being asserted (i.e. `widgetBuilds` and friends)
Given how complex (and in-flux) this directory is, I'm also requesting
either John, Jonah or I review any changes.
[^1]: Except the name of the `.ci.yaml` task, i.e. `name:
Linux_pixel_7pro external_ui_integration_test` because I'm apparently
not able to change that without creating a new task as `bringup: true`
and playing a bit of a dance. Maybe that's worth doing though (in future
PRs)?
2024-01-24 12:44:31 -08:00
engine-flutter-autoroll
fb4eef1c9c
Roll Flutter Engine from 0b9fce355df9 to 4bc368ee5f74 (3 revisions) ( #142157 )
...
0b9fce355d...4bc368ee5fjonahwilliams@google.com [Impeller] use const std::unique_ptr ref for Sampler type. (flutter/engine#49974 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from c353c00a4dcb to 9ea7cb490804 (1 revision) (flutter/engine#50005 )
2024-01-24 mbrase@google.com Replace Fuchsia logging macros (FX_LOG*) with FML logging (flutter/engine#49970 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 19:55:07 +00:00
hangyu
6adc8246e4
Update navigationBar label's maxScaleFactor to meet GAR requirement ( #141998 )
...
fixes: https://github.com/flutter/flutter/issues/141997
2024-01-24 19:45:47 +00:00
engine-flutter-autoroll
8fb4a64853
Roll Flutter Engine from b65556fa543e to 0b9fce355df9 (1 revision) ( #142147 )
...
b65556fa54...0b9fce355dskia-flutter-autoroll@skia.org Roll Skia from 26ac196b95c4 to c353c00a4dcb (1 revision) (flutter/engine#50004 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 18:18:06 +00:00
Flutter GitHub Bot
a0df2c4573
Marks Mac_arm64 build_tests_2_4 to be unflaky ( #142115 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 build_tests_2_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_2_4%22 ).
This test can be marked as unflaky.
2024-01-24 18:11:53 +00:00
Flutter GitHub Bot
07ece1aad2
Marks Mac_x64 build_tests_2_4 to be unflaky ( #142111 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 build_tests_2_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_2_4%22 ).
This test can be marked as unflaky.
2024-01-24 17:56:38 +00:00
Flutter GitHub Bot
fdda3b5ac0
Marks Mac_x64 build_tests_1_4 to be unflaky ( #142110 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 build_tests_1_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_1_4%22 ).
This test can be marked as unflaky.
2024-01-24 17:56:35 +00:00
Flutter GitHub Bot
a0e0387a80
Marks Mac_x64 build_tests_3_4 to be unflaky ( #142112 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 build_tests_3_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_3_4%22 ).
This test can be marked as unflaky.
2024-01-24 17:55:43 +00:00
Greg Price
e661ed3a00
Revise tooltip theme docs, including more cross-references ( #137316 )
...
Much of the new wording here is borrowed from [ChipTheme], [SliderTheme], or [RadioThemeData], which I think are pretty good. I believe a lot of other theme classes have similar wording too. I've also made some tweaks of my own, notably the references to [MaterialApp.theme].
This started from a desire to have clearer cross-references pointing at what to do with a FooThemeData to make it take effect:
https://github.com/flutter/flutter/pull/135879#discussion_r1355851481
but then as I started writing I kept finding more and more small things I wanted to adjust, including a couple of bits that were extraneous or obsolete.
2024-01-24 17:26:03 +00:00
godofredoc
5d48b5c8b5
Run some tests explicitly in both arm and x64. ( #141910 )
...
This is part of the process to start running tests on either arm64 or x64 if the host architecture is not important for the test.
2024-01-24 17:24:12 +00:00
engine-flutter-autoroll
787a51fa08
Roll Flutter Engine from ba3a70ce7722 to b65556fa543e (3 revisions) ( #142140 )
...
ba3a70ce77...b65556fa54skia-flutter-autoroll@skia.org Roll Dart SDK from 8307fb417cb9 to 0f7c49da26da (1 revision) (flutter/engine#50001 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 6556502887bf to 26ac196b95c4 (1 revision) (flutter/engine#50000 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 8115d045c95d to 8307fb417cb9 (1 revision) (flutter/engine#49999 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 16:50:52 +00:00
LongCatIsLooong
b6e758addb
Fixes #138773 , port autocomplete to OverlayPortal ( #140285 )
...
Fixes #138773 , port autocomplete to OverlayPortal
2024-01-24 16:49:18 +00:00
Jesús S Guerrero
b5262f0d80
Revert "[web] - Fix broken TextField in semantics mode when it's a sibling of Navigator" ( #142129 )
...
Reverts flutter/flutter#138446
b/322136071
2024-01-24 16:13:26 +00:00
Flutter GitHub Bot
161fd82c7f
Marks Mac_arm64 build_tests_1_4 to be unflaky ( #142114 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 build_tests_1_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_1_4%22 ).
This test can be marked as unflaky.
2024-01-24 15:50:11 +00:00
engine-flutter-autoroll
229098c2d9
Roll Packages from 841fe901fe2b to 8fbdf65d0235 (2 revisions) ( #142139 )
...
841fe901fe...8fbdf65d02stuartmorgan@google.com [webview_flutter] Use a local web server for legacy web integration tests (flutter/packages#5956 )
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter from 3ee8ff287a5b673c28e4flutter/packages#5965 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 15:41:19 +00:00
Flutter GitHub Bot
277366d2cc
Marks Mac_arm64 build_tests_3_4 to be unflaky ( #142116 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 build_tests_3_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_3_4%22 ).
This test can be marked as unflaky.
2024-01-24 15:39:25 +00:00
Flutter GitHub Bot
db0ce8a498
Marks Mac_x64 build_tests_4_4 to be unflaky ( #142113 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 build_tests_4_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_4_4%22 ).
This test can be marked as unflaky.
2024-01-24 15:09:03 +00:00
Flutter GitHub Bot
e7ff0e0e8f
Marks Mac_arm64 build_tests_4_4 to be unflaky ( #142117 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 build_tests_4_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_4_4%22 ).
This test can be marked as unflaky.
2024-01-24 14:59:41 +00:00
engine-flutter-autoroll
19b06f4ee9
Roll Flutter Engine from 7c592dbfa032 to ba3a70ce7722 (2 revisions) ( #142130 )
...
7c592dbfa0...ba3a70ce77skia-flutter-autoroll@skia.org Roll Dart SDK from 69af2ca8332f to 8115d045c95d (1 revision) (flutter/engine#49998 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 1af4f1216478 to 6556502887bf (1 revision) (flutter/engine#49997 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 12:20:26 +00:00
engine-flutter-autoroll
6de70abacd
Roll Flutter Engine from 700235c85d4a to 7c592dbfa032 (2 revisions) ( #142108 )
...
700235c85d...7c592dbfa0matanlurey@users.noreply.github.com Fix a typo in `geometry.cc#ComputeUVGeometryForRect`. (flutter/engine#49986 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from be4b398b4f2e to 1af4f1216478 (1 revision) (flutter/engine#49993 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 09:30:34 +00:00
engine-flutter-autoroll
b61ef0426b
Roll Flutter Engine from da96f9de3f69 to 700235c85d4a (1 revision) ( #142100 )
...
da96f9de3f...700235c85dskia-flutter-autoroll@skia.org Roll Dart SDK from 838cd732e56a to 69af2ca8332f (1 revision) (flutter/engine#49990 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 05:33:55 +00:00
engine-flutter-autoroll
094306eadb
Roll Flutter Engine from 220416cfa6ca to da96f9de3f69 (5 revisions) ( #142098 )
...
220416cfa6...da96f9de3fskia-flutter-autoroll@skia.org Roll Skia from c396b2171b16 to be4b398b4f2e (2 revisions) (flutter/engine#49988 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 5646ac9669f8 to 838cd732e56a (3 revisions) (flutter/engine#49982 )
2024-01-24 jonahwilliams@google.com [ui] hold a strong reference to fragment program objects. (flutter/engine#49868 )
2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from 4e42423c7f6f to c396b2171b16 (1 revision) (flutter/engine#49987 )
2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from e7d10257ffb5 to 4e42423c7f6f (4 revisions) (flutter/engine#49985 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 04:25:38 +00:00
yim
24e7a0be8b
Don't change the height of the Textfield's labelStyle when it focused. ( #141943 )
...
Fixes #141448
2024-01-24 04:13:50 +00:00
Polina Cherkasova
be031cb908
Ignore a leak. ( #141737 )
2024-01-24 04:01:23 +00:00
Xilai Zhang
23c08bf08f
[github actions] FINALLY fix the mysterious token error in github actions ( #142058 )
...
This should finally (with high confidence) fix https://github.com/flutter/flutter/issues/141980 , the mysterious error where git push sometimes fail.
**Root cause**:
When a pull request merges onto flutter's master branch, it is actually a merge from a branch on a flutter contributor's repository, to flutter's repository. Therefore, the [actor](https://stackoverflow.com/questions/58737785/github-actions-empty-env-secrets ) of the pull request event, is the user that opened the pull request. And this actor would not have write access to repo and therefore the repo secret resolves to empty.
Therefore [running your pull_request workflow when a pull request merges](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges ) doesn't work because even though we are not running our workflows on a forked repository, the **actor** of the pull_request event comes from a forked repository, and secrets are not passed to this actor.
The correct way is using [pull_request_target](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target ) event instead of pull_request event. In workflows triggered by this event, GITHUB_TOKEN is granted read/write repository permission unless the permissions key is specified and the workflow **can** access secrets, even when the actor of the workflow trigger comes from a fork.
Note that workflows of this event runs in the context of the base commit and not the merge commit. But this doesn't matter for our use case since we are good with using the actions file from the base commit in the pull request event.
**Tested**:
I was finally able to reproduce the error by:
1. create a pull request under the username of different user other than the repository owner
2. merge and label the pull request, and use the token of this different user, but use it as repository secrets in the workflow
[reproduced error](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7619699924/job/20753210562 )
previously I wasn't able to reproduce this error on my personal repo because the actors in my tests are the same user.
Also tested on my personal repo, following the steps mentioned above, that using the pull_request_event type fixes the error. [succeeded run](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7630017020/job/20784762242 )
**The Debug Process**:
spent quite a while looking at other things during debugging, but they turned out to be unrelated. things that we experimented with are workflow conditions, ssh setup, git push url, manual trigger, workflow env, secret setup, dependency on market place actions (actions/checkout and peter-evans/create-pullrequest)
2024-01-24 03:50:00 +00:00
Jackson Gardner
a668aa7f99
Revert "Add abifilters to our gradle templates" ( #142089 )
...
Reverts flutter/flutter#135529
This had some failures in postsubmit:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20gradle_plugin_light_apk_test/17054/overview
and
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20gradle_plugin_fat_apk_test/17262/overview
We should revert and then investigate.
2024-01-23 19:05:20 -08:00
engine-flutter-autoroll
90e4a12f2a
Roll Flutter Engine from 0b9b538bd458 to 220416cfa6ca (2 revisions) ( #142079 )
...
0b9b538bd4...220416cfa6matanlurey@users.noreply.github.com Geometry Wars: Documentation Edition (flutter/engine#49910 )
2024-01-23 jason-simmons@users.noreply.github.com Exclude the Dart SDK sdk/lib/svg/dart2js directory from the license crawl (flutter/engine#49977 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 23:31:25 +00:00
Gray Mackall
512335230c
Add abifilters to our gradle templates ( #135529 )
...
Fixes https://github.com/flutter/flutter/issues/135173 , and could also be interpreted as fixing https://github.com/flutter/flutter/issues/83596 based on @chinmaygarde 's comment.
2024-01-23 23:19:23 +00:00
engine-flutter-autoroll
edc73bce49
Roll Flutter Engine from 11a16d83ab6c to 0b9b538bd458 (2 revisions) ( #142076 )
...
11a16d83ab...0b9b538bd4zanderso@users.noreply.github.com Roll buildroot to 5d969bd98e31ec90c23ccb982666ace80559f442 (flutter/engine#49956 )
2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from 59a70a1efc39 to e7d10257ffb5 (3 revisions) (flutter/engine#49978 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 22:44:54 +00:00
dependabot[bot]
5dd667a6da
Bump actions/upload-artifact from 4.2.0 to 4.3.0 ( #142075 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.2.0 to 4.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Reorganize upload code in prep for merge logic & add more tests by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/504 ">actions/upload-artifact#504</a></li>
<li>Add sub-action to merge artifacts by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/505 ">actions/upload-artifact#505</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.3.0 ">https://github.com/actions/upload-artifact/compare/v4...v4.3.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="26f96dfa69https://redirect.github.com/actions/upload-artifact/issues/505 ">#505</a> from actions/robherley/merge-artifacts</li>
<li><a href="530ed2c9b853ef6987b390b0f8eed8199a58f54f3f353f9d9e997fffa35552899c8c02https://redirect.github.com/actions/upload-artifact/issues/504 ">#504</a> from actions/robherley/reorganize</li>
<li><a href="da58a3f7b21f64adb853694cdabd8b...26f96dfa69https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.2.0&new-version=4.3.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-01-23 22:31:17 +00:00
Andrew Kolos
cbe0ceafe2
consolidate AssetBundle::entries and AssetBundle::entryKinds into a new type, AssetBundleEntry ( #142029 )
...
Part of work on https://github.com/flutter/flutter/pull/141194
The [`AssetBundle`](0833929c99/packages/flutter_tools/lib/src/asset.dart (L80)https://github.com/flutter/flutter/pull/141194 , I am considering associating more information with an asset. In particular, what transformers are meant to be applied to it when copying it to the build output. Rather than adding another map member onto `AssetBundle` (e.g. `entryTransformers`), I decided to make things neater by introducing the `AssetBundleEntry` type.
2024-01-23 22:00:46 +00:00
engine-flutter-autoroll
2bd5abf829
Roll Flutter Engine from 57d6b518f920 to 11a16d83ab6c (4 revisions) ( #142071 )
...
57d6b518f9...11a16d83ableroux_bruno@yahoo.fr [Web] Fix an assertion error due to synthesized keyboard events (flutter/engine#49087 )
2024-01-23 737941+loic-sharma@users.noreply.github.com [Windows] Introduce egl::Context (flutter/engine#49954 )
2024-01-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uQK4l0QeH_PlZO6cF... to kYC2-fFgjbb36mukB... (flutter/engine#49976 )
2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from 58973cca0edd to 59a70a1efc39 (17 revisions) (flutter/engine#49975 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uQK4l0QeH_Pl to kYC2-fFgjbb3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 21:39:38 +00:00
engine-flutter-autoroll
6238482073
Roll Flutter Engine from 994054143fc3 to 57d6b518f920 (3 revisions) ( #142067 )
...
994054143f...57d6b518f9jonahwilliams@google.com [Impeller] fix validation error for playground texture upload. (flutter/engine#49957 )
2024-01-23 bdero@google.com [Impeller] Fix runtime effect pipeline depth/stencil. (flutter/engine#49953 )
2024-01-23 zanderso@users.noreply.github.com Exclude prebuilts/Library from Mac builder_cache (flutter/engine#49971 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 20:57:53 +00:00
Christopher Fujino
1cee81c40a
[flutter_tools] fix language_version_test and enable shuffle ( #142009 )
...
Part of https://github.com/flutter/flutter/issues/85160
2024-01-23 20:31:53 +00:00
Ian Hickson
574e598118
Merge flutter_goldens_client into flutter_goldens ( #141900 )
...
This is part 1 of a broken down version of the #140101 refactor.
2024-01-23 21:07:31 +01:00
Lau Ching Jun
f52eaaea08
Allow overriding the native assets yaml file in the resident runner. ( #142016 )
...
This is used when the native assets are built by a separate build system.
Context: b/286799303
2024-01-23 19:49:10 +00:00
engine-flutter-autoroll
f04958a11b
Roll Flutter Engine from b229878c57f5 to 994054143fc3 (1 revision) ( #142059 )
...
b229878c57...994054143f30870216+gaaclarke@users.noreply.github.com [Impeller] turned on validation errors for one golden image test (flutter/engine#49955 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 19:33:49 +00:00
hangyu
bff417ac43
Update material banner maxScaleFactor to meet GAR requirement ( #142015 )
...
fixes: https://github.com/flutter/flutter/issues/142012
2024-01-23 19:24:54 +00:00
Qun Cheng
e86c1c88e2
Add tooltip for the clear button on SearchAnchor's search view ( #141804 )
...
Fixes #141347
This PR is to add a "clear text" tooltip for the clear button on `SearchAnchor`'s search view and also add a `clearButtonTooltip` entry for `material_localizations`.
2024-01-23 17:47:06 +00:00
engine-flutter-autoroll
5b673c28e4
Roll Flutter Engine from fd0335a910b8 to b229878c57f5 (1 revision) ( #142051 )
...
fd0335a910...b229878c57mbrase@google.com Update buildroot for fidl_binding_deps() support in the Fuchsia SDK (flutter/engine#49909 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 17:35:14 +00:00
Michael Goderbauer
930403c6c3
Remove unused clipBehavior from OverflowBar ( #141976 )
...
Fixes https://github.com/flutter/flutter/issues/141606 .
OverflowBar doesn't do any clipping and therefore there's no need to specify a clip behavior.
2024-01-23 17:16:26 +00:00
engine-flutter-autoroll
2b6c2eee46
Roll Packages from e4cbf235ec4d to 841fe901fe2b (7 revisions) ( #142047 )
...
e4cbf235ec...841fe901fekatelovett@google.com [two_dimensional_scrollables] Fix TableSpanDecoration rects when axes are reversed (flutter/packages#5916 )
2024-01-22 43054281+camsim99@users.noreply.github.com [most on Android] Bump compile SDK version to 34 (flutter/packages#5783 )
2024-01-22 dshukertjr@gmail.com [url_launcher]: Fix a grammar error in the comments of launchUrl method (flutter/packages#5919 )
2024-01-22 10687576+bparrishMines@users.noreply.github.com [webview_platform_interface] Adds WebResourceRequest to HttpResponseError (flutter/packages#5790 )
2024-01-22 43054281+camsim99@users.noreply.github.com [camerax] Update `Activity` references when `ActivityAware` lifecycle methods called (flutter/packages#5784 )
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter from 5dea6b994e3ee8ff287aflutter/packages#5955 )
2024-01-22 stuartmorgan@google.com [espresso] Replace deprecated `getObservatoryUri` (flutter/packages#5788 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 15:44:16 +00:00
engine-flutter-autoroll
1fb845f599
Roll Flutter Engine from d2855da628da to fd0335a910b8 (1 revision) ( #142046 )
...
d2855da628...fd0335a910skia-flutter-autoroll@skia.org Roll Dart SDK from 5bd0742466d2 to 5646ac9669f8 (3 revisions) (flutter/engine#49965 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 15:21:59 +00:00
Bruno Leroux
bef9763008
Add Share button to the SelectableRegion toolbar on Android ( #141447 )
...
## Description
This PR adds the share button to text selection toolbar buttons on Android ~~and iOS~~ for `SelectableRegion` (and therefore `SelectionArea`).
https://github.com/flutter/flutter/pull/139479 adds this button for `EditableText` (which is used by `TextField` and `SelectableText` but not by `SelectionArea`).
**Edit**: supporting this on iOS will need more work (see https://github.com/flutter/flutter/pull/141447#issuecomment-1889942622 and https://github.com/flutter/flutter/issues/141775 ).
## Related Issue
Follow up for https://github.com/flutter/flutter/issues/138728
## Tests
Adds 1 test.
2024-01-23 13:25:34 +00:00
David Martos
63018fe6cb
Relax the warning of unavailable tokens in gen_defaults when a default value is provided ( #140872 )
...
Fixes some false positives and false negatives from the `gen_defaults` tool regarding unavailable tokens in the Material spec.
Fixes #140871
# Before
# After
These new issues that are logged are being fixed in https://github.com/flutter/flutter/pull/140573
---
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-01-23 09:35:22 +00:00
engine-flutter-autoroll
aac6f33e51
Roll Flutter Engine from 37f68f6fc7fc to d2855da628da (1 revision) ( #142033 )
...
37f68f6fc7...d2855da628flutter/engine#49961 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 06:57:07 +00:00
engine-flutter-autoroll
5fbf951555
Roll Flutter Engine from 9e582c9032e5 to 37f68f6fc7fc (1 revision) ( #142027 )
...
9e582c9032...37f68f6fc7matanlurey@users.noreply.github.com Change how OpenGL textures are flipped in the Android embedder. (flutter/engine#49938 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 02:56:37 +00:00
engine-flutter-autoroll
676e322616
Roll Flutter Engine from df6b15d35703 to 9e582c9032e5 (1 revision) ( #142026 )
...
df6b15d357...9e582c9032skia-flutter-autoroll@skia.org Roll Dart SDK from 9470ea6b00a5 to 5bd0742466d2 (1 revision) (flutter/engine#49951 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 02:02:30 +00:00
engine-flutter-autoroll
5978d6bdb6
Roll Flutter Engine from d3dbd4225e08 to df6b15d35703 (6 revisions) ( #142023 )
...
d3dbd4225e...df6b15d357jonahwilliams@google.com [Impeller] dont emulate command buffers for compute on Metal/Vulkan. (flutter/engine#49922 )
2024-01-22 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed colorspace for metal screenshots (flutter/engine#49941 )
2024-01-22 jonahwilliams@google.com [Impeller] remove frame counter that was unused in Vulkan allocator. (flutter/engine#49913 )
2024-01-22 jason-simmons@users.noreply.github.com [Impeller] Create the golden test screenshotter after setting the Vulkan ICD environment variable (flutter/engine#49948 )
2024-01-22 737941+loic-sharma@users.noreply.github.com [Windows] Rename and move EGL types (flutter/engine#49900 )
2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from fa5f2461554f to 58973cca0edd (2 revisions) (flutter/engine#49947 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-23 01:18:27 +00:00
Ian Hickson
5dc3b1894f
Add a comment about how to test flutter_goldens ( #141902 )
...
This is part 2 of a broken down version of the #140101 refactor.
This particular change wasn't in that original refactor but is a note to myself so that I remember how to test each of these changes in the future.
2024-01-23 00:49:07 +00:00
