Commit graph

9681 commits

Author SHA1 Message Date
Chris Bracken 2c0c9ba9e5
Apply media padding in complex layout benchmark drawer header (#13610)
By default BoxScrollView (and hence ListView, which is a subclass)
padding is the media padding along its scroll axis in order to avoid
placing list items within areas where user interaction should be
minimised -- e.g. under the status bar, or in and around the iPhone X
notch in landscape mode.

In cases where a list item should occupy the padding area, developers
should set the ListView padding to EdgeInsets.zero so as not to pick up
the default media padding. For widgets inside the drawer that should
avoid safe areas, developers can add a SafeArea widget.
2017-12-15 12:46:35 -08:00
amirh 05dba60c63
keep recursing past directories with pubspec.yaml when gathering packages (#13573) 2017-12-15 12:21:03 -08:00
Chris Bracken 6728d4845d
Revert "Require Xcode 9.0 or later for iOS builds (#13608)" (#13612)
Our devicelab machines have not yet been upgraded to Xcode 9. Once this
has been done, I'll re-land this.

This reverts commit 0fac5f01a2.
2017-12-15 11:59:42 -08:00
Chris Bracken 0fac5f01a2
Require Xcode 9.0 or later for iOS builds (#13608)
We now require Xcode 9.0, which ships with the iOS 11 SDK, for iOS
builds. This change does not affect the minimum supported iOS deployment
target, which remains iOS 8.

The iOS 11 SDK adds support for safe area insets, which model the status
bar, iPhone X home indicator, and symmetric horizontal insets to avoid
the iPhone X sensor housing when in landscape mode.
2017-12-15 11:44:01 -08:00
Chris Bracken d8bfb3a99b
Apply media padding to Gallery Material Design demos (#13593)
Applies media padding (e.g. iPhone X safe area insets) to the Material Design demos in the Gallery.

Covers the following demos:
* Buttons (via the TabbedComponentDemoScaffold change)
* Cards
* Expansion panels
* Grid list
* Icons
* Images (via the TabbedComponentDemoScaffold change)
* Page Selector
* Progress Indicator
* Scrollable tabs
* Selection controls (via the TabbedComponentDemoScaffold change)
* Snack bar
* Tabs
* Text fields
* Tooltips

Fixes #13594
2017-12-15 10:13:30 -08:00
Martin Kustermann d9edab84e4
Roll engine to d945976b04cc82d32c9691dae1fc8e4955222b3d (#13605) 2017-12-15 16:03:49 +01:00
Yegor 235b64ed2f
make date picker accessible (#13502)
* make date picker accessible

* make test file lookup location-independent

* address some comments

* always wrap in IgnorePointer

* no bitmasks for flags and actions

* recommend List<*>
2017-12-14 20:38:39 -08:00
Chris Bracken dc9c95375f
Apply media padding in Color, Typography demos (#13592) 2017-12-14 18:32:41 -08:00
Chris Bracken dd943fefe0
Apply media padding in Cupertino Navigation demo (#13585)
Adds safe areas around:
1. The body of the colour swatch view (tab 1)
2. The chat header (tab 2)
3. The chat bubbles (tab 2)
4. The 'Sign In' launcher button (tab 3)
2017-12-14 17:38:48 -08:00
Chris Bracken 8a77036b35
Center Shrine demo title with centerTitle (#13586)
Rather than use a Center widget, center the title using AppBar's
centerTitle property. This ensures the title is horizontally centred
with respect to the screen rather than centred in the space between the
leading and trailing app bar widgets, which are asymmetrical in Shrine.
2017-12-14 16:53:30 -08:00
Chris Bracken 5bbcf6d4fc
Apply T, L, R media padding in Cupertino nav bar (#13580)
Applies top, left, right media padding for iOS safe area insets. This is
a follow-up to the media padding applied to large titles in
flutter/flutter#13550.
2017-12-14 15:26:16 -08:00
Ian Hickson c28121eeca
Allow the ErrorWidget to be overridden. (#13578)
Fixes https://github.com/flutter/flutter/issues/10695
2017-12-14 15:05:41 -08:00
Michael Goderbauer f9cf5a1f3d
Add a11y label to modal barrier (#13543) 2017-12-14 15:03:51 -08:00
xster 6299dbada8
Document various 'alignment' members so it's clear how to concretely specify it. (#13577) 2017-12-14 13:19:26 -08:00
amirh 81e2da9dd9
when plugins are out of date, show the command line to update (#13572) 2017-12-14 10:34:35 -08:00
Régis Crelier eb77d0140b
Roll engine to e0d19e2897b6c4c8c48f05d23a2b90bd32ab5d49 (#13570) 2017-12-14 10:34:21 -08:00
amirh becab558e1
flutter update-packages (#13571)
* flutter update-packages

* update plugin registrant for flutter_gallery
2017-12-14 10:07:51 -08:00
amirh 7d90bfc179
Pin the test package to 0.12.26 (#13546) 2017-12-14 08:52:56 -08:00
Phil Quitslund 3346c5c736
Update plugin test template. (#13516)
* Update plugin test template.

* Add flutter test run verification.

* Tweak and test runs for package projects.
2017-12-14 08:51:33 -08:00
Sarah Zakarias 5e18c07614
Reapply flutter_assets (#13567)
* Revert "Revert engine (#13547)"

This reverts commit ee65db11d4.

* Keep flaky mark
2017-12-14 17:27:25 +01:00
Sarah Zakarias 5c90c35f22
Write flutter_assets directory on Windows (#13564) 2017-12-14 16:08:31 +01:00
Mikkel Nygaard Ravn 5ae507a752
Revert "Refresh template instances (#13563)" (#13565)
This reverts commit 05d6b08ffe.
2017-12-14 15:38:39 +01:00
Mikkel Nygaard Ravn 05d6b08ffe
Refresh template instances (#13563) 2017-12-14 15:19:59 +01:00
Phil Quitslund 82e18827e1
Updated flutter_tools test running instructions. (#13533) 2017-12-14 06:01:28 -08:00
Mikkel Nygaard Ravn a2296aa8e3
Simplify project template (#13558) 2017-12-14 11:38:20 +01:00
xster c3c3b68bf7
Add some docs and warnings to PageController.page (#13509)
* partial

* add doc and warning

* add correction

* review

* fix test
2017-12-13 19:32:59 -08:00
xster 6b6803738c
Add more checks to scheduleWarmUpFrame (#13552)
* Add more checks to scheduleWarmUpFrame

* review

* add test
2017-12-13 19:20:39 -08:00
Chris Bracken 20fb6621eb
Apply media padding in ListTile (#13545)
Applies media padding (e.g. iOS safe area insets) around the list tile
children inside the InkWell.

Also adds safe area around gallery section titles for consistency with
surrounding list tiles.
2017-12-13 18:39:36 -08:00
Chris Bracken 486aa63b4c
Apply media padding in Cupertino nav bar (#13550)
Applies left and right media padding to Cupertino navigation bar large
titles.
2017-12-13 18:23:33 -08:00
Michael Goderbauer e5846d962e
Verify that committed GeneratedPluginRegistrant are up-to-date (#13541) 2017-12-13 17:49:54 -08:00
Jason Simmons 998bf194a3
Fixes to a text_painter_rtl whitespace test (#13551)
* Query selection rectangles for all three characters in the text
* Change the last character to be non-whitespace.  Minikin's line breaker will
  truncate whitespace characters at the end of a line.
2017-12-13 17:48:10 -08:00
xster c2a86a65b0
Add more doc to MediaQuery padding (#13525)
* add mediaquery docs

* review
2017-12-13 17:35:38 -08:00
Ian Hickson 2eb26f1349
Update AnimatedDefaultTextStyle to match DefaultTextStyle (#13531)
We've added a bunch of non-animatable properties to DefaultTextStyle.
This adds them to AnimatedDefaultTextStyle so that you can use them
even when your text style is animating.
2017-12-13 17:13:50 -08:00
Yegor ee65db11d4
Revert engine (#13547)
* Revert "Include a directory with Flutter assets (#12944)"

This reverts commit 3af6b9cbf5.

* Revert "Upgrade project.pbxproj to include flutter_assets (#13011)"

This reverts commit 08128cb29b.

* Revert "Upgrade complex_layout project.pbxproj to include flutter_assets (#13544)"

This reverts commit 35f1a04195.

* mark complex_layout_ios__start_up as flaky
2017-12-13 16:25:25 -08:00
Yegor 0df37f2f97
mark flutter_gallery_ios__start_up as flaky (#13542) 2017-12-13 15:45:40 -08:00
Sarah Zakarias 35f1a04195
Upgrade complex_layout project.pbxproj to include flutter_assets (#13544) 2017-12-14 00:14:51 +01:00
Sarah Zakarias 08128cb29b
Upgrade project.pbxproj to include flutter_assets (#13011) 2017-12-13 23:02:10 +01:00
Sarah Zakarias 3af6b9cbf5
Include a directory with Flutter assets (#12944) 2017-12-13 22:30:32 +01:00
Yegor 1c6decaa5e
update APK path in devicelab tests (#13540)
* update APK path in devicelab tests

* add missing transitive dependency on archive

* use path used by flutter tools
2017-12-13 13:12:10 -08:00
Mikkel Nygaard Ravn 789c7b75f7
Fix gradle plugin test (#13535) 2017-12-13 13:38:26 +01:00
Mikkel Nygaard Ravn e5aac6928b
Support Android Gradle plugin v3.0.1 (#13492) 2017-12-13 12:16:22 +01:00
Michael Goderbauer d04c906e0b
Add arguments to SemanticsActions; implement extend selection for a11y (#13490)
**This PR contains a breaking API change:**
`SemanticsConfiguration.addAction()` has been removed and replaces by action-specific setters (`onTap`, `onLongPress`, etc.) to take care of the fact that some action handlers (those, who take arguments) have different signatures.
2017-12-12 16:59:35 -08:00
Michael Goderbauer 1dd68d5deb
Roll engine to 2bdb21985c5eb9250a7b744b9b4d606c5ba30945 (#13526) 2017-12-12 16:01:08 -08:00
Mehmet Fidanboylu 951b85a12b
Increase coverage collection timeout to 2 minutes. Leafy is hitting the limits of the previous timeout of 30 seconds for tests that touch a lot of code in the app. (#13527) 2017-12-12 15:54:18 -08:00
Ian Hickson 9ac5963d2a
Fix TableBorder bugs (#13495)
Add more tests, fix docs, fix painting bugs...

Fixes https://github.com/flutter/flutter/issues/12902
2017-12-12 15:24:09 -08:00
Mehmet Fidanboylu d4868b9c80
Add test for interim state of the animation to make sure we are transitioning the border color the right way. (#13499) 2017-12-12 14:34:51 -08:00
Chris Bracken 60d4a60811
Roll engine to 4ea7075c1def9dce38f16a3c9bf0ed6fb6b2d441 (#13523)
Includes:
flutter/engine#4425
2017-12-12 14:29:27 -08:00
Greg Spencer 4e1643ebe0
Updating SDK and package versions (#13524)
Updating SDK and package versions now that alpha has been rolled to 0.0.20
2017-12-12 14:20:59 -08:00
Chris Bracken 63027b035d
Roll engine to 6c6b709b2c4008e243dda3c148521c35e6e8b3df (#13522)
Includes:
flutter/engine#4442
flutter/engine#4445
flutter/engine#4444
flutter/engine#4448 (reverts flutter/engine#4444)
flutter/engine#4447
2017-12-12 13:37:19 -08:00
xster e2192a90fc
Remove top mediaquery padding from modal bottom sheets (#13497) 2017-12-12 11:25:20 -08:00