Commit graph

14623 commits

Author SHA1 Message Date
Jonah Williams ef5fc1ae65
limit open files on macOS when copying assets (#34050) 2019-06-07 12:59:33 -07:00
Dan Field bc3ca10e71
Make it easier to pass local engine flags when running devicelab tests (#34054) 2019-06-07 12:49:09 -07:00
Jonah Williams 227ffb58d7
fix devicelab test for chrome reload worklow (#34056) 2019-06-07 12:44:17 -07:00
Amir Hardon 362b999b90
Revert "Prevent exception being thrown on hasScrolledBody (#31485)" (#34061)
This reverts commit ab707aca8f.
2019-06-07 12:43:27 -07:00
Danny Tuppeny d2e6ab69a2
Increase daemon protocol version for getSupportedPlatforms (#33980) 2019-06-07 07:48:27 +01:00
Jonah Williams 0d6122ad45
skip web test on crazy import (#34017) 2019-06-06 21:26:07 -07:00
Jonah Williams 42a14b5891
Compatibility pass on flutter/foundation tests for JavaScript compilation. (1) (#33349) 2019-06-06 21:22:00 -07:00
engine-flutter-autoroll 03872b6315
0602dbb27 Roll src/third_party/dart 9dcb026b26..6e0d978505 (72 commits) (#34027)
74975a4d17...0602dbb275

git log 74975a4d17162f23bea92ac298d1b96c2995a529..0602dbb27547cd03d8f8e816b7995cace854f7e6 --no-merges --oneline
0602dbb27 Roll src/third_party/dart 9dcb026b26..6e0d978505 (72 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-06-07 00:11:55 -04:00
Jonah Williams 698d458dc8
Add chrome stable to dockerfile and web shard (#33787) 2019-06-06 21:10:24 -07:00
Jonah Williams c91b657116
Codegen an entrypoint for flutter web applications (#33956) 2019-06-06 21:05:55 -07:00
Gary Qian 4e5cf5efb0
Revert "Reland "Text inline widgets, TextSpan rework" (#33946)" (#34002)
This reverts commit 14414f350a.
2019-06-06 18:25:36 -07:00
Gary Qian 3dd87ff78e
Revert "Re-add deprecated method for plugin migration compatibility. (#34006)" (#34022)
This reverts commit 160a5680ae.
2019-06-06 16:49:57 -07:00
Michael Goderbauer 926bc6231a
Remove print (#34004) 2019-06-06 16:26:12 -07:00
liyuqian 07083a51da
Manual roll the engine to land the timing API (#33989)
This will manually land https://github.com/flutter/engine/pull/8983 in
the framework.
2019-06-06 16:11:27 -07:00
stuartmorgan 17d6f6a072
Make plugins Swift-first on macOS (#33997)
Instead of sharing the iOS codepath that uses an ObjC generated plugin
registrant and expecting plugins to have an ObjC interface layer, switch
to generating a Swift registrant and expecting plugins to have a Swift
interface.

This means plugins on macOS that use Swift won't need an ObjC wrapper,
and plugins that use ObjC will need a Swift wrapper (inverting the
structure relative to iOS).
2019-06-06 15:49:24 -07:00
Gary Qian 160a5680ae
Re-add deprecated method for plugin migration compatibility. (#34006) 2019-06-06 15:44:06 -07:00
Jonah Williams 3f4ce34877
make sure version check includes hotfixes (#33459) 2019-06-06 15:28:20 -07:00
Amir Hardon 7d27550f6f
Respond to AndroidView focus events. (#33901)
When an AndroidView gains focus we invoke the(newly introduced)
'TextInput.setPlatformViewClient' text_input system channel method
which sets the platform view as the text input target.

When the AndroidView loses focus we send a clearFocus message to
platform views system channel(so the engine can clear the focus from
the platform view).

This PR is going to land before the engine implementation is rolled to
the framework, we swallow MissingPluginException for the newly
introduced method channel methods so this is a no-op before the engine
is ready(after the engine is rolled with the corresponding change I'll
remove the logic to swallow the exceptions).

The engine counterpart is in: flutter/engine#9203
2019-06-06 14:49:31 -07:00
stuartmorgan fb8df82c06
Add 'doctor' support for Windows (#33872)
Moves the logic for finding vcvars64.bat to a new VisualStudio class
that encapsulates finding, and providing information about, VisualStudio
installations. Adds a validator for it, and runs it for Windows
workflows in doctor.
2019-06-06 14:02:27 -07:00
stuartmorgan 9751f3e537
Add use_frameworks to macOS Podfile template (#33987)
This wasn't included originally since it didn't seem to be necessary for
macOS in testing, but not having it breaks Swift plugins. This matches
the iOS Swift Podfile template.
2019-06-06 12:43:37 -07:00
Anthony e1d0ded926
[Material] Create a themable Range Slider (continuous and discrete) (#31681)
Creates a Material Design range slider.

The range slider is based off the updated slider, with the main difference being that it has 2 thumbs.
By default, the thumbs cannot pass each other and both the thumb and the value indicator create a stroke when they are overlapping for better visibility.
2019-06-06 15:31:02 -04:00
Kate Lovett 005fa1c689
Updating names to correct versioning convention (#33865) 2019-06-06 12:15:44 -07:00
Alexander Aprelev 30dbc4c767
Whitelist adb.exe heap corruption exit code. (#33951)
* Whitelist adb.exe heap corruption exit code.

In android platform tools 29.0.0 adb.exe shell seems to be exiting with heap corruption exit code, otherwise producing results as expected. This PR whitelists this exit code on Windows.

Fixes https://github.com/flutter/flutter/issues/33938.

* Fix condition

* Fix 'shell am start' command

* Fix stop command

* Refactor into runAdbMostlyChecked(Sync/Async)

* runAdbMostlyChecked -> runAdbChecked
2019-06-06 12:01:03 -07:00
Zachary Anderson 5555725fe3
[flutter_tool] Fix 'q' for Fuchsia profile/debug mode (#33846) 2019-06-06 11:16:19 -07:00
Michael Goderbauer 9114f4456c
Add localFocalPoint to ScaleDetector (#33955) 2019-06-06 11:09:39 -07:00
LongCatIsLooong d759197d1f
Add scrollbars to Gallery (#33634) 2019-06-06 10:54:28 -07:00
Rubens de Melo 23174c34b1 Include advice about dispose in TextEditingController api (#33653)
* include advice about dispose

The same note in https://flutter.dev/docs/cookbook/forms/text-field-changes

* Include remember to dispose texteditingcontroller

Almost the same note here https://flutter.dev/docs/cookbook/forms/text-field-changes#2-use-a-texteditingcontroller .

* include remember to dispose TextEditingController and link to see also

* remove extras spaces and duplicated comment

* include details about using Positioned.fill

* Revert "include details about using Positioned.fill"

This reverts commit c06196f888.

* rever comment about Positioned.fill

* Include of and remove extra white space

Include of and remove extra white space in the end of line

* improve link description to cookbook

///  * Learn how to use a [TextEditingController] in one of our [cookbook recipe]s.(https://flutter.dev/docs/cookbook/forms/text-field-changes#2-use-a-texteditingcontroller)

* include of, remove extra white space and improve description link to cookbook.

include of, remove extra white space and improve description link to cookbook.

* include of, remove extra white space and improve link description to cookbook

include of, remove extra white space and improve link description to cookbook

* include of, remove extra white space and improve link description to cookbook

include of, remove extra white space and improve link description to cookbook

* remove extra white spaces

* remove extra white space
2019-06-06 10:41:48 -07:00
sjindel-google f83df74b6b
Don't print warning message when running benchmarks test. (#33842)
# Description
Currently the benchmarks test prints a scary warning message, even when it passes, that a benchmark is being run with asserts enabled.

Normally we don't want developers to do this, because the performance of code with asserts is not characteristic of what end-users will experience. However, we need to unit-test benchmarkWidgets, so I've added a contraindicated option to suppress the warning for the test.

# Related Issues
25049 (comment)
2019-06-06 19:39:32 +02:00
Zachary Anderson 366dcb1588
Revert engine back to afb9d510c3bb0f1b97980434b41200a2d3491697 (#33982)
Revert "Add currentSystemFrameTimeStamp to SchedulerBinding (#33886)"

This reverts commit 61b83d320e.
2019-06-06 09:50:45 -07:00
Gary Qian 14414f350a
Reland "Text inline widgets, TextSpan rework" (#33946) 2019-06-05 18:14:17 -07:00
engine-flutter-autoroll 881cdfdeb0
3371da1e0 Add platform_fuchsia.cc for default font on fuchsia (flutter/engine#9204) (#33953)
7826548462...3371da1e09

git log 78265484623037c6544dfd5380367bca29fa27b0..3371da1e09511cb047c746e8209ec91550714b05 --no-merges --oneline
3371da1e0 Add platform_fuchsia.cc for default font on fuchsia (flutter/engine#9204)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-06-05 21:11:55 -04:00
Michael Goderbauer 61b83d320e
Add currentSystemFrameTimeStamp to SchedulerBinding (#33886) 2019-06-05 18:02:01 -07:00
engine-flutter-autoroll c84767cae8
Roll engine afb9d510c3bb..782654846230 (3 commits) (#33950)
afb9d510c3...7826548462

git log afb9d510c3bb0f1b97980434b41200a2d3491697..78265484623037c6544dfd5380367bca29fa27b0 --no-merges --oneline
782654846 Align fuchsia and non-fuchsia tracing (flutter/engine#9199)
5ea125eaf Switch PlatformViewsController from Activity ref to Application ref. (flutter/engine#9193)
fd4368c85 Skip golden tests on non-Linux OSes (flutter/engine#9198)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-06-05 20:24:55 -04:00
Greg Spencer 947bd7524a
Fix a bug in Shortcuts with synonyms, and add tests. (#33949)
This fixes a rather embarrassing bug in ShortcutManager that happened because I forgot to add the tests I meant to add.

This fixes the bug, and adds the tests.
2019-06-05 17:13:25 -07:00
Jason Simmons 95818d2b7a
Reland "Framework support for font features in text styles" (#33876)
See https://github.com/flutter/flutter/issues/31691
2019-06-05 16:36:05 -07:00
Greg Spencer f0978c225a
Game controller button support (#33868)
This adds support for game controller buttons. It adds some supplemental USB HID codes that aren't available from the Chromium source code, and maps those on Android to the game pad buttons that Android supports. Other platforms are not supported yet.
2019-06-05 16:23:17 -07:00
engine-flutter-autoroll 4e4d3a5de4
afb9d510c Roll src/third_party/skia 7e2c3cdbb238..e0d90c84e42f (19 commits) (flutter/engine#9202) (#33945)
669ac3848d...afb9d510c3

git log 669ac3848d0f52d0d4db28af1ed5e73d8c3a86ef..afb9d510c3bb0f1b97980434b41200a2d3491697 --no-merges --oneline
afb9d510c Roll src/third_party/skia 7e2c3cdbb238..e0d90c84e42f (19 commits) (flutter/engine#9202)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-06-05 19:22:59 -04:00
Zachary Anderson 5180201fe1
[flutter_tool] Track APK sha calculation time (#33923) 2019-06-05 15:28:19 -07:00
Jonah Williams b3382b9907
Reland support flutter test on platform chrome (#33859) 2019-06-05 15:27:49 -07:00
Jonah Williams 7548614350
Prevent windows web doctor from launching chrome (#33874) 2019-06-05 15:16:50 -07:00
engine-flutter-autoroll b7a9a75bb9
Roll engine bf15bd080314..669ac3848d0f (6 commits) (#33940)
bf15bd0803...669ac3848d

git log bf15bd0803142ffc3500f8e5ad4d37aca34246ff..669ac3848d0f52d0d4db28af1ed5e73d8c3a86ef --no-merges --oneline
669ac3848 roll dart and update libraries files (flutter/engine#9201)
a6451caff Roll src/third_party/skia 89fc1db4e809..7e2c3cdbb238 (2 commits) (flutter/engine#9195)
178e7e320 Revert "Roll src/third_party/dart b080e7c97a..9dcb026b26 (30 commits)" (flutter/engine#9200)
369ba9ee5 Roll src/third_party/dart b080e7c97a..9dcb026b26 (30 commits)
44b1cedff Allow the task queues to be swapped in MessageLoops (flutter/engine#9189)
89c0c1b8f Roll src/third_party/skia 346f82c1c3e0..89fc1db4e809 (2 commits) (flutter/engine#9191)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-06-05 17:44:56 -04:00
K. P. Sroka ab707aca8f Prevent exception being thrown on hasScrolledBody (#31485)
Convert scheduling to use `scheduleMicrotask` instead of `Timer.run`
2019-06-05 13:30:59 -07:00
MH Johnson 1b87f558d5
[Material] Add support for hovered, pressed, and focused text color on Buttons. (#33090)
* Support for stateful text colors in buttons

* Add color and a11y tests for buttons
2019-06-05 15:46:53 -04:00
Jonah Williams 50ea6f32d3
add benchmarks to track web size (#33892) 2019-06-05 12:40:21 -07:00
engine-flutter-autoroll a6e77377ff
Roll engine 86aa01442b5d..bf15bd080314 (5 commits) (#33895)
86aa01442b...bf15bd0803

git log 86aa01442b5d5a6b9b16ff3cf15d529a92d9d75c..bf15bd0803142ffc3500f8e5ad4d37aca34246ff --no-merges --oneline
bf15bd080 Add the key event source, vendorId, and productId from Android (flutter/engine#9186)
d4c7c30fd Roll src/third_party/skia a4bb02063672..346f82c1c3e0 (6 commits) (flutter/engine#9188)
7746e2e7f Compile the physical_shape_layer_unittests.cc TU. (flutter/engine#9187)
12f48f760 Allow for whitelisted flags to be passed to the Dart VM (flutter/engine#9148)
b304dabc3 [scene_host] Cleanup scene_host closures (flutter/engine#9061)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-06-05 15:37:56 -04:00
Gary Qian 2db7918eb5
Revert "Text inline widgets, TextSpan rework (#33794)" (#33928)
This reverts commit 86862c1e62.
2019-06-05 11:35:46 -07:00
Kate Lovett 5a6a664094
The the doc fix (#33917) 2019-06-05 09:07:53 -07:00
Hans Muller 5948b3daca
Updated localizations (#33883) 2019-06-04 17:49:15 -07:00
Gary Qian 86862c1e62
Text inline widgets, TextSpan rework (#33794)
* Merge in changes for inline widgets

* Make analyzer happy, fix tests

* Fix analyzer

* Add missing doc

* Docs on RichText

* Fix analyzer some more

* Remove whitespace at end of line

* Update goldens

* Text fixes

* Analyzer
2019-06-04 16:27:53 -07:00
engine-flutter-autoroll b3b6d03737
Roll engine 661c24e4f359..86aa01442b5d (2 commits) (#33869)
661c24e4f3...86aa01442b

git log 661c24e4f359c60915a21c285d1d34777f0ccb30..86aa01442b5d5a6b9b16ff3cf15d529a92d9d75c --no-merges --oneline
86aa01442 Fix platform views channel regression (flutter/engine#9185)
bd358e797 Roll src/third_party/skia 806267973f8d..a4bb02063672 (10 commits) (flutter/engine#9184)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-06-04 19:25:55 -04:00