Valentin Vignal
2676c84a90
Disable leak tracking for selection text area ( #147273 )
2024-04-24 09:06:17 -07:00
Taha Tesser
fa85f69e47
Add missing overlayColor
property in styleFrom
methods ( #146685 )
...
fixes [Add missing `overlayColor` property in `styleFrom` methods](https://github.com/flutter/flutter/issues/146636 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
enum Sizes { extraSmall, small, medium, large, extraLarge }
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
Text('styleFrom(overlayColor: Colors.red)', style: Theme.of(context).textTheme.titleLarge),
TextButton(
style: TextButton.styleFrom(overlayColor: Colors.red),
onPressed: () {},
child: const Text('TextButton'),
),
IconButton(
style: IconButton.styleFrom(
overlayColor: Colors.red,
),
onPressed: () {},
icon: const Icon(Icons.add),
),
MenuBar(
children: [
MenuItemButton(
style: MenuItemButton.styleFrom(overlayColor: Colors.red),
child: const Text('MenuItemButton'),
onPressed: () {},
),
SubmenuButton(
style: SubmenuButton.styleFrom(overlayColor: Colors.red),
menuChildren: [
MenuItemButton(
child: const Text('MenuItemButton'),
onPressed: () {},
),
],
child: const Text('SubmenuButton'),
),
],
),
SegmentedButton<Sizes>(
style:
SegmentedButton.styleFrom(overlayColor: Colors.red),
segments: const <ButtonSegment<Sizes>>[
ButtonSegment<Sizes>(
value: Sizes.extraSmall, label: Text('XS')),
ButtonSegment<Sizes>(value: Sizes.small, label: Text('S')),
ButtonSegment<Sizes>(value: Sizes.medium, label: Text('M')),
ButtonSegment<Sizes>(
value: Sizes.large,
label: Text('L'),
),
ButtonSegment<Sizes>(
value: Sizes.extraLarge, label: Text('XL')),
],
selected: const {Sizes.medium},
onSelectionChanged: (Set<Sizes> newSelection) {},
multiSelectionEnabled: true,
),
],
),
),
),
);
}
}
```
</details>
### Preview
![ScreenRecording2024-04-12at15 25 58-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/89b9638d-f369-4ef1-b501-17c9c74b2541 )
2024-04-24 11:56:32 +00:00
engine-flutter-autoroll
ffea970ce8
Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) ( #147293 )
...
3d91141e7e...b5d5832f71
2024-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 60cb97ab64e6 to 5227dc5103f6 (1 revision) (flutter/engine#52356 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 11:04:26 +00:00
engine-flutter-autoroll
65e657799f
Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) ( #147281 )
...
d4f63383d3...3d91141e7e
2024-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from cf9144942ca1 to 60cb97ab64e6 (1 revision) (flutter/engine#52351 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 04:26:40 +00:00
engine-flutter-autoroll
49770cd929
Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) ( #147276 )
...
fcb1060113...d4f63383d3
2024-04-24 jonahwilliams@google.com [Impeller] delete unused geometry API. (flutter/engine#52347 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 02:55:10 +00:00
engine-flutter-autoroll
143cd4442a
Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) ( #147272 )
...
7f89b43673...fcb1060113
2024-04-23 zanderso@users.noreply.github.com [et] Don't require the --verbose flag when requesting a ci/ build (flutter/engine#52339 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 02:15:13 +00:00
engine-flutter-autoroll
89490e11e8
Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) ( #147270 )
...
9819627013...7f89b43673
2024-04-23 chris@bracken.jp [macOS] Disable FlutterEngineTest.BackgroundColor (flutter/engine#52341 )
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from cdede8e2e18b to e15464e6e982 (2 revisions) (flutter/engine#52344 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 01:13:33 +00:00
engine-flutter-autoroll
8159f13aa8
Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) ( #147267 )
...
d56a231cdd...9819627013
2024-04-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 6a670b60eb06 to cf9144942ca1 (1 revision) (flutter/engine#52338 )
2024-04-23 jonahwilliams@google.com [Impeller] Reland: Compute UVs in vertex stage. (flutter/engine#52303 )
2024-04-23 chinmaygarde@google.com [Impeller] Add DriverInfoVK::IsEmulator and a log dumper for driver info. (flutter/engine#52337 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-24 00:29:32 +00:00
engine-flutter-autoroll
85b3c4a1a4
Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) ( #147266 )
...
5f17a779f1...d56a231cdd
2024-04-23 chris@bracken.jp Add containsCommand matcher (flutter/engine#52306 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 23:48:09 +00:00
engine-flutter-autoroll
e202a2002c
Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) ( #147264 )
...
303e718908...5f17a779f1
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from f09c6745031c to cdede8e2e18b (1 revision) (flutter/engine#52335 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 23:02:07 +00:00
Tomasz Gucio
7b3f743c3c
Remove unneeded local variables and comments in Editable and RenderParagraph ( #146843 )
...
This PR removes unnecessary local variables and related comments in `Editable` and `RenderParagraph` as both now use another `TextPainter` instance for intrinsics cache.
Test-exempt: minor refactor and comments.
2024-04-23 22:30:06 +00:00
Kostia Sokolovskyi
9ebf80a80a
Add test for sliver_animated_opacity.0.dart API example. ( #146722 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/implicit_animations/sliver_animated_opacity.0_test.dart` test
2024-04-23 22:10:50 +00:00
Mairramer
790ce64f0b
Adds AutovalidateMode.onFocusChange to Form and FormField ( #140962 )
...
This will add a new autovalidateMode to Form and FormField, based on issue #40675 .
2024-04-23 22:09:05 +00:00
engine-flutter-autoroll
292a817f60
Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) ( #147262 )
...
b686508a1d...303e718908
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from f9d6a2cf4179 to f09c6745031c (1 revision) (flutter/engine#52334 )
2024-04-23 jacksongardner@google.com [skwasm] Fix sampling options for low filter quality to match CanvasKit. (flutter/engine#52331 )
2024-04-23 chinmaygarde@google.com [Impeller] Fix Vulkan validation error on latest MoltenVK. (flutter/engine#52332 )
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from 21563606e32d to f9d6a2cf4179 (1 revision) (flutter/engine#52330 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 22:03:21 +00:00
engine-flutter-autoroll
66e0913d73
Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) ( #147258 )
...
f23cc4dda1...b686508a1d
2024-04-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from L533ubzhjWwW7jxbc... to le_-uFgRD5DjvvqgL... (flutter/engine#52329 )
2024-04-23 jonahwilliams@google.com [Impeller] only use framebuffer advanced blends if available. (flutter/engine#52284 )
2024-04-23 jonahwilliams@google.com [Impeller] drawVertices uber shader. (flutter/engine#52315 )
2024-04-23 skia-flutter-autoroll@skia.org Roll Dart SDK from acd54f86bdbb to 6a670b60eb06 (1 revision) (flutter/engine#52327 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from L533ubzhjWwW to le_-uFgRD5Dj
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 21:17:01 +00:00
Kostia Sokolovskyi
f6dc1ac00d
Add test for focus_node.0.dart API example. ( #146943 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/focus_manager/focus_node.0_test.dart` test
2024-04-23 20:32:07 +00:00
engine-flutter-autoroll
16cace56a0
Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) ( #147255 )
...
066953b740...f23cc4dda1
2024-04-23 30870216+gaaclarke@users.noreply.github.com [Impeller] Cleanup `PipelineVK::Create` (flutter/engine#52278 )
2024-04-23 johnoneil@users.noreply.github.com Issue #146080 : Fix for incorrect STB based atlas glyph scaling (flutter/engine#51882 )
2024-04-23 jason-simmons@users.noreply.github.com [Impeller] Do not call std::forward on the serialized arguments in the canvas recorder (flutter/engine#52307 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 20:10:22 +00:00
Jesse
9689f7f89c
Refactor framework + test harness tests ( #146213 )
...
Refactor the framework + test harness test suites in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing tests
The refactor of both suites included in this PR because they both depended on util functions and variables that also needed to be refactored.
Part of https://github.com/flutter/flutter/issues/145482
2024-04-23 19:29:04 +00:00
Taha Tesser
e34a9e3f39
Fix chips delete icon override the default icon size and ignores IconTheme
from the chip property and ChipThemeData
( #146509 )
...
fixes [Provided delete icon overrides the default delete icon size](https://github.com/flutter/flutter/issues/146404 )
fixes [Chips delete icon ignores `IconTheme` from `Chip.iconTheme` and `ChipThemeData.iconTheme`](https://github.com/flutter/flutter/issues/146501 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
chipTheme: const ChipThemeData(
iconTheme: IconThemeData(
color: Colors.red,
),
),
),
home: Scaffold(
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
FilterChip(
avatar: const Icon(Icons.favorite),
onDeleted: () {},
label: const Text('Filter Chip'),
onSelected: (value) {},
),
const SizedBox(height: 10),
FilterChip(
avatar: const Icon(Icons.favorite),
// ignore: prefer_const_constructors
deleteIcon: const Icon(Icons.delete),
onDeleted: () {},
label: const Text('Filter Chip'),
onSelected: (value) {},
),
],
),
),
),
);
}
}
```
</details>
### Before
![Screenshot 2024-04-09 at 16 48 48](https://github.com/flutter/flutter/assets/48603081/79d14a63-3c24-4f3e-bda4-5de76b319160 )
### After
![Screenshot 2024-04-09 at 16 48 31](https://github.com/flutter/flutter/assets/48603081/8d54373f-53f1-4908-bd9c-2ee351227f27 )
2024-04-23 19:24:00 +00:00
engine-flutter-autoroll
e219cb0085
Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) ( #147248 )
...
f794e6719d...066953b740
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from 0756b4606e6f to 21563606e32d (2 revisions) (flutter/engine#52325 )
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from a373bf46bffb to 0756b4606e6f (3 revisions) (flutter/engine#52323 )
2024-04-23 jonahwilliams@google.com [Impeller] add test case for path that explicitly closes at origin. (flutter/engine#52314 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 19:16:07 +00:00
Gil Nobrega
dd647b0909
Fix frozen StretchingOverscrollIndicator
animation ( #147195 )
...
`StretchingOverscrollIndicator`'s controller does not have a minimum value for its animation duration.
When the `OverscrollNotification`'s `velocity` is small enough (< `25`) the controller's `absorbImpact` method sets this animation duration to 0ms, making the animation appear frozen to the user.
This PR sets a minimum animation duration of 50ms.
Fixes #146277
| Before | After |
| --- | --- |
| <video src="https://github.com/flutter/flutter/assets/82336674/8761f14e-d5a5-4a39-b8e7-9e77433ce2c6 " width=250px />| <video src="https://github.com/flutter/flutter/assets/82336674/57b38448-29fb-41ad-a947-d7cf1c160ca3 " width=250px /> |
2024-04-23 19:14:30 +00:00
Kostia Sokolovskyi
ff5e2d5922
Add test for animated_align.0.dart API example. ( #146719 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/implicit_animations/animated_align.0_test.dart` test
2024-04-23 19:13:14 +00:00
ChoiYS
47ce800c14
Fix typos related to Navigator ( #147221 )
...
This PR fixes some typos and improves readability in the documentation for the Navigator and NavigatorObserver classes.
</br>
2024-04-23 19:13:12 +00:00
Valentin Vignal
b0198426b5
Fix memory leak in switch painter ( #147228 )
2024-04-23 11:14:19 -07:00
Kostia Sokolovskyi
b0524b354b
Add test for animated_positioned.0.dart API example. ( #146720 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/implicit_animations/animated_positioned.0_test.dart` test
2024-04-23 17:16:07 +00:00
Kate Lovett
e10e9a90af
Update icon tree shaker to allow system font fallback ( #147202 )
...
Fixes https://github.com/flutter/flutter/issues/147189
This allows const `IconData` to fallback to the system font if `fontFamily` is not provided.
A similar non-fatal error occurs when IconData specifies a font that is not included in the manifest, so I modeled after that error message:
b4121a1867/packages/flutter_tools/lib/src/build_system/targets/icon_tree_shaker.dart (L122)
2024-04-23 16:40:29 +00:00
Nate
a83e111a87
flutter/lib/src/
: refactoring if-chains into switch expressions (#146293 )
...
Based on issue #144903 , this pull request aims to bring the codebase more in line with the [Flutter repo style guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-using-if-chains-or--or--with-enum-values ):
> ### Avoid using `if` chains or `?:` or `==` with enum values
2024-04-23 16:32:15 +00:00
engine-flutter-autoroll
a91c62dcd0
Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) ( #147241 )
...
79f49954cc...f794e6719d
2024-04-23 skia-flutter-autoroll@skia.org Roll Dart SDK from b340d0f393b6 to acd54f86bdbb (1 revision) (flutter/engine#52321 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 15:59:42 +00:00
engine-flutter-autoroll
a399fa4b71
Roll Packages from 01a32c4a464f to cf6d2803d93e (5 revisions) ( #147240 )
...
01a32c4a46...cf6d2803d9
2024-04-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.2 to 4.3.3 (flutter/packages#6598)
2024-04-22 zeqinjie@qq.com [image_picker] Fix If imageToScale is nil, the app will crash (#146682 ) (flutter/packages#6514 )
2024-04-22 engine-flutter-autoroll@skia.org Roll Flutter from 1a905d508d
to 140edb9883
(5 revisions) (flutter/packages#6594 )
2024-04-22 ditman@gmail.com [pointer_interceptor_web] Remove semantic tests. (flutter/packages#6580 )
2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/packages#6571 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 15:45:17 +00:00
engine-flutter-autoroll
77043bae1a
Roll Flutter Engine from ffd3911b1ff7 to 79f49954cce8 (2 revisions) ( #147235 )
...
ffd3911b1f...79f49954cc
2024-04-23 jonnywang@google.com [fuchsia] Update Fuchsia API version to 17 (flutter/engine#52266 )
2024-04-23 kjlubick@users.noreply.github.com [skia] Remove no-op GN flag (flutter/engine#52121 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 14:17:32 +00:00
engine-flutter-autoroll
a9a556be29
Roll Flutter Engine from c7d9deb66bf7 to ffd3911b1ff7 (1 revision) ( #147227 )
...
c7d9deb66b...ffd3911b1f
2024-04-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/engine#52318 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 11:11:33 +00:00
flutter-pub-roller-bot
1465da40b7
Roll pub packages ( #147220 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-04-23 09:37:29 +00:00
engine-flutter-autoroll
572c75e968
Roll Flutter Engine from 075d834489d0 to c7d9deb66bf7 (2 revisions) ( #147215 )
...
075d834489...c7d9deb66b
2024-04-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.3 (flutter/engine#52319 )
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from fe545a316f68 to a373bf46bffb (3 revisions) (flutter/engine#52317 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 08:16:59 +00:00
Bruno Leroux
e9926c4848
Mention visualDensity impact on ButtonStyle.padding documentation ( #147048 )
...
## Description
This PR adds some information about how the Material buttons padding is impacted by visual density.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/137411
## Tests
Documentation only.
2024-04-23 08:15:53 +00:00
engine-flutter-autoroll
1f59013c65
Roll Flutter Engine from 9c0d24ff1cb6 to 075d834489d0 (1 revision) ( #147214 )
...
9c0d24ff1c...075d834489
2024-04-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f64eecc8cf3 to b340d0f393b6 (1 revision) (flutter/engine#52316 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 07:32:33 +00:00
Valentin Vignal
1be28aa61a
Fix memory leaks in CupertinoTextMagnifier
( #147208 )
2024-04-22 22:26:09 -07:00
engine-flutter-autoroll
3e8408bb63
Roll Flutter Engine from 004e98839ed7 to 9c0d24ff1cb6 (1 revision) ( #147211 )
...
004e98839e...9c0d24ff1c
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from db21ce8d0f28 to fe545a316f68 (1 revision) (flutter/engine#52313 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 05:15:09 +00:00
engine-flutter-autoroll
b11c4bc0f0
Roll Flutter Engine from 79f753650c6e to 004e98839ed7 (1 revision) ( #147209 )
...
79f753650c...004e98839e
2024-04-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 95f95b3118fe to 9f64eecc8cf3 (2 revisions) (flutter/engine#52312 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 04:27:31 +00:00
engine-flutter-autoroll
dbcbaf8d53
Roll Flutter Engine from f8e373da5227 to 79f753650c6e (1 revision) ( #147206 )
...
f8e373da52...79f753650c
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from e6de04b82b57 to db21ce8d0f28 (1 revision) (flutter/engine#52309 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 03:47:32 +00:00
Dimil Kalathiya
65fbd52b1a
fixes cupertino page transition leak ( #147133 )
2024-04-22 20:40:43 -07:00
Valentin Vignal
4938403a7a
Fix memory leaks in PopupMenu
( #147174 )
2024-04-22 20:40:33 -07:00
engine-flutter-autoroll
89a4ffaad5
Roll Flutter Engine from 62c9f17169cf to f8e373da5227 (2 revisions) ( #147205 )
...
62c9f17169...f8e373da52
2024-04-22 41930132+hellohuanlin@users.noreply.github.com [ios_edit_menu]add native edit menu (flutter/engine#50095 )
2024-04-22 matanlurey@users.noreply.github.com Fail `run_impeller_golden_tests` if `LUCI_CONTEXT && !GOLDCTL` (flutter/engine#52300 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 02:16:42 +00:00
engine-flutter-autoroll
33c6acbed3
Roll Flutter Engine from 33c828fb3ff5 to 62c9f17169cf (4 revisions) ( #147203 )
...
33c828fb3f...62c9f17169
2024-04-22 jonahwilliams@google.com [Impeller] skip lineTo for empty contours. (flutter/engine#52290 )
2024-04-22 skia-flutter-autoroll@skia.org Roll Skia from 3b32e3280b67 to e6de04b82b57 (6 revisions) (flutter/engine#52304 )
2024-04-22 jonahwilliams@google.com [Impeller] re-enable gold CTL. (flutter/engine#52299 )
2024-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 0ed66a4d77cb to 95f95b3118fe (1 revision) (flutter/engine#52301 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 01:33:09 +00:00
dependabot[bot]
c217f763e9
Bump actions/upload-artifact from 4.3.2 to 4.3.3 ( #147192 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.2 to 4.3.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.3</h2>
<h2>What's Changed</h2>
<ul>
<li>updating <code>@actions/artifact</code> dependency to v2.1.6 by <a href="https://github.com/eggyhead "><code>@âeggyhead</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/565 ">actions/upload-artifact#565</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.2...v4.3.3 ">https://github.com/actions/upload-artifact/compare/v4.3.2...v4.3.3 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="65462800fd
"><code>6546280</code></a> updating package version</li>
<li><a href="c004fb4bf6
"><code>c004fb4</code></a> Merge branch 'main' into eggyhead/use-artifact-v2.1.6</li>
<li><a href="90aba496fc
"><code>90aba49</code></a> updating toolkit artifact dependency to 2.1.6</li>
<li><a href="b06cde36fc
"><code>b06cde3</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/563 ">#563</a> from actions/eggyhead/release-4.3.2</li>
<li>See full diff in <a href="1746f4ab65...65462800fd
">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.2&new-version=4.3.3 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-23 00:23:02 +00:00
dependabot[bot]
be62c7f743
Bump github/codeql-action from 3.25.1 to 3.25.2 ( #147193 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.1 to 3.25.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="8f596b4ae3
"><code>8f596b4</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2254 ">#2254</a> from github/update-v3.25.2-4909c1ffb</li>
<li><a href="de8916ec5a
"><code>de8916e</code></a> Update changelog for v3.25.2</li>
<li><a href="4909c1ffb9
"><code>4909c1f</code></a> Bump the npm group with 3 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2253 ">#2253</a>)</li>
<li><a href="f45390cde1
"><code>f45390c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2252 ">#2252</a> from github/henrymercer/failed-external-repo-config-...</li>
<li><a href="1be8c488eb
"><code>1be8c48</code></a> Add configuration error for failing to clone external Git repo</li>
<li><a href="82edfe29ce
"><code>82edfe2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2246 ">#2246</a> from github/koesie10/remove-incorrect-log</li>
<li><a href="8786e1f9a1
"><code>8786e1f</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2249 ">#2249</a> from github/mergeback/v3.25.1-to-main-c7f91257</li>
<li><a href="3c7ac61481
"><code>3c7ac61</code></a> Update checked-in dependencies</li>
<li><a href="b5bd9be6da
"><code>b5bd9be</code></a> Update changelog and version after v3.25.1</li>
<li><a href="5d73b1bd71
"><code>5d73b1b</code></a> Remove incorrect log message</li>
<li>See full diff in <a href="c7f9125735...8f596b4ae3
">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.25.1&new-version=3.25.2 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-04-23 00:21:05 +00:00
engine-flutter-autoroll
0c7270f435
Roll Flutter Engine from a4b71f02a1c7 to 33c828fb3ff5 (9 revisions) ( #147190 )
...
a4b71f02a1...33c828fb3f
2024-04-22 skia-flutter-autoroll@skia.org Roll Skia from eb29b46236e6 to 3b32e3280b67 (1 revision) (flutter/engine#52298 )
2024-04-22 magder@google.com Break dependency cycle of FlutterViewController <-> FlutterPlatformView (flutter/engine#52271 )
2024-04-22 chris@bracken.jp [et] Lookup output filesystem path, not label (flutter/engine#52248 )
2024-04-22 skia-flutter-autoroll@skia.org Roll Skia from 975859a96f8f to eb29b46236e6 (9 revisions) (flutter/engine#52297 )
2024-04-22 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add configuration for maximum canvases (flutter/engine#51735 )
2024-04-22 120297255+PurplePolyhedron@users.noreply.github.com Fix link in BlendMode.saturation (flutter/engine#52156 )
2024-04-22 magder@google.com Refactor and migrate FlutterUndoManagerPlugin to ARC (flutter/engine#52234 )
2024-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Rr9lFiKCPhMXDGa89... to L533ubzhjWwW7jxbc... (flutter/engine#52293 )
2024-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 0a83dd7e61b1 to 0ed66a4d77cb (1 revision) (flutter/engine#52294 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Rr9lFiKCPhMX to L533ubzhjWwW
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 00:06:31 +00:00
flutter-pub-roller-bot
b4121a1867
Roll pub packages ( #147094 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-04-22 20:42:07 +00:00
Polina Cherkasova
1d7c680e25
Re-land fix for not disposed TabController ( #146745 )
...
Fixes https://github.com/flutter/flutter/issues/144910
2024-04-22 20:28:50 +00:00
engine-flutter-autoroll
d261a908d4
Roll Flutter Engine from 75ca2195c936 to a4b71f02a1c7 (1 revision) ( #147175 )
...
75ca2195c9...a4b71f02a1
2024-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from d4c5d9c92e4d to 0a83dd7e61b1 (1 revision) (flutter/engine#52291 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-22 20:19:07 +00:00
Lam Thanh Nhan
bd651347e1
Update examples/api
for android platform ( #147102 )
...
In the `examples/api`, the Android platform missed this step while migrating to the declarative plugins {} block described in [flutter-gradle-plugin-apply](https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply ), so all examples of `examples/api` cannot run.
Fixes #147100
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-04-22 20:14:13 +00:00