Commit graph

72 commits

Author SHA1 Message Date
Zachary Anderson a84e369bd2
Revert "Allow Flutter golden file tests to be flaky (#114450)" (#114902)
This reverts commit 53e6876226.
2022-11-08 09:26:55 -08:00
Kate Lovett 53e6876226
Allow Flutter golden file tests to be flaky (#114450)
* allow marking a golden check as flaky

* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib

* Pause

* ++

* ++

* Analyzer therapy

* Once more with feeling

* Nits

* Review feedback

* Silly oops

* Test progress

* More tests

* Finish

* Nits

* Analyzer

* Review feedback

Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
eggfly cf309b61b4
Fix some typos (#110077) 2022-08-24 21:56:09 +08:00
Kate Lovett abbc0bedca
Add more logs to diagnose Gold flake (#108930) 2022-08-04 00:11:23 +00:00
Pierre-Louis 74cfc3db67
Use curly_braces_in_flow_control_structures for non-flutter packages (#104629)
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_test`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins`

* fix comments

* Use `curly_braces_in_flow_control_structures` for `packages/integration_test`

* fix indentation
2022-05-25 20:01:11 +02:00
Yegor 3fe2cbabc4
[web] allow small golden deltas in HTML renderer (#102791) 2022-04-29 11:49:05 -07:00
Kate Lovett 324e6d9d4e
Re-enable Gold post-submit fail state (#101528) 2022-04-07 15:36:09 -07:00
Kate Lovett 8e7b361651
Add back Gold passfail (#100576) 2022-03-22 14:00:20 -07:00
Kate Lovett 2386fd90c9
Disable post-submit Gold failures entirely (#100332) 2022-03-17 17:07:02 -05:00
Kate Lovett 7f241ba3fa
Disable post-submit failures (#100308) 2022-03-17 11:58:26 -05:00
Kate Lovett 895beb04bb
Initialize the Skia client more efficiently (#95055) 2021-12-10 18:54:10 -08:00
Kate Lovett ea52013895
Close tree if unapproved golden images get in (#93516) 2021-11-15 12:40:32 -08:00
Yegor ad7727a21c
[web] enable CanvasKit tests using a local bundle fetched from CIPD (#92134) 2021-10-21 11:13:18 -07:00
Ian Hickson 299d484903
Enable more lints (#91642) 2021-10-14 22:03:03 -07:00
Ian Hickson f25b833f27
Enable avoid_print lint. (#91444) 2021-10-07 16:48:04 -07:00
Mouad Debbar c2ea78d231
Revert "Enable avoid_print lint. (#91332)" (#91438)
This reverts commit cb378edc9e.
2021-10-07 16:16:17 -04:00
Ian Hickson cb378edc9e
Enable avoid_print lint. (#91332) 2021-10-07 09:53:03 -07:00
Kate Lovett 65d8dd988d
Update md5 method in flutter_goldens_client (#90154) 2021-09-15 17:42:05 -07:00
Kate Lovett 8587b609a6
Update local gold api (#90072) 2021-09-14 14:53:33 -05:00
Alexandre Ardhuin 80990c21e2
code formatting (#85783) 2021-07-07 23:06:05 -07:00
Alexandre Ardhuin 34059eec2c
enable lint prefer_interpolation_to_compose_strings (#83407) 2021-06-01 11:14:06 -07:00
Alexandre Ardhuin 9bca38c5e5
remove unnecessary String.toString() (#81859) 2021-05-07 14:54:02 -07:00
Michael Goderbauer 0f91f0d48a
Clean-up analysis_options files (#77098) 2021-03-02 21:14:03 -08:00
Dan Field 1747adb630
Drop mockito for flutter_goldens (#74782) 2021-01-27 13:09:46 -08:00
Kate Lovett 085f1daa43
Clean up after large refactor (#67939) 2020-10-13 13:42:02 -07:00
Kate Lovett 72696f77dd
Remove Cirrus support for Gold (#67468) 2020-10-08 14:19:42 -05:00
Kate Lovett 9618e10a52
Add versioning to gold endpoints (#66054) 2020-09-18 14:47:09 -07:00
Michael R Fairhurst 7f3c9b6bda
Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Kate Lovett ee69eebfbd
Update Gold for new endpoint (#64982) 2020-09-02 16:35:06 -07:00
Kate Lovett cad4d1333e
Fix Gold json for digest paramset (#64757) 2020-08-27 17:48:05 -07:00
Jonah Williams 41e553bbfc
[flutter_tools] migrate flutter_goldens, flutter_goldens client to null-safety (#64201) 2020-08-24 15:31:05 -07:00
Ian Hickson b045c14eb5
Make the Skia expectation parser more resilient and update to "master_str". (#62898) 2020-08-04 18:53:31 -07:00
Alexandre Ardhuin f7d2bcdfe0
nnbd annotation in flutter_goldens_client (#59069) 2020-06-09 12:23:01 -07:00
Kate Lovett ea67a65bde
Re-land Luci Support for Gold (#52760) 2020-03-18 12:56:02 -07:00
Kate Lovett 48fc135003
Revert "Refactoring Gold to enable both Luci & Cirrus support (#49815)" (#52670)
This reverts commit 7edcc92b10.
2020-03-16 10:26:09 -07:00
Kate Lovett 7edcc92b10
Refactoring Gold to enable both Luci & Cirrus support (#49815) 2020-03-13 20:11:01 -07:00
Kate Lovett aa622fbb26
Switching to Gold Status Check (#51968) 2020-03-13 11:41:01 -07:00
Mike Rogers 57d84adc2d
Fix 2 typos within comments (#52181)
* occure > occur
* occured > occurred
* uptodate > up-to-date
2020-03-08 08:48:26 +00:00
Alexandre Ardhuin f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Kate Lovett 1c15cd863b
Fix Gold flake from gsutil fallback (#50149) 2020-02-05 11:03:02 -08:00
Kate Lovett 84aa29ce63 Gold Pre-submit flow for contributors without permissions (#47551) 2020-01-09 08:08:03 -08:00
Kate Lovett 89d72a1208 Throwing when goldctl cannot authorize/initialize (#45925) 2019-12-16 12:18:03 -08:00
Lau Ching Jun c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Kate Lovett 9011cece25
Pre-Submit Tryjobs for Flutter Gold (#44474) 2019-12-04 15:43:36 -08:00
Ian Hickson 449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Kate Lovett 1374a41313
Provide debug output for Gold uploads on post-submit (#45704) 2019-11-27 11:29:53 -08:00
Greg Spencer a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Alexandre Ardhuin 1f3ff5ca42
implicit-casts:false in flutter_goldens and flutter_goldens_client (#45249)
* implicit-casts:false in flutter_goldens and flutter_goldens_client

* fix type
2019-11-21 17:46:37 +01:00
Kate Lovett 26d09f1ab4
Gold Performance improvements (#43748) 2019-10-31 11:44:07 -07:00
Kate Lovett 7bc02037e3
Re-land Local & Pre-Submit Support for Skia Gold (#43371) 2019-10-25 15:05:21 -07:00