Commit graph

189 commits

Author SHA1 Message Date
Ian Hickson 33e9fd8934
ImageDecoration.lerp (#130533) (#131349)
This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes https://github.com/flutter/flutter/issues/12452

This was first landed in https://github.com/flutter/flutter/pull/130533 and reverted in https://github.com/flutter/flutter/pull/131347.
2023-07-26 23:48:08 +00:00
Ian Hickson 27e912316f
Revert "ImageDecoration.lerp" (#131347)
Reverts flutter/flutter#130533

Tree breakage.
2023-07-26 11:09:59 -07:00
Ian Hickson bae1ac2f6f
ImageDecoration.lerp (#130533)
This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes https://github.com/flutter/flutter/issues/12452
2023-07-26 17:31:23 +00:00
Michael Goderbauer 55b6f049a6
Enable unreachable_from_main lint - it is stable now!!1 (#129854)
PLUS: clean-up of all the unreachable stuff.
2023-07-06 00:09:01 +00:00
Michael Goderbauer aa5f4a28e9
Enable no_wildcard_variable_uses lint (#129858)
Wildcard parameters and local variables (e.g. underscore-only names like _, __, ___, etc.) will become non-binding in a future version of the Dart language. Any existing code that uses wildcard parameters or variables will break. In anticipation of this change, and to make adoption easier, this lint disallows wildcard and variable parameter uses.

We had no violations of this in the framework. Let's keep it that way!
2023-07-01 01:16:21 +00:00
Parker Lougheed c65e908449
Update analysis, linter, and repo links in analysis options (#129686)
Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499
2023-06-28 17:30:15 +00:00
Michael Goderbauer 60a87d0798
Sync Lints (#127976)
Syncs our lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml:
* removed the deprecated `iterable_contains_unrelated_type` and `list_remove_unrelated_type` lints (their replacement `collection_methods_unrelated_type` was already enabled for us)
* enabled the new `no_self_assignments` and fixed one issue triggered by the lint.
2023-06-02 04:27:17 +00:00
Michael Goderbauer 5e1ba701ed
enable no_literal_bool_comparisons lint (#126647) 2023-05-16 16:14:23 +00:00
Michael Goderbauer 42d9a2b3fa
Sync lints (#126316)
Sync lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml and enable `implicit_reopen` and `type_literal_in_constant_pattern` (which have no violations). Also contains some clean-up work towards enabling `matching_super_parameters`, which is not quite ready yet due to its handling of "private" arguments.
2023-05-11 13:27:51 +00:00
Michael Goderbauer f6b9c4da23
Update prefer_final_parameters comment (#125465)
Per discusion in https://github.com/flutter/flutter/pull/125061.
2023-04-26 07:36:19 +00:00
Michael Goderbauer 31798757e7
replace some ._() constructors with class modifiers (#122765) 2023-03-23 12:29:18 -07:00
Michael Goderbauer fda9ecfef7
Remove 1745 decorative breaks (#123259)
Remove 1745 decorative breaks
2023-03-22 21:12:22 +00:00
Michael Goderbauer 06ed8e65a7
Enable prefer_mixin (#123159)
Enable prefer_mixin
2023-03-21 23:12:26 +00:00
Michael Goderbauer cf9ba6c341
Enable invalid_case_patterns lint (#122318)
Enable invalid_case_patterns lint
2023-03-09 20:54:41 +00:00
Lioness100 26b6c1bedd
Fix typos (#121171)
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
Taha Tesser a819d61569
Remove prefer_equal_for_default_values lint rule (#120533)
* Remove `prefer_equal_for_default_values` lint rule

* Remove prefer_equal_for_default_values line
2023-02-13 19:47:48 +00:00
Sam Rawlins e62abfae62
Remove unreachable_from_main linter rule (#120110)
* Remove unreachable_from_main linter rule

* Comment out

* Update analysis_options.yaml

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-06 17:52:30 -08:00
Michael Goderbauer 50ed8a34b0
Enable unnecessary_null_comparison check (#118849)
* Enable unnecessary_null_comparison outside of packages

* fix snippet

* enable for all
2023-01-24 21:24:11 +00:00
Michael Goderbauer b308555ed1
Enable dangling_library_doc_comments and library_annotations lints (#117365) 2022-12-20 16:03:21 -08:00
Michael Goderbauer fdd2d7d64a
Sync analysis_options.yaml & cleanups (#117327) 2022-12-20 14:15:39 -08:00
Michael Goderbauer 81bc54be75
Enable use_colored_box lint (#117370) 2022-12-20 14:09:55 -08:00
Michael Goderbauer 0220afdd3e
enable use_enums (#117376) 2022-12-20 20:06:24 +00:00
Michael Goderbauer fa3777bd3e
Enable sized_box_shrink_expand lint (#117371)
* Enable  lint

* note about discarded_futures

* note about use_decorated_box

* update note on require_trailing_commas
2022-12-20 19:07:15 +00:00
Michael Goderbauer c7eb5b943e
Enable conditional_uri_does_not_exist (#108652) 2022-08-01 22:59:04 +00:00
Michael Goderbauer 2b1288eeed
clean-up analysis_options.yaml (#108747) 2022-08-01 21:54:03 +00:00
Michael Goderbauer 3d1f707317
enable avoid_returning_null (#108650) 2022-07-29 23:41:02 +00:00
Michael Goderbauer 10a7c9ba22
Unify analysis options (#108462) 2022-07-28 09:07:49 -07:00
Alexandre Ardhuin ccd33631e3
enable combinators_ordering (#107847) 2022-07-18 22:04:07 +00:00
Pierre-Louis 15aa3bfda3
turn on curly_braces_in_flow_control_structures for develop-facing code (#105113) 2022-06-02 11:25:40 +02:00
Michael Goderbauer cc4cc699f8
Enable use_super_parameters lint (#101074) 2022-04-14 13:26:18 -07:00
Michael Goderbauer a01424773e
Enable unnecessary_import (#101600) 2022-04-08 12:56:45 -07:00
Michael Goderbauer cae740b903
Enable strict-casts (as replacement for implicit-casts) (#101567) 2022-04-08 11:15:34 -07:00
Zachary Anderson c3b11c1632
Removes soon to be deprecated analyzer option (#100862) 2022-03-27 10:50:07 -07:00
Tomasz Gucio e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint (#98753) 2022-02-22 14:39:20 -08:00
Michael Goderbauer 5684b9f69e
Enable no_leading_underscores_for_local_identifiers (#96422) 2022-01-21 14:43:59 -08:00
Sam Rawlins 2cdef81ecf
Use strict-raw-types analysis instead of no-implicit-dynamic (#96296) 2022-01-20 15:45:09 -08:00
Michael Goderbauer 40a2689b9c
enable unnecessary_late (#96417) 2022-01-12 21:10:19 -08:00
Michael Goderbauer 5ac9714066
Enable no_leading_underscores_for_library_prefixes (#96420) 2022-01-11 17:35:13 -08:00
Michael Goderbauer 2a529bc536
Sync analysis_options.yaml with all.yaml, enable secure_pubspec_urls (#96299) 2022-01-07 13:50:18 -08:00
Michael Goderbauer babfcb99d1
Update comment about prefer_final_parameters (#95215) 2021-12-13 14:44:10 -08:00
Ian Hickson 299d484903
Enable more lints (#91642) 2021-10-14 22:03:03 -07:00
Ian Hickson 66dd2add7e
Add some more new lints (#91659) 2021-10-12 11:33:04 -07:00
Ian Hickson bb5cbdc635
Enable depend_on_referenced_packages lint (#91653) 2021-10-12 11:28:02 -07:00
Ian Hickson 6d5fc420b6
Enable sort_child_properties_last lint (#91585) 2021-10-11 21:23:02 -07:00
Ian Hickson 9421627324
Enable only_throw_errors (#91567) 2021-10-11 14:13:03 -07:00
Ian Hickson f90b019c68
Enable prefer_relative_imports and fix files. (#91573) 2021-10-11 10:28:07 -07:00
Ian Hickson 7b01346c5c
Enable no_default_cases lint (#91530) 2021-10-11 10:23:04 -07:00
Ian Hickson b3f63d38ac
Document why some lints aren't enabled and fix some minor issues. (#91527) 2021-10-09 04:03:03 -07:00
Ian Hickson 61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00