Commit Graph

18 Commits

Author SHA1 Message Date
auto-submit[bot]
54e9f2dbe6
Reverts "Refactor external_uiexternal_textures" (#142173)
Reverts flutter/flutter#142062
Initiated by: eliasyishak
This change reverts the following previous change:
Original Description:
This PR makes no _behavioral_ changes to executed code, and instead focuses on organization and naming:

1. Almost[^1] anything named `external_ui` is renamed `external_textures`
1. Extended the README to explain the intent of the test, as well as how to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart` and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is being asserted (i.e. `widgetBuilds` and friends)

Given how complex (and in-flux) this directory is, I'm also requesting either John, Jonah or I review any changes.

[^1]: Except the name of the `.ci.yaml` task, i.e. `name: Linux_pixel_7pro external_ui_integration_test` because I'm apparently not able to change that without creating a new task as `bringup: true` and playing a bit of a dance. Maybe that's worth doing though (in future PRs)?
2024-01-24 21:41:17 +00:00
Matan Lurey
2e2042ff8e
Refactor external_uiexternal_textures (#142062)
This PR makes no _behavioral_ changes to executed code, and instead
focuses on organization and naming:

1. Almost[^1] anything named `external_ui` is renamed
`external_textures`
1. Extended the README to explain the intent of the test, as well as how
to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart`
and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is
being asserted (i.e. `widgetBuilds` and friends)

Given how complex (and in-flux) this directory is, I'm also requesting
either John, Jonah or I review any changes.

[^1]: Except the name of the `.ci.yaml` task, i.e. `name:
Linux_pixel_7pro external_ui_integration_test` because I'm apparently
not able to change that without creating a new task as `bringup: true`
and playing a bit of a dance. Maybe that's worth doing though (in future
PRs)?
2024-01-24 12:44:31 -08:00
Jenn Magder
b33b872d99
Add self back to CODEOWNERS (#140080)
I'm back from leave.  Revert https://github.com/flutter/flutter/pull/125337 but don't take back the `CODEOWNERS` file itself.
2023-12-14 05:56:29 +00:00
Jenn Magder
a2c247117b
Remove self from CODEOWNERS (#125337)
Remove self from `CODEOWNERS` file for `flutter_tools`. Now that we have the PR cocoon labeler the tools team should see any PRs that change these files, and tag the right people to review.

Also remove ownership of the `CODEOWNERS` file itself.
2023-04-21 22:33:05 +00:00
keyonghan
cc8c51bf95
remove (#122624)
Remove ownership on ci.yaml
2023-03-14 22:15:58 +00:00
Christopher Fujino
048725981e
remove Christopher Fujino from codeowners of //dev/ci (#121281)
Co-authored-by: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com>
2023-02-23 01:09:48 +00:00
Kate Lovett
a13fb5f6f7
Remove Piinks from Owners (#111929) 2022-09-19 23:37:56 +00:00
Christopher Fujino
3ce2ab9159
Auto-submit pub packages autoroll PRs (#108635) 2022-07-29 19:53:05 +00:00
Casey Hillers
10142b5817
[CODEOWNERS] Remove caseyhillers from ci.yaml (#100642) 2022-03-24 18:47:19 -07:00
Casey Hillers
261fcf1f4f
[codeowners] Remove *_builders.json ownership (#91691) 2021-10-12 13:23:05 -07:00
keyonghan
3b4c2c42df
Add owners for .ci.yaml (#91687) 2021-10-12 11:38:03 -07:00
Casey Hillers
e38a0e97d5
Remove CODEOWNERS on .ci.yaml (#82977) 2021-05-20 10:14:03 -07:00
Casey Hillers
3fe3719022
Lock prod_builders.json/try_builders.json (#82305) 2021-05-11 17:24:02 -07:00
Casey Hillers
8743f94f49
Create dev/ci.yaml (#79396) 2021-04-02 11:09:03 -07:00
Kate Lovett
2ce36f6199
Goldens owner, removed obsolete pattern (#54206) 2020-04-07 12:26:02 -07:00
Jenn Magder
1da96a9cdf Add @christopherfujino as owner of dev/ci (docker) (#48261) 2020-01-06 13:55:03 -08:00
Kate Lovett
55c979ea09
Updating code owners for golden file changes (#38564) 2019-08-15 09:13:45 -07:00
Jenn Magder
11d3d45b6b
Add GitHub CODEOWNERS file to auto-add reviewers by path (#36492) 2019-07-22 10:23:12 -07:00