development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable hot mode by default. --no-hot disables it (#5794)

Browse source
This commit is contained in:
John McCutchan 2016-09-13 14:38:05 -07:00 committed by GitHub
parent e85f1629e5
commit fd50ccdd95
1 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
packages/flutter_tools/lib/src/commands/run.dart
View file

@ -65,8 +65,8 @@ class RunCommand extends RunCommandBase {
// Option to enable hot reloading.
argParser.addFlag('hot',
negatable: false,
defaultsTo: false,
negatable: true,
defaultsTo: true,
help: 'Run with support for hot reloading.');
// Option to write the pid to a file.
@ -90,7 +90,7 @@ class RunCommand extends RunCommandBase {
String get usagePath {
Device device = deviceForCommand;
String command = argResults['hot'] ? 'hotrun' : name;
String command = shouldUseHotMode() ? 'hotrun' : name;
if (device == null)
return command;
@ -111,6 +111,10 @@ class RunCommand extends RunCommandBase {
}
}
bool shouldUseHotMode() {
return argResults['hot'] && (getBuildMode() == BuildMode.debug);
}
@override
Future<int> runInProject() async {
int debugPort;
@ -143,16 +147,14 @@ class RunCommand extends RunCommandBase {
Cache.releaseLockEarly();
// Do some early error checks for hot mode.
bool hotMode = argResults['hot'];
// Enable hot mode by default if ``--no-hot` was not passed and we are in
// debug mode.
final bool hotMode = shouldUseHotMode();
if (hotMode) {
if (getBuildMode() != BuildMode.debug) {
printError('Hot mode only works with debug builds.');
return 1;
}
if (!deviceForCommand.supportsHotMode) {
printError('Hot mode is not supported by this device.');
printError('Hot mode is not supported by this device. '
'Run with --no-hot.');
return 1;
}
}
@ -164,7 +166,7 @@ class RunCommand extends RunCommandBase {
}
ResidentRunner runner;
if (argResults['hot']) {
if (hotMode) {
runner = new HotRunner(
deviceForCommand,
target: targetFile,