development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 03:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed ProgressIndicatorTheme.wrap() to just return a new ProgressIndicatorTheme. (#81359)

Browse source
This commit is contained in:
Darren Austin 2021-04-28 12:06:37 -07:00 committed by GitHub
parent f6726b425d
commit f4dee5c62e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/flutter/lib/src/material/progress_indicator_theme.dart
View file

@ -177,8 +177,7 @@ class ProgressIndicatorTheme extends InheritedTheme {
@override
Widget wrap(BuildContext context, Widget child) {
final ProgressIndicatorTheme? ancestorTheme = context.findAncestorWidgetOfExactType<ProgressIndicatorTheme>();
return identical(this, ancestorTheme) ? child : ProgressIndicatorTheme(data: data, child: child);
return ProgressIndicatorTheme(data: data, child: child);
}
@override

31
packages/flutter/test/material/progress_indicator_test.dart
View file

@ -826,4 +826,35 @@ void main() {
TargetPlatform.linux,
}),
);
testWidgets('ProgressIndicatorTheme.wrap() always creates a new ProgressIndicatorTheme', (WidgetTester tester) async {
late BuildContext builderContext;
const ProgressIndicatorThemeData themeData = ProgressIndicatorThemeData(
color: Color(0xFFFF0000),
linearTrackColor: Color(0xFF00FF00),
);
final ProgressIndicatorTheme progressTheme = ProgressIndicatorTheme(
data: themeData,
child: Builder(
builder: (BuildContext context) {
builderContext = context;
return const LinearProgressIndicator(value: 0.5);
}
),
);
await tester.pumpWidget(MaterialApp(
home: progressTheme,
));
final Widget wrappedTheme = progressTheme.wrap(builderContext, Container());
// Make sure the returned widget is a new ProgressIndicatorTheme instance
// with the same theme data as the original.
expect(wrappedTheme, isNot(equals(progressTheme)));
expect(wrappedTheme, isInstanceOf<ProgressIndicatorTheme>());
expect((wrappedTheme as ProgressIndicatorTheme).data, themeData);
});
}