Remove deprecated WidgetsBinding.[deferFirstFrameReport, allowFirstFrameReport] (#72893)

packages/flutter/lib/fix_data.yaml

@@ -11,6 +11,28 @@
 version: 1
 transforms:
 
+  # Changes made in https://github.com/flutter/flutter/pull/45941
+  - title: 'Rename to deferFirstFrame'
+    date: 2020-12-23
+    element:
+      uris: [ 'material.dart', 'cupertino.dart', 'widgets.dart' ]
+      method: 'deferFirstFrameReport'
+      inClass: 'WidgetsBinding'
+    changes:
+      - kind: 'rename'
+        newName: 'deferFirstFrame'
+
+  # Changes made in https://github.com/flutter/flutter/pull/45941
+  - title: 'Rename to allowFirstFrame'
+    date: 2020-12-23
+    element:
+      uris: [ 'material.dart', 'cupertino.dart', 'widgets.dart' ]
+      method: 'allowFirstFrameReport'
+      inClass: 'WidgetsBinding'
+    changes:
+      - kind: 'rename'
+        newName: 'allowFirstFrame'
+
   # Changes made in https://github.com/flutter/flutter/pull/44189
   - title: 'Rename to dependOnInheritedElement'
     date: 2020-12-23

packages/flutter/lib/src/widgets/binding.dart

@@ -731,36 +731,6 @@ mixin WidgetsBinding on BindingBase, ServicesBinding, SchedulerBinding, GestureB
   ///  * [firstFrameRasterized], whether the first frame has finished rendering.
   bool get debugDidSendFirstFrameEvent => !_needToReportFirstFrame;
 
-  /// Tell the framework not to report the frame it is building as a "useful"
-  /// first frame until there is a corresponding call to [allowFirstFrameReport].
-  ///
-  /// Deprecated. Use [deferFirstFrame]/[allowFirstFrame] to delay rendering the
-  /// first frame.
-  @Deprecated(
-    'Use deferFirstFrame/allowFirstFrame to delay rendering the first frame. '
-    'This feature was deprecated after v1.12.4.'
-  )
-  void deferFirstFrameReport() {
-    if (!kReleaseMode) {
-      deferFirstFrame();
-    }
-  }
-
-  /// When called after [deferFirstFrameReport]: tell the framework to report
-  /// the frame it is building as a "useful" first frame.
-  ///
-  /// Deprecated. Use [deferFirstFrame]/[allowFirstFrame] to delay rendering the
-  /// first frame.
-  @Deprecated(
-    'Use deferFirstFrame/allowFirstFrame to delay rendering the first frame. '
-    'This feature was deprecated after v1.12.4.'
-  )
-  void allowFirstFrameReport() {
-    if (!kReleaseMode) {
-      allowFirstFrame();
-    }
-  }
-
   void _handleBuildScheduled() {
     // If we're in the process of building dirty elements, then changes
     // should not trigger a new frame.

packages/flutter/test_fixes/cupertino.dart

@@ -9,6 +9,11 @@ void main() {
   const CupertinoTextThemeData themeData = CupertinoTextThemeData(brightness: Brightness.dark);
   themeData.copyWith(brightness: Brightness.light);
 
+  // Changes made in https://github.com/flutter/flutter/pull/45941
+  final WidgetsBinding binding = WidgetsBinding.instance!;
+  binding.deferFirstFrameReport();
+  binding.allowFirstFrameReport();
+
   // Changes made in https://github.com/flutter/flutter/pull/44189
   const StatefulElement statefulElement = StatefulElement(myWidget);
   statefulElement.inheritFromElement(ancestor);

packages/flutter/test_fixes/cupertino.dart.expect

@@ -9,6 +9,11 @@ void main() {
   const CupertinoTextThemeData themeData = CupertinoTextThemeData();
   themeData.copyWith();
 
+  // Changes made in https://github.com/flutter/flutter/pull/45941
+  final WidgetsBinding binding = WidgetsBinding.instance!;
+  binding.deferFirstFrame();
+  binding.allowFirstFrame();
+
   // Changes made in https://github.com/flutter/flutter/pull/44189
   const StatefulElement statefulElement = StatefulElement(myWidget);
   statefulElement.dependOnInheritedElement(ancestor);

packages/flutter/test_fixes/material.dart

@@ -8,6 +8,11 @@ void main() {
   // Change made in https://github.com/flutter/flutter/pull/15303
   showDialog(child: Text('Fix me.'));
 
+  // Changes made in https://github.com/flutter/flutter/pull/45941
+  final WidgetsBinding binding = WidgetsBinding.instance!;
+  binding.deferFirstFrameReport();
+  binding.allowFirstFrameReport();
+
   // Changes made in https://github.com/flutter/flutter/pull/44189
   const StatefulElement statefulElement = StatefulElement(myWidget);
   statefulElement.inheritFromElement(ancestor);

packages/flutter/test_fixes/material.dart.expect

@@ -8,6 +8,11 @@ void main() {
   // Change made in https://github.com/flutter/flutter/pull/15303
   showDialog(builder: (context) => Text('Fix me.'));
 
+  // Changes made in https://github.com/flutter/flutter/pull/45941
+  final WidgetsBinding binding = WidgetsBinding.instance!;
+  binding.deferFirstFrame();
+  binding.allowFirstFrame();
+
   // Changes made in https://github.com/flutter/flutter/pull/44189
    const StatefulElement statefulElement = StatefulElement(myWidget);
    statefulElement.dependOnInheritedElement(ancestor);

packages/flutter/test_fixes/widgets.dart

@@ -5,6 +5,11 @@
 import 'package:flutter/widgets.dart';
 
 void main() {
+  // Changes made in https://github.com/flutter/flutter/pull/45941
+  final WidgetsBinding binding = WidgetsBinding.instance!;
+  binding.deferFirstFrameReport();
+  binding.allowFirstFrameReport();
+
   // Changes made in https://github.com/flutter/flutter/pull/44189
   const StatefulElement statefulElement = StatefulElement(myWidget);
   statefulElement.inheritFromElement(ancestor);

packages/flutter/test_fixes/widgets.dart.expect

@@ -5,6 +5,11 @@
 import 'package:flutter/widgets.dart';
 
 void main() {
+  // Changes made in https://github.com/flutter/flutter/pull/45941
+  final WidgetsBinding binding = WidgetsBinding.instance!;
+  binding.deferFirstFrame();
+  binding.allowFirstFrame();
+
   // Changes made in https://github.com/flutter/flutter/pull/44189
   const StatefulElement statefulElement = StatefulElement(myWidget);
   statefulElement.dependOnInheritedElement(ancestor);