development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-09-13 21:32:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tools] Fix type error in ChromiumDevice.startApp (#111935)

Browse source
This commit is contained in:
Christopher Fujino 2022-09-20 11:10:13 -07:00 committed by GitHub
parent 3a1a25339e
commit eead1efe5f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 34 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/flutter_tools/lib/src/web/web_device.dart
View file

@ -118,7 +118,7 @@ abstract class ChromiumDevice extends Device {
@override
Future<LaunchResult> startApp(
covariant WebApplicationPackage package, {
WebApplicationPackage? package, {
String? mainPath,
String? route,
required DebuggingOptions debuggingOptions,
@ -454,7 +454,7 @@ class WebServerDevice extends Device {
Future<String> get sdkNameAndVersion async => 'Flutter Tools';
@override
Future<LaunchResult> startApp(ApplicationPackage package, {
Future<LaunchResult> startApp(ApplicationPackage? package, {
String? mainPath,
String? route,
required DebuggingOptions debuggingOptions,

2
packages/flutter_tools/test/general.shard/resident_web_runner_test.dart
View file

@ -340,7 +340,7 @@ void main() {
fakeVmServiceHost =
FakeVmServiceHost(requests: kAttachExpectations.toList());
setupMocks();
fileSystem.file(fileSystem.path.join('web', 'index.html')).deleteSync();
fileSystem.directory('web').deleteSync(recursive: true);
final ResidentWebRunner residentWebRunner = ResidentWebRunner(
flutterDevice,
flutterProject:

31
packages/flutter_tools/test/general.shard/web/devices_test.dart
View file

@ -112,6 +112,37 @@ void main() {
expect(device.supportsRuntimeMode(BuildMode.jitRelease), false);
});
testWithoutContext('ChromiumDevice accepts null package', () async {
final MemoryFileSystem fs = MemoryFileSystem.test();
final FakePlatform platform = FakePlatform();
final FakeProcessManager pm = FakeProcessManager.any();
final BufferLogger logger = BufferLogger.test();
final GoogleChromeDevice device = GoogleChromeDevice(
fileSystem: fs,
processManager: pm,
platform: platform,
chromiumLauncher: ChromiumLauncher(
fileSystem: fs,
platform: platform,
processManager: pm,
operatingSystemUtils: FakeOperatingSystemUtils(),
browserFinder: findChromeExecutable,
logger: logger,
),
logger: logger,
);
await expectLater(
() => device.startApp(
null,
debuggingOptions: DebuggingOptions.disabled(BuildInfo.debug),
platformArgs: <String, Object?>{'uri': 'localhost:1234'},
),
// The tool exit here is irrelevant, this test simply ensures ChromiumDevice.startApp
// will accept a null value for a package.
throwsToolExit(message: 'Failed to launch browser'),
);
});
testWithoutContext('Chrome device is listed when Chrome can be run', () async {
final WebDevices webDevices = WebDevices(
featureFlags: TestFeatureFlags(isWebEnabled: true),